Patch Set 1:

My concern with SFL4J is "yet another dependency".

In general the JGit approach is to wrap and throw any underlying exception, so the caller can handle failure by doing whatever they want with it. I worry that a robust logging framework may cause us to get lazy and log the underlying exception, then throw, which is not the best experience to have from a library.

This stupid wrapper allows an embedder to catch a few exceptions that I would otherwise throw away, such as from a background thread that is doing pre-work that if not done would just be done by the real application thread and reported that way.

In particular I was using it because there was a runtime exception throwing out of DfsBlockCache on the ReadAheadTask code that I wanted to see. I am actually happier throwing away this change than I am about importing SFL4J.