Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

shouldn't the factory class be registered with the platform extension "org.eclipse.ui.elementFactories" ?

IElementFactory says:

"Clients should implement this interface and  include the name of their class in an extension to the platform extension point named "org.eclipse.ui.elementFactories".