The following document contains the results of SpotBugs
SpotBugs Version is 3.1.1
Threshold is medium
Effort is default
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.eclipse.jgit.lfs.LfsBlobLoader.getCachedBytes() may expose internal representation by returning LfsBlobLoader.cached | MALICIOUS_CODE | EI_EXPOSE_REP | 109 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.eclipse.jgit.lfs.LfsPointer defines compareTo(LfsPointer) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 201-206 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.eclipse.jgit.lfs.LfsPrePushHook.uploadContents(HttpConnection, Map): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 220 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.eclipse.jgit.lfs.SmudgeFilter.downloadLfsResource(Lfs, Repository, LfsPointer[]): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 181 | High |
| Possible null pointer dereference in org.eclipse.jgit.lfs.SmudgeFilter.downloadLfsResource(Lfs, Repository, LfsPointer[]) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 223 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.eclipse.jgit.lfs.SmudgeFilter.downloadLfsResource(Lfs, Repository, LfsPointer[]) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 223 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten public or protected field header in org.eclipse.jgit.lfs.internal.LfsConnectionFactory.getLfsContentConnection(Repository, Protocol$Action, String) | STYLE | NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD | 234 | Medium |
| Exception is caught when Exception is not thrown in org.eclipse.jgit.lfs.internal.LfsConnectionFactory.discoverLfsUrl(Repository, String, Map, String) | STYLE | REC_CATCH_EXCEPTION | 178 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in new org.eclipse.jgit.lfs.internal.LfsConnectionFactory$AuthCache(Protocol$ExpiringAction) | STYLE | REC_CATCH_EXCEPTION | 342 | Medium |
| Call to method of static java.text.DateFormat in new org.eclipse.jgit.lfs.internal.LfsConnectionFactory$AuthCache(Protocol$ExpiringAction) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 337 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.eclipse.jgit.lfs.lib.LfsPointerFilter defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 106 | High |
