PMD Results

The following document contains the results of PMD 5.6.1.

Files

org/eclipse/jgit/api/AddCommand.java

Violation Line
Useless parentheses. 211212
Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 212
Useless parentheses. 213214

org/eclipse/jgit/api/ArchiveCommand.java

Violation Line
Avoid modifiers which are implied by the context 122213

org/eclipse/jgit/api/CheckoutCommand.java

Violation Line
Avoid modifiers which are implied by the context 140161
Useless parentheses. 576

org/eclipse/jgit/api/CleanCommand.java

Violation Line
Useless parentheses. 204
Useless parentheses. 205

org/eclipse/jgit/api/CloneCommand.java

Violation Line
Avoid empty catch blocks 709712

org/eclipse/jgit/api/CommitCommand.java

Violation Line
Useless parentheses. 398399
Useless parentheses. 400
Useless parentheses. 532

org/eclipse/jgit/api/FetchCommand.java

Violation Line
Useless parentheses. 193194

org/eclipse/jgit/api/LogCommand.java

Violation Line
Avoid empty catch blocks 289292
Avoid empty catch blocks 292296

org/eclipse/jgit/api/NameRevCommand.java

Violation Line
Useless parentheses. 284

org/eclipse/jgit/api/RebaseCommand.java

Violation Line
These nested if statements could be combined 716721
Useless parentheses. 783784
Useless parentheses. 783
Useless parentheses. 784
These nested if statements could be combined 13011304

org/eclipse/jgit/api/StashApplyCommand.java

Violation Line
These nested if statements could be combined 375379

org/eclipse/jgit/api/TagCommand.java

Violation Line
Avoid unused method parameters such as 'state'. 216

org/eclipse/jgit/api/TransportConfigCallback.java

Violation Line
Avoid modifiers which are implied by the context 71

org/eclipse/jgit/attributes/Attribute.java

Violation Line
Avoid modifiers which are implied by the context 7086

org/eclipse/jgit/attributes/Attributes.java

Violation Line
Useless parentheses. 159
Useless parentheses. 172
Useless parentheses. 185
Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Violation Line
Useless parentheses. 144

org/eclipse/jgit/attributes/AttributesNodeProvider.java

Violation Line
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 79

org/eclipse/jgit/attributes/AttributesProvider.java

Violation Line
Avoid modifiers which are implied by the context 56

org/eclipse/jgit/attributes/AttributesRule.java

Violation Line
Avoid empty catch blocks 157159

org/eclipse/jgit/attributes/FilterCommandFactory.java

Violation Line
Avoid modifiers which are implied by the context 7273

org/eclipse/jgit/blame/BlameGenerator.java

Violation Line
Avoid empty while statements 431433
Avoid empty if statements 521525

org/eclipse/jgit/diff/DiffConfig.java

Violation Line
Avoid modifiers which are implied by the context 6271

org/eclipse/jgit/diff/DiffEntry.java

Violation Line
Avoid modifiers which are implied by the context 7590
Avoid modifiers which are implied by the context 9399

org/eclipse/jgit/diff/DiffFormatter.java

Violation Line
Too many static imports may lead to messy code 451235
Avoid empty catch blocks 714716

org/eclipse/jgit/diff/Edit.java

Violation Line
Avoid modifiers which are implied by the context 6779

org/eclipse/jgit/diff/MyersDiff.java

Violation Line
Useless parentheses. 320
Useless parentheses. 442443
Useless parentheses. 501
Useless parentheses. 549

org/eclipse/jgit/diff/RawTextComparator.java

Violation Line
Useless parentheses. 83
Useless parentheses. 133
Useless parentheses. 171
Useless parentheses. 206
Useless parentheses. 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Violation Line
Useless parentheses. 366

org/eclipse/jgit/dircache/DirCache.java

Violation Line
Avoid unused constructor parameters such as 'fs'. 375
Avoid empty catch blocks 440442

org/eclipse/jgit/dircache/DirCacheBuilder.java

Violation Line
Avoid using a branching statement as the last in a loop. 181

org/eclipse/jgit/dircache/DirCacheCheckout.java

Violation Line
Useless parentheses. 233
Useless parentheses. 233
Avoid empty if statements 454457
Avoid empty if statements 459464
Useless parentheses. 638
Useless parentheses. 780
Useless parentheses. 781
Useless parentheses. 781
Useless parentheses. 781
Useless parentheses. 877
These nested if statements could be combined 889898
These nested if statements could be combined 892897
Useless parentheses. 11201121
Avoid empty while statements 15641566

org/eclipse/jgit/dircache/DirCacheEntry.java

Violation Line
Useless parentheses. 122
Useless parentheses. 290
Useless parentheses. 392
Useless parentheses. 392

org/eclipse/jgit/dircache/DirCacheIterator.java

Violation Line
These nested if statements could be combined 246252

org/eclipse/jgit/dircache/DirCacheTree.java

Violation Line
Useless parentheses. 492

org/eclipse/jgit/errors/NoMergeBaseException.java

Violation Line
Avoid modifiers which are implied by the context 6685

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Violation Line
Avoid unused constructor parameters such as 'otp'. 65
Avoid unused constructor parameters such as 'otp'. 78

org/eclipse/jgit/fnmatch/CharacterHead.java

Violation Line
Unnecessary final modifier in final class 6365

org/eclipse/jgit/fnmatch/GroupHead.java

Violation Line
Unnecessary final modifier in final class 135142
Unnecessary final modifier in final class 164166
Unnecessary final modifier in final class 173175
Unnecessary final modifier in final class 182184
Unnecessary final modifier in final class 191193
Unnecessary final modifier in final class 200202
Unnecessary final modifier in final class 209211
Unnecessary final modifier in final class 222224

org/eclipse/jgit/fnmatch/Head.java

Violation Line
Avoid modifiers which are implied by the context 57

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Violation Line
Unnecessary final modifier in final class 5759

org/eclipse/jgit/fnmatch/WildCardHead.java

Violation Line
Unnecessary final modifier in final class 5456

org/eclipse/jgit/gitrepo/ManifestParser.java

Violation Line
Avoid modifiers which are implied by the context 111112

org/eclipse/jgit/gitrepo/RepoCommand.java

Violation Line
Avoid modifiers which are implied by the context 153
Avoid modifiers which are implied by the context 169170
Avoid empty catch blocks 516518
Useless parentheses. 709
Useless parentheses. 710
Useless parentheses. 737
Useless parentheses. 738

org/eclipse/jgit/hooks/GitHook.java

Violation Line
Avoid empty catch blocks 162164

org/eclipse/jgit/ignore/IgnoreNode.java

Violation Line
Avoid modifiers which are implied by the context 6279

org/eclipse/jgit/ignore/internal/IMatcher.java

Violation Line
Avoid modifiers which are implied by the context 5364

org/eclipse/jgit/ignore/internal/NameMatcher.java

Violation Line
Ternary operators that can be simplified with || or && 66
Useless parentheses. 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Violation Line
Too many static imports may lead to messy code 43343
Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 131

org/eclipse/jgit/ignore/internal/Strings.java

Violation Line
Useless parentheses. 138
Avoid modifiers which are implied by the context 234236
These nested if statements could be combined 337339
Useless parentheses. 398

org/eclipse/jgit/ignore/internal/WildMatcher.java

Violation Line
Unnecessary final modifier in final class 6468
Unnecessary final modifier in final class 7274

org/eclipse/jgit/internal/ketch/ElectionRound.java

Violation Line
These nested if statements could be combined 106108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Violation Line
Too many static imports may lead to messy code 44642
Avoid modifiers which are implied by the context 129141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Violation Line
Too many static imports may lead to messy code 44158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Violation Line
Too many static imports may lead to messy code 44791
Invoke equals() on the object you've already ensured is not null 348

org/eclipse/jgit/internal/ketch/KetchSystem.java

Violation Line
Too many static imports may lead to messy code 44374

org/eclipse/jgit/internal/ketch/LagCheck.java

Violation Line
Too many static imports may lead to messy code 44185
Avoid empty catch blocks 150152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Violation Line
Too many static imports may lead to messy code 44240

org/eclipse/jgit/internal/ketch/Proposal.java

Violation Line
Too many static imports may lead to messy code 44448
Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 427

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Violation Line
Too many static imports may lead to messy code 44329

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Violation Line
Too many static imports may lead to messy code 44247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Violation Line
Avoid empty if statements 8183

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Violation Line
Avoid empty if statements 8991

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Violation Line
Too many static imports may lead to messy code 44253

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Violation Line
Too many static imports may lead to messy code 44788
Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Violation Line
Avoid empty catch blocks 247249
Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 623
Useless parentheses. 630

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Violation Line
Avoid modifiers which are implied by the context 90151

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Violation Line
Too many static imports may lead to messy code 44541

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Violation Line
Useless parentheses. 100
Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 515

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Violation Line
Unnecessary final modifier in final class 247249
Useless parentheses. 564
Useless parentheses. 570
Useless parentheses. 577
Useless parentheses. 583
Useless parentheses. 600
Useless parentheses. 624
Useless parentheses. 709
Useless parentheses. 717
Useless parentheses. 789
Useless parentheses. 837
Useless parentheses. 952
Useless parentheses. 1059

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Violation Line
Avoid empty catch blocks 183185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Violation Line
Avoid empty catch blocks 363365
Avoid empty catch blocks 383385
Useless parentheses. 785

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Violation Line
Too many static imports may lead to messy code 44182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Violation Line
Avoid empty catch blocks 384386

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Violation Line
Avoid empty catch blocks 176178

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Violation Line
Ensure you override both equals() and hashCode() 141

org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java

Violation Line
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 73
Avoid modifiers which are implied by the context 86
Avoid modifiers which are implied by the context 105
Avoid modifiers which are implied by the context 134

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Violation Line
Too many static imports may lead to messy code 44465

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Violation Line
Avoid empty catch blocks 122124

org/eclipse/jgit/internal/storage/file/BitSet.java

Violation Line
Unnecessary final modifier in final class 6264
Unnecessary final modifier in final class 6674
Unnecessary final modifier in final class 7680
Unnecessary final modifier in final class 8285
Unnecessary final modifier in final class 87112
Unnecessary final modifier in final class 114116
Unnecessary final modifier in final class 118120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Violation Line
Unnecessary final modifier in final class 360362

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Violation Line
Avoid empty catch blocks 112114
These nested if statements could be combined 199201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Violation Line
Avoid modifiers which are implied by the context 6365

org/eclipse/jgit/internal/storage/file/FileRepository.java

Violation Line
These nested if statements could be combined 237240
Avoid empty catch blocks 331333

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Violation Line
Useless parentheses. 198

org/eclipse/jgit/internal/storage/file/GC.java

Violation Line
Avoid empty catch blocks 420422
Avoid empty catch blocks 457459
Avoid empty catch blocks 573576
Avoid empty catch blocks 953955
Useless parentheses. 973975
Avoid empty catch blocks 978980
Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1148
Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1151

org/eclipse/jgit/internal/storage/file/GcLog.java

Violation Line
Avoid empty catch blocks 111113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Violation Line
Unnecessary final modifier in final class 7680
Unnecessary final modifier in final class 82124
Unnecessary final modifier in final class 126129
Unnecessary final modifier in final class 131133
Unnecessary final modifier in final class 135137
Unnecessary final modifier in final class 139141
Unnecessary final modifier in final class 143147
Unnecessary final modifier in final class 149153
Unnecessary final modifier in final class 155162
Unnecessary final modifier in final class 164166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Violation Line
Avoid empty catch blocks 98100

org/eclipse/jgit/internal/storage/file/LockFile.java

Violation Line
Avoid empty catch blocks 101103
Avoid unused constructor parameters such as 'fs'. 155

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Violation Line
These nested if statements could be combined 327329
These nested if statements could be combined 343345
Avoid using a branching statement as the last in a loop. 501
Avoid using a branching statement as the last in a loop. 594
Avoid using a branching statement as the last in a loop. 640
Useless parentheses. 655
Useless parentheses. 656
Avoid empty catch blocks 730732
Useless parentheses. 776

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Violation Line
Avoid empty catch blocks 216218

org/eclipse/jgit/internal/storage/file/PackBitmapIndex.java

Violation Line
Avoid empty catch blocks 107109

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Violation Line
Useless parentheses. 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Violation Line
Useless parentheses. 445
Useless parentheses. 451
Useless parentheses. 458
Useless parentheses. 464
Useless parentheses. 481
Useless parentheses. 514
Useless parentheses. 534
Useless parentheses. 591
Useless parentheses. 599
Avoid empty catch blocks 714718
Useless parentheses. 849
Useless parentheses. 898
Useless parentheses. 1013
Useless parentheses. 1119
Useless parentheses. 1205

org/eclipse/jgit/internal/storage/file/PackIndex.java

Violation Line
Avoid empty catch blocks 109111

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Violation Line
Useless parentheses. 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Violation Line
Useless parentheses. 231
Useless parentheses. 338

org/eclipse/jgit/internal/storage/file/PackInserter.java

Violation Line
Avoid empty catch blocks 329331
Avoid empty catch blocks 336338
Avoid empty catch blocks 341343

org/eclipse/jgit/internal/storage/file/PackLock.java

Violation Line
Avoid unused constructor parameters such as 'fs'. 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Violation Line
Too many static imports may lead to messy code 44551
Avoid using a branching statement as the last in a loop. 356
Useless parentheses. 393
Useless parentheses. 394
Avoid empty catch blocks 451453
Avoid empty catch blocks 472486
Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Violation Line
Too many static imports may lead to messy code 471490
Avoid using a branching statement as the last in a loop. 516
These nested if statements could be combined 538539
Useless parentheses. 1162
Useless parentheses. 1177
Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1214
Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1245
Avoid modifiers which are implied by the context 13841388

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Violation Line
Avoid empty catch blocks 217219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Violation Line
Too many static imports may lead to messy code 46270
Useless parentheses. 226

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Violation Line
Avoid empty if statements 6973

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Violation Line
Useless parentheses. 319

org/eclipse/jgit/internal/storage/io/BlockSource.java

Violation Line
Avoid empty catch blocks 136138

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Violation Line
Useless parentheses. 68

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Violation Line
This for loop could be simplified to a while loop 140150
Unnecessary final modifier in final class 267269
Ternary operators that can be simplified with || or && 355

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Violation Line
Avoid using a branching statement as the last in a loop. 225
Avoid empty catch blocks 309311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Violation Line
Unnecessary final modifier in final class 5761
Unnecessary final modifier in final class 6466
Unnecessary final modifier in final class 6971
Unnecessary final modifier in final class 7476
Unnecessary final modifier in final class 7981
Unnecessary final modifier in final class 8393

org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java

Violation Line
Avoid modifiers which are implied by the context 82
Avoid modifiers which are implied by the context 117119
Avoid modifiers which are implied by the context 158159
Avoid modifiers which are implied by the context 203205
Avoid modifiers which are implied by the context 219220
Avoid modifiers which are implied by the context 237238

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Violation Line
Unnecessary final modifier in final class 110114
Unnecessary final modifier in final class 118138
Unnecessary final modifier in final class 146153
Unnecessary final modifier in final class 170172
Unnecessary final modifier in final class 190205
Useless parentheses. 193
Unnecessary final modifier in final class 207216
Unnecessary final modifier in final class 218225
Unnecessary final modifier in final class 227232
Unnecessary final modifier in final class 239241
Unnecessary final modifier in final class 252254
Unnecessary final modifier in final class 257259

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Violation Line
Too many static imports may lead to messy code 452609
Avoid empty while statements 18491851
These nested if statements could be combined 21292130
Useless parentheses. 2145
Useless parentheses. 2146
Useless parentheses. 2514
Useless parentheses. 2531
Avoid modifiers which are implied by the context 25572575

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Violation Line
Useless parentheses. 137
Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 220
Useless parentheses. 253
Useless parentheses. 254255
Useless parentheses. 255
Useless parentheses. 256
Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 267
Avoid empty while statements 275278
These nested if statements could be combined 286289

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Violation Line
Too many static imports may lead to messy code 44589
Useless parentheses. 561
Useless parentheses. 573

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Violation Line
Too many static imports may lead to messy code 44605
Useless parentheses. 138

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Violation Line
Too many static imports may lead to messy code 44249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Violation Line
Too many static imports may lead to messy code 44698
Useless parentheses. 172
Useless parentheses. 447
Avoid using a branching statement as the last in a loop. 507
Avoid using a branching statement as the last in a loop. 567
Invoke equals() on the object you've already ensured is not null 676

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Violation Line
Too many static imports may lead to messy code 44835
Avoid using a branching statement as the last in a loop. 683

org/eclipse/jgit/internal/storage/reftree/Command.java

Violation Line
Too many static imports may lead to messy code 44342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Violation Line
Too many static imports may lead to messy code 44417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Violation Line
Too many static imports may lead to messy code 44227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Violation Line
Too many static imports may lead to messy code 44286

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Violation Line
Unnecessary final modifier in final class 7787
Unnecessary final modifier in final class 101109
Unnecessary final modifier in final class 122125
Unnecessary final modifier in final class 134139
Unnecessary final modifier in final class 141153
Unnecessary final modifier in final class 155166
Unnecessary final modifier in final class 247267
Unnecessary final modifier in final class 283303
Unnecessary final modifier in final class 319339
Unnecessary final modifier in final class 346348
Unnecessary final modifier in final class 376397

org/eclipse/jgit/lib/AnyObjectId.java

Violation Line
Ternary operators that can be simplified with || or && 278

org/eclipse/jgit/lib/AsyncObjectLoaderQueue.java

Violation Line
Avoid modifiers which are implied by the context 81
Avoid modifiers which are implied by the context 90
Avoid modifiers which are implied by the context 97
Avoid modifiers which are implied by the context 118

org/eclipse/jgit/lib/AsyncObjectSizeQueue.java

Violation Line
Avoid modifiers which are implied by the context 76
Avoid modifiers which are implied by the context 85
Avoid modifiers which are implied by the context 92
Avoid modifiers which are implied by the context 99

org/eclipse/jgit/lib/AsyncOperation.java

Violation Line
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 76

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Violation Line
Too many static imports may lead to messy code 44783
Useless parentheses. 113
Avoid empty catch blocks 554556

org/eclipse/jgit/lib/BitmapIndex.java

Violation Line
Avoid modifiers which are implied by the context 77117
Avoid modifiers which are implied by the context 123224

org/eclipse/jgit/lib/BlobObjectChecker.java

Violation Line
Avoid modifiers which are implied by the context 5869

org/eclipse/jgit/lib/CheckoutEntry.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 22

org/eclipse/jgit/lib/Config.java

Violation Line
Avoid modifiers which are implied by the context 14381447
Avoid modifiers which are implied by the context 14771493

org/eclipse/jgit/lib/ConfigSnapshot.java

Violation Line
Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 281

org/eclipse/jgit/lib/CoreConfig.java

Violation Line
Avoid modifiers which are implied by the context 6372
Avoid modifiers which are implied by the context 8190
Avoid modifiers which are implied by the context 97112
Avoid modifiers which are implied by the context 119131
Avoid modifiers which are implied by the context 148153
Avoid modifiers which are implied by the context 160167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Violation Line
Avoid empty catch blocks 128130

org/eclipse/jgit/lib/FileMode.java

Violation Line
Do not start a literal by 0 unless its an octal value 68
Do not start a literal by 0 unless its an octal value 71
Do not start a literal by 0 unless its an octal value 74
Do not start a literal by 0 unless its an octal value 77
Do not start a literal by 0 unless its an octal value 80
Do not start a literal by 0 unless its an octal value 83
Do not start a literal by 0 unless its an octal value 106
Do not start a literal by 0 unless its an octal value 110
Do not start a literal by 0 unless its an octal value 115
Do not start a literal by 0 unless its an octal value 119
Do not start a literal by 0 unless its an octal value 157

org/eclipse/jgit/lib/GitmoduleEntry.java

Violation Line
No need to import a type that lives in the same package 45

org/eclipse/jgit/lib/IndexDiff.java

Violation Line
Avoid modifiers which are implied by the context 107195
Avoid modifiers which are implied by the context 346
These nested if statements could be combined 473476
These nested if statements could be combined 512516
Useless parentheses. 514515
Useless parentheses. 610611
Useless parentheses. 610611
Useless parentheses. 610
Useless parentheses. 621

org/eclipse/jgit/lib/ObjectChecker.java

Violation Line
Too many static imports may lead to messy code 451254
Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 563
Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 595
Useless parentheses. 928
Useless parentheses. 929
Useless parentheses. 11001101
Useless parentheses. 1102
Useless parentheses. 1103

org/eclipse/jgit/lib/ProgressMonitor.java

Violation Line
Avoid modifiers which are implied by the context 52

org/eclipse/jgit/lib/RebaseTodoLine.java

Violation Line
Avoid modifiers which are implied by the context 61118
These nested if statements could be combined 191194

org/eclipse/jgit/lib/Ref.java

Violation Line
Avoid modifiers which are implied by the context 64126
Avoid modifiers which are implied by the context 134
Avoid modifiers which are implied by the context 147
Avoid modifiers which are implied by the context 166
Avoid modifiers which are implied by the context 181
Avoid modifiers which are implied by the context 191
Avoid modifiers which are implied by the context 201
Avoid modifiers which are implied by the context 208
Avoid modifiers which are implied by the context 219

org/eclipse/jgit/lib/RefUpdate.java

Violation Line
Avoid modifiers which are implied by the context 68171
These nested if statements could be combined 778780

org/eclipse/jgit/lib/ReflogEntry.java

Violation Line
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 83
Avoid modifiers which are implied by the context 90
Avoid modifiers which are implied by the context 97
Avoid modifiers which are implied by the context 104
Avoid modifiers which are implied by the context 111
Avoid modifiers which are implied by the context 120

org/eclipse/jgit/lib/ReflogReader.java

Violation Line
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 70
Avoid modifiers which are implied by the context 80
Avoid modifiers which are implied by the context 9091

org/eclipse/jgit/lib/Repository.java

Violation Line
Useless parentheses. 824
Useless parentheses. 825
Useless parentheses. 826
These nested if statements could be combined 882883
Avoid empty catch blocks 13311335
Avoid empty catch blocks 13481350
Avoid empty catch blocks 13611363

org/eclipse/jgit/lib/RepositoryBuilder.java

Violation Line
Avoid unused imports such as 'java.io.File' 46

org/eclipse/jgit/lib/RepositoryCache.java

Violation Line
Useless parentheses. 302
Avoid modifiers which are implied by the context 347368

org/eclipse/jgit/lib/StoredConfig.java

Violation Line
Overriding method merely calls super 9597

org/eclipse/jgit/lib/TreeFormatter.java

Violation Line
Too many static imports may lead to messy code 44403

org/eclipse/jgit/merge/EolAwareOutputStream.java

Violation Line
Useless parentheses. 86
Useless parentheses. 94

org/eclipse/jgit/merge/MergeConfig.java

Violation Line
Avoid empty catch blocks 7274

org/eclipse/jgit/merge/MergeFormatterPass.java

Violation Line
Useless parentheses. 75

org/eclipse/jgit/merge/MergeResult.java

Violation Line
Useless parentheses. 141

org/eclipse/jgit/merge/ResolveMerger.java

Violation Line
Too many static imports may lead to messy code 471312
These nested if statements could be combined 392394
Useless parentheses. 785786
Useless parentheses. 785786
These nested if statements could be combined 785810
Useless parentheses. 785
These nested if statements could be combined 801802
Useless parentheses. 848849

org/eclipse/jgit/merge/ThreeWayMerger.java

Violation Line
Avoid unused constructor parameters such as 'inCore'. 86

org/eclipse/jgit/nls/GlobalBundleCache.java

Violation Line
Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 50
Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 51

org/eclipse/jgit/nls/NLS.java

Violation Line
Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 49
Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 50

org/eclipse/jgit/notes/NoteMapMerger.java

Violation Line
Useless parentheses. 284
Useless parentheses. 286
Invoke equals() on the object you've already ensured is not null 298

org/eclipse/jgit/patch/BinaryHunk.java

Violation Line
Avoid modifiers which are implied by the context 6167

org/eclipse/jgit/patch/CombinedFileHeader.java

Violation Line
Overriding method merely calls super 152154

org/eclipse/jgit/patch/FileHeader.java

Violation Line
Too many static imports may lead to messy code 44651
Avoid modifiers which are implied by the context 107116
Avoid empty catch blocks 247250
Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 295

org/eclipse/jgit/patch/FormatError.java

Violation Line
Avoid modifiers which are implied by the context 5662

org/eclipse/jgit/patch/Patch.java

Violation Line
Too many static imports may lead to messy code 44392

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Violation Line
Useless parentheses. 195

org/eclipse/jgit/revplot/PlotWalk.java

Violation Line
Avoid empty catch blocks 166168

org/eclipse/jgit/revwalk/AsyncRevObjectQueue.java

Violation Line
Avoid modifiers which are implied by the context 69

org/eclipse/jgit/revwalk/BitmapWalker.java

Violation Line
Avoid empty catch blocks 138141
Avoid empty catch blocks 157172

org/eclipse/jgit/revwalk/DateRevQueue.java

Violation Line
Useless parentheses. 121

org/eclipse/jgit/revwalk/DepthWalk.java

Violation Line
Avoid modifiers which are implied by the context 64
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 79
Avoid modifiers which are implied by the context 82101
Avoid modifiers which are implied by the context 104181
Avoid modifiers which are implied by the context 184274

org/eclipse/jgit/revwalk/ObjectWalk.java

Violation Line
Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 60
Do not start a literal by 0 unless its an octal value 86
Do not start a literal by 0 unless its an octal value 87
Do not start a literal by 0 unless its an octal value 88
Do not start a literal by 0 unless its an octal value 89
Avoid using a branching statement as the last in a loop. 324
Avoid empty while statements 740742

org/eclipse/jgit/revwalk/RevCommitList.java

Violation Line
Avoid empty catch blocks 193196
Useless parentheses. 371

org/eclipse/jgit/revwalk/RevWalk.java

Violation Line
Useless qualified this usage in the same class. 1358

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Violation Line
Avoid using a branching statement as the last in a loop. 126

org/eclipse/jgit/submodule/SubmoduleWalk.java

Violation Line
Useless parentheses. 528
Avoid using a branching statement as the last in a loop. 622

org/eclipse/jgit/transport/AdvertiseRefsHook.java

Violation Line
Avoid modifiers which are implied by the context 5868
Avoid modifiers which are implied by the context 8081
Avoid modifiers which are implied by the context 9394

org/eclipse/jgit/transport/BasePackConnection.java

Violation Line
Avoid empty catch blocks 331333
Avoid empty catch blocks 342344
Avoid empty catch blocks 372374

org/eclipse/jgit/transport/BasePackFetchConnection.java

Violation Line
Avoid empty catch blocks 423425
Avoid empty catch blocks 480482
Avoid empty catch blocks 500503
Avoid empty catch blocks 802804

org/eclipse/jgit/transport/BasePackPushConnection.java

Violation Line
Avoid empty catch blocks 185187
Avoid empty catch blocks 191193
Useless parentheses. 437

org/eclipse/jgit/transport/BaseReceivePack.java

Violation Line
Too many static imports may lead to messy code 441982
Avoid empty catch blocks 380382
Avoid empty catch blocks 391393
Avoid empty catch blocks 407409
Avoid empty catch blocks 10551057
Avoid empty catch blocks 13621364

org/eclipse/jgit/transport/BundleFetchConnection.java

Violation Line
Avoid empty catch blocks 266268
Avoid empty catch blocks 303305

org/eclipse/jgit/transport/Connection.java

Violation Line
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 85
Avoid modifiers which are implied by the context 98
Avoid modifiers which are implied by the context 118
Avoid modifiers which are implied by the context 135
Avoid modifiers which are implied by the context 144

org/eclipse/jgit/transport/Daemon.java

Violation Line
Avoid using java.lang.ThreadGroup; it is not thread safe 112
Avoid empty catch blocks 316318
Avoid empty catch blocks 342344
Avoid empty catch blocks 426428
Avoid empty catch blocks 428430
Avoid empty catch blocks 430432
Avoid empty catch blocks 435437
Avoid empty catch blocks 440442

org/eclipse/jgit/transport/DaemonService.java

Violation Line
Useless qualified this usage in the same class. 70

org/eclipse/jgit/transport/FetchConnection.java

Violation Line
Avoid modifiers which are implied by the context 112114
Avoid modifiers which are implied by the context 154156
Avoid modifiers which are implied by the context 176
Avoid modifiers which are implied by the context 199
Avoid modifiers which are implied by the context 211
Avoid modifiers which are implied by the context 221

org/eclipse/jgit/transport/FetchProcess.java

Violation Line
Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 539

org/eclipse/jgit/transport/FetchResult.java

Violation Line
Avoid unused imports such as 'java.util.Collection' 50

org/eclipse/jgit/transport/GitProtocolConstants.java

Violation Line
Avoid modifiers which are implied by the context 218220

org/eclipse/jgit/transport/HttpAuthMethod.java

Violation Line
Useless parentheses. 175
Useless parentheses. 176
Avoid empty catch blocks 192194
Avoid empty if statements 416418
Avoid empty if statements 419421

org/eclipse/jgit/transport/HttpConfig.java

Violation Line
Useless parentheses. 96114
Avoid empty if statements 392394

org/eclipse/jgit/transport/InternalFetchConnection.java

Violation Line
Avoid empty catch blocks 110112
Avoid empty catch blocks 112114
Avoid empty catch blocks 123125
Avoid empty catch blocks 129131

org/eclipse/jgit/transport/InternalPushConnection.java

Violation Line
Avoid empty catch blocks 102104
Avoid empty catch blocks 104106
Avoid empty catch blocks 106108
Avoid empty catch blocks 108110
Avoid empty catch blocks 113115
Avoid empty catch blocks 119121

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Violation Line
Avoid empty catch blocks 367369
Avoid empty catch blocks 369371
Avoid empty catch blocks 390392
These nested if statements could be combined 454467
Avoid empty catch blocks 464466

org/eclipse/jgit/transport/JschSession.java

Violation Line
Avoid empty catch blocks 171173

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Violation Line
These nested if statements could be combined 103107

org/eclipse/jgit/transport/NonceGenerator.java

Violation Line
Avoid modifiers which are implied by the context 6970
Avoid modifiers which are implied by the context 9495

org/eclipse/jgit/transport/ObjectCountCallback.java

Violation Line
Avoid unused imports such as 'java.io.OutputStream' 46
Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 48

org/eclipse/jgit/transport/OpenSshConfig.java

Violation Line
Avoid empty catch blocks 232234
Avoid empty catch blocks 372374

org/eclipse/jgit/transport/PackParser.java

Violation Line
Avoid modifiers which are implied by the context 106112
Useless parentheses. 851
Useless parentheses. 1026
Avoid empty catch blocks 11841188
Avoid empty catch blocks 12041208

org/eclipse/jgit/transport/PacketLineIn.java

Violation Line
Avoid modifiers which are implied by the context 7788
Avoid empty catch blocks 245247

org/eclipse/jgit/transport/PostReceiveHook.java

Violation Line
Avoid modifiers which are implied by the context 6672
Avoid modifiers which are implied by the context 8485

org/eclipse/jgit/transport/PostUploadHook.java

Violation Line
Avoid modifiers which are implied by the context 6065
Avoid modifiers which are implied by the context 75

org/eclipse/jgit/transport/PreReceiveHook.java

Violation Line
Avoid modifiers which are implied by the context 8288
Avoid modifiers which are implied by the context 102

org/eclipse/jgit/transport/PreUploadHook.java

Violation Line
Avoid modifiers which are implied by the context 6285
Avoid modifiers which are implied by the context 99101
Avoid modifiers which are implied by the context 123126
Avoid modifiers which are implied by the context 144146

org/eclipse/jgit/transport/PushCertificateIdent.java

Violation Line
Useless parentheses. 267

org/eclipse/jgit/transport/PushCertificateParser.java

Violation Line
Avoid modifiers which are implied by the context 8798
Avoid empty catch blocks 265268

org/eclipse/jgit/transport/PushConnection.java

Violation Line
Avoid modifiers which are implied by the context 116118
Avoid modifiers which are implied by the context 166168

org/eclipse/jgit/transport/PushProcess.java

Violation Line
Avoid empty catch blocks 296298

org/eclipse/jgit/transport/ReceiveCommand.java

Violation Line
Avoid modifiers which are implied by the context 7598
Avoid modifiers which are implied by the context 101134
Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 279
Useless parentheses. 777
These nested if statements could be combined 780784
Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 843
Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 871
Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 875
Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 881

org/eclipse/jgit/transport/ReceivePack.java

Violation Line
Avoid empty catch blocks 323325

org/eclipse/jgit/transport/RefAdvertiser.java

Violation Line
Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 167
Useless parentheses. 295

org/eclipse/jgit/transport/RefFilter.java

Violation Line
Avoid modifiers which are implied by the context 6469
Avoid modifiers which are implied by the context 79

org/eclipse/jgit/transport/RefSpec.java

Violation Line
These nested if statements could be combined 553554

org/eclipse/jgit/transport/RemoteRefUpdate.java

Violation Line
Avoid modifiers which are implied by the context 75127

org/eclipse/jgit/transport/RemoteSession.java

Violation Line
Avoid modifiers which are implied by the context 81
Avoid modifiers which are implied by the context 86

org/eclipse/jgit/transport/SideBandInputStream.java

Violation Line
Useless parentheses. 154

org/eclipse/jgit/transport/Transport.java

Violation Line
Avoid empty catch blocks 170173
Avoid empty catch blocks 176178

org/eclipse/jgit/transport/TransportAmazonS3.java

Violation Line
Avoid empty catch blocks 263265

org/eclipse/jgit/transport/TransportBundle.java

Violation Line
Avoid modifiers which are implied by the context 61

org/eclipse/jgit/transport/TransportBundleFile.java

Violation Line
Useless parentheses. 89

org/eclipse/jgit/transport/TransportBundleStream.java

Violation Line
Avoid empty catch blocks 118120

org/eclipse/jgit/transport/TransportGitAnon.java

Violation Line
Avoid empty catch blocks 153155
Avoid empty catch blocks 213215
Avoid empty catch blocks 252254

org/eclipse/jgit/transport/TransportGitSsh.java

Violation Line
Useless parentheses. 182
Avoid empty catch blocks 352354
Avoid empty catch blocks 359361

org/eclipse/jgit/transport/TransportHttp.java

Violation Line
Too many static imports may lead to messy code 471454
These nested if statements could be combined 760762
Avoid empty while statements 910912
Avoid empty catch blocks 931933
Avoid empty catch blocks 937939

org/eclipse/jgit/transport/TransportLocal.java

Violation Line
Useless parentheses. 115

org/eclipse/jgit/transport/TransportProtocol.java

Violation Line
Avoid modifiers which are implied by the context 93104

org/eclipse/jgit/transport/TransportSftp.java

Violation Line
Avoid empty catch blocks 362365

org/eclipse/jgit/transport/URIish.java

Violation Line
Useless parentheses. 275276
Useless parentheses. 346
Useless parentheses. 347

org/eclipse/jgit/transport/UploadPack.java

Violation Line
Too many static imports may lead to messy code 441727
Avoid modifiers which are implied by the context 114144
Useless parentheses. 677678
Avoid empty catch blocks 834836
Avoid empty catch blocks 847849
Avoid empty while statements 856858
Avoid empty catch blocks 891893
Avoid empty catch blocks 10051007

org/eclipse/jgit/transport/UploadPackLogger.java

Violation Line
Avoid modifiers which are implied by the context 6267
Avoid modifiers which are implied by the context 76

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Violation Line
These nested if statements could be combined 120124

org/eclipse/jgit/transport/WalkFetchConnection.java

Violation Line
Avoid using a branching statement as the last in a loop. 597
Avoid empty catch blocks 846848

org/eclipse/jgit/transport/WalkPushConnection.java

Violation Line
Avoid empty catch blocks 302306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Violation Line
Avoid empty catch blocks 421423

org/eclipse/jgit/transport/http/HttpConnection.java

Violation Line
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 72
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 78
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 78
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 84
Avoid modifiers which are implied by the context 84
Avoid modifiers which are implied by the context 90
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 90
Avoid modifiers which are implied by the context 98
Avoid modifiers which are implied by the context 103
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 103
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 108
Avoid modifiers which are implied by the context 108
Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 113
Avoid modifiers which are implied by the context 113
Avoid modifiers which are implied by the context 122
Avoid modifiers which are implied by the context 130
Avoid modifiers which are implied by the context 139
Avoid modifiers which are implied by the context 147
Avoid modifiers which are implied by the context 159
Avoid modifiers which are implied by the context 173174
Avoid modifiers which are implied by the context 184
Avoid modifiers which are implied by the context 194
Avoid modifiers which are implied by the context 204
Avoid modifiers which are implied by the context 213
Avoid modifiers which are implied by the context 225
Avoid modifiers which are implied by the context 236
Avoid modifiers which are implied by the context 246
Avoid modifiers which are implied by the context 256
Avoid modifiers which are implied by the context 265
Avoid modifiers which are implied by the context 274
Avoid modifiers which are implied by the context 283
Avoid modifiers which are implied by the context 293
Avoid modifiers which are implied by the context 301
Avoid modifiers which are implied by the context 309
Avoid modifiers which are implied by the context 317
Avoid modifiers which are implied by the context 335337
Avoid modifiers which are implied by the context 348349

org/eclipse/jgit/transport/http/HttpConnectionFactory.java

Violation Line
Avoid modifiers which are implied by the context 65
Avoid modifiers which are implied by the context 7879

org/eclipse/jgit/transport/resolver/ReceivePackFactory.java

Violation Line
Avoid modifiers which are implied by the context 6066

org/eclipse/jgit/transport/resolver/RepositoryResolver.java

Violation Line
Avoid modifiers which are implied by the context 6066

org/eclipse/jgit/transport/resolver/UploadPackFactory.java

Violation Line
Avoid modifiers which are implied by the context 6066

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Violation Line
Too many static imports may lead to messy code 45445
Avoid using a branching statement as the last in a loop. 202

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Violation Line
Avoid using a branching statement as the last in a loop. 149

org/eclipse/jgit/treewalk/TreeWalk.java

Violation Line
Avoid modifiers which are implied by the context 111122
Useless parentheses. 648
Avoid using a branching statement as the last in a loop. 877
Useless parentheses. 1315
Useless parentheses. 1455

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Violation Line
Useless parentheses. 282283
Avoid empty catch blocks 436440
Avoid empty while statements 476478
These nested if statements could be combined 852853
Useless parentheses. 14711472
Useless parentheses. 14731474

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Violation Line
Useless parentheses. 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Violation Line
Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Violation Line
Useless parentheses. 116

org/eclipse/jgit/util/Base64.java

Violation Line
Useless parentheses. 121
Useless parentheses. 128
Useless parentheses. 135
Unnecessary use of fully qualified name 'StandardCharsets.UTF_8' due to existing static import 'java.nio.charset.StandardCharsets.UTF_8' 181
Useless parentheses. 230

org/eclipse/jgit/util/ChangeIdUtil.java

Violation Line
Avoid using a branching statement as the last in a loop. 200
Avoid using a branching statement as the last in a loop. 293

org/eclipse/jgit/util/FS.java

Violation Line
Avoid empty if statements 624627
Useless parentheses. 695
Avoid empty catch blocks 12051212
Avoid empty catch blocks 15331535

org/eclipse/jgit/util/FS_POSIX.java

Violation Line
Do not start a literal by 0 unless its an octal value 83
These nested if statements could be combined 199217
These nested if statements could be combined 200216
Useless parentheses. 473
Useless parentheses. 473

org/eclipse/jgit/util/FS_Win32.java

Violation Line
These nested if statements could be combined 129145

org/eclipse/jgit/util/FileUtils.java

Violation Line
Avoid empty catch blocks 295297
Avoid using a branching statement as the last in a loop. 496
Ternary operators that can be simplified with || or && 809

org/eclipse/jgit/util/GSSManagerFactory.java

Violation Line
Useless parentheses. 64

org/eclipse/jgit/util/GitDateFormatter.java

Violation Line
Avoid modifiers which are implied by the context 71117

org/eclipse/jgit/util/GitDateParser.java

Violation Line
Avoid empty catch blocks 231233

org/eclipse/jgit/util/IO.java

Violation Line
Avoid empty catch blocks 119121
Avoid empty catch blocks 179181

org/eclipse/jgit/util/LfsFactory.java

Violation Line
Avoid modifiers which are implied by the context 315

org/eclipse/jgit/util/NB.java

Violation Line
Useless parentheses. 91
Useless parentheses. 203
Useless parentheses. 206

org/eclipse/jgit/util/ProcessResult.java

Violation Line
Avoid modifiers which are implied by the context 5469

org/eclipse/jgit/util/RawParseUtils.java

Violation Line
Too many static imports may lead to messy code 451255
Unnecessary final modifier in final class 128135
Unnecessary final modifier in final class 209243
Useless parentheses. 234
Avoid empty catch blocks 237239
Unnecessary final modifier in final class 263297
Useless parentheses. 288
Avoid empty catch blocks 291293
Unnecessary final modifier in final class 314327
Unnecessary final modifier in final class 344368
Unnecessary final modifier in final class 386434
Unnecessary final modifier in final class 445450
Unnecessary final modifier in final class 464466
Unnecessary final modifier in final class 484490
Unnecessary final modifier in final class 503510
Unnecessary final modifier in final class 523525
Unnecessary final modifier in final class 540548
Unnecessary final modifier in final class 561569
Unnecessary final modifier in final class 582584
Unnecessary final modifier in final class 600609
Unnecessary final modifier in final class 637663
Useless parentheses. 659
Unnecessary final modifier in final class 678685
Unnecessary final modifier in final class 700709
Unnecessary final modifier in final class 724737
Unnecessary final modifier in final class 752762
Useless parentheses. 869
Unnecessary final modifier in final class 11651176
Unnecessary final modifier in final class 11891198
Unnecessary final modifier in final class 12141224
Useless parentheses. 1217

org/eclipse/jgit/util/RawSubStringPattern.java

Violation Line
Avoid empty while statements 100102
Avoid using a branching statement as the last in a loop. 112

org/eclipse/jgit/util/RefMap.java

Violation Line
Invoke equals() on the object you've already ensured is not null 428

org/eclipse/jgit/util/RelativeDateFormatter.java

Violation Line
Useless parentheses. 122
Useless parentheses. 126
Useless parentheses. 127

org/eclipse/jgit/util/TemporaryBuffer.java

Violation Line
Avoid empty catch blocks 405407

org/eclipse/jgit/util/io/StreamCopyThread.java

Violation Line
Avoid empty catch blocks 163165
Avoid empty catch blocks 168170

org/eclipse/jgit/util/sha1/SHA1.java

Violation Line
Ternary operators that can be simplified with || or && 85
Unnecessary final modifier in final class 589592
Unnecessary final modifier in final class 594600

org/eclipse/jgit/util/time/MonotonicClock.java

Violation Line
Avoid unused imports such as 'java.time.Duration' 46