FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
116 21 0 0

Files

Class Bugs
org.eclipse.jgit.pgm.Archive 1
org.eclipse.jgit.pgm.Diff 1
org.eclipse.jgit.pgm.Main 1
org.eclipse.jgit.pgm.TextBuiltin 1
org.eclipse.jgit.pgm.debug.DiffAlgorithms 4
org.eclipse.jgit.pgm.debug.LfsStore 1
org.eclipse.jgit.pgm.debug.LfsStore$AppServer 1
org.eclipse.jgit.pgm.debug.ShowPackDelta 1
org.eclipse.jgit.pgm.debug.TextHashFunctions 3
org.eclipse.jgit.pgm.debug.TextHashFunctions$Line 1
org.eclipse.jgit.pgm.opt.AbstractTreeIteratorHandler 1
org.eclipse.jgit.pgm.opt.CmdLineParser 1
org.eclipse.jgit.pgm.opt.ObjectIdHandler 1
org.eclipse.jgit.pgm.opt.RevCommitHandler 1
org.eclipse.jgit.pgm.opt.RevTreeHandler 1
org.eclipse.jgit.pgm.opt.SubcommandHandler 1

org.eclipse.jgit.pgm.Archive

Bug Category Details Line Priority
org.eclipse.jgit.pgm.Archive.run() may fail to clean up java.io.OutputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 85 Medium

org.eclipse.jgit.pgm.Diff

Bug Category Details Line Priority
Return value of TextBuiltin.die(String) ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 185 Medium

org.eclipse.jgit.pgm.Main

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.pgm.Main.createErrorWriter(): new java.io.PrintWriter(OutputStream) I18N DM_DEFAULT_ENCODING 194 High

org.eclipse.jgit.pgm.TextBuiltin

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.pgm.TextBuiltin.init(Repository, String): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 165 High

org.eclipse.jgit.pgm.debug.DiffAlgorithms

Bug Category Details Line Priority
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.DiffAlgorithms.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 255 Medium
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.DiffAlgorithms.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 257 Medium
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.DiffAlgorithms.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 260 Medium
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.DiffAlgorithms.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 262 Medium

org.eclipse.jgit.pgm.debug.LfsStore

Bug Category Details Line Priority
Return value of org.eclipse.jgit.pgm.TextBuiltin.die(String) ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 305 Medium

org.eclipse.jgit.pgm.debug.LfsStore$AppServer

Bug Category Details Line Priority
Should org.eclipse.jgit.pgm.debug.LfsStore$AppServer be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 95-161 Medium

org.eclipse.jgit.pgm.debug.ShowPackDelta

Bug Category Details Line Priority
org.eclipse.jgit.pgm.debug.ShowPackDelta.getDelta(ObjectReader, RevObject) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 128 Medium

org.eclipse.jgit.pgm.debug.TextHashFunctions

Bug Category Details Line Priority
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.TextHashFunctions.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 352 Medium
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.TextHashFunctions.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 362 Medium
Format string should use %n rather than \n in org.eclipse.jgit.pgm.debug.TextHashFunctions.run(Repository) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 355 Medium

org.eclipse.jgit.pgm.debug.TextHashFunctions$Line

Bug Category Details Line Priority
Should org.eclipse.jgit.pgm.debug.TextHashFunctions$Line be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 483-499 Medium

org.eclipse.jgit.pgm.opt.AbstractTreeIteratorHandler

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.kohsuke.args4j.CmdLineParser to org.eclipse.jgit.pgm.opt.CmdLineParser in new org.eclipse.jgit.pgm.opt.AbstractTreeIteratorHandler(CmdLineParser, OptionDef, Setter) STYLE BC_UNCONFIRMED_CAST 92 Medium

org.eclipse.jgit.pgm.opt.CmdLineParser

Bug Category Details Line Priority
The class name org.eclipse.jgit.pgm.opt.CmdLineParser shadows the simple name of the superclass org.kohsuke.args4j.CmdLineParser BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 83-351 High

org.eclipse.jgit.pgm.opt.ObjectIdHandler

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.kohsuke.args4j.CmdLineParser to org.eclipse.jgit.pgm.opt.CmdLineParser in new org.eclipse.jgit.pgm.opt.ObjectIdHandler(CmdLineParser, OptionDef, Setter) STYLE BC_UNCONFIRMED_CAST 79 Medium

org.eclipse.jgit.pgm.opt.RevCommitHandler

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.kohsuke.args4j.CmdLineParser to org.eclipse.jgit.pgm.opt.CmdLineParser in new org.eclipse.jgit.pgm.opt.RevCommitHandler(CmdLineParser, OptionDef, Setter) STYLE BC_UNCONFIRMED_CAST 83 Medium

org.eclipse.jgit.pgm.opt.RevTreeHandler

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.kohsuke.args4j.CmdLineParser to org.eclipse.jgit.pgm.opt.CmdLineParser in new org.eclipse.jgit.pgm.opt.RevTreeHandler(CmdLineParser, OptionDef, Setter) STYLE BC_UNCONFIRMED_CAST 82 Medium

org.eclipse.jgit.pgm.opt.SubcommandHandler

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.kohsuke.args4j.CmdLineParser to org.eclipse.jgit.pgm.opt.CmdLineParser in new org.eclipse.jgit.pgm.opt.SubcommandHandler(CmdLineParser, OptionDef, Setter) STYLE BC_UNCONFIRMED_CAST 80 Medium