FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.1.0-RC3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
1490 148 0 5

Files

Class Bugs
org.eclipse.jgit.api.ApplyCommand 3
org.eclipse.jgit.api.CloneCommand 1
org.eclipse.jgit.api.CommitCommand 1
org.eclipse.jgit.api.GarbageCollectCommand 1
org.eclipse.jgit.api.MergeResult 2
org.eclipse.jgit.api.RebaseCommand 4
org.eclipse.jgit.api.RevertCommand 1
org.eclipse.jgit.api.SubmoduleStatusCommand 1
org.eclipse.jgit.api.errors.FilterFailedException 2
org.eclipse.jgit.attributes.AttributesHandler 1
org.eclipse.jgit.attributes.FilterCommand 2
org.eclipse.jgit.diff.RawText 1
org.eclipse.jgit.dircache.DirCacheCheckout 2
org.eclipse.jgit.dircache.DirCacheEntry 1
org.eclipse.jgit.dircache.DirCacheIterator 2
org.eclipse.jgit.errors.CheckoutConflictException 2
org.eclipse.jgit.gitrepo.ManifestParser 1
org.eclipse.jgit.internal.ketch.KetchLeader 3
org.eclipse.jgit.internal.ketch.LeaderSnapshot 1
org.eclipse.jgit.internal.ketch.Proposal 5
org.eclipse.jgit.internal.storage.dfs.BlockBasedFile 1
org.eclipse.jgit.internal.storage.dfs.DfsBlockCache 1
org.eclipse.jgit.internal.storage.dfs.DfsCachedPack 1
org.eclipse.jgit.internal.storage.dfs.DfsObjDatabase 1
org.eclipse.jgit.internal.storage.dfs.DfsObjectToPack 2
org.eclipse.jgit.internal.storage.dfs.DfsReader 1
org.eclipse.jgit.internal.storage.dfs.DfsStreamKey$ByteArrayDfsStreamKey 1
org.eclipse.jgit.internal.storage.dfs.DfsStreamKey$ForReverseIndex 1
org.eclipse.jgit.internal.storage.dfs.InMemoryRepository$MemObjDatabase 1
org.eclipse.jgit.internal.storage.dfs.InMemoryRepository$MemPack 1
org.eclipse.jgit.internal.storage.file.GC 6
org.eclipse.jgit.internal.storage.file.GcLog 1
org.eclipse.jgit.internal.storage.file.LocalCachedPack 1
org.eclipse.jgit.internal.storage.file.LocalObjectToPack 2
org.eclipse.jgit.internal.storage.file.LockFile 1
org.eclipse.jgit.internal.storage.file.ObjectDirectory 4
org.eclipse.jgit.internal.storage.file.ObjectDirectoryPackParser 1
org.eclipse.jgit.internal.storage.file.PackBitmapIndexRemapper$Entry 1
org.eclipse.jgit.internal.storage.file.PackFile 1
org.eclipse.jgit.internal.storage.file.PackIndexWriter 2
org.eclipse.jgit.internal.storage.file.PackInserter 1
org.eclipse.jgit.internal.storage.file.WindowCursor 1
org.eclipse.jgit.internal.storage.pack.DeltaIndex 1
org.eclipse.jgit.internal.storage.pack.DeltaTask$WeightedPath 1
org.eclipse.jgit.internal.storage.pack.ObjectToPack 1
org.eclipse.jgit.internal.storage.pack.PackExt 1
org.eclipse.jgit.internal.storage.pack.PackOutputStream 2
org.eclipse.jgit.internal.storage.pack.PackWriterBitmapPreparer 1
org.eclipse.jgit.internal.storage.pack.PackWriterBitmapPreparer$CommitSelectionHelper$1 1
org.eclipse.jgit.internal.storage.reftable.ReftableWriter$RefList 1
org.eclipse.jgit.lib.CommitBuilder 1
org.eclipse.jgit.lib.ConfigSnapshot$LineComparator 1
org.eclipse.jgit.lib.Constants 5
org.eclipse.jgit.lib.DefaultTypedConfigGetter 1
org.eclipse.jgit.lib.ObjectChecker 10
org.eclipse.jgit.lib.ObjectLoader$SmallObject 2
org.eclipse.jgit.lib.ObjectStream$SmallStream 1
org.eclipse.jgit.lib.RebaseTodoFile 1
org.eclipse.jgit.lib.RefDatabase 1
org.eclipse.jgit.lib.RepositoryCache 2
org.eclipse.jgit.merge.Merger 1
org.eclipse.jgit.merge.ResolveMerger 3
org.eclipse.jgit.patch.FileHeader 1
org.eclipse.jgit.patch.FormatError 1
org.eclipse.jgit.revwalk.ObjectWalk 1
org.eclipse.jgit.revwalk.RevCommit 2
org.eclipse.jgit.transport.AmazonS3 1
org.eclipse.jgit.transport.CredentialItem$CharArrayType 2
org.eclipse.jgit.transport.FetchProcess 1
org.eclipse.jgit.transport.HttpTransport 1
org.eclipse.jgit.transport.JschConfigSessionFactory 1
org.eclipse.jgit.transport.NetRC 1
org.eclipse.jgit.transport.OpenSshConfig 1
org.eclipse.jgit.transport.PackParser$DeltaChain 1
org.eclipse.jgit.transport.PushCertificateParser 1
org.eclipse.jgit.transport.SideBandInputStream 1
org.eclipse.jgit.transport.Transport 1
org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider 1
org.eclipse.jgit.transport.WalkFetchConnection 2
org.eclipse.jgit.treewalk.AbstractTreeIterator 2
org.eclipse.jgit.treewalk.CanonicalTreeParser 2
org.eclipse.jgit.treewalk.EmptyTreeIterator 1
org.eclipse.jgit.treewalk.WorkingTreeIterator 2
org.eclipse.jgit.util.Base64 2
org.eclipse.jgit.util.FS_POSIX 2
org.eclipse.jgit.util.FS_Win32 1
org.eclipse.jgit.util.IO 1
org.eclipse.jgit.util.QuotedString$BourneStyle 1
org.eclipse.jgit.util.RawCharSequence 1
org.eclipse.jgit.util.RawParseUtils 2
org.eclipse.jgit.util.SystemReader 2
org.eclipse.jgit.util.io.AutoCRLFInputStream 1

org.eclipse.jgit.api.ApplyCommand

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.api.ApplyCommand.apply(File, FileHeader): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 262 High
org.eclipse.jgit.api.ApplyCommand.apply(File, FileHeader) may fail to clean up java.io.Writer on checked exception EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE 262 Medium
Switch statement found in org.eclipse.jgit.api.ApplyCommand.apply(File, FileHeader) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 218-242 Medium

org.eclipse.jgit.api.CloneCommand

Bug Category Details Line Priority
Possible null pointer dereference in org.eclipse.jgit.api.CloneCommand.deleteChildren(File) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 687 Medium

org.eclipse.jgit.api.CommitCommand

Bug Category Details Line Priority
Return value of org.eclipse.jgit.revwalk.RevCommit.getTree() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 250 Medium

org.eclipse.jgit.api.GarbageCollectCommand

Bug Category Details Line Priority
org.eclipse.jgit.api.GarbageCollectCommand.setExpire(Date) may expose internal representation by storing an externally mutable object into GarbageCollectCommand.expire MALICIOUS_CODE EI_EXPOSE_REP2 129 Medium

org.eclipse.jgit.api.MergeResult

Bug Category Details Line Priority
org.eclipse.jgit.api.MergeResult.getMergedCommits() may expose internal representation by returning MergeResult.mergedCommits MALICIOUS_CODE EI_EXPOSE_REP 374 Medium
new org.eclipse.jgit.api.MergeResult(ObjectId, ObjectId, ObjectId[], MergeResult$MergeStatus, MergeStrategy, Map, Map, String) may expose internal representation by storing an externally mutable object into MergeResult.mergedCommits MALICIOUS_CODE EI_EXPOSE_REP2 332 Medium

org.eclipse.jgit.api.RebaseCommand

Bug Category Details Line Priority
Exceptional return value of java.io.File.createNewFile() ignored in org.eclipse.jgit.api.RebaseCommand.calculatePickList(RevCommit) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1194 Medium
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.api.RebaseCommand.processStep(RebaseTodoLine, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 489 Medium
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.api.RebaseCommand.squashIntoPrevious(boolean, RebaseTodoLine) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 792 Medium
Switch statement found in org.eclipse.jgit.api.RebaseCommand.processStep(RebaseTodoLine, boolean) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 479-482 Medium

org.eclipse.jgit.api.RevertCommand

Bug Category Details Line Priority
Load of known null value in org.eclipse.jgit.api.RevertCommand.call() STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 209 Medium

org.eclipse.jgit.api.SubmoduleStatusCommand

Bug Category Details Line Priority
Load of known null value in org.eclipse.jgit.api.SubmoduleStatusCommand.getStatus(SubmoduleWalk) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 143 Medium

org.eclipse.jgit.api.errors.FilterFailedException

Bug Category Details Line Priority
org.eclipse.jgit.api.errors.FilterFailedException.getOutput() may expose internal representation by returning FilterFailedException.stdout MALICIOUS_CODE EI_EXPOSE_REP 127 Medium
new org.eclipse.jgit.api.errors.FilterFailedException(int, String, String, byte[], String) may expose internal representation by storing an externally mutable object into FilterFailedException.stdout MALICIOUS_CODE EI_EXPOSE_REP2 104 Medium

org.eclipse.jgit.attributes.AttributesHandler

Bug Category Details Line Priority
Redundant nullcheck of t, which is known to be non-null in org.eclipse.jgit.attributes.AttributesHandler.rootOf(AbstractTreeIterator) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 429 Medium

org.eclipse.jgit.attributes.FilterCommand

Bug Category Details Line Priority
Unread public/protected field: org.eclipse.jgit.attributes.FilterCommand.in STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 75 Medium
Unread public/protected field: org.eclipse.jgit.attributes.FilterCommand.out STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 76 Medium

org.eclipse.jgit.diff.RawText

Bug Category Details Line Priority
new org.eclipse.jgit.diff.RawText(byte[]) may expose internal representation by storing an externally mutable object into RawText.content MALICIOUS_CODE EI_EXPOSE_REP2 91 Medium

org.eclipse.jgit.dircache.DirCacheCheckout

Bug Category Details Line Priority
Load of known null value in org.eclipse.jgit.dircache.DirCacheCheckout.processEntry(CanonicalTreeParser, CanonicalTreeParser, DirCacheBuildIterator, WorkingTreeIterator) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 948 Medium
Load of known null value in org.eclipse.jgit.dircache.DirCacheCheckout.processEntry(CanonicalTreeParser, CanonicalTreeParser, DirCacheBuildIterator, WorkingTreeIterator) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 1016 Medium

org.eclipse.jgit.dircache.DirCacheEntry

Bug Category Details Line Priority
new org.eclipse.jgit.dircache.DirCacheEntry(byte[], int) may expose internal representation by storing an externally mutable object into DirCacheEntry.path MALICIOUS_CODE EI_EXPOSE_REP2 287 Medium

org.eclipse.jgit.dircache.DirCacheIterator

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.dircache.DirCacheIterator.<static initializer for DirCacheIterator>(): String.getBytes() I18N DM_DEFAULT_ENCODING 77 High
org.eclipse.jgit.dircache.DirCacheIterator.idBuffer() may expose internal representation by returning DirCacheIterator.zeroid MALICIOUS_CODE EI_EXPOSE_REP 164 Medium

org.eclipse.jgit.errors.CheckoutConflictException

Bug Category Details Line Priority
org.eclipse.jgit.errors.CheckoutConflictException.getConflictingFiles() may expose internal representation by returning CheckoutConflictException.conflicting MALICIOUS_CODE EI_EXPOSE_REP 87 Medium
new org.eclipse.jgit.errors.CheckoutConflictException(String[]) may expose internal representation by storing an externally mutable object into CheckoutConflictException.conflicting MALICIOUS_CODE EI_EXPOSE_REP2 78 Medium

org.eclipse.jgit.gitrepo.ManifestParser

Bug Category Details Line Priority
org.eclipse.jgit.gitrepo.ManifestParser.startElement(String, String, String, Attributes) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 239 Medium

org.eclipse.jgit.internal.ketch.KetchLeader

Bug Category Details Line Priority
Switch statement found in org.eclipse.jgit.internal.ketch.KetchLeader.onReplicaUpdate(KetchReplica) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 512-517 Medium
org.eclipse.jgit.internal.ketch.KetchLeader.notifySuccess(Round) does not release lock on all paths MT_CORRECTNESS UL_UNRELEASED_LOCK 543 High
org.eclipse.jgit.internal.ketch.KetchLeader.notifySuccess(Round) does not release lock on all exception paths MT_CORRECTNESS UL_UNRELEASED_LOCK_EXCEPTION_PATH 543 Medium

org.eclipse.jgit.internal.ketch.LeaderSnapshot

Bug Category Details Line Priority
Format string should use %n rather than \n in org.eclipse.jgit.internal.ketch.LeaderSnapshot.toString() BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 122 Medium

org.eclipse.jgit.internal.ketch.Proposal

Bug Category Details Line Priority
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.ketch.Proposal.addListener(Runnable) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 266 Medium
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.ketch.Proposal.await() MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 316 Medium
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.ketch.Proposal.await(long, TimeUnit) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 335 Medium
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.ketch.Proposal.awaitStateChange(Proposal$State, long, TimeUnit) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 359 Medium
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.ketch.Proposal.notifyState(Proposal$State) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 369 Medium

org.eclipse.jgit.internal.storage.dfs.BlockBasedFile

Bug Category Details Line Priority
Dead store to len in org.eclipse.jgit.internal.storage.dfs.BlockBasedFile.readOneBlock(long, DfsReader, ReadableChannel) STYLE DLS_DEAD_LOCAL_STORE 187 Medium

org.eclipse.jgit.internal.storage.dfs.DfsBlockCache

Bug Category Details Line Priority
Increment of volatile field org.eclipse.jgit.internal.storage.dfs.DfsBlockCache.statEvict in org.eclipse.jgit.internal.storage.dfs.DfsBlockCache.reserveSpace(int) MT_CORRECTNESS VO_VOLATILE_INCREMENT 361 High

org.eclipse.jgit.internal.storage.dfs.DfsCachedPack

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.eclipse.jgit.internal.storage.pack.StoredObjectRepresentation to org.eclipse.jgit.internal.storage.dfs.DfsObjectRepresentation in org.eclipse.jgit.internal.storage.dfs.DfsCachedPack.hasObject(ObjectToPack, StoredObjectRepresentation) STYLE BC_UNCONFIRMED_CAST 78 Medium

org.eclipse.jgit.internal.storage.dfs.DfsObjDatabase

Bug Category Details Line Priority
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.storage.dfs.DfsObjDatabase.scanPacks(DfsObjDatabase$PackList) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 462 Medium

org.eclipse.jgit.internal.storage.dfs.DfsObjectToPack

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.eclipse.jgit.internal.storage.pack.StoredObjectRepresentation to org.eclipse.jgit.internal.storage.dfs.DfsObjectRepresentation in org.eclipse.jgit.internal.storage.dfs.DfsObjectToPack.select(StoredObjectRepresentation) STYLE BC_UNCONFIRMED_CAST 83 Medium
Class org.eclipse.jgit.internal.storage.dfs.DfsObjectToPack defines non-transient non-serializable instance field pack BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.eclipse.jgit.internal.storage.dfs.DfsReader

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.eclipse.jgit.internal.storage.pack.ObjectToPack to org.eclipse.jgit.internal.storage.dfs.DfsObjectToPack in org.eclipse.jgit.internal.storage.dfs.DfsReader.copyObjectAsIs(PackOutputStream, ObjectToPack, boolean) STYLE BC_UNCONFIRMED_CAST 638 Medium

org.eclipse.jgit.internal.storage.dfs.DfsStreamKey$ByteArrayDfsStreamKey

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.dfs.DfsStreamKey$ByteArrayDfsStreamKey defines equals but not hashCode BAD_PRACTICE HE_EQUALS_NO_HASHCODE 101-107 Medium

org.eclipse.jgit.internal.storage.dfs.DfsStreamKey$ForReverseIndex

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.dfs.DfsStreamKey$ForReverseIndex defines equals but not hashCode BAD_PRACTICE HE_EQUALS_NO_HASHCODE 121 Medium

org.eclipse.jgit.internal.storage.dfs.InMemoryRepository$MemObjDatabase

Bug Category Details Line Priority
Should org.eclipse.jgit.internal.storage.dfs.InMemoryRepository$MemObjDatabase be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 111-172 Medium

org.eclipse.jgit.internal.storage.dfs.InMemoryRepository$MemPack

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.dfs.InMemoryRepository$MemPack doesn't override DfsPackDescription.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.eclipse.jgit.internal.storage.file.GC

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.file.GC.setExpire(Date) may expose internal representation by storing an externally mutable object into GC.expire MALICIOUS_CODE EI_EXPOSE_REP2 1424 Medium
org.eclipse.jgit.internal.storage.file.GC.setPackExpire(Date) may expose internal representation by storing an externally mutable object into GC.packExpire MALICIOUS_CODE EI_EXPOSE_REP2 1438 Medium
org.eclipse.jgit.internal.storage.file.GC.deleteTempPacksIdx() may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 970 Medium
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.internal.storage.file.GC.prune(Set) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 680 Medium
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.internal.storage.file.GC.writePack(Set, Set, Set, Set, List) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1233 Medium
Exceptional return value of java.io.File.setReadOnly() ignored in org.eclipse.jgit.internal.storage.file.GC.writePack(Set, Set, Set, Set, List) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1202 Medium

org.eclipse.jgit.internal.storage.file.GcLog

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.internal.storage.file.GcLog.commit() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 171 Medium

org.eclipse.jgit.internal.storage.file.LocalCachedPack

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.eclipse.jgit.internal.storage.pack.StoredObjectRepresentation to org.eclipse.jgit.internal.storage.file.LocalObjectRepresentation in org.eclipse.jgit.internal.storage.file.LocalCachedPack.hasObject(ObjectToPack, StoredObjectRepresentation) STYLE BC_UNCONFIRMED_CAST 91 Medium

org.eclipse.jgit.internal.storage.file.LocalObjectToPack

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.eclipse.jgit.internal.storage.pack.StoredObjectRepresentation to org.eclipse.jgit.internal.storage.file.LocalObjectRepresentation in org.eclipse.jgit.internal.storage.file.LocalObjectToPack.select(StoredObjectRepresentation) STYLE BC_UNCONFIRMED_CAST 73 Medium
Class org.eclipse.jgit.internal.storage.file.LocalObjectToPack defines non-transient non-serializable instance field pack BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.eclipse.jgit.internal.storage.file.LockFile

Bug Category Details Line Priority
Exceptional return value of java.io.File.setLastModified(long) ignored in org.eclipse.jgit.internal.storage.file.LockFile.waitForStatChange() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 433 Medium

org.eclipse.jgit.internal.storage.file.ObjectDirectory

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.internal.storage.file.ObjectDirectory.open(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 1039 High
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.storage.file.ObjectDirectory.myAlternates() MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 1000 Medium
Synchronization performed on java.util.concurrent.atomic.AtomicReference in org.eclipse.jgit.internal.storage.file.ObjectDirectory.scanPacks(ObjectDirectory$PackList) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 865 Medium
Exceptional return value of java.io.File.setReadOnly() ignored in org.eclipse.jgit.internal.storage.file.ObjectDirectory.insertUnpackedObject(File, ObjectId, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 720 Medium

org.eclipse.jgit.internal.storage.file.ObjectDirectoryPackParser

Bug Category Details Line Priority
Exceptional return value of java.io.File.setReadOnly() ignored in org.eclipse.jgit.internal.storage.file.ObjectDirectoryPackParser.parse(ProgressMonitor, ProgressMonitor) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 204 Medium

org.eclipse.jgit.internal.storage.file.PackBitmapIndexRemapper$Entry

Bug Category Details Line Priority
Should org.eclipse.jgit.internal.storage.file.PackBitmapIndexRemapper$Entry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 206-213 Medium

org.eclipse.jgit.internal.storage.file.PackFile

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.file.PackFile.mmap(long, int) forces garbage collection; extremely dubious except in benchmarking code PERFORMANCE DM_GC 716 High

org.eclipse.jgit.internal.storage.file.PackIndexWriter

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.file.PackIndexWriter.write(List, byte[]) may expose internal representation by storing an externally mutable object into PackIndexWriter.packChecksum MALICIOUS_CODE EI_EXPOSE_REP2 210 Medium
org.eclipse.jgit.internal.storage.file.PackIndexWriter.TOC should be package protected MALICIOUS_CODE MS_PKGPROTECT 69 Medium

org.eclipse.jgit.internal.storage.file.PackInserter

Bug Category Details Line Priority
Exceptional return value of java.io.File.setReadOnly() ignored in org.eclipse.jgit.internal.storage.file.PackInserter.flush() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 269 Medium

org.eclipse.jgit.internal.storage.file.WindowCursor

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.eclipse.jgit.internal.storage.pack.ObjectToPack to org.eclipse.jgit.internal.storage.file.LocalObjectToPack in org.eclipse.jgit.internal.storage.file.WindowCursor.copyObjectAsIs(PackOutputStream, ObjectToPack, boolean) STYLE BC_UNCONFIRMED_CAST 209 Medium

org.eclipse.jgit.internal.storage.pack.DeltaIndex

Bug Category Details Line Priority
new org.eclipse.jgit.internal.storage.pack.DeltaIndex(byte[]) may expose internal representation by storing an externally mutable object into DeltaIndex.src MALICIOUS_CODE EI_EXPOSE_REP2 133 Medium

org.eclipse.jgit.internal.storage.pack.DeltaTask$WeightedPath

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.pack.DeltaTask$WeightedPath defines compareTo(DeltaTask$WeightedPath) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 250-254 Medium

org.eclipse.jgit.internal.storage.pack.ObjectToPack

Bug Category Details Line Priority
Class org.eclipse.jgit.internal.storage.pack.ObjectToPack defines non-transient non-serializable instance field cachedDelta BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.eclipse.jgit.internal.storage.pack.PackExt

Bug Category Details Line Priority
Public static org.eclipse.jgit.internal.storage.pack.PackExt.values() may expose internal representation by returning PackExt.VALUES MALICIOUS_CODE MS_EXPOSE_REP 67 Medium

org.eclipse.jgit.internal.storage.pack.PackOutputStream

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.pack.PackOutputStream.getCopyBuffer() may expose internal representation by returning PackOutputStream.copyBuffer MALICIOUS_CODE EI_EXPOSE_REP 229 Medium
Potentially dangerous use of non-short-circuit logic in org.eclipse.jgit.internal.storage.pack.PackOutputStream.writeHeader(ObjectToPack, long) STYLE NS_DANGEROUS_NON_SHORT_CIRCUIT 186 High

org.eclipse.jgit.internal.storage.pack.PackWriterBitmapPreparer

Bug Category Details Line Priority
Result of integer multiplication cast to long in new org.eclipse.jgit.internal.storage.pack.PackWriterBitmapPreparer(ObjectReader, PackBitmapIndexBuilder, ProgressMonitor, Set, PackConfig) STYLE ICAST_INTEGER_MULTIPLY_CAST_TO_LONG 134 Medium

org.eclipse.jgit.internal.storage.pack.PackWriterBitmapPreparer$CommitSelectionHelper$1

Bug Category Details Line Priority
org.eclipse.jgit.internal.storage.pack.PackWriterBitmapPreparer$CommitSelectionHelper$1.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 605 Medium

org.eclipse.jgit.internal.storage.reftable.ReftableWriter$RefList

Bug Category Details Line Priority
Class org.eclipse.jgit.internal.storage.reftable.ReftableWriter$RefList defines non-transient non-serializable instance field blockPos BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.eclipse.jgit.lib.CommitBuilder

Bug Category Details Line Priority
org.eclipse.jgit.lib.CommitBuilder.getParentIds() may expose internal representation by returning CommitBuilder.parentIds MALICIOUS_CODE EI_EXPOSE_REP 144 Medium

org.eclipse.jgit.lib.ConfigSnapshot$LineComparator

Bug Category Details Line Priority
org.eclipse.jgit.lib.ConfigSnapshot$LineComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 219-222 Medium

org.eclipse.jgit.lib.Constants

Bug Category Details Line Priority
Public static org.eclipse.jgit.lib.Constants.encodedTypeString(int) may expose internal representation by returning Constants.ENCODED_TYPE_BLOB MALICIOUS_CODE MS_EXPOSE_REP 501 Medium
Public static org.eclipse.jgit.lib.Constants.encodedTypeString(int) may expose internal representation by returning Constants.ENCODED_TYPE_COMMIT MALICIOUS_CODE MS_EXPOSE_REP 497 Medium
Public static org.eclipse.jgit.lib.Constants.encodedTypeString(int) may expose internal representation by returning Constants.ENCODED_TYPE_TAG MALICIOUS_CODE MS_EXPOSE_REP 503 Medium
Public static org.eclipse.jgit.lib.Constants.encodedTypeString(int) may expose internal representation by returning Constants.ENCODED_TYPE_TREE MALICIOUS_CODE MS_EXPOSE_REP 499 Medium
org.eclipse.jgit.lib.Constants.PACK_SIGNATURE is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 224 Medium

org.eclipse.jgit.lib.DefaultTypedConfigGetter

Bug Category Details Line Priority
Switch statement found in org.eclipse.jgit.lib.DefaultTypedConfigGetter.getLong(Config, String, String, String, long) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 165-173 Medium

org.eclipse.jgit.lib.ObjectChecker

Bug Category Details Line Priority
org.eclipse.jgit.lib.ObjectChecker.author is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 119 Medium
org.eclipse.jgit.lib.ObjectChecker.committer is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 122 Medium
org.eclipse.jgit.lib.ObjectChecker.encoding is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 125 Medium
org.eclipse.jgit.lib.ObjectChecker.tagger is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 137 Medium
org.eclipse.jgit.lib.ObjectChecker.object should be package protected MALICIOUS_CODE MS_PKGPROTECT 128 Medium
org.eclipse.jgit.lib.ObjectChecker.parent should be package protected MALICIOUS_CODE MS_PKGPROTECT 116 Medium
org.eclipse.jgit.lib.ObjectChecker.tag should be package protected MALICIOUS_CODE MS_PKGPROTECT 134 Medium
org.eclipse.jgit.lib.ObjectChecker.tree should be package protected MALICIOUS_CODE MS_PKGPROTECT 113 Medium
org.eclipse.jgit.lib.ObjectChecker.type should be package protected MALICIOUS_CODE MS_PKGPROTECT 131 Medium
Switch statement found in org.eclipse.jgit.lib.ObjectChecker.checkNotWindowsDevice(byte[], int, int, AnyObjectId) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 944-1001 Medium

org.eclipse.jgit.lib.ObjectLoader$SmallObject

Bug Category Details Line Priority
org.eclipse.jgit.lib.ObjectLoader$SmallObject.getCachedBytes() may expose internal representation by returning ObjectLoader$SmallObject.data MALICIOUS_CODE EI_EXPOSE_REP 318 Medium
new org.eclipse.jgit.lib.ObjectLoader$SmallObject(int, byte[]) may expose internal representation by storing an externally mutable object into ObjectLoader$SmallObject.data MALICIOUS_CODE EI_EXPOSE_REP2 298 Medium

org.eclipse.jgit.lib.ObjectStream$SmallStream

Bug Category Details Line Priority
new org.eclipse.jgit.lib.ObjectStream$SmallStream(int, byte[]) may expose internal representation by storing an externally mutable object into ObjectStream$SmallStream.data MALICIOUS_CODE EI_EXPOSE_REP2 93 Medium

org.eclipse.jgit.lib.RebaseTodoFile

Bug Category Details Line Priority
Redundant nullcheck of action, which is known to be non-null in org.eclipse.jgit.lib.RebaseTodoFile.parseLine(byte[], int, int) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 186 Medium

org.eclipse.jgit.lib.RefDatabase

Bug Category Details Line Priority
org.eclipse.jgit.lib.RefDatabase.SEARCH_PATH is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 73 High

org.eclipse.jgit.lib.RepositoryCache

Bug Category Details Line Priority
Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.eclipse.jgit.lib.RepositoryCache.openRepository(RepositoryCache$Key, boolean) MT_CORRECTNESS AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION 268 Medium
Synchronization performed on java.util.concurrent.ScheduledThreadPoolExecutor in org.eclipse.jgit.lib.RepositoryCache.configureEviction(RepositoryCacheConfig) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 239 Medium

org.eclipse.jgit.merge.Merger

Bug Category Details Line Priority
Unread public/protected field: org.eclipse.jgit.merge.Merger.monitor STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 107 Medium

org.eclipse.jgit.merge.ResolveMerger

Bug Category Details Line Priority
org.eclipse.jgit.merge.ResolveMerger.getCommitNames() may expose internal representation by returning ResolveMerger.commitNames MALICIOUS_CODE EI_EXPOSE_REP 983 Medium
org.eclipse.jgit.merge.ResolveMerger.setCommitNames(String[]) may expose internal representation by storing an externally mutable object into ResolveMerger.commitNames MALICIOUS_CODE EI_EXPOSE_REP2 975 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.eclipse.jgit.merge.ResolveMerger.writeMergedFile(MergeResult) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 896 Medium

org.eclipse.jgit.patch.FileHeader

Bug Category Details Line Priority
org.eclipse.jgit.patch.FileHeader.getBuffer() may expose internal representation by returning FileHeader.buf MALICIOUS_CODE EI_EXPOSE_REP 169 Medium

org.eclipse.jgit.patch.FormatError

Bug Category Details Line Priority
org.eclipse.jgit.patch.FormatError.getBuffer() may expose internal representation by returning FormatError.buf MALICIOUS_CODE EI_EXPOSE_REP 90 Medium

org.eclipse.jgit.revwalk.ObjectWalk

Bug Category Details Line Priority
org.eclipse.jgit.revwalk.ObjectWalk.getPathBuffer() may expose internal representation by returning ObjectWalk.pathBuf MALICIOUS_CODE EI_EXPOSE_REP 625 Medium

org.eclipse.jgit.revwalk.RevCommit

Bug Category Details Line Priority
org.eclipse.jgit.revwalk.RevCommit.getParents() may expose internal representation by returning RevCommit.parents MALICIOUS_CODE EI_EXPOSE_REP 367 Medium
org.eclipse.jgit.revwalk.RevCommit.getRawBuffer() may expose internal representation by returning RevCommit.buffer MALICIOUS_CODE EI_EXPOSE_REP 383 Medium

org.eclipse.jgit.transport.AmazonS3

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.transport.AmazonS3.error(String, String, HttpURLConnection): new String(byte[]) I18N DM_DEFAULT_ENCODING 550 High

org.eclipse.jgit.transport.CredentialItem$CharArrayType

Bug Category Details Line Priority
org.eclipse.jgit.transport.CredentialItem$CharArrayType.getValue() may expose internal representation by returning CredentialItem$CharArrayType.value MALICIOUS_CODE EI_EXPOSE_REP 184 Medium
org.eclipse.jgit.transport.CredentialItem$CharArrayType.setValueNoCopy(char[]) may expose internal representation by storing an externally mutable object into CredentialItem$CharArrayType.value MALICIOUS_CODE EI_EXPOSE_REP2 210 Medium

org.eclipse.jgit.transport.FetchProcess

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.transport.FetchProcess.updateFETCH_HEAD(FetchResult): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 321 High

org.eclipse.jgit.transport.HttpTransport

Bug Category Details Line Priority
org.eclipse.jgit.transport.HttpTransport.connectionFactory should be package protected MALICIOUS_CODE MS_PKGPROTECT 62 Medium

org.eclipse.jgit.transport.JschConfigSessionFactory

Bug Category Details Line Priority
org.eclipse.jgit.transport.JschConfigSessionFactory.getSession(URIish, CredentialsProvider, FS, int) calls Thread.sleep() with a lock held MT_CORRECTNESS SWL_SLEEP_WITH_LOCK_HELD 149 Medium

org.eclipse.jgit.transport.NetRC

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.transport.NetRC.parse(): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 209 High

org.eclipse.jgit.transport.OpenSshConfig

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.transport.OpenSshConfig.parse(InputStream): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 243 High

org.eclipse.jgit.transport.PackParser$DeltaChain

Bug Category Details Line Priority
Class org.eclipse.jgit.transport.PackParser$DeltaChain defines non-transient non-serializable instance field head BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.eclipse.jgit.transport.PushCertificateParser

Bug Category Details Line Priority
Redundant nullcheck of org.eclipse.jgit.transport.PushCertificateParser.pusher, which is known to be non-null in org.eclipse.jgit.transport.PushCertificateParser.receiveHeader(PushCertificateParser$StringReader, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 376 Medium

org.eclipse.jgit.transport.SideBandInputStream

Bug Category Details Line Priority
Found reliance on default encoding in org.eclipse.jgit.transport.SideBandInputStream.doProgressLine(String): String.getBytes() I18N DM_DEFAULT_ENCODING 236 High

org.eclipse.jgit.transport.Transport

Bug Category Details Line Priority
Uninitialized read of hookOutRedirect in new org.eclipse.jgit.transport.Transport(Repository, URIish) CORRECTNESS UR_UNINIT_READ 834 Medium

org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider

Bug Category Details Line Priority
new org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider(String, char[]) may expose internal representation by storing an externally mutable object into UsernamePasswordCredentialsProvider.password MALICIOUS_CODE EI_EXPOSE_REP2 76 Medium

org.eclipse.jgit.transport.WalkFetchConnection

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.transport.WalkFetchConnection.close() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 268 Medium
Switch statement found in org.eclipse.jgit.transport.WalkFetchConnection.markLocalObjComplete(RevObject) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 717-725 Medium

org.eclipse.jgit.treewalk.AbstractTreeIterator

Bug Category Details Line Priority
org.eclipse.jgit.treewalk.AbstractTreeIterator.getEntryPathBuffer() may expose internal representation by returning AbstractTreeIterator.path MALICIOUS_CODE EI_EXPOSE_REP 474 Medium
org.eclipse.jgit.treewalk.AbstractTreeIterator.zeroid is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 90 Medium

org.eclipse.jgit.treewalk.CanonicalTreeParser

Bug Category Details Line Priority
org.eclipse.jgit.treewalk.CanonicalTreeParser.idBuffer() may expose internal representation by returning CanonicalTreeParser.raw MALICIOUS_CODE EI_EXPOSE_REP 265 Medium
org.eclipse.jgit.treewalk.CanonicalTreeParser.reset(byte[]) may expose internal representation by storing an externally mutable object into CanonicalTreeParser.raw MALICIOUS_CODE EI_EXPOSE_REP2 139 Medium

org.eclipse.jgit.treewalk.EmptyTreeIterator

Bug Category Details Line Priority
org.eclipse.jgit.treewalk.EmptyTreeIterator.idBuffer() may expose internal representation by returning EmptyTreeIterator.zeroid MALICIOUS_CODE EI_EXPOSE_REP 107 Medium

org.eclipse.jgit.treewalk.WorkingTreeIterator

Bug Category Details Line Priority
org.eclipse.jgit.treewalk.WorkingTreeIterator.idBuffer() may expose internal representation by returning WorkingTreeIterator.contentId MALICIOUS_CODE EI_EXPOSE_REP 264 Medium
org.eclipse.jgit.treewalk.WorkingTreeIterator.idBuffer() may expose internal representation by returning WorkingTreeIterator.zeroid MALICIOUS_CODE EI_EXPOSE_REP 295 Medium

org.eclipse.jgit.util.Base64

Bug Category Details Line Priority
Switch statement found in org.eclipse.jgit.util.Base64.encode3to4(byte[], int, int, byte[], int) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 115-119 Medium
Switch statement found in org.eclipse.jgit.util.Base64.encode3to4(byte[], int, int, byte[], int) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 113-123 Medium

org.eclipse.jgit.util.FS_POSIX

Bug Category Details Line Priority
org.eclipse.jgit.util.FS_POSIX.getAtomicFileCreationSupportOption(FileBasedConfig) has Boolean return type and returns explicit null BAD_PRACTICE NP_BOOLEAN_RETURN_NULL 122 Medium
Exception is caught when Exception is not thrown in org.eclipse.jgit.util.FS_POSIX.readUmask() STYLE REC_CATCH_EXCEPTION 172 Medium

org.eclipse.jgit.util.FS_Win32

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.util.FS_Win32.detectSymlinkSupport() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 189 Medium

org.eclipse.jgit.util.IO

Bug Category Details Line Priority
org.eclipse.jgit.util.IO.readWholeStream(InputStream, int) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 221 Medium

org.eclipse.jgit.util.QuotedString$BourneStyle

Bug Category Details Line Priority
Switch statement found in org.eclipse.jgit.util.QuotedString$BourneStyle.quote(String) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 143-151 Medium

org.eclipse.jgit.util.RawCharSequence

Bug Category Details Line Priority
new org.eclipse.jgit.util.RawCharSequence(byte[], int, int) may expose internal representation by storing an externally mutable object into RawCharSequence.buffer MALICIOUS_CODE EI_EXPOSE_REP2 72 Medium

org.eclipse.jgit.util.RawParseUtils

Bug Category Details Line Priority
Switch statement found in org.eclipse.jgit.util.RawParseUtils.parseBase10(byte[], int, MutableInteger) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 218-224 Medium
Switch statement found in org.eclipse.jgit.util.RawParseUtils.parseLongBase10(byte[], int, MutableInteger) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 272-278 Medium

org.eclipse.jgit.util.SystemReader

Bug Category Details Line Priority
Write to static field org.eclipse.jgit.util.SystemReader.isMacOS from instance method org.eclipse.jgit.util.SystemReader.isMacOS() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 333 Medium
Write to static field org.eclipse.jgit.util.SystemReader.isWindows from instance method org.eclipse.jgit.util.SystemReader.isWindows() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 322 Medium

org.eclipse.jgit.util.io.AutoCRLFInputStream

Bug Category Details Line Priority
Useless condition: it's known that b == 10 at this point STYLE UC_USELESS_CONDITION 130 High