Change Log Report

Total number of changed sets: 1

Changes between tags 'v4.11.0.201803080745-r' and 'v5.0.0.201806131550-r'

Total commits: 19
Total number of files changed: 23

Timestamp Author Details
2018-06-13 21:42:40 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v e729a83bd24bbc25f7ac209baee01f561fe218c8
org.eclipse.jgit.http.server/pom.xml v e729a83bd24bbc25f7ac209baee01f561fe218c8

JGit v5.0.0.201806131550-r

Change-Id: Ia2d548676217250593c3f0c383aec19e12e5e4a4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-06-13 18:11:23 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v 94a585e6e87e09880e611a79585fb24090fee271
org.eclipse.jgit.http.server/pom.xml v 94a585e6e87e09880e611a79585fb24090fee271

JGit v5.0.0.201806131210-r

Change-Id: Iedccfcaf57c11822f1faf5d5195357de42b2a14e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-06-05 15:31:07 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v cb0abf787e576d676fc703cde6153bf8c0e08c1d
org.eclipse.jgit.http.server/pom.xml v cb0abf787e576d676fc703cde6153bf8c0e08c1d

Prepare 5.0.0-SNAPSHOT builds

Change-Id: I9acca328146aa7100fbc1b457fcb1f8fd87cf52a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-06-05 13:10:10 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v ca57743a45162ea32ff0312b2f758720d1d1f356
org.eclipse.jgit.http.server/pom.xml v ca57743a45162ea32ff0312b2f758720d1d1f356

JGit v5.0.0.201806050710-rc3

Change-Id: Ic7a6a87dd3a21351e60fbf6cd330456adf1f6800
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-30 23:16:23 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v c473bbf8029743e54e890fcd66998ac011e83b9c
org.eclipse.jgit.http.server/pom.xml v c473bbf8029743e54e890fcd66998ac011e83b9c

Prepare 5.0.0-SNAPSHOT builds

Change-Id: I9c4a0465f8e85041d24da97f4b4c7ad5f5eed3e4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-30 21:33:49 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v dbf091a7eeb9ecc51518bbf20239df50a302f3d9
org.eclipse.jgit.http.server/pom.xml v dbf091a7eeb9ecc51518bbf20239df50a302f3d9

JGit v5.0.0.201805301535-rc2

Change-Id: Ifad678794525c01838b03e52bada66e1c089c5ae
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-23 01:54:32 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v 9ad70313818aad4a64a7d5d30c2c428948fb28de
org.eclipse.jgit.http.server/pom.xml v 9ad70313818aad4a64a7d5d30c2c428948fb28de

Prepare 5.0.0-SNAPSHOT builds

Change-Id: Ie343ccf37f46168041046500a2e19acc80814cfe
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-22 23:43:43 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v 812abefd58ed588b8aa8eadfb59993c084251e09
org.eclipse.jgit.http.server/pom.xml v 812abefd58ed588b8aa8eadfb59993c084251e09

JGit v5.0.0.201805221745-rc1

Change-Id: Ie2c35fab87f294b00f9754b07b60a848bf256b10
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-16 22:23:51 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v 57971057545b5e15c718527da11e79f18db63137
org.eclipse.jgit.http.server/pom.xml v 57971057545b5e15c718527da11e79f18db63137

Prepare 5.0.0-SNAPSHOT builds

Change-Id: I65d7d74c6124507aa9cb2856c74db6a1a6935bab
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-16 16:34:16 Han-Wen Nienhuys <hanwen@google.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/AsIsFileFilter.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/FileSender.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/ObjectFileServlet.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/ServletUtils.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/SmartServiceInfoRefs.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/TextFileServlet.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/RegexPipeline.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/SuffixPipeline.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/UrlPipeline.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/AsIsFileService.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/DefaultReceivePackFactory.java v f3ec7cf3f0436a79e252251a31dbc62694555897
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/DefaultUploadPackFactory.java v f3ec7cf3f0436a79e252251a31dbc62694555897

Remove further unnecessary 'final' keywords

Remove it from

* package private functions.

* try blocks

* for loops

this was done with the following python script:

$ cat f.py
import sys
import re
import os

def replaceFinal(m):
return m.group(1) + "(" + m.group(2).replace('final ', '') + ")"

methodDecl = re.compile(r"^([\t ]*[a-zA-Z_ ]+)\(([^)]*)\)")

def subst(fn):
input = open(fn)
os.rename(fn, fn + "~")

dest = open(fn, 'w')
for l in input:
l = methodDecl.sub(replaceFinal, l)
dest.write(l)
dest.close()


for root, dirs, files in os.walk(".", topdown=False):
for f in files:
if not f.endswith('.java'):
continue

full = os.path.join(root, f)
print full
subst(full)

Change-Id: If533a75a417594fc893e7c669d2c1f0f6caeb7ca
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
2018-05-16 05:07:34 David Pursehouse <david.pursehouse@gmail.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/InfoRefsServlet.java v a2b10e56bd0bb56bb45c9d000167258036b6d3b2

InfoRefsServlet: Refactor to not use deprecated methods

- Replace RefDatabase#getRefs(String) with #getRefsByPrefix(String)
- Replace RefAdvertiser#send(Map<String, Ref>) with #send(Collection<Ref>)

Bug: 534731
Change-Id: I25b617c3b0c54793cf4ab5b62f002e17745a5377
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
2018-05-16 01:20:14 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v a8aabc3d1536470004e32d3547127f709f6b0f47
org.eclipse.jgit.http.server/pom.xml v a8aabc3d1536470004e32d3547127f709f6b0f47

JGit v5.0.0.201805151920-m7

Change-Id: I42eb046c8ac8537672010aabe21459293cb23838
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-05-14 18:42:02 Han-Wen Nienhuys <hanwen@google.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/FileSender.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/GitServlet.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/InfoPacksServlet.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/InfoRefsServlet.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/IsLocalFilter.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/ObjectFileServlet.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/RepositoryFilter.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/ServletUtils.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/TextFileServlet.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ErrorServlet.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/RegexGroupFilter.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/DefaultReceivePackFactory.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/DefaultUploadPackFactory.java v 6d370d837c5faa7caff2e6e3e4723b887f2fbdca

Remove 'final' in parameter lists

Change-Id: Id924f79c8b2c720297ebc49bf9c5d4ddd6d52547
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
2018-04-25 22:59:52 Jonathan Tan <jonathantanmy@google.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/SmartServiceInfoRefs.java v c32a62cd4abf5529c9e56a1c8140de76c107ff93

Give info/refs services more control over response

Currently, SmartServiceInfoRefs always prints "# service=serviceName"
followed by a flush packet in response to an info/refs request, and then
hands it off to the specific service class. Printing of "#
service=serviceName" is mandated for protocol v0, but not v2.

Therefore, the existing code works for protocol v0, but whenever a
service that supports protocol v2 receives an info/refs request, it must
first determine which protocol version is to be used (depending on, for
example, the request and any relevant configuration variables), and then
decide if "# service=serviceName" needs to be printed.

Create a new method that v2-supporting service classes can override,
covering the printing of both "# service=serviceName" and everything
that the #advertise method prints. This will be used in a subsequent
commit in which UploadPackServlet (and the other classes it uses) is
updated to support protocol v2.

Change-Id: Ia026b06e96a6b15937514096babd024ef77df1ea
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Jonathan Nieder <jrn@google.com>
2018-03-13 09:55:05 David Pursehouse <david.pursehouse@gmail.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/RepositoryFilter.java v 98667d385149a64ca0be04419e3329472a33892d

RepositoryFilter: Refactor doFilter to open Repository in try-with-resource

Change-Id: Ic4a056eebe567ff933519d6a805edb7e97c71b22
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
2018-03-13 03:44:23 David Pursehouse <david.pursehouse@gmail.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/ServletUtils.java v 5c70be00856d5375485e6f062b6e1e09a606601f
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/SmartOutputStream.java v 5c70be00856d5375485e6f062b6e1e09a606601f

Open auto-closeable resources in try-with-resource

When an auto-closeable resources is not opened in try-with-resource,
the warning "should be managed by try-with-resource" is emitted by
Eclipse.

Fix the ones that can be silenced simply by moving the declaration of
the variable into a try-with-resource.

In cases where we explicitly call the close() method, for example in
tests where we are testing specific behavior caused by the close(),
suppress the warning.

Leave the ones that will require more significant refcactoring to fix.
They can be done in separate commits that can be reviewed and tested
in isolation.

Change-Id: I9682cd20fb15167d3c7f9027cecdc82bc50b83c4
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
2018-03-08 23:09:18 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v d0f1f5eef60653b820f61c24ec30763280ee8ba4
org.eclipse.jgit.http.server/pom.xml v d0f1f5eef60653b820f61c24ec30763280ee8ba4

Prepare 5.0.0-SNAPSHOT builds

Change-Id: I2d2f50ed8a12f310e7cac68eed5536bd460c403f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-03-08 21:10:08 Matthias Sohn <matthias.sohn@sap.com> org.eclipse.jgit.http.server/META-INF/MANIFEST.MF v f389e18a2853d9f73336f4cf0e7ac2931dc4ce9b
org.eclipse.jgit.http.server/pom.xml v f389e18a2853d9f73336f4cf0e7ac2931dc4ce9b

Prepare 4.11.1-SNAPSHOT builds

Change-Id: Id9aa6b7e8f56de5183b6cd57ef0e790ec9debd4d
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2018-02-28 23:36:44 Jonathan Tan <jonathantanmy@google.com> org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/UploadPackServlet.java v f516c1df9d18ff9aaba1dd5668db1776d42dd2bb
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/DefaultUploadPackFactory.java v f516c1df9d18ff9aaba1dd5668db1776d42dd2bb

Add protocol v2 support in http

Teach UploadPack to support protocol v2 with non-bidirectional pipes,
and add support to the HTTP protocol for v2. This is only activated if
the repository's config has "protocol.version" equal to 2.

Change-Id: I093a14acd2c3850b8b98e14936a716958f35a848
Helped-by: Matthias Sohn <matthias.sohn@sap.com>
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Jonathan Nieder <jrn@google.com>