PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 149

Priority 3

org/eclipse/jgit/lfs/LfsBlobFilter.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 120–122

org/eclipse/jgit/lfs/LfsPrePushHook.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43–277
EmptyWhileStmt Avoid empty while statements 138–140

org/eclipse/jgit/lfs/Protocol.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'gson': the method is declared in an interface type 170–175

org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 81–92
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 106–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromLongObjectId': the method is already in a final class 127–132
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 141–147
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 149–160
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt64': private methods cannot be overridden 162–174
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 252–268
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 284–300
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 316–332
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 339–341
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 369–386

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 278

org/eclipse/jgit/lfs/lib/LongObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 252–263

Priority 4

org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 143–144
UselessParentheses Useless parentheses. 310–311

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 51

Files

org/eclipse/jgit/lfs/LfsBlobFilter.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 120–122

org/eclipse/jgit/lfs/LfsPrePushHook.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43–277
EmptyWhileStmt Avoid empty while statements 3 138–140

org/eclipse/jgit/lfs/Protocol.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'gson': the method is declared in an interface type 3 170–175

org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 143–144
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 149
UselessParentheses Useless parentheses. 4 310–311

org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 81–92
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 106–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromLongObjectId': the method is already in a final class 3 127–132
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 141–147
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 149–160
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt64': private methods cannot be overridden 3 162–174
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 252–268
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 284–300
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 316–332
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 339–341
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 369–386

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 4 51
SimplifiedTernary Ternary operators that can be simplified with || or && 3 278

org/eclipse/jgit/lfs/lib/LongObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 252–263