PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 181

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 501
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 594
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 640

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 356

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 516

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 225

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 516
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 576

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 683

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 324

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 126

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 624

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 594

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 202

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 149

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 864

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 200
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 293

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 505

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 112

Priority 3

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 127194

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Stage': nested enums are implicitly static 140161
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 158160

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 706709

org/eclipse/jgit/api/LogCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 285288
EmptyCatchBlock Avoid empty catch blocks 288292

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 716721
CollapsibleIfStatements These nested if statements could be combined 13001303

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 375379

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 216

org/eclipse/jgit/api/TransportConfigCallback.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'configure': the method is declared in an interface type 71

org/eclipse/jgit/attributes/Attribute.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 7086

org/eclipse/jgit/attributes/AttributesNodeProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getInfoAttributesNode': the method is declared in an interface type 66
UnnecessaryModifier Unnecessary modifier 'public' on method 'getGlobalAttributesNode': the method is declared in an interface type 79

org/eclipse/jgit/attributes/AttributesProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAttributes': the method is declared in an interface type 56

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 157159

org/eclipse/jgit/attributes/FilterCommandFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 7273

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 431433
EmptyIfStmt Avoid empty if statements 521525
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 10191021

org/eclipse/jgit/diff/DiffConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenameDetectionType': nested enums are implicitly static 6271

org/eclipse/jgit/diff/DiffEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'ChangeType': nested enums are implicitly static 7590
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Side': nested enums are implicitly static 9399

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 451243
EmptyCatchBlock Avoid empty catch blocks 722724

org/eclipse/jgit/diff/Edit.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 6779

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 377

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 457460
EmptyIfStmt Avoid empty if statements 462467
CollapsibleIfStatements These nested if statements could be combined 892901
CollapsibleIfStatements These nested if statements could be combined 895900
EmptyWhileStmt Avoid empty while statements 15711573

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 246252

org/eclipse/jgit/errors/NoMergeBaseException.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MergeBaseFailureReason': nested enums are implicitly static 6685

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 63

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 6365

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 135142
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 164166
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 173175
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 182184
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 191193
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 200202
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 209211
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 222224

org/eclipse/jgit/fnmatch/Head.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getNextHeads': the method is declared in an interface type 57

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 5759

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 5456

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 111112

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 153
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 169170
EmptyCatchBlock Avoid empty catch blocks 516518

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 162164

org/eclipse/jgit/ignore/IgnoreNode.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MatchResult': nested enums are implicitly static 6279

org/eclipse/jgit/ignore/internal/IMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 5364

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 66

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43343

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatternState': nested enums are implicitly static 234236
CollapsibleIfStatements These nested if statements could be combined 337339

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 6468
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 7274

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 106108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44642
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 129141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44791
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 348

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44374

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44185
EmptyCatchBlock Avoid empty catch blocks 150152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44240

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44448
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 114116

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44329

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 8183

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 8991

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44253

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44788

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 248250

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackSource': nested enums are implicitly static 100235

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44533

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 245247

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 183185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 361363
EmptyCatchBlock Avoid empty catch blocks 381383

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 384386

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 176178

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 141

org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'position': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'position': the method is declared in an interface type 73
UnnecessaryModifier Unnecessary modifier 'public' on method 'size': the method is declared in an interface type 86
UnnecessaryModifier Unnecessary modifier 'public' on method 'blockSize': the method is declared in an interface type 105
UnnecessaryModifier Unnecessary modifier 'public' on method 'setReadAheadBytes': the method is declared in an interface type 134

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44460

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 122124

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 6264
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 6674
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 8285
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 87112
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 114116
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 118120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 344346

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 112114
CollapsibleIfStatements These nested if statements could be combined 199201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'InsertLooseObjectResult': nested enums are implicitly static 6365

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 225228
EmptyCatchBlock Avoid empty catch blocks 298300

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 423425
EmptyCatchBlock Avoid empty catch blocks 460462
EmptyCatchBlock Avoid empty catch blocks 578581
EmptyCatchBlock Avoid empty catch blocks 959961
EmptyCatchBlock Avoid empty catch blocks 984986

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 111113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 82124
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 126129
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 131133
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 135137
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 143147
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 149153
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 155162
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 164166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 98100

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 327329
CollapsibleIfStatements These nested if statements could be combined 343345
EmptyCatchBlock Avoid empty catch blocks 730732

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 220222

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 398419
EmptyCatchBlock Avoid empty catch blocks 734738

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 349351
EmptyCatchBlock Avoid empty catch blocks 356358
EmptyCatchBlock Avoid empty catch blocks 361363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44551
EmptyCatchBlock Avoid empty catch blocks 451453
EmptyCatchBlock Avoid empty catch blocks 472486

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 471490
CollapsibleIfStatements These nested if statements could be combined 538539
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 13841388

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 217219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 46274

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 6973

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 127133

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 136138

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 140150
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 267269
SimplifiedTernary Ternary operators that can be simplified with || or && 355

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 309311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 5761
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 6466
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 6971
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 7476
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 7981
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 8393

org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'newObjectToPack': the method is declared in an interface type 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectObjectRepresentation': the method is declared in an interface type 117119
UnnecessaryModifier Unnecessary modifier 'public' on method 'writeObjects': the method is declared in an interface type 158159
UnnecessaryModifier Unnecessary modifier 'public' on method 'copyObjectAsIs': the method is declared in an interface type 203205
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'copyPackAsIs': the method is declared in an interface type 219220
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCachedPacksAndUpdate': the method is declared in an interface type 237238

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 118138
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 146153
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 170172
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 190205
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 207216
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 218225
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 227232
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 239241
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 252254
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 257259

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 452352
EmptyWhileStmt Avoid empty while statements 18591861
CollapsibleIfStatements These nested if statements could be combined 21562157
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 21712174
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackingPhase': nested enums are implicitly static 23002318

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 294296
CollapsibleIfStatements These nested if statements could be combined 306310

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44589

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44605

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44707
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 685

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44835

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44286

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 7787
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 101109
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 122125
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 134139
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 141153
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 155166
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 247267
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 283303
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 319339
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 346348
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 376397

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 280

org/eclipse/jgit/lib/AsyncObjectLoaderQueue.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 81
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCurrent': the method is declared in an interface type 90
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObjectId': the method is declared in an interface type 97
UnnecessaryModifier Unnecessary modifier 'public' on method 'open': the method is declared in an interface type 118

org/eclipse/jgit/lib/AsyncObjectSizeQueue.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 76
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCurrent': the method is declared in an interface type 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObjectId': the method is declared in an interface type 92
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSize': the method is declared in an interface type 99

org/eclipse/jgit/lib/AsyncOperation.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'cancel': the method is declared in an interface type 71
UnnecessaryModifier Unnecessary modifier 'public' on method 'release': the method is declared in an interface type 76

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44783

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 77117
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 123211

org/eclipse/jgit/lib/BlobObjectChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL_CHECKER': the field is declared in an interface type 5869

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 7577

org/eclipse/jgit/lib/CheckoutEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getFromBranch': the method is declared in an interface type 15
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getToBranch': the method is declared in an interface type 22

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 14391448
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 14761492

org/eclipse/jgit/lib/CoreConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AutoCRLF': nested enums are implicitly static 6372
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EOL': nested enums are implicitly static 8190
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EolStreamType': nested enums are implicitly static 97112
UnnecessaryModifier Unnecessary modifier 'static' on enum 'CheckStat': nested enums are implicitly static 119131
UnnecessaryModifier Unnecessary modifier 'static' on enum 'SymLinks': nested enums are implicitly static 148153
UnnecessaryModifier Unnecessary modifier 'static' on enum 'HideDotFiles': nested enums are implicitly static 160167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 128130

org/eclipse/jgit/lib/FileMode.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 68
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 71
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 74
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 77
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 83
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 106
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 110
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 115
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 119
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 157

org/eclipse/jgit/lib/GitmoduleEntry.java

Rule Violation Line
ImportFromSamePackage No need to import a type that lives in the same package 45

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'StageState': nested enums are implicitly static 107195
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 145147
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 346
CollapsibleIfStatements These nested if statements could be combined 473476
CollapsibleIfStatements These nested if statements could be combined 512516

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 451254

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 237249

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 340342
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 344346
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 348355

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 257259

org/eclipse/jgit/lib/ProgressMonitor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'UNKNOWN': the field is declared in an interface type 52

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Action': nested enums are implicitly static 61118
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 8790
CollapsibleIfStatements These nested if statements could be combined 191194

org/eclipse/jgit/lib/Ref.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Storage': nested enums are implicitly static 64126
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Storage': the enum is declared in an interface type 64126
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 108111
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 134
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'isSymbolic': the method is declared in an interface type 147
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getLeaf': the method is declared in an interface type 166
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getTarget': the method is declared in an interface type 181
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getObjectId': the method is declared in an interface type 191
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getPeeledObjectId': the method is declared in an interface type 201
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'isPeeled': the method is declared in an interface type 208
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getStorage': the method is declared in an interface type 219

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 68171
CollapsibleIfStatements These nested if statements could be combined 778780

org/eclipse/jgit/lib/ReflogEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'PREFIX_CREATED': the field is declared in an interface type 60
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'PREFIX_FAST_FORWARD': the field is declared in an interface type 72
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'PREFIX_FORCED_UPDATE': the field is declared in an interface type 83
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getOldId': the method is declared in an interface type 90
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getNewId': the method is declared in an interface type 97
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getWho': the method is declared in an interface type 104
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getComment': the method is declared in an interface type 111
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'parseCheckout': the method is declared in an interface type 120

org/eclipse/jgit/lib/ReflogReader.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getLastEntry': the method is declared in an interface type 62
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getReverseEntries': the method is declared in an interface type 70
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getReverseEntry': the method is declared in an interface type 80
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getReverseEntries': the method is declared in an interface type 9091

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 885886
EmptyCatchBlock Avoid empty catch blocks 13221326
EmptyCatchBlock Avoid empty catch blocks 13391341
EmptyCatchBlock Avoid empty catch blocks 13521354

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 347368

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 9597

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 7476

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44403

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7274

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 471352
CollapsibleIfStatements These nested if statements could be combined 408410
CollapsibleIfStatements These nested if statements could be combined 823849
CollapsibleIfStatements These nested if statements could be combined 839841

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 86

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 298

org/eclipse/jgit/patch/BinaryHunk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 6167

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 152154

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44653
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatchType': nested enums are implicitly static 107116
EmptyCatchBlock Avoid empty catch blocks 248251

org/eclipse/jgit/patch/FormatError.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Severity': nested enums are implicitly static 5763

org/eclipse/jgit/patch/Patch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44392

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 198200

org/eclipse/jgit/revwalk/AsyncRevObjectQueue.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 69

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 138141
EmptyCatchBlock Avoid empty catch blocks 157172

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDepth': the method is declared in an interface type 64
UnnecessaryModifier Unnecessary modifier 'public' on method 'getUnshallowFlag': the method is declared in an interface type 72
UnnecessaryModifier Unnecessary modifier 'public' on method 'getReinterestingFlag': the method is declared in an interface type 79
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 82101
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 82101
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 104181
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 184274

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 86
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 87
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 88
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 89
EmptyWhileStmt Avoid empty while statements 740742

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 193196

org/eclipse/jgit/revwalk/RevWalk.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 1358

org/eclipse/jgit/transport/AdvertiseRefsHook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DEFAULT': the field is declared in an interface type 5868
UnnecessaryModifier Unnecessary modifier 'public' on method 'advertiseRefs': the method is declared in an interface type 8081
UnnecessaryModifier Unnecessary modifier 'public' on method 'advertiseRefs': the method is declared in an interface type 9394

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 345347
EmptyCatchBlock Avoid empty catch blocks 356358
EmptyCatchBlock Avoid empty catch blocks 386388

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 429431
EmptyCatchBlock Avoid empty catch blocks 485487
EmptyCatchBlock Avoid empty catch blocks 505508
EmptyCatchBlock Avoid empty catch blocks 788790

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 185187
EmptyCatchBlock Avoid empty catch blocks 191193

org/eclipse/jgit/transport/BaseReceivePack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 441982
EmptyCatchBlock Avoid empty catch blocks 380382
EmptyCatchBlock Avoid empty catch blocks 391393
EmptyCatchBlock Avoid empty catch blocks 407409
EmptyCatchBlock Avoid empty catch blocks 10551057
EmptyCatchBlock Avoid empty catch blocks 13621364

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 265267
EmptyCatchBlock Avoid empty catch blocks 302304

org/eclipse/jgit/transport/Connection.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRefsMap': the method is declared in an interface type 71
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRefs': the method is declared in an interface type 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRef': the method is declared in an interface type 98
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMessages': the method is declared in an interface type 135
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPeerUserAgent': the method is declared in an interface type 144

org/eclipse/jgit/transport/Daemon.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 114
EmptyCatchBlock Avoid empty catch blocks 325327
EmptyCatchBlock Avoid empty catch blocks 351353
EmptyCatchBlock Avoid empty catch blocks 435437
EmptyCatchBlock Avoid empty catch blocks 437439
EmptyCatchBlock Avoid empty catch blocks 439441
EmptyCatchBlock Avoid empty catch blocks 444446
EmptyCatchBlock Avoid empty catch blocks 449451

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 72

org/eclipse/jgit/transport/FetchConnection.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'fetch': the method is declared in an interface type 112114
UnnecessaryModifier Unnecessary modifier 'public' on method 'fetch': the method is declared in an interface type 154156
UnnecessaryModifier Unnecessary modifier 'public' on method 'didFetchIncludeTags': the method is declared in an interface type 176
UnnecessaryModifier Unnecessary modifier 'public' on method 'didFetchTestConnectivity': the method is declared in an interface type 199
UnnecessaryModifier Unnecessary modifier 'public' on method 'setPackLockMessage': the method is declared in an interface type 211
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPackLocks': the method is declared in an interface type 221

org/eclipse/jgit/transport/GitProtocolConstants.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MultiAck': nested enums are implicitly static 261263

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 192194
EmptyIfStmt Avoid empty if statements 416418
EmptyIfStmt Avoid empty if statements 419421

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 132134
EmptyIfStmt Avoid empty if statements 389391

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 110112
EmptyCatchBlock Avoid empty catch blocks 112114
EmptyCatchBlock Avoid empty catch blocks 123125
EmptyCatchBlock Avoid empty catch blocks 129131

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 102104
EmptyCatchBlock Avoid empty catch blocks 104106
EmptyCatchBlock Avoid empty catch blocks 106108
EmptyCatchBlock Avoid empty catch blocks 108110
EmptyCatchBlock Avoid empty catch blocks 113115
EmptyCatchBlock Avoid empty catch blocks 119121

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 432434
EmptyCatchBlock Avoid empty catch blocks 434436
EmptyCatchBlock Avoid empty catch blocks 455457
CollapsibleIfStatements These nested if statements could be combined 519532
EmptyCatchBlock Avoid empty catch blocks 529531

org/eclipse/jgit/transport/JschSession.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 171173

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 103107

org/eclipse/jgit/transport/NonceGenerator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createNonce': the method is declared in an interface type 6970
UnnecessaryModifier Unnecessary modifier 'public' on method 'verify': the method is declared in an interface type 9495

org/eclipse/jgit/transport/OpenSshConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 233235
EmptyCatchBlock Avoid empty catch blocks 373375

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 106112
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 731754
EmptyCatchBlock Avoid empty catch blocks 11841188
EmptyCatchBlock Avoid empty catch blocks 12001204

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AckNackResult': nested enums are implicitly static 8596
EmptyCatchBlock Avoid empty catch blocks 260262

org/eclipse/jgit/transport/PostReceiveHook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 6672
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPostReceive': the method is declared in an interface type 8485

org/eclipse/jgit/transport/PostUploadHook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 6065
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPostUpload': the method is declared in an interface type 75

org/eclipse/jgit/transport/PreReceiveHook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 8288
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPreReceive': the method is declared in an interface type 102

org/eclipse/jgit/transport/PreUploadHook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 6285
UnnecessaryModifier Unnecessary modifier 'public' on method 'onBeginNegotiateRound': the method is declared in an interface type 99101
UnnecessaryModifier Unnecessary modifier 'public' on method 'onEndNegotiateRound': the method is declared in an interface type 123126
UnnecessaryModifier Unnecessary modifier 'public' on method 'onSendPack': the method is declared in an interface type 144146

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 5557

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43220

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 8798
EmptyCatchBlock Avoid empty catch blocks 265268

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 7678

org/eclipse/jgit/transport/PushConnection.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 116118
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 166168

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 296298

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 7598
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 101134
CollapsibleIfStatements These nested if statements could be combined 780784

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 323325

org/eclipse/jgit/transport/RefFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DEFAULT': the field is declared in an interface type 6469
UnnecessaryModifier Unnecessary modifier 'public' on method 'filter': the method is declared in an interface type 79

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 553554

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 75127

org/eclipse/jgit/transport/RemoteSession.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'exec': the method is declared in an interface type 81
UnnecessaryModifier Unnecessary modifier 'public' on method 'disconnect': the method is declared in an interface type 86

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 8789

org/eclipse/jgit/transport/Transport.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 160162

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 263265

org/eclipse/jgit/transport/TransportBundle.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'V2_BUNDLE_SIGNATURE': the field is declared in an interface type 61

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 118120

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 154156
EmptyCatchBlock Avoid empty catch blocks 214216
EmptyCatchBlock Avoid empty catch blocks 253255

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 353355
EmptyCatchBlock Avoid empty catch blocks 360362

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 471450
CollapsibleIfStatements These nested if statements could be combined 772774
EmptyWhileStmt Avoid empty while statements 907909
EmptyCatchBlock Avoid empty catch blocks 928930
EmptyCatchBlock Avoid empty catch blocks 934936

org/eclipse/jgit/transport/TransportProtocol.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'URIishField': nested enums are implicitly static 93104

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 362365

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 442203
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RequestPolicy': nested enums are implicitly static 126156
EmptyCatchBlock Avoid empty catch blocks 941943
EmptyCatchBlock Avoid empty catch blocks 954956
EmptyWhileStmt Avoid empty while statements 963965
EmptyWhileStmt Avoid empty while statements 11981200
EmptyWhileStmt Avoid empty while statements 12071209
EmptyCatchBlock Avoid empty catch blocks 12541256
EmptyCatchBlock Avoid empty catch blocks 14241426

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 120124

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 843845

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 302306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 423425

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_OK': the field is declared in an interface type 72
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_MOVED_PERM': the field is declared in an interface type 78
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_MOVED_TEMP': the field is declared in an interface type 84
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_SEE_OTHER': the field is declared in an interface type 90
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_11_MOVED_TEMP': the field is declared in an interface type 98
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_NOT_FOUND': the field is declared in an interface type 103
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_UNAUTHORIZED': the field is declared in an interface type 108
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_FORBIDDEN': the field is declared in an interface type 113
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResponseCode': the method is declared in an interface type 122
UnnecessaryModifier Unnecessary modifier 'public' on method 'getURL': the method is declared in an interface type 130
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResponseMessage': the method is declared in an interface type 139
UnnecessaryModifier Unnecessary modifier 'public' on method 'getHeaderFields': the method is declared in an interface type 147
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRequestProperty': the method is declared in an interface type 159
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRequestMethod': the method is declared in an interface type 173174
UnnecessaryModifier Unnecessary modifier 'public' on method 'setUseCaches': the method is declared in an interface type 184
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConnectTimeout': the method is declared in an interface type 194
UnnecessaryModifier Unnecessary modifier 'public' on method 'setReadTimeout': the method is declared in an interface type 204
UnnecessaryModifier Unnecessary modifier 'public' on method 'getContentType': the method is declared in an interface type 213
UnnecessaryModifier Unnecessary modifier 'public' on method 'getInputStream': the method is declared in an interface type 225
UnnecessaryModifier Unnecessary modifier 'public' on method 'getHeaderField': the method is declared in an interface type 236
UnnecessaryModifier Unnecessary modifier 'public' on method 'getContentLength': the method is declared in an interface type 246
UnnecessaryModifier Unnecessary modifier 'public' on method 'setInstanceFollowRedirects': the method is declared in an interface type 256
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDoOutput': the method is declared in an interface type 265
UnnecessaryModifier Unnecessary modifier 'public' on method 'setFixedLengthStreamingMode': the method is declared in an interface type 274
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOutputStream': the method is declared in an interface type 283
UnnecessaryModifier Unnecessary modifier 'public' on method 'setChunkedStreamingMode': the method is declared in an interface type 293
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRequestMethod': the method is declared in an interface type 301
UnnecessaryModifier Unnecessary modifier 'public' on method 'usingProxy': the method is declared in an interface type 309
UnnecessaryModifier Unnecessary modifier 'public' on method 'connect': the method is declared in an interface type 317
UnnecessaryModifier Unnecessary modifier 'public' on method 'configure': the method is declared in an interface type 335337
UnnecessaryModifier Unnecessary modifier 'public' on method 'setHostnameVerifier': the method is declared in an interface type 348349

org/eclipse/jgit/transport/http/HttpConnectionFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 65
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 7879

org/eclipse/jgit/transport/resolver/ReceivePackFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DISABLED': the field is declared in an interface type 6066

org/eclipse/jgit/transport/resolver/RepositoryResolver.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NONE': the field is declared in an interface type 6066

org/eclipse/jgit/transport/resolver/UploadPackFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DISABLED': the field is declared in an interface type 6066

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45445

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'OperationType': nested enums are implicitly static 114125

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 473477
EmptyWhileStmt Avoid empty while statements 513515
CollapsibleIfStatements These nested if statements could be combined 901902

org/eclipse/jgit/util/FS.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 381383
EmptyIfStmt Avoid empty if statements 12161219
EmptyCatchBlock Avoid empty catch blocks 18261833
EmptyCatchBlock Avoid empty catch blocks 21652167

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 87
CollapsibleIfStatements These nested if statements could be combined 172190
CollapsibleIfStatements These nested if statements could be combined 173189

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 166168
CollapsibleIfStatements These nested if statements could be combined 182198

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 304306
SimplifiedTernary Ternary operators that can be simplified with || or && 826

org/eclipse/jgit/util/GitDateFormatter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Format': nested enums are implicitly static 71117

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 131133
EmptyCatchBlock Avoid empty catch blocks 231233

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 315

org/eclipse/jgit/util/LongMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 169173
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 176178

org/eclipse/jgit/util/ProcessResult.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 5469

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 451344
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 129136
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 210244
EmptyCatchBlock Avoid empty catch blocks 238240
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 264298
EmptyCatchBlock Avoid empty catch blocks 292294
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 315328
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 345369
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 387435
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 446451
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 465467
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 485491
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 504511
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 524526
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 541549
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 562571
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 586605
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 618626
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 639641
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 657666
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 696705
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 723730
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 767774
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 789798
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 813826
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 841851
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 12541265
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 12781287
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 13031313

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 100102
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 117119
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 121123

org/eclipse/jgit/util/RefMap.java

Rule Violation Line
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 428

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 405407

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7173

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 149151
EmptyCatchBlock Avoid empty catch blocks 154156

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 85
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 589592
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 594600

Priority 4

org/eclipse/jgit/api/AddCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 212213
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 213
UselessParentheses Useless parentheses. 214215

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 576

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 205

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 398399
UselessParentheses Useless parentheses. 400
UselessParentheses Useless parentheses. 532

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 256

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 433
UselessParentheses Useless parentheses. 433

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 195196

org/eclipse/jgit/api/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 416

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 284

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 783
UselessParentheses Useless parentheses. 783784
UselessParentheses Useless parentheses. 784
UselessParentheses Useless parentheses. 1721

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 159
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 185
UselessParentheses Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 144

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 320
UselessParentheses Useless parentheses. 442443
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 549

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 133
UselessParentheses Useless parentheses. 171
UselessParentheses Useless parentheses. 206
UselessParentheses Useless parentheses. 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Line
UselessParentheses Useless parentheses. 381

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
UselessParentheses Useless parentheses. 234
UselessParentheses Useless parentheses. 234
UselessParentheses Useless parentheses. 641
UselessParentheses Useless parentheses. 719
UselessParentheses Useless parentheses. 720
UselessParentheses Useless parentheses. 721
UselessParentheses Useless parentheses. 722
UselessParentheses Useless parentheses. 723
UselessParentheses Useless parentheses. 724
UselessParentheses Useless parentheses. 783
UselessParentheses Useless parentheses. 784
UselessParentheses Useless parentheses. 784
UselessParentheses Useless parentheses. 784
UselessParentheses Useless parentheses. 880
UselessParentheses Useless parentheses. 11231124

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 125
UselessParentheses Useless parentheses. 294
UselessParentheses Useless parentheses. 418
UselessParentheses Useless parentheses. 418

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Line
UselessParentheses Useless parentheses. 493

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 705
UselessParentheses Useless parentheses. 706

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 131

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UselessParentheses Useless parentheses. 138
UselessParentheses Useless parentheses. 398

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 427

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 626
UselessParentheses Useless parentheses. 633

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Line
UselessParentheses Useless parentheses. 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 579

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 561
UselessParentheses Useless parentheses. 567
UselessParentheses Useless parentheses. 574
UselessParentheses Useless parentheses. 580
UselessParentheses Useless parentheses. 597
UselessParentheses Useless parentheses. 621
UselessParentheses Useless parentheses. 706
UselessParentheses Useless parentheses. 714
UselessParentheses Useless parentheses. 786
UselessParentheses Useless parentheses. 834
UselessParentheses Useless parentheses. 949
UselessParentheses Useless parentheses. 1056

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 766

org/eclipse/jgit/internal/storage/dfs/DfsReftableDatabase.java

Rule Violation Line
UselessParentheses Useless parentheses. 244245

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Line
UselessParentheses Useless parentheses. 578
UselessParentheses Useless parentheses. 578

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
UselessParentheses Useless parentheses. 979981
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1157
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1160

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 655
UselessParentheses Useless parentheses. 656
UselessParentheses Useless parentheses. 776

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 465
UselessParentheses Useless parentheses. 471
UselessParentheses Useless parentheses. 478
UselessParentheses Useless parentheses. 484
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 534
UselessParentheses Useless parentheses. 554
UselessParentheses Useless parentheses. 611
UselessParentheses Useless parentheses. 619
UselessParentheses Useless parentheses. 869
UselessParentheses Useless parentheses. 918
UselessParentheses Useless parentheses. 1033
UselessParentheses Useless parentheses. 1124
UselessParentheses Useless parentheses. 1139
UselessParentheses Useless parentheses. 1225

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Line
UselessParentheses Useless parentheses. 231
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 393
UselessParentheses Useless parentheses. 394
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 1162
UselessParentheses Useless parentheses. 1177
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1214
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1245

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 242

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Line
UselessParentheses Useless parentheses. 319

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 68

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 193

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 382
UselessParentheses Useless parentheses. 2172
UselessParentheses Useless parentheses. 2173
UselessParentheses Useless parentheses. 2257
UselessParentheses Useless parentheses. 2274

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
UselessParentheses Useless parentheses. 136
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 237
UselessParentheses Useless parentheses. 271
UselessParentheses Useless parentheses. 272273
UselessParentheses Useless parentheses. 273
UselessParentheses Useless parentheses. 274
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 285

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 561
UselessParentheses Useless parentheses. 573

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 138

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 456

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 113

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UselessParentheses Useless parentheses. 1411

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 281

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 514515
UselessParentheses Useless parentheses. 607
UselessParentheses Useless parentheses. 607608
UselessParentheses Useless parentheses. 607608
UselessParentheses Useless parentheses. 618
UselessParentheses Useless parentheses. 735736

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 563
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 595
UselessParentheses Useless parentheses. 868
UselessParentheses Useless parentheses. 928
UselessParentheses Useless parentheses. 929
UselessParentheses Useless parentheses. 1007
UselessParentheses Useless parentheses. 1019
UselessParentheses Useless parentheses. 11001101
UselessParentheses Useless parentheses. 1102
UselessParentheses Useless parentheses. 1103

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
UselessParentheses Useless parentheses. 618
UselessParentheses Useless parentheses. 630
UselessParentheses Useless parentheses. 827
UselessParentheses Useless parentheses. 828
UselessParentheses Useless parentheses. 829

org/eclipse/jgit/lib/RepositoryBuilder.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.File' 46

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UselessParentheses Useless parentheses. 302

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Line
UselessParentheses Useless parentheses. 317

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Line
UselessParentheses Useless parentheses. 75

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 141

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 823
UselessParentheses Useless parentheses. 823824
UselessParentheses Useless parentheses. 823824
UselessParentheses Useless parentheses. 887888

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 51

org/eclipse/jgit/nls/NLS.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 49
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 50

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 284
UselessParentheses Useless parentheses. 286

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 297

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 195

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Line
UselessParentheses Useless parentheses. 121

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 104
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 184

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 60

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
UselessParentheses Useless parentheses. 371

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 530

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 401402
UselessParentheses Useless parentheses. 437

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 542

org/eclipse/jgit/transport/FetchResult.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 50

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
UselessParentheses Useless parentheses. 175
UselessParentheses Useless parentheses. 176

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 95113

org/eclipse/jgit/transport/ObjectCountCallback.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.OutputStream' 46
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 48

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 851
UselessParentheses Useless parentheses. 1026

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Line
UselessParentheses Useless parentheses. 267

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 279
UselessParentheses Useless parentheses. 777
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 843
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 871
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 875
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 881

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 167
UselessParentheses Useless parentheses. 320

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 355356

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 154

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 89

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
UselessParentheses Useless parentheses. 182

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Line
UselessParentheses Useless parentheses. 115

org/eclipse/jgit/transport/URIish.java

Rule Violation Line
UselessParentheses Useless parentheses. 276277
UselessParentheses Useless parentheses. 337
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
UselessParentheses Useless parentheses. 700701

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 72
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 78
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 84
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 103
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 108
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 113

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 84

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 1302
UselessParentheses Useless parentheses. 1443

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
UselessParentheses Useless parentheses. 327328
UselessParentheses Useless parentheses. 15251526
UselessParentheses Useless parentheses. 15271528

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Line
UselessParentheses Useless parentheses. 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Line
UselessParentheses Useless parentheses. 116

org/eclipse/jgit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses. 120
UselessParentheses Useless parentheses. 127
UselessParentheses Useless parentheses. 134

org/eclipse/jgit/util/FS.java

Rule Violation Line
UselessParentheses Useless parentheses. 1290

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
UselessParentheses Useless parentheses. 463
UselessParentheses Useless parentheses. 463

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 64

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 261262

org/eclipse/jgit/util/NB.java

Rule Violation Line
UselessParentheses Useless parentheses. 91
UselessParentheses Useless parentheses. 203
UselessParentheses Useless parentheses. 206

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
UselessParentheses Useless parentheses. 235
UselessParentheses Useless parentheses. 289
UselessParentheses Useless parentheses. 748
UselessParentheses Useless parentheses. 958
UselessParentheses Useless parentheses. 1306

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Line
UselessParentheses Useless parentheses. 122
UselessParentheses Useless parentheses. 126
UselessParentheses Useless parentheses. 127

org/eclipse/jgit/util/time/MonotonicClock.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.time.Duration' 46

Files

org/eclipse/jgit/api/AddCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 212213
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 4 213
UselessParentheses Useless parentheses. 4 214215

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 3 127194

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Stage': nested enums are implicitly static 3 140161
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 3 158160
UselessParentheses Useless parentheses. 4 576

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 204
UselessParentheses Useless parentheses. 4 205

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 706709

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 398399
UselessParentheses Useless parentheses. 4 400
UselessParentheses Useless parentheses. 4 532

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 4 256

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 433
UselessParentheses Useless parentheses. 4 433

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 195196

org/eclipse/jgit/api/LogCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 285288
EmptyCatchBlock Avoid empty catch blocks 3 288292

org/eclipse/jgit/api/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 416

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 284

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 716721
UselessParentheses Useless parentheses. 4 783
UselessParentheses Useless parentheses. 4 783784
UselessParentheses Useless parentheses. 4 784
CollapsibleIfStatements These nested if statements could be combined 3 13001303
UselessParentheses Useless parentheses. 4 1721

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 375379

org/eclipse/jgit/api/TagCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 3 216

org/eclipse/jgit/api/TransportConfigCallback.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'configure': the method is declared in an interface type 3 71

org/eclipse/jgit/attributes/Attribute.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 3 7086

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 159
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 185
UselessParentheses Useless parentheses. 4 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144

org/eclipse/jgit/attributes/AttributesNodeProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getInfoAttributesNode': the method is declared in an interface type 3 66
UnnecessaryModifier Unnecessary modifier 'public' on method 'getGlobalAttributesNode': the method is declared in an interface type 3 79

org/eclipse/jgit/attributes/AttributesProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAttributes': the method is declared in an interface type 3 56

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 157159

org/eclipse/jgit/attributes/FilterCommandFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 7273

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 431433
EmptyIfStmt Avoid empty if statements 3 521525
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 3 10191021

org/eclipse/jgit/diff/DiffConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenameDetectionType': nested enums are implicitly static 3 6271

org/eclipse/jgit/diff/DiffEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'ChangeType': nested enums are implicitly static 3 7590
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Side': nested enums are implicitly static 3 9399

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 451243
EmptyCatchBlock Avoid empty catch blocks 3 722724

org/eclipse/jgit/diff/Edit.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 6779

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 320
UselessParentheses Useless parentheses. 4 442443
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 549

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 133
UselessParentheses Useless parentheses. 4 171
UselessParentheses Useless parentheses. 4 206
UselessParentheses Useless parentheses. 4 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 381

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 377

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 181

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 234
UselessParentheses Useless parentheses. 4 234
EmptyIfStmt Avoid empty if statements 3 457460
EmptyIfStmt Avoid empty if statements 3 462467
UselessParentheses Useless parentheses. 4 641
UselessParentheses Useless parentheses. 4 719
UselessParentheses Useless parentheses. 4 720
UselessParentheses Useless parentheses. 4 721
UselessParentheses Useless parentheses. 4 722
UselessParentheses Useless parentheses. 4 723
UselessParentheses Useless parentheses. 4 724
UselessParentheses Useless parentheses. 4 783
UselessParentheses Useless parentheses. 4 784
UselessParentheses Useless parentheses. 4 784
UselessParentheses Useless parentheses. 4 784
UselessParentheses Useless parentheses. 4 880
CollapsibleIfStatements These nested if statements could be combined 3 892901
CollapsibleIfStatements These nested if statements could be combined 3 895900
UselessParentheses Useless parentheses. 4 11231124
EmptyWhileStmt Avoid empty while statements 3 15711573

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 125
UselessParentheses Useless parentheses. 4 294
UselessParentheses Useless parentheses. 4 418
UselessParentheses Useless parentheses. 4 418

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 246252

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 493

org/eclipse/jgit/errors/NoMergeBaseException.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MergeBaseFailureReason': nested enums are implicitly static 3 6685

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 3 63

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 6365

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 135142
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 164166
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 173175
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 182184
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 191193
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 200202
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 209211
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 222224

org/eclipse/jgit/fnmatch/Head.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getNextHeads': the method is declared in an interface type 3 57

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 5759

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 5456

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 3 111112

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 3 153
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 3 169170
EmptyCatchBlock Avoid empty catch blocks 3 516518
UselessParentheses Useless parentheses. 4 705
UselessParentheses Useless parentheses. 4 706

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 162164

org/eclipse/jgit/ignore/IgnoreNode.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MatchResult': nested enums are implicitly static 3 6279

org/eclipse/jgit/ignore/internal/IMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 3 5364

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 66
UselessParentheses Useless parentheses. 4 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43343
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 4 131

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 138
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatternState': nested enums are implicitly static 3 234236
CollapsibleIfStatements These nested if statements could be combined 3 337339
UselessParentheses Useless parentheses. 4 398

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 6468
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 7274

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 106108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44642
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 3 129141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44791
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 348

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44374

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44185
EmptyCatchBlock Avoid empty catch blocks 3 150152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44240

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44448
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 3 114116
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 427

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44329

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 8183

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 8991

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44253

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44788
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 248250
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 626
UselessParentheses Useless parentheses. 4 633

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackSource': nested enums are implicitly static 3 100235

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44533

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 579

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 3 245247
UselessParentheses Useless parentheses. 4 561
UselessParentheses Useless parentheses. 4 567
UselessParentheses Useless parentheses. 4 574
UselessParentheses Useless parentheses. 4 580
UselessParentheses Useless parentheses. 4 597
UselessParentheses Useless parentheses. 4 621
UselessParentheses Useless parentheses. 4 706
UselessParentheses Useless parentheses. 4 714
UselessParentheses Useless parentheses. 4 786
UselessParentheses Useless parentheses. 4 834
UselessParentheses Useless parentheses. 4 949
UselessParentheses Useless parentheses. 4 1056

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 183185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 361363
EmptyCatchBlock Avoid empty catch blocks 3 381383
UselessParentheses Useless parentheses. 4 766

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 384386

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 176178

org/eclipse/jgit/internal/storage/dfs/DfsReftableDatabase.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 244245

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 141

org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'position': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'position': the method is declared in an interface type 3 73
UnnecessaryModifier Unnecessary modifier 'public' on method 'size': the method is declared in an interface type 3 86
UnnecessaryModifier Unnecessary modifier 'public' on method 'blockSize': the method is declared in an interface type 3 105
UnnecessaryModifier Unnecessary modifier 'public' on method 'setReadAheadBytes': the method is declared in an interface type 3 134

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44460

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 122124

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 6264
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 6674
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 8285
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 3 87112
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 114116
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 118120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 3 344346

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 112114
CollapsibleIfStatements These nested if statements could be combined 3 199201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'InsertLooseObjectResult': nested enums are implicitly static 3 6365

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 225228
EmptyCatchBlock Avoid empty catch blocks 3 298300

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 578
UselessParentheses Useless parentheses. 4 578

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 423425
EmptyCatchBlock Avoid empty catch blocks 3 460462
EmptyCatchBlock Avoid empty catch blocks 3 578581
EmptyCatchBlock Avoid empty catch blocks 3 959961
UselessParentheses Useless parentheses. 4 979981
EmptyCatchBlock Avoid empty catch blocks 3 984986
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1157
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1160

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 111113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 3 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 3 82124
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 3 126129
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 131133
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 135137
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 3 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 3 143147
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 3 149153
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 3 155162
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 3 164166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 98100

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 327329
CollapsibleIfStatements These nested if statements could be combined 3 343345
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 501
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 594
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 640
UselessParentheses Useless parentheses. 4 655
UselessParentheses Useless parentheses. 4 656
EmptyCatchBlock Avoid empty catch blocks 3 730732
UselessParentheses Useless parentheses. 4 776

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 220222

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 3 398419
UselessParentheses Useless parentheses. 4 465
UselessParentheses Useless parentheses. 4 471
UselessParentheses Useless parentheses. 4 478
UselessParentheses Useless parentheses. 4 484
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 534
UselessParentheses Useless parentheses. 4 554
UselessParentheses Useless parentheses. 4 611
UselessParentheses Useless parentheses. 4 619
EmptyCatchBlock Avoid empty catch blocks 3 734738
UselessParentheses Useless parentheses. 4 869
UselessParentheses Useless parentheses. 4 918
UselessParentheses Useless parentheses. 4 1033
UselessParentheses Useless parentheses. 4 1124
UselessParentheses Useless parentheses. 4 1139
UselessParentheses Useless parentheses. 4 1225

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 231
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 349351
EmptyCatchBlock Avoid empty catch blocks 3 356358
EmptyCatchBlock Avoid empty catch blocks 3 361363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44551
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 356
UselessParentheses Useless parentheses. 4 393
UselessParentheses Useless parentheses. 4 394
EmptyCatchBlock Avoid empty catch blocks 3 451453
EmptyCatchBlock Avoid empty catch blocks 3 472486
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 471490
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 516
CollapsibleIfStatements These nested if statements could be combined 3 538539
UselessParentheses Useless parentheses. 4 1162
UselessParentheses Useless parentheses. 4 1177
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1214
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 4 1245
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 3 13841388

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 217219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 46274
UselessParentheses Useless parentheses. 4 242

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 6973

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 3 127133

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 319

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 136138

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 68

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Priority Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 3 140150
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 267269
SimplifiedTernary Ternary operators that can be simplified with || or && 3 355

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 225
EmptyCatchBlock Avoid empty catch blocks 3 309311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 5761
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3 6466
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3 6971
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 7476
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 3 7981
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 3 8393

org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'newObjectToPack': the method is declared in an interface type 3 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectObjectRepresentation': the method is declared in an interface type 3 117119
UnnecessaryModifier Unnecessary modifier 'public' on method 'writeObjects': the method is declared in an interface type 3 158159
UnnecessaryModifier Unnecessary modifier 'public' on method 'copyObjectAsIs': the method is declared in an interface type 3 203205
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'copyPackAsIs': the method is declared in an interface type 3 219220
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCachedPacksAndUpdate': the method is declared in an interface type 3 237238

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 118138
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 3 146153
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 3 170172
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 3 190205
UselessParentheses Useless parentheses. 4 193
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 3 207216
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 3 218225
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 3 227232
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 3 239241
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 3 252254
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 3 257259

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 452352
UselessParentheses Useless parentheses. 4 382
EmptyWhileStmt Avoid empty while statements 3 18591861
CollapsibleIfStatements These nested if statements could be combined 3 21562157
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 3 21712174
UselessParentheses Useless parentheses. 4 2172
UselessParentheses Useless parentheses. 4 2173
UselessParentheses Useless parentheses. 4 2257
UselessParentheses Useless parentheses. 4 2274
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackingPhase': nested enums are implicitly static 3 23002318

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 136
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 237
UselessParentheses Useless parentheses. 4 271
UselessParentheses Useless parentheses. 4 272273
UselessParentheses Useless parentheses. 4 273
UselessParentheses Useless parentheses. 4 274
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 285
EmptyWhileStmt Avoid empty while statements 3 294296
CollapsibleIfStatements These nested if statements could be combined 3 306310

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44589
UselessParentheses Useless parentheses. 4 561
UselessParentheses Useless parentheses. 4 573

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44605
UselessParentheses Useless parentheses. 4 138

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44707
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 456
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 516
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 576
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 685

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44835
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 683

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44286

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 7787
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 101109
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 3 122125
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 134139
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 141153
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 3 155166
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 247267
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 283303
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 319339
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 346348
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 376397

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 280

org/eclipse/jgit/lib/AsyncObjectLoaderQueue.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 3 81
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCurrent': the method is declared in an interface type 3 90
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObjectId': the method is declared in an interface type 3 97
UnnecessaryModifier Unnecessary modifier 'public' on method 'open': the method is declared in an interface type 3 118

org/eclipse/jgit/lib/AsyncObjectSizeQueue.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 3 76
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCurrent': the method is declared in an interface type 3 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObjectId': the method is declared in an interface type 3 92
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSize': the method is declared in an interface type 3 99

org/eclipse/jgit/lib/AsyncOperation.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'cancel': the method is declared in an interface type 3 71
UnnecessaryModifier Unnecessary modifier 'public' on method 'release': the method is declared in an interface type 3 76

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44783
UselessParentheses Useless parentheses. 4 113

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 3 77117
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 3 123211

org/eclipse/jgit/lib/BlobObjectChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL_CHECKER': the field is declared in an interface type 3 5869

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 3 7577

org/eclipse/jgit/lib/CheckoutEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getFromBranch': the method is declared in an interface type 3 15
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getToBranch': the method is declared in an interface type 3 22

org/eclipse/jgit/lib/Config.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1411
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 3 14391448
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 3 14761492

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 4 281

org/eclipse/jgit/lib/CoreConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AutoCRLF': nested enums are implicitly static 3 6372
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EOL': nested enums are implicitly static 3 8190
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EolStreamType': nested enums are implicitly static 3 97112
UnnecessaryModifier Unnecessary modifier 'static' on enum 'CheckStat': nested enums are implicitly static 3 119131
UnnecessaryModifier Unnecessary modifier 'static' on enum 'SymLinks': nested enums are implicitly static 3 148153
UnnecessaryModifier Unnecessary modifier 'static' on enum 'HideDotFiles': nested enums are implicitly static 3 160167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 128130

org/eclipse/jgit/lib/FileMode.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 68
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 71
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 74
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 77
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 83
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 106
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 110
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 115
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 119
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 157

org/eclipse/jgit/lib/GitmoduleEntry.java

Rule Violation Priority Line
ImportFromSamePackage No need to import a type that lives in the same package 3 45

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'StageState': nested enums are implicitly static 3 107195
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 3 145147
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 3 346
CollapsibleIfStatements These nested if statements could be combined 3 473476
CollapsibleIfStatements These nested if statements could be combined 3 512516
UselessParentheses Useless parentheses. 4 514515
UselessParentheses Useless parentheses. 4 607
UselessParentheses Useless parentheses. 4 607608
UselessParentheses Useless parentheses. 4 607608
UselessParentheses Useless parentheses. 4 618
UselessParentheses Useless parentheses. 4 735736

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 451254
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 563
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 595
UselessParentheses Useless parentheses. 4 868
UselessParentheses Useless parentheses. 4 928
UselessParentheses Useless parentheses. 4 929
UselessParentheses Useless parentheses. 4 1007
UselessParentheses Useless parentheses. 4 1019
UselessParentheses Useless parentheses. 4 11001101
UselessParentheses Useless parentheses. 4 1102
UselessParentheses Useless parentheses. 4 1103

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 237249

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 3 340342
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 3 344346
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 3 348355

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 257259

org/eclipse/jgit/lib/ProgressMonitor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'UNKNOWN': the field is declared in an interface type 3 52

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Action': nested enums are implicitly static 3 61118
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 3 8790
CollapsibleIfStatements These nested if statements could be combined 3 191194

org/eclipse/jgit/lib/Ref.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Storage': nested enums are implicitly static 3 64126
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Storage': the enum is declared in an interface type 3 64126
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 3 108111
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 3 134
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'isSymbolic': the method is declared in an interface type 3 147
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getLeaf': the method is declared in an interface type 3 166
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getTarget': the method is declared in an interface type 3 181
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getObjectId': the method is declared in an interface type 3 191
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getPeeledObjectId': the method is declared in an interface type 3 201
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'isPeeled': the method is declared in an interface type 3 208
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getStorage': the method is declared in an interface type 3 219

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 3 68171
CollapsibleIfStatements These nested if statements could be combined 3 778780

org/eclipse/jgit/lib/ReflogEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'PREFIX_CREATED': the field is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'PREFIX_FAST_FORWARD': the field is declared in an interface type 3 72
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'PREFIX_FORCED_UPDATE': the field is declared in an interface type 3 83
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getOldId': the method is declared in an interface type 3 90
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getNewId': the method is declared in an interface type 3 97
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getWho': the method is declared in an interface type 3 104
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getComment': the method is declared in an interface type 3 111
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'parseCheckout': the method is declared in an interface type 3 120

org/eclipse/jgit/lib/ReflogReader.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getLastEntry': the method is declared in an interface type 3 62
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getReverseEntries': the method is declared in an interface type 3 70
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getReverseEntry': the method is declared in an interface type 3 80
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'getReverseEntries': the method is declared in an interface type 3 9091

org/eclipse/jgit/lib/Repository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 618
UselessParentheses Useless parentheses. 4 630
UselessParentheses Useless parentheses. 4 827
UselessParentheses Useless parentheses. 4 828
UselessParentheses Useless parentheses. 4 829
CollapsibleIfStatements These nested if statements could be combined 3 885886
EmptyCatchBlock Avoid empty catch blocks 3 13221326
EmptyCatchBlock Avoid empty catch blocks 3 13391341
EmptyCatchBlock Avoid empty catch blocks 3 13521354

org/eclipse/jgit/lib/RepositoryBuilder.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.File' 4 46

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 302
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 3 347368

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 9597

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 7476

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44403

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 317

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7274

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 75

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 141

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 471352
CollapsibleIfStatements These nested if statements could be combined 3 408410
UselessParentheses Useless parentheses. 4 823
UselessParentheses Useless parentheses. 4 823824
CollapsibleIfStatements These nested if statements could be combined 3 823849
UselessParentheses Useless parentheses. 4 823824
CollapsibleIfStatements These nested if statements could be combined 3 839841
UselessParentheses Useless parentheses. 4 887888

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 3 86

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 51

org/eclipse/jgit/nls/NLS.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 49
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 50

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 284
UselessParentheses Useless parentheses. 4 286
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 298

org/eclipse/jgit/patch/BinaryHunk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 6167

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 152154

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44653
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatchType': nested enums are implicitly static 3 107116
EmptyCatchBlock Avoid empty catch blocks 3 248251
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 4 297

org/eclipse/jgit/patch/FormatError.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Severity': nested enums are implicitly static 3 5763

org/eclipse/jgit/patch/Patch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44392

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 195

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 198200

org/eclipse/jgit/revwalk/AsyncRevObjectQueue.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 3 69

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 138141
EmptyCatchBlock Avoid empty catch blocks 3 157172

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 121

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDepth': the method is declared in an interface type 3 64
UnnecessaryModifier Unnecessary modifier 'public' on method 'getUnshallowFlag': the method is declared in an interface type 3 72
UnnecessaryModifier Unnecessary modifier 'public' on method 'getReinterestingFlag': the method is declared in an interface type 3 79
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 3 82101
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 3 82101
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 3 104181
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 104
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 184
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 3 184274

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 4 60
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 86
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 87
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 88
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 89
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 324
EmptyWhileStmt Avoid empty while statements 3 740742

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 193196
UselessParentheses Useless parentheses. 4 371

org/eclipse/jgit/revwalk/RevWalk.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 1358

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 126

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 530
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 624

org/eclipse/jgit/transport/AdvertiseRefsHook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DEFAULT': the field is declared in an interface type 3 5868
UnnecessaryModifier Unnecessary modifier 'public' on method 'advertiseRefs': the method is declared in an interface type 3 8081
UnnecessaryModifier Unnecessary modifier 'public' on method 'advertiseRefs': the method is declared in an interface type 3 9394

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 345347
EmptyCatchBlock Avoid empty catch blocks 3 356358
EmptyCatchBlock Avoid empty catch blocks 3 386388

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 429431
EmptyCatchBlock Avoid empty catch blocks 3 485487
EmptyCatchBlock Avoid empty catch blocks 3 505508
EmptyCatchBlock Avoid empty catch blocks 3 788790

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 185187
EmptyCatchBlock Avoid empty catch blocks 3 191193
UselessParentheses Useless parentheses. 4 401402
UselessParentheses Useless parentheses. 4 437

org/eclipse/jgit/transport/BaseReceivePack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 441982
EmptyCatchBlock Avoid empty catch blocks 3 380382
EmptyCatchBlock Avoid empty catch blocks 3 391393
EmptyCatchBlock Avoid empty catch blocks 3 407409
EmptyCatchBlock Avoid empty catch blocks 3 10551057
EmptyCatchBlock Avoid empty catch blocks 3 13621364

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 265267
EmptyCatchBlock Avoid empty catch blocks 3 302304

org/eclipse/jgit/transport/Connection.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRefsMap': the method is declared in an interface type 3 71
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRefs': the method is declared in an interface type 3 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRef': the method is declared in an interface type 3 98
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMessages': the method is declared in an interface type 3 135
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPeerUserAgent': the method is declared in an interface type 3 144

org/eclipse/jgit/transport/Daemon.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 114
EmptyCatchBlock Avoid empty catch blocks 3 325327
EmptyCatchBlock Avoid empty catch blocks 3 351353
EmptyCatchBlock Avoid empty catch blocks 3 435437
EmptyCatchBlock Avoid empty catch blocks 3 437439
EmptyCatchBlock Avoid empty catch blocks 3 439441
EmptyCatchBlock Avoid empty catch blocks 3 444446
EmptyCatchBlock Avoid empty catch blocks 3 449451

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 72

org/eclipse/jgit/transport/FetchConnection.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'fetch': the method is declared in an interface type 3 112114
UnnecessaryModifier Unnecessary modifier 'public' on method 'fetch': the method is declared in an interface type 3 154156
UnnecessaryModifier Unnecessary modifier 'public' on method 'didFetchIncludeTags': the method is declared in an interface type 3 176
UnnecessaryModifier Unnecessary modifier 'public' on method 'didFetchTestConnectivity': the method is declared in an interface type 3 199
UnnecessaryModifier Unnecessary modifier 'public' on method 'setPackLockMessage': the method is declared in an interface type 3 211
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPackLocks': the method is declared in an interface type 3 221

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 4 542

org/eclipse/jgit/transport/FetchResult.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 50

org/eclipse/jgit/transport/GitProtocolConstants.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MultiAck': nested enums are implicitly static 3 261263

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 175
UselessParentheses Useless parentheses. 4 176
EmptyCatchBlock Avoid empty catch blocks 3 192194
EmptyIfStmt Avoid empty if statements 3 416418
EmptyIfStmt Avoid empty if statements 3 419421

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 95113
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 3 132134
EmptyIfStmt Avoid empty if statements 3 389391

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 110112
EmptyCatchBlock Avoid empty catch blocks 3 112114
EmptyCatchBlock Avoid empty catch blocks 3 123125
EmptyCatchBlock Avoid empty catch blocks 3 129131

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 102104
EmptyCatchBlock Avoid empty catch blocks 3 104106
EmptyCatchBlock Avoid empty catch blocks 3 106108
EmptyCatchBlock Avoid empty catch blocks 3 108110
EmptyCatchBlock Avoid empty catch blocks 3 113115
EmptyCatchBlock Avoid empty catch blocks 3 119121

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 432434
EmptyCatchBlock Avoid empty catch blocks 3 434436
EmptyCatchBlock Avoid empty catch blocks 3 455457
CollapsibleIfStatements These nested if statements could be combined 3 519532
EmptyCatchBlock Avoid empty catch blocks 3 529531

org/eclipse/jgit/transport/JschSession.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 171173

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 103107

org/eclipse/jgit/transport/NonceGenerator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createNonce': the method is declared in an interface type 3 6970
UnnecessaryModifier Unnecessary modifier 'public' on method 'verify': the method is declared in an interface type 3 9495

org/eclipse/jgit/transport/ObjectCountCallback.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.OutputStream' 4 46
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 4 48

org/eclipse/jgit/transport/OpenSshConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 233235
EmptyCatchBlock Avoid empty catch blocks 3 373375

org/eclipse/jgit/transport/PackParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 3 106112
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 3 731754
UselessParentheses Useless parentheses. 4 851
UselessParentheses Useless parentheses. 4 1026
EmptyCatchBlock Avoid empty catch blocks 3 11841188
EmptyCatchBlock Avoid empty catch blocks 3 12001204

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AckNackResult': nested enums are implicitly static 3 8596
EmptyCatchBlock Avoid empty catch blocks 3 260262

org/eclipse/jgit/transport/PostReceiveHook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 3 6672
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPostReceive': the method is declared in an interface type 3 8485

org/eclipse/jgit/transport/PostUploadHook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 3 6065
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPostUpload': the method is declared in an interface type 3 75

org/eclipse/jgit/transport/PreReceiveHook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 3 8288
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPreReceive': the method is declared in an interface type 3 102

org/eclipse/jgit/transport/PreUploadHook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NULL': the field is declared in an interface type 3 6285
UnnecessaryModifier Unnecessary modifier 'public' on method 'onBeginNegotiateRound': the method is declared in an interface type 3 99101
UnnecessaryModifier Unnecessary modifier 'public' on method 'onEndNegotiateRound': the method is declared in an interface type 3 123126
UnnecessaryModifier Unnecessary modifier 'public' on method 'onSendPack': the method is declared in an interface type 3 144146

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 3 5557

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43220

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 267

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 3 8798
EmptyCatchBlock Avoid empty catch blocks 3 265268

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 7678

org/eclipse/jgit/transport/PushConnection.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 3 116118
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 3 166168

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 296298

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 7598
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 3 101134
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 279
UselessParentheses Useless parentheses. 4 777
CollapsibleIfStatements These nested if statements could be combined 3 780784
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 843
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 871
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 875
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 881

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 323325

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 4 167
UselessParentheses Useless parentheses. 4 320

org/eclipse/jgit/transport/RefFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DEFAULT': the field is declared in an interface type 3 6469
UnnecessaryModifier Unnecessary modifier 'public' on method 'filter': the method is declared in an interface type 3 79

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 553554

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 3 75127
UselessParentheses Useless parentheses. 4 355356

org/eclipse/jgit/transport/RemoteSession.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'exec': the method is declared in an interface type 3 81
UnnecessaryModifier Unnecessary modifier 'public' on method 'disconnect': the method is declared in an interface type 3 86

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 154

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 3 8789

org/eclipse/jgit/transport/Transport.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 160162

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 263265

org/eclipse/jgit/transport/TransportBundle.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'V2_BUNDLE_SIGNATURE': the field is declared in an interface type 3 61

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 118120

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 154156
EmptyCatchBlock Avoid empty catch blocks 3 214216
EmptyCatchBlock Avoid empty catch blocks 3 253255

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 182
EmptyCatchBlock Avoid empty catch blocks 3 353355
EmptyCatchBlock Avoid empty catch blocks 3 360362

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 471450
CollapsibleIfStatements These nested if statements could be combined 3 772774
EmptyWhileStmt Avoid empty while statements 3 907909
EmptyCatchBlock Avoid empty catch blocks 3 928930
EmptyCatchBlock Avoid empty catch blocks 3 934936

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 115

org/eclipse/jgit/transport/TransportProtocol.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'URIishField': nested enums are implicitly static 3 93104

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 362365

org/eclipse/jgit/transport/URIish.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 276277
UselessParentheses Useless parentheses. 4 337
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 442203
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RequestPolicy': nested enums are implicitly static 3 126156
UselessParentheses Useless parentheses. 4 700701
EmptyCatchBlock Avoid empty catch blocks 3 941943
EmptyCatchBlock Avoid empty catch blocks 3 954956
EmptyWhileStmt Avoid empty while statements 3 963965
EmptyWhileStmt Avoid empty while statements 3 11981200
EmptyWhileStmt Avoid empty while statements 3 12071209
EmptyCatchBlock Avoid empty catch blocks 3 12541256
EmptyCatchBlock Avoid empty catch blocks 3 14241426

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 120124

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 594
EmptyCatchBlock Avoid empty catch blocks 3 843845

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 302306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 423425

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 4 72
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_OK': the field is declared in an interface type 3 72
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 4 78
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_MOVED_PERM': the field is declared in an interface type 3 78
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_MOVED_TEMP': the field is declared in an interface type 3 84
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 4 84
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_SEE_OTHER': the field is declared in an interface type 3 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 4 90
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_11_MOVED_TEMP': the field is declared in an interface type 3 98
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_NOT_FOUND': the field is declared in an interface type 3 103
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 4 103
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_UNAUTHORIZED': the field is declared in an interface type 3 108
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 4 108
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 4 113
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'HTTP_FORBIDDEN': the field is declared in an interface type 3 113
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResponseCode': the method is declared in an interface type 3 122
UnnecessaryModifier Unnecessary modifier 'public' on method 'getURL': the method is declared in an interface type 3 130
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResponseMessage': the method is declared in an interface type 3 139
UnnecessaryModifier Unnecessary modifier 'public' on method 'getHeaderFields': the method is declared in an interface type 3 147
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRequestProperty': the method is declared in an interface type 3 159
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRequestMethod': the method is declared in an interface type 3 173174
UnnecessaryModifier Unnecessary modifier 'public' on method 'setUseCaches': the method is declared in an interface type 3 184
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConnectTimeout': the method is declared in an interface type 3 194
UnnecessaryModifier Unnecessary modifier 'public' on method 'setReadTimeout': the method is declared in an interface type 3 204
UnnecessaryModifier Unnecessary modifier 'public' on method 'getContentType': the method is declared in an interface type 3 213
UnnecessaryModifier Unnecessary modifier 'public' on method 'getInputStream': the method is declared in an interface type 3 225
UnnecessaryModifier Unnecessary modifier 'public' on method 'getHeaderField': the method is declared in an interface type 3 236
UnnecessaryModifier Unnecessary modifier 'public' on method 'getContentLength': the method is declared in an interface type 3 246
UnnecessaryModifier Unnecessary modifier 'public' on method 'setInstanceFollowRedirects': the method is declared in an interface type 3 256
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDoOutput': the method is declared in an interface type 3 265
UnnecessaryModifier Unnecessary modifier 'public' on method 'setFixedLengthStreamingMode': the method is declared in an interface type 3 274
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOutputStream': the method is declared in an interface type 3 283
UnnecessaryModifier Unnecessary modifier 'public' on method 'setChunkedStreamingMode': the method is declared in an interface type 3 293
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRequestMethod': the method is declared in an interface type 3 301
UnnecessaryModifier Unnecessary modifier 'public' on method 'usingProxy': the method is declared in an interface type 3 309
UnnecessaryModifier Unnecessary modifier 'public' on method 'connect': the method is declared in an interface type 3 317
UnnecessaryModifier Unnecessary modifier 'public' on method 'configure': the method is declared in an interface type 3 335337
UnnecessaryModifier Unnecessary modifier 'public' on method 'setHostnameVerifier': the method is declared in an interface type 3 348349

org/eclipse/jgit/transport/http/HttpConnectionFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 65
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 7879

org/eclipse/jgit/transport/resolver/ReceivePackFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DISABLED': the field is declared in an interface type 3 6066

org/eclipse/jgit/transport/resolver/RepositoryResolver.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NONE': the field is declared in an interface type 3 6066

org/eclipse/jgit/transport/resolver/UploadPackFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'DISABLED': the field is declared in an interface type 3 6066

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45445
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 202

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 84

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 149

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'OperationType': nested enums are implicitly static 3 114125
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 864
UselessParentheses Useless parentheses. 4 1302
UselessParentheses Useless parentheses. 4 1443

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 327328
EmptyCatchBlock Avoid empty catch blocks 3 473477
EmptyWhileStmt Avoid empty while statements 3 513515
CollapsibleIfStatements These nested if statements could be combined 3 901902
UselessParentheses Useless parentheses. 4 15251526
UselessParentheses Useless parentheses. 4 15271528

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 4 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 116

org/eclipse/jgit/util/Base64.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 120
UselessParentheses Useless parentheses. 4 127
UselessParentheses Useless parentheses. 4 134

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 200
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 293

org/eclipse/jgit/util/FS.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 381383
EmptyIfStmt Avoid empty if statements 3 12161219
UselessParentheses Useless parentheses. 4 1290
EmptyCatchBlock Avoid empty catch blocks 3 18261833
EmptyCatchBlock Avoid empty catch blocks 3 21652167

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 87
CollapsibleIfStatements These nested if statements could be combined 3 172190
CollapsibleIfStatements These nested if statements could be combined 3 173189
UselessParentheses Useless parentheses. 4 463
UselessParentheses Useless parentheses. 4 463

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 166168
CollapsibleIfStatements These nested if statements could be combined 3 182198

org/eclipse/jgit/util/FileUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 304306
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 505
SimplifiedTernary Ternary operators that can be simplified with || or && 3 826

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 64

org/eclipse/jgit/util/GitDateFormatter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Format': nested enums are implicitly static 3 71117

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 3 131133
EmptyCatchBlock Avoid empty catch blocks 3 231233
UselessParentheses Useless parentheses. 4 261262

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 3 315

org/eclipse/jgit/util/LongMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 3 169173
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 176178

org/eclipse/jgit/util/NB.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91
UselessParentheses Useless parentheses. 4 203
UselessParentheses Useless parentheses. 4 206

org/eclipse/jgit/util/ProcessResult.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 3 5469

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 451344
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 3 129136
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 3 210244
UselessParentheses Useless parentheses. 4 235
EmptyCatchBlock Avoid empty catch blocks 3 238240
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 3 264298
UselessParentheses Useless parentheses. 4 289
EmptyCatchBlock Avoid empty catch blocks 3 292294
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 3 315328
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 3 345369
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 3 387435
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 3 446451
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 465467
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 485491
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 3 504511
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 524526
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 541549
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 3 562571
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 3 586605
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 3 618626
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 639641
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 657666
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 3 696705
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 3 723730
UselessParentheses Useless parentheses. 4 748
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 3 767774
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 3 789798
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 3 813826
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 3 841851
UselessParentheses Useless parentheses. 4 958
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 3 12541265
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 3 12781287
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 3 13031313
UselessParentheses Useless parentheses. 4 1306

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 100102
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 112
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 3 117119
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 3 121123

org/eclipse/jgit/util/RefMap.java

Rule Violation Priority Line
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 428

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 122
UselessParentheses Useless parentheses. 4 126
UselessParentheses Useless parentheses. 4 127

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 405407

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7173

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 149151
EmptyCatchBlock Avoid empty catch blocks 3 154156

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 85
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 3 589592
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 3 594600

org/eclipse/jgit/util/time/MonotonicClock.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.time.Duration' 4 46