PMD Results

The following document contains the results of PMD 6.29.0.

Violations By Priority

Priority 2

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 148

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 514

org/eclipse/jgit/internal/storage/file/PackDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 224
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 251
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 277

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 323

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 502

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 192

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 507
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 585

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 688

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 378

org/eclipse/jgit/revwalk/TopoNonIntermixSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 114

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 102

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 623

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 566

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 169

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 116

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 831

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 166
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 259

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 512

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 79

Priority 3

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 93160

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 125127

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 776779

org/eclipse/jgit/api/LogCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 266271

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 690695
CollapsibleIfStatements These nested if statements could be combined 12781281

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 372376

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 213

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 124126

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 513515
EmptyIfStmt Avoid empty if statements 603607
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 11011103

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121244
EmptyCatchBlock Avoid empty catch blocks 720722

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 342
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'DirCacheVersion(int)': enum constructors are implicitly private 10381040

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 437440
EmptyIfStmt Avoid empty if statements 442447
CollapsibleIfStatements These nested if statements could be combined 901910
CollapsibleIfStatements These nested if statements could be combined 904909
CollapsibleIfStatements These nested if statements could be combined 12261232
EmptyWhileStmt Avoid empty while statements 16461648

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 215221

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 30

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 2931

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 101108
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 130132
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 148150
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 157159
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 166168
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 175177
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 188190

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 2325

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 2022

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 7879

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 144147
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 171172
EmptyCatchBlock Avoid empty catch blocks 559561

org/eclipse/jgit/ignore/IMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 2638
UnnecessaryModifier Unnecessary modifier 'public' on method 'createPathMatcher': the method is declared in an interface type 5357

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 33

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10310

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 302304

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3135
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3941

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 4850

org/eclipse/jgit/internal/revwalk/AddToBitmapWithCacheFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 6163

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 5658

org/eclipse/jgit/internal/revwalk/BitmappedReachabilityChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'dontFollow': private methods cannot be overridden 146150

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11244

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11727

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 215217

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11490

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 182184

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 150152

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 326328
EmptyCatchBlock Avoid empty catch blocks 346348

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11149

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 341343

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 143145

org/eclipse/jgit/internal/storage/dfs/DfsReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8991

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 108

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 2931
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3341
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 4952
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 5479
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 8183
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 8587

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 316318

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7981
CollapsibleIfStatements These nested if statements could be combined 166168

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 167169

org/eclipse/jgit/internal/storage/file/FileReftableStack.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 199202
EmptyCatchBlock Avoid empty catch blocks 318320
CollapsibleIfStatements These nested if statements could be combined 723725

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 198201
EmptyCatchBlock Avoid empty catch blocks 271273

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 390392
EmptyCatchBlock Avoid empty catch blocks 421423
EmptyCatchBlock Avoid empty catch blocks 539542
EmptyCatchBlock Avoid empty catch blocks 934936

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7880

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 4991
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 9396
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 98100
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 102104
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 106108
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 116120
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 122129
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 131133

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 6567

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 273275
CollapsibleIfStatements These nested if statements could be combined 289291
CollapsibleIfStatements These nested if statements could be combined 486488

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 188190

org/eclipse/jgit/internal/storage/file/Pack.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 354375
EmptyCatchBlock Avoid empty catch blocks 691695

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 350352
EmptyCatchBlock Avoid empty catch blocks 357359
EmptyCatchBlock Avoid empty catch blocks 362364

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 35

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11514
EmptyCatchBlock Avoid empty catch blocks 414416
EmptyCatchBlock Avoid empty catch blocks 435449

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 141477
CollapsibleIfStatements These nested if statements could be combined 524525
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 13731377

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 181183

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 13255

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 3640

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StatsRecorder': member interfaces are implicitly static 114183
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 328334
UnnecessaryModifier Unnecessary modifier 'static' on interface 'PageRef': member interfaces are implicitly static 781845
UnnecessaryModifier Unnecessary modifier 'static' on interface 'CleanupQueue': member interfaces are implicitly static 970973

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103105

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 4284
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 4284

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 106116
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 229231
SimplifiedTernary Ternary operators that can be simplified with || or && 317

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 276278

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 2428
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3133
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3638
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 4143
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 4648
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 5060

org/eclipse/jgit/internal/storage/pack/PackExt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PackExt(String)': enum constructors are implicitly private 3436

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 7781
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 85105
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 113120
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 137139
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 158173
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 175184
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 186193
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 195200
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 220222
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 225227

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 122516
EmptyWhileStmt Avoid empty while statements 19391941
CollapsibleIfStatements These nested if statements could be combined 22812282
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 22962299

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 261263
CollapsibleIfStatements These nested if statements could be combined 273277

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11567

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11572

org/eclipse/jgit/internal/storage/reftable/MergedReftable.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 299302

org/eclipse/jgit/internal/storage/reftable/ReftableBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11382

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11216

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11720
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 692

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11840

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10174

org/eclipse/jgit/internal/transport/connectivity/IterativeConnectivityChecker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8486

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 346348

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 203205
EmptyCatchBlock Avoid empty catch blocks 413415

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 4454
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 6876
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 8992
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 101106
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 108123
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 125136
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 217237
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 253273
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 289309
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 316318
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 346367

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 266

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11795

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 4694
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 100188

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 4244

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 14901499
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 15271543

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 9597

org/eclipse/jgit/lib/FileMode.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 35
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 38
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 41
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 44
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 47
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 50
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 75
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 85
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 90
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 130

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3133

org/eclipse/jgit/lib/GpgObjectSigner.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'canLocateSigningKey': the method is declared in an interface type 9093

org/eclipse/jgit/lib/GpgSignatureVerifier.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'verify': the method is declared in an interface type 5960

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 116118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 319
CollapsibleIfStatements These nested if statements could be combined 505508
CollapsibleIfStatements These nested if statements could be combined 550554

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121244

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 208222

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 307309
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 311313
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 315322

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 225227

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 5457
CollapsibleIfStatements These nested if statements could be combined 158161

org/eclipse/jgit/lib/Ref.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 7578

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 749751

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 875876

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 314335

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 4143

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11370

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 3941

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 141357
CollapsibleIfStatements These nested if statements could be combined 375377
CollapsibleIfStatements These nested if statements could be combined 788840
CollapsibleIfStatements These nested if statements could be combined 827830

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 53

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11620
EmptyCatchBlock Avoid empty catch blocks 215218

org/eclipse/jgit/patch/Patch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11359

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 164166

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 133136
EmptyCatchBlock Avoid empty catch blocks 152167

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 76112
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 76112
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 115242
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 245360

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 54
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 55
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 56
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 57
EmptyWhileStmt Avoid empty while statements 810812

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 160163

org/eclipse/jgit/storage/file/WindowCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11306

org/eclipse/jgit/storage/file/WindowCacheStats.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenFiles': the method is declared in an interface type 3032
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenBytes': the method is declared in an interface type 3941
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStats': the method is declared in an interface type 4749

org/eclipse/jgit/storage/pack/PackConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121222

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 14704
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 217
EmptyCatchBlock Avoid empty catch blocks 654656
EmptyCatchBlock Avoid empty catch blocks 665667
EmptyCatchBlock Avoid empty catch blocks 695697

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 607609
EmptyCatchBlock Avoid empty catch blocks 663665
EmptyCatchBlock Avoid empty catch blocks 683686
EmptyCatchBlock Avoid empty catch blocks 988990

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 152154
EmptyCatchBlock Avoid empty catch blocks 158160

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 231233
EmptyCatchBlock Avoid empty catch blocks 268270

org/eclipse/jgit/transport/ConnectivityChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'ConnectivityCheckInfo': members of interface types are implicitly public 51137
UnnecessaryModifier Unnecessary modifier 'static' on class 'ConnectivityCheckInfo': types nested within an interface type are implicitly static 51137

org/eclipse/jgit/transport/Daemon.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 81
EmptyCatchBlock Avoid empty catch blocks 282284
EmptyCatchBlock Avoid empty catch blocks 308310
EmptyCatchBlock Avoid empty catch blocks 392394
EmptyCatchBlock Avoid empty catch blocks 394396
EmptyCatchBlock Avoid empty catch blocks 396398
EmptyCatchBlock Avoid empty catch blocks 401403
EmptyCatchBlock Avoid empty catch blocks 406408

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 39

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12579
EmptyCatchBlock Avoid empty catch blocks 139141

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11237
EmptyCatchBlock Avoid empty catch blocks 115118
EmptyCatchBlock Avoid empty catch blocks 127130

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3164
EmptyCatchBlock Avoid empty catch blocks 188190

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 159161
EmptyIfStmt Avoid empty if statements 383385
EmptyIfStmt Avoid empty if statements 386388

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 143145
EmptyIfStmt Avoid empty if statements 521523

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7780
EmptyCatchBlock Avoid empty catch blocks 8688
EmptyCatchBlock Avoid empty catch blocks 9294

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7073
EmptyCatchBlock Avoid empty catch blocks 8284
EmptyCatchBlock Avoid empty catch blocks 8890

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 103107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 699722
EmptyCatchBlock Avoid empty catch blocks 11581162
EmptyCatchBlock Avoid empty catch blocks 11761180

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 338340

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 110115

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 2224

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10248
EmptyIfStmt Avoid empty if statements 6971

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 5465
EmptyCatchBlock Avoid empty catch blocks 232235

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 4345

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 263265

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 747751

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 112269
EmptyCatchBlock Avoid empty catch blocks 363365
EmptyCatchBlock Avoid empty catch blocks 374376
EmptyCatchBlock Avoid empty catch blocks 390392
EmptyCatchBlock Avoid empty catch blocks 10481050
EmptyCatchBlock Avoid empty catch blocks 13751377

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11423

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 521522

org/eclipse/jgit/transport/SshConfigStore.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'EMPTY_CONFIG': the field is declared in an interface type 91113

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 5456

org/eclipse/jgit/transport/Transport.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 130132

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 231233

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8587

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 128130
EmptyCatchBlock Avoid empty catch blocks 205207
EmptyCatchBlock Avoid empty catch blocks 244246

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 372374
EmptyCatchBlock Avoid empty catch blocks 379381

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 141924
CollapsibleIfStatements These nested if statements could be combined 986988
EmptyWhileStmt Avoid empty while statements 13531355
EmptyCatchBlock Avoid empty catch blocks 13741376
EmptyCatchBlock Avoid empty catch blocks 13801382

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 313316

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 112441
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 206208
EmptyWhileStmt Avoid empty while statements 10731075
EmptyWhileStmt Avoid empty while statements 13331335
EmptyWhileStmt Avoid empty while statements 13421344
EmptyCatchBlock Avoid empty catch blocks 13891391
EmptyCatchBlock Avoid empty catch blocks 15571559

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 8791

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 815817

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 273277

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 388390

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12411

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 442446
EmptyWhileStmt Avoid empty while statements 482484
CollapsibleIfStatements These nested if statements could be combined 880881
EmptyCatchBlock Avoid empty catch blocks 15231525

org/eclipse/jgit/util/FS.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 454456
EmptyIfStmt Avoid empty if statements 14401443
EmptyCatchBlock Avoid empty catch blocks 21302137
EmptyCatchBlock Avoid empty catch blocks 24692471

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 59
CollapsibleIfStatements These nested if statements could be combined 146160

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 131133
CollapsibleIfStatements These nested if statements could be combined 147163

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 310312
SimplifiedTernary Ternary operators that can be simplified with || or && 854

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 98100
EmptyCatchBlock Avoid empty catch blocks 198200

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 305

org/eclipse/jgit/util/LongMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 136140
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 143145

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121307
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 98105
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 179213
EmptyCatchBlock Avoid empty catch blocks 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 233267
EmptyCatchBlock Avoid empty catch blocks 261263
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 284297
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 314338
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 356404
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 415420
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 434436
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 454460
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 473480
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 493495
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 510518
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 531540
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 555574
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 587595
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 608610
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 626635
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 659667
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 685692
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 730737
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 752761
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 776789
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 804814
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 12171228
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 12411250
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 12661276

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 6769
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 8486
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 8890

org/eclipse/jgit/util/References.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 3133

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 377379

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 3840

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 116118
EmptyCatchBlock Avoid empty catch blocks 121123

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 54
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 562565
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 567573

Priority 4

org/eclipse/jgit/api/AddCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 179180
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 180
UselessParentheses Useless parentheses. 181182

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 554

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 171
UselessParentheses Useless parentheses. 172

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 412413
UselessParentheses Useless parentheses. 414
UselessParentheses Useless parentheses. 548

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 223

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 453
UselessParentheses Useless parentheses. 453

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 164166

org/eclipse/jgit/api/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 383

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 251

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 757758
UselessParentheses Useless parentheses. 757
UselessParentheses Useless parentheses. 758
UselessParentheses Useless parentheses. 1725

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 223

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 159
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 185
UselessParentheses Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 144

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 287
UselessParentheses Useless parentheses. 409410
UselessParentheses Useless parentheses. 468
UselessParentheses Useless parentheses. 516

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 50
UselessParentheses Useless parentheses. 100
UselessParentheses Useless parentheses. 138
UselessParentheses Useless parentheses. 173
UselessParentheses Useless parentheses. 217

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Line
UselessParentheses Useless parentheses. 348

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
UselessParentheses Useless parentheses. 651
UselessParentheses Useless parentheses. 729
UselessParentheses Useless parentheses. 730
UselessParentheses Useless parentheses. 731
UselessParentheses Useless parentheses. 732
UselessParentheses Useless parentheses. 733
UselessParentheses Useless parentheses. 734
UselessParentheses Useless parentheses. 793
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 889
UselessParentheses Useless parentheses. 11361137

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 152
UselessParentheses Useless parentheses. 307
UselessParentheses Useless parentheses. 473
UselessParentheses Useless parentheses. 473

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Line
UselessParentheses Useless parentheses. 461

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 748
UselessParentheses Useless parentheses. 749

org/eclipse/jgit/ignore/FastIgnoreRule.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'IMatcher.NO_MATCH' due to existing static import 'org.eclipse.jgit.ignore.IMatcher.NO_MATCH' 68

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 97

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 99

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UselessParentheses Useless parentheses. 105
UselessParentheses Useless parentheses. 363

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 34

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 437

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 593
UselessParentheses Useless parentheses. 600

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Line
UselessParentheses Useless parentheses. 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 545

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 436
UselessParentheses Useless parentheses. 442
UselessParentheses Useless parentheses. 449
UselessParentheses Useless parentheses. 455
UselessParentheses Useless parentheses. 472
UselessParentheses Useless parentheses. 496
UselessParentheses Useless parentheses. 582
UselessParentheses Useless parentheses. 590
UselessParentheses Useless parentheses. 670
UselessParentheses Useless parentheses. 720
UselessParentheses Useless parentheses. 839
UselessParentheses Useless parentheses. 949

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 729

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 255
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 257
UselessParentheses Useless parentheses. 271272
UselessParentheses Useless parentheses. 274275
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 419
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 425
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 451
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 535

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Line
UselessParentheses Useless parentheses. 559
UselessParentheses Useless parentheses. 559

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 411
UselessParentheses Useless parentheses. 954957
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1140
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1143
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 1217

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 256257

org/eclipse/jgit/internal/storage/file/Pack.java

Rule Violation Line
UselessParentheses Useless parentheses. 421
UselessParentheses Useless parentheses. 427
UselessParentheses Useless parentheses. 434
UselessParentheses Useless parentheses. 440
UselessParentheses Useless parentheses. 457
UselessParentheses Useless parentheses. 490
UselessParentheses Useless parentheses. 510
UselessParentheses Useless parentheses. 567
UselessParentheses Useless parentheses. 575
UselessParentheses Useless parentheses. 827
UselessParentheses Useless parentheses. 876
UselessParentheses Useless parentheses. 991
UselessParentheses Useless parentheses. 1082
UselessParentheses Useless parentheses. 1097

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 130

org/eclipse/jgit/internal/storage/file/PackDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 285
UselessParentheses Useless parentheses. 286
UselessParentheses Useless parentheses. 340

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 207

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Line
UselessParentheses Useless parentheses. 198
UselessParentheses Useless parentheses. 305

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 356
UselessParentheses Useless parentheses. 357
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 509

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 1151
UselessParentheses Useless parentheses. 1166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1234

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Line
UselessParentheses Useless parentheses. 286

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 35

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 161

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 353
UselessParentheses Useless parentheses. 2207
UselessParentheses Useless parentheses. 22082211
UselessParentheses Useless parentheses. 2297
UselessParentheses Useless parentheses. 2298
UselessParentheses Useless parentheses. 2388
UselessParentheses Useless parentheses. 2405

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
UselessParentheses Useless parentheses. 102
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 203
UselessParentheses Useless parentheses. 237
UselessParentheses Useless parentheses. 238239
UselessParentheses Useless parentheses. 239
UselessParentheses Useless parentheses. 240
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 252

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 539
UselessParentheses Useless parentheses. 551

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 105

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 105
UselessParentheses Useless parentheses. 449

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 206207

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 8485

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UselessParentheses Useless parentheses. 1457

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 248

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 552553
UselessParentheses Useless parentheses. 675676
UselessParentheses Useless parentheses. 675676
UselessParentheses Useless parentheses. 675
UselessParentheses Useless parentheses. 804805

org/eclipse/jgit/lib/ObjectBuilder.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StandardCharsets.UTF_8' due to existing static import 'java.nio.charset.StandardCharsets.UTF_8' 43

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 538
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 570
UselessParentheses Useless parentheses. 843
UselessParentheses Useless parentheses. 903
UselessParentheses Useless parentheses. 904
UselessParentheses Useless parentheses. 982
UselessParentheses Useless parentheses. 994
UselessParentheses Useless parentheses. 10751076
UselessParentheses Useless parentheses. 1077
UselessParentheses Useless parentheses. 1078

org/eclipse/jgit/lib/RefDatabase.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' 441

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
UselessParentheses Useless parentheses. 603
UselessParentheses Useless parentheses. 615
UselessParentheses Useless parentheses. 817
UselessParentheses Useless parentheses. 818
UselessParentheses Useless parentheses. 819

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UselessParentheses Useless parentheses. 269

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Line
UselessParentheses Useless parentheses. 289

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Line
UselessParentheses Useless parentheses. 57

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 108

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 788789
UselessParentheses Useless parentheses. 788789
UselessParentheses Useless parentheses. 788
UselessParentheses Useless parentheses. 890891

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 18
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 19

org/eclipse/jgit/nls/NLS.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 17
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 18

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 251
UselessParentheses Useless parentheses. 253

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 264

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 162

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Line
UselessParentheses Useless parentheses. 91

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 115
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 245

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 529

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 506507
UselessParentheses Useless parentheses. 880

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 367368
UselessParentheses Useless parentheses. 403

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 574

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
UselessParentheses Useless parentheses. 142
UselessParentheses Useless parentheses. 143

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 104122
UselessParentheses Useless parentheses. 454455
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 521

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 819
UselessParentheses Useless parentheses. 994

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Line
UselessParentheses Useless parentheses. 234

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 246
UselessParentheses Useless parentheses. 744
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 810
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 838
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 842
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 848

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1347

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 136
UselessParentheses Useless parentheses. 292293

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 322323

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 121

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 56

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
UselessParentheses Useless parentheses. 165

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
UselessParentheses Useless parentheses. 1044

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Line
UselessParentheses Useless parentheses. 83

org/eclipse/jgit/transport/URIish.java

Rule Violation Line
UselessParentheses Useless parentheses. 244245
UselessParentheses Useless parentheses. 308
UselessParentheses Useless parentheses. 309
UselessParentheses Useless parentheses. 333
UselessParentheses Useless parentheses. 334

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
UselessParentheses Useless parentheses. 1402
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_TAGS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_TAGS' 1998

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 41
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_AUTHORITATIVE' due to existing import 'java.net.HttpURLConnection' 47
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 53
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 59
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 100

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 50
UselessParentheses Useless parentheses. 51

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 1269
UselessParentheses Useless parentheses. 1406

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
UselessParentheses Useless parentheses. 296297
UselessParentheses Useless parentheses. 15401541
UselessParentheses Useless parentheses. 15421543

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Line
UselessParentheses Useless parentheses. 44

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Line
UselessParentheses Useless parentheses. 83

org/eclipse/jgit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses. 120
UselessParentheses Useless parentheses. 127
UselessParentheses Useless parentheses. 134

org/eclipse/jgit/util/FS.java

Rule Violation Line
UselessParentheses Useless parentheses. 1514
UselessParentheses Useless parentheses. 19871988
UselessParentheses Useless parentheses. 20032004

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
UselessParentheses Useless parentheses. 466
UselessParentheses Useless parentheses. 466

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 31

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 229230

org/eclipse/jgit/util/HttpSupport.java

Rule Violation Line
UselessParentheses Useless parentheses. 450
UselessParentheses Useless parentheses. 450

org/eclipse/jgit/util/NB.java

Rule Violation Line
UselessParentheses Useless parentheses. 58
UselessParentheses Useless parentheses. 170
UselessParentheses Useless parentheses. 173

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 258
UselessParentheses Useless parentheses. 711
UselessParentheses Useless parentheses. 921
UselessParentheses Useless parentheses. 1269

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Line
UselessParentheses Useless parentheses. 89
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 94

Files

org/eclipse/jgit/api/AddCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 179180
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 4 180
UselessParentheses Useless parentheses. 4 181182

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 3 93160

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 3 125127
UselessParentheses Useless parentheses. 4 554

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 171
UselessParentheses Useless parentheses. 4 172

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 776779

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 412413
UselessParentheses Useless parentheses. 4 414
UselessParentheses Useless parentheses. 4 548

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 4 223

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 453
UselessParentheses Useless parentheses. 4 453

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 164166

org/eclipse/jgit/api/LogCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 266271

org/eclipse/jgit/api/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 383

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 251

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 690695
UselessParentheses Useless parentheses. 4 757758
UselessParentheses Useless parentheses. 4 757
UselessParentheses Useless parentheses. 4 758
CollapsibleIfStatements These nested if statements could be combined 3 12781281
UselessParentheses Useless parentheses. 4 1725

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 372376

org/eclipse/jgit/api/TagCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 3 213
UselessParentheses Useless parentheses. 4 223

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 159
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 185
UselessParentheses Useless parentheses. 4 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 124126

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 513515
EmptyIfStmt Avoid empty if statements 3 603607
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 3 11011103

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121244
EmptyCatchBlock Avoid empty catch blocks 3 720722

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 287
UselessParentheses Useless parentheses. 4 409410
UselessParentheses Useless parentheses. 4 468
UselessParentheses Useless parentheses. 4 516

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 50
UselessParentheses Useless parentheses. 4 100
UselessParentheses Useless parentheses. 4 138
UselessParentheses Useless parentheses. 4 173
UselessParentheses Useless parentheses. 4 217

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 348

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 342
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'DirCacheVersion(int)': enum constructors are implicitly private 3 10381040

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 148

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 437440
EmptyIfStmt Avoid empty if statements 3 442447
UselessParentheses Useless parentheses. 4 651
UselessParentheses Useless parentheses. 4 729
UselessParentheses Useless parentheses. 4 730
UselessParentheses Useless parentheses. 4 731
UselessParentheses Useless parentheses. 4 732
UselessParentheses Useless parentheses. 4 733
UselessParentheses Useless parentheses. 4 734
UselessParentheses Useless parentheses. 4 793
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 889
CollapsibleIfStatements These nested if statements could be combined 3 901910
CollapsibleIfStatements These nested if statements could be combined 3 904909
UselessParentheses Useless parentheses. 4 11361137
CollapsibleIfStatements These nested if statements could be combined 3 12261232
EmptyWhileStmt Avoid empty while statements 3 16461648

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 152
UselessParentheses Useless parentheses. 4 307
UselessParentheses Useless parentheses. 4 473
UselessParentheses Useless parentheses. 4 473

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 215221

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 461

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 3 30

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 2931

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 101108
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 130132
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 148150
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 157159
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 166168
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 175177
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 188190

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 2325

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 2022

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 3 7879

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 3 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 3 144147
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 3 171172
EmptyCatchBlock Avoid empty catch blocks 3 559561
UselessParentheses Useless parentheses. 4 748
UselessParentheses Useless parentheses. 4 749

org/eclipse/jgit/ignore/FastIgnoreRule.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'IMatcher.NO_MATCH' due to existing static import 'org.eclipse.jgit.ignore.IMatcher.NO_MATCH' 4 68

org/eclipse/jgit/ignore/IMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 3 2638
UnnecessaryModifier Unnecessary modifier 'public' on method 'createPathMatcher': the method is declared in an interface type 3 5357

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 33
UselessParentheses Useless parentheses. 4 97

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10310
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 4 99

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 105
CollapsibleIfStatements These nested if statements could be combined 3 302304
UselessParentheses Useless parentheses. 4 363

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 3135
UselessParentheses Useless parentheses. 4 34
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 3941

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 4850

org/eclipse/jgit/internal/revwalk/AddToBitmapWithCacheFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 6163

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 5658

org/eclipse/jgit/internal/revwalk/BitmappedReachabilityChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'dontFollow': private methods cannot be overridden 3 146150

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11244

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11727
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 437

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 215217
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 593
UselessParentheses Useless parentheses. 4 600

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11490

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 545

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 3 182184
UselessParentheses Useless parentheses. 4 436
UselessParentheses Useless parentheses. 4 442
UselessParentheses Useless parentheses. 4 449
UselessParentheses Useless parentheses. 4 455
UselessParentheses Useless parentheses. 4 472
UselessParentheses Useless parentheses. 4 496
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 514
UselessParentheses Useless parentheses. 4 582
UselessParentheses Useless parentheses. 4 590
UselessParentheses Useless parentheses. 4 670
UselessParentheses Useless parentheses. 4 720
UselessParentheses Useless parentheses. 4 839
UselessParentheses Useless parentheses. 4 949

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 150152

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 326328
EmptyCatchBlock Avoid empty catch blocks 3 346348
UselessParentheses Useless parentheses. 4 729

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11149

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 341343

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 143145

org/eclipse/jgit/internal/storage/dfs/DfsReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8991

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 108

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 2931
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 3341
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 4952
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 3 5479
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 8183
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 8587

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 3 316318

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7981
CollapsibleIfStatements These nested if statements could be combined 3 166168

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 167169
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 255
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 257
UselessParentheses Useless parentheses. 4 271272
UselessParentheses Useless parentheses. 4 274275
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 4 419
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 4 425
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 451
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 535

org/eclipse/jgit/internal/storage/file/FileReftableStack.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 199202
EmptyCatchBlock Avoid empty catch blocks 3 318320
CollapsibleIfStatements These nested if statements could be combined 3 723725

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 198201
EmptyCatchBlock Avoid empty catch blocks 3 271273

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 559
UselessParentheses Useless parentheses. 4 559

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 390392
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 411
EmptyCatchBlock Avoid empty catch blocks 3 421423
EmptyCatchBlock Avoid empty catch blocks 3 539542
EmptyCatchBlock Avoid empty catch blocks 3 934936
UselessParentheses Useless parentheses. 4 954957
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1140
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1143
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 1217

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7880

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 3 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 3 4991
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 3 9396
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 98100
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 102104
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 3 106108
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 3 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 3 116120
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 3 122129
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 3 131133

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 6567

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 256257
CollapsibleIfStatements These nested if statements could be combined 3 273275
CollapsibleIfStatements These nested if statements could be combined 3 289291
CollapsibleIfStatements These nested if statements could be combined 3 486488

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 188190

org/eclipse/jgit/internal/storage/file/Pack.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 3 354375
UselessParentheses Useless parentheses. 4 421
UselessParentheses Useless parentheses. 4 427
UselessParentheses Useless parentheses. 4 434
UselessParentheses Useless parentheses. 4 440
UselessParentheses Useless parentheses. 4 457
UselessParentheses Useless parentheses. 4 490
UselessParentheses Useless parentheses. 4 510
UselessParentheses Useless parentheses. 4 567
UselessParentheses Useless parentheses. 4 575
EmptyCatchBlock Avoid empty catch blocks 3 691695
UselessParentheses Useless parentheses. 4 827
UselessParentheses Useless parentheses. 4 876
UselessParentheses Useless parentheses. 4 991
UselessParentheses Useless parentheses. 4 1082
UselessParentheses Useless parentheses. 4 1097

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 130

org/eclipse/jgit/internal/storage/file/PackDirectory.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 224
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 251
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 277
UselessParentheses Useless parentheses. 4 285
UselessParentheses Useless parentheses. 4 286
UselessParentheses Useless parentheses. 4 340

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 207

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 198
UselessParentheses Useless parentheses. 4 305

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 350352
EmptyCatchBlock Avoid empty catch blocks 3 357359
EmptyCatchBlock Avoid empty catch blocks 3 362364

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 35

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11514
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 323
UselessParentheses Useless parentheses. 4 356
UselessParentheses Useless parentheses. 4 357
EmptyCatchBlock Avoid empty catch blocks 3 414416
EmptyCatchBlock Avoid empty catch blocks 3 435449
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 509

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 141477
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 502
CollapsibleIfStatements These nested if statements could be combined 3 524525
UselessParentheses Useless parentheses. 4 1151
UselessParentheses Useless parentheses. 4 1166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 4 1234
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 3 13731377

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 181183

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 13255

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 3640

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StatsRecorder': member interfaces are implicitly static 3 114183
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 3 328334
UnnecessaryModifier Unnecessary modifier 'static' on interface 'PageRef': member interfaces are implicitly static 3 781845
UnnecessaryModifier Unnecessary modifier 'static' on interface 'CleanupQueue': member interfaces are implicitly static 3 970973

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 286

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103105

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 3 4284
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 3 4284

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 35

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Priority Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 3 106116
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 229231
SimplifiedTernary Ternary operators that can be simplified with || or && 3 317

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 192
EmptyCatchBlock Avoid empty catch blocks 3 276278

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 2428
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3 3133
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3 3638
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 4143
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 3 4648
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 3 5060

org/eclipse/jgit/internal/storage/pack/PackExt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PackExt(String)': enum constructors are implicitly private 3 3436

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 7781
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 85105
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 3 113120
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 3 137139
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 3 158173
UselessParentheses Useless parentheses. 4 161
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 3 175184
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 3 186193
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 3 195200
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 3 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 3 220222
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 3 225227

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 122516
UselessParentheses Useless parentheses. 4 353
EmptyWhileStmt Avoid empty while statements 3 19391941
UselessParentheses Useless parentheses. 4 2207
UselessParentheses Useless parentheses. 4 22082211
CollapsibleIfStatements These nested if statements could be combined 3 22812282
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 3 22962299
UselessParentheses Useless parentheses. 4 2297
UselessParentheses Useless parentheses. 4 2298
UselessParentheses Useless parentheses. 4 2388
UselessParentheses Useless parentheses. 4 2405

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 102
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 203
UselessParentheses Useless parentheses. 4 237
UselessParentheses Useless parentheses. 4 238239
UselessParentheses Useless parentheses. 4 239
UselessParentheses Useless parentheses. 4 240
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 252
EmptyWhileStmt Avoid empty while statements 3 261263
CollapsibleIfStatements These nested if statements could be combined 3 273277

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11567
UselessParentheses Useless parentheses. 4 539
UselessParentheses Useless parentheses. 4 551

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11572
UselessParentheses Useless parentheses. 4 105

org/eclipse/jgit/internal/storage/reftable/MergedReftable.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 299302

org/eclipse/jgit/internal/storage/reftable/ReftableBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11382

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11216

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11720
UselessParentheses Useless parentheses. 4 105
UselessParentheses Useless parentheses. 4 449
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 507
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 585
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 692

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11840
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 688

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10174

org/eclipse/jgit/internal/transport/connectivity/IterativeConnectivityChecker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8486

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 206207
EmptyCatchBlock Avoid empty catch blocks 3 346348

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 203205
EmptyCatchBlock Avoid empty catch blocks 3 413415

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 4454
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 6876
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 3 8992
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 101106
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 108123
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 3 125136
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 217237
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 253273
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 289309
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 316318
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 346367

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 266

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11795
UselessParentheses Useless parentheses. 4 8485

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 3 4694
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 3 100188

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 3 4244

org/eclipse/jgit/lib/Config.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1457
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 3 14901499
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 3 15271543

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 4 248

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 9597

org/eclipse/jgit/lib/FileMode.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 35
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 38
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 41
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 44
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 47
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 50
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 75
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 85
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 90
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 130

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3 3133

org/eclipse/jgit/lib/GpgObjectSigner.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'canLocateSigningKey': the method is declared in an interface type 3 9093

org/eclipse/jgit/lib/GpgSignatureVerifier.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'verify': the method is declared in an interface type 3 5960

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 3 116118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 3 319
CollapsibleIfStatements These nested if statements could be combined 3 505508
CollapsibleIfStatements These nested if statements could be combined 3 550554
UselessParentheses Useless parentheses. 4 552553
UselessParentheses Useless parentheses. 4 675676
UselessParentheses Useless parentheses. 4 675676
UselessParentheses Useless parentheses. 4 675
UselessParentheses Useless parentheses. 4 804805

org/eclipse/jgit/lib/ObjectBuilder.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StandardCharsets.UTF_8' due to existing static import 'java.nio.charset.StandardCharsets.UTF_8' 4 43

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121244
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 538
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 570
UselessParentheses Useless parentheses. 4 843
UselessParentheses Useless parentheses. 4 903
UselessParentheses Useless parentheses. 4 904
UselessParentheses Useless parentheses. 4 982
UselessParentheses Useless parentheses. 4 994
UselessParentheses Useless parentheses. 4 10751076
UselessParentheses Useless parentheses. 4 1077
UselessParentheses Useless parentheses. 4 1078

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 208222

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 3 307309
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 3 311313
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 3 315322

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 225227

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 3 5457
CollapsibleIfStatements These nested if statements could be combined 3 158161

org/eclipse/jgit/lib/Ref.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 3 7578

org/eclipse/jgit/lib/RefDatabase.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' 4 441

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 749751

org/eclipse/jgit/lib/Repository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 603
UselessParentheses Useless parentheses. 4 615
UselessParentheses Useless parentheses. 4 817
UselessParentheses Useless parentheses. 4 818
UselessParentheses Useless parentheses. 4 819
CollapsibleIfStatements These nested if statements could be combined 3 875876

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 269
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 3 314335

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 4143

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11370

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 289

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 3941

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 57

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 108

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 141357
CollapsibleIfStatements These nested if statements could be combined 3 375377
UselessParentheses Useless parentheses. 4 788789
UselessParentheses Useless parentheses. 4 788789
UselessParentheses Useless parentheses. 4 788
CollapsibleIfStatements These nested if statements could be combined 3 788840
CollapsibleIfStatements These nested if statements could be combined 3 827830
UselessParentheses Useless parentheses. 4 890891

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 3 53

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 18
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 19

org/eclipse/jgit/nls/NLS.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 17
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 18

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 251
UselessParentheses Useless parentheses. 4 253

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11620
EmptyCatchBlock Avoid empty catch blocks 3 215218
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 4 264

org/eclipse/jgit/patch/Patch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11359

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 162

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 164166

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 133136
EmptyCatchBlock Avoid empty catch blocks 3 152167

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 3 76112
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 3 76112
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 115
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 3 115242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 245
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 3 245360

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 54
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 55
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 56
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 57
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 378
EmptyWhileStmt Avoid empty while statements 3 810812

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 160163
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/revwalk/TopoNonIntermixSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 114

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 102

org/eclipse/jgit/storage/file/WindowCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11306

org/eclipse/jgit/storage/file/WindowCacheStats.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenFiles': the method is declared in an interface type 3 3032
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenBytes': the method is declared in an interface type 3 3941
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStats': the method is declared in an interface type 3 4749

org/eclipse/jgit/storage/pack/PackConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121222

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 529
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 623

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 14704
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 217
EmptyCatchBlock Avoid empty catch blocks 3 654656
EmptyCatchBlock Avoid empty catch blocks 3 665667
EmptyCatchBlock Avoid empty catch blocks 3 695697

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 506507
EmptyCatchBlock Avoid empty catch blocks 3 607609
EmptyCatchBlock Avoid empty catch blocks 3 663665
EmptyCatchBlock Avoid empty catch blocks 3 683686
UselessParentheses Useless parentheses. 4 880
EmptyCatchBlock Avoid empty catch blocks 3 988990

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 152154
EmptyCatchBlock Avoid empty catch blocks 3 158160
UselessParentheses Useless parentheses. 4 367368
UselessParentheses Useless parentheses. 4 403

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 231233
EmptyCatchBlock Avoid empty catch blocks 3 268270

org/eclipse/jgit/transport/ConnectivityChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'ConnectivityCheckInfo': members of interface types are implicitly public 3 51137
UnnecessaryModifier Unnecessary modifier 'static' on class 'ConnectivityCheckInfo': types nested within an interface type are implicitly static 3 51137

org/eclipse/jgit/transport/Daemon.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 81
EmptyCatchBlock Avoid empty catch blocks 3 282284
EmptyCatchBlock Avoid empty catch blocks 3 308310
EmptyCatchBlock Avoid empty catch blocks 3 392394
EmptyCatchBlock Avoid empty catch blocks 3 394396
EmptyCatchBlock Avoid empty catch blocks 3 396398
EmptyCatchBlock Avoid empty catch blocks 3 401403
EmptyCatchBlock Avoid empty catch blocks 3 406408

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 39

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12579
EmptyCatchBlock Avoid empty catch blocks 3 139141
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 4 574

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11237
EmptyCatchBlock Avoid empty catch blocks 3 115118
EmptyCatchBlock Avoid empty catch blocks 3 127130

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3 3164
EmptyCatchBlock Avoid empty catch blocks 3 188190

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 142
UselessParentheses Useless parentheses. 4 143
EmptyCatchBlock Avoid empty catch blocks 3 159161
EmptyIfStmt Avoid empty if statements 3 383385
EmptyIfStmt Avoid empty if statements 3 386388

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 104122
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 3 143145
UselessParentheses Useless parentheses. 4 454455
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 521
EmptyIfStmt Avoid empty if statements 3 521523

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7780
EmptyCatchBlock Avoid empty catch blocks 3 8688
EmptyCatchBlock Avoid empty catch blocks 3 9294

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7073
EmptyCatchBlock Avoid empty catch blocks 3 8284
EmptyCatchBlock Avoid empty catch blocks 3 8890

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 103107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 3 699722
UselessParentheses Useless parentheses. 4 819
UselessParentheses Useless parentheses. 4 994
EmptyCatchBlock Avoid empty catch blocks 3 11581162
EmptyCatchBlock Avoid empty catch blocks 3 11761180

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 338340

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 110115

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 3 2224

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10248
EmptyIfStmt Avoid empty if statements 3 6971

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 234

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 3 5465
EmptyCatchBlock Avoid empty catch blocks 3 232235

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 4345

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 263265

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 246
UselessParentheses Useless parentheses. 4 744
CollapsibleIfStatements These nested if statements could be combined 3 747751
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 810
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 838
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 842
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 848

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 112269
EmptyCatchBlock Avoid empty catch blocks 3 363365
EmptyCatchBlock Avoid empty catch blocks 3 374376
EmptyCatchBlock Avoid empty catch blocks 3 390392
EmptyCatchBlock Avoid empty catch blocks 3 10481050
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1347
EmptyCatchBlock Avoid empty catch blocks 3 13751377

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11423
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 4 136
UselessParentheses Useless parentheses. 4 292293

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 521522

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 322323

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 121

org/eclipse/jgit/transport/SshConfigStore.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'EMPTY_CONFIG': the field is declared in an interface type 3 91113

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 3 5456

org/eclipse/jgit/transport/Transport.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 130132

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 231233

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8587

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 128130
EmptyCatchBlock Avoid empty catch blocks 3 205207
EmptyCatchBlock Avoid empty catch blocks 3 244246

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 165
EmptyCatchBlock Avoid empty catch blocks 3 372374
EmptyCatchBlock Avoid empty catch blocks 3 379381

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 141924
CollapsibleIfStatements These nested if statements could be combined 3 986988
UselessParentheses Useless parentheses. 4 1044
EmptyWhileStmt Avoid empty while statements 3 13531355
EmptyCatchBlock Avoid empty catch blocks 3 13741376
EmptyCatchBlock Avoid empty catch blocks 3 13801382

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 313316

org/eclipse/jgit/transport/URIish.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 244245
UselessParentheses Useless parentheses. 4 308
UselessParentheses Useless parentheses. 4 309
UselessParentheses Useless parentheses. 4 333
UselessParentheses Useless parentheses. 4 334

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 112441
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 3 206208
EmptyWhileStmt Avoid empty while statements 3 10731075
EmptyWhileStmt Avoid empty while statements 3 13331335
EmptyWhileStmt Avoid empty while statements 3 13421344
EmptyCatchBlock Avoid empty catch blocks 3 13891391
UselessParentheses Useless parentheses. 4 1402
EmptyCatchBlock Avoid empty catch blocks 3 15571559
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_TAGS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_TAGS' 4 1998

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 8791

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 566
EmptyCatchBlock Avoid empty catch blocks 3 815817

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 273277

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 388390

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 4 41
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_AUTHORITATIVE' due to existing import 'java.net.HttpURLConnection' 4 47
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 4 53
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 4 59
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 4 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 4 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 4 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 4 100

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12411
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 169

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 50
UselessParentheses Useless parentheses. 4 51

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 116

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 831
UselessParentheses Useless parentheses. 4 1269
UselessParentheses Useless parentheses. 4 1406

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 296297
EmptyCatchBlock Avoid empty catch blocks 3 442446
EmptyWhileStmt Avoid empty while statements 3 482484
CollapsibleIfStatements These nested if statements could be combined 3 880881
EmptyCatchBlock Avoid empty catch blocks 3 15231525
UselessParentheses Useless parentheses. 4 15401541
UselessParentheses Useless parentheses. 4 15421543

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 44

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83

org/eclipse/jgit/util/Base64.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 120
UselessParentheses Useless parentheses. 4 127
UselessParentheses Useless parentheses. 4 134

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 166
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 259

org/eclipse/jgit/util/FS.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 454456
EmptyIfStmt Avoid empty if statements 3 14401443
UselessParentheses Useless parentheses. 4 1514
UselessParentheses Useless parentheses. 4 19871988
UselessParentheses Useless parentheses. 4 20032004
EmptyCatchBlock Avoid empty catch blocks 3 21302137
EmptyCatchBlock Avoid empty catch blocks 3 24692471

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 59
CollapsibleIfStatements These nested if statements could be combined 3 146160
UselessParentheses Useless parentheses. 4 466
UselessParentheses Useless parentheses. 4 466

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 131133
CollapsibleIfStatements These nested if statements could be combined 3 147163

org/eclipse/jgit/util/FileUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 310312
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 512
SimplifiedTernary Ternary operators that can be simplified with || or && 3 854

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 31

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 3 98100
EmptyCatchBlock Avoid empty catch blocks 3 198200
UselessParentheses Useless parentheses. 4 229230

org/eclipse/jgit/util/HttpSupport.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 450
UselessParentheses Useless parentheses. 4 450

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 3 305

org/eclipse/jgit/util/LongMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 3 136140
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 143145

org/eclipse/jgit/util/NB.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 58
UselessParentheses Useless parentheses. 4 170
UselessParentheses Useless parentheses. 4 173

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121307
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 3 98105
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 3 179213
UselessParentheses Useless parentheses. 4 204
EmptyCatchBlock Avoid empty catch blocks 3 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 3 233267
UselessParentheses Useless parentheses. 4 258
EmptyCatchBlock Avoid empty catch blocks 3 261263
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 3 284297
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 3 314338
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 3 356404
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 3 415420
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 434436
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 454460
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 3 473480
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 493495
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 510518
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 3 531540
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 3 555574
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 3 587595
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 608610
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 626635
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 3 659667
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 3 685692
UselessParentheses Useless parentheses. 4 711
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 3 730737
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 3 752761
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 3 776789
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 3 804814
UselessParentheses Useless parentheses. 4 921
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 3 12171228
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 3 12411250
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 3 12661276
UselessParentheses Useless parentheses. 4 1269

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 6769
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 79
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 3 8486
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 3 8890

org/eclipse/jgit/util/References.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 3 3133

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 377379

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 3840

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 116118
EmptyCatchBlock Avoid empty catch blocks 3 121123

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 54
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 3 562565
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 3 567573