PMD Results

The following document contains the results of PMD 6.29.0.

Violations By Priority

Priority 2

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 148

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 514

org/eclipse/jgit/internal/storage/file/PackDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 224
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 251
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 277

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 323

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 502

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 192

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 507
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 585

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 688

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 378

org/eclipse/jgit/revwalk/TopoNonIntermixSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 114

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 102

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 623

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 566

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 169

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 116

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 831

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 166
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 259

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 512

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 79

Priority 3

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 93–160

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 125–127

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 776–779

org/eclipse/jgit/api/LogCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 266–271

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 690–695
CollapsibleIfStatements These nested if statements could be combined 1278–1281

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 372–376

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 213

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 124–126

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 513–515
EmptyIfStmt Avoid empty if statements 603–607
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 1101–1103

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–1244
EmptyCatchBlock Avoid empty catch blocks 720–722

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 342
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'DirCacheVersion(int)': enum constructors are implicitly private 1038–1040

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 437–440
EmptyIfStmt Avoid empty if statements 442–447
CollapsibleIfStatements These nested if statements could be combined 901–910
CollapsibleIfStatements These nested if statements could be combined 904–909
CollapsibleIfStatements These nested if statements could be combined 1226–1232
EmptyWhileStmt Avoid empty while statements 1646–1648

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 215–221

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 30

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 29–31

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 101–108
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 130–132
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 139–141
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 148–150
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 157–159
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 166–168
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 175–177
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 188–190

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 23–25

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 20–22

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 78–79

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 144–147
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 171–172
EmptyCatchBlock Avoid empty catch blocks 559–561

org/eclipse/jgit/ignore/IMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 26–38
UnnecessaryModifier Unnecessary modifier 'public' on method 'createPathMatcher': the method is declared in an interface type 53–57

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 33

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10–310

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 302–304

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 31–35
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 39–41

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 48–50

org/eclipse/jgit/internal/revwalk/AddToBitmapWithCacheFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 61–63

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 56–58

org/eclipse/jgit/internal/revwalk/BitmappedReachabilityChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'dontFollow': private methods cannot be overridden 146–150

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–244

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–727

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 215–217

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–490

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 182–184

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 150–152

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 326–328
EmptyCatchBlock Avoid empty catch blocks 346–348

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–149

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 341–343

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 143–145

org/eclipse/jgit/internal/storage/dfs/DfsReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 89–91

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 108

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 29–31
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 33–41
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 43–47
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 49–52
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 54–79
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 81–83
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 85–87

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 316–318

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 79–81
CollapsibleIfStatements These nested if statements could be combined 166–168

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 167–169

org/eclipse/jgit/internal/storage/file/FileReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 281–283
CollapsibleIfStatements These nested if statements could be combined 686–688

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 198–201
EmptyCatchBlock Avoid empty catch blocks 271–273

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 390–392
EmptyCatchBlock Avoid empty catch blocks 421–423
EmptyCatchBlock Avoid empty catch blocks 539–542
EmptyCatchBlock Avoid empty catch blocks 934–936

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 78–80

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 43–47
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 49–91
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 93–96
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 98–100
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 102–104
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 106–108
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 110–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 116–120
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 122–129
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 131–133

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 65–67

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 273–275
CollapsibleIfStatements These nested if statements could be combined 289–291
CollapsibleIfStatements These nested if statements could be combined 486–488

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 188–190

org/eclipse/jgit/internal/storage/file/Pack.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 354–375
EmptyCatchBlock Avoid empty catch blocks 691–695

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 350–352
EmptyCatchBlock Avoid empty catch blocks 357–359
EmptyCatchBlock Avoid empty catch blocks 362–364

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 35

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–514
EmptyCatchBlock Avoid empty catch blocks 414–416
EmptyCatchBlock Avoid empty catch blocks 435–449

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 14–1477
CollapsibleIfStatements These nested if statements could be combined 524–525
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 1373–1377

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 181–183

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 13–255

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 36–40

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StatsRecorder': member interfaces are implicitly static 114–183
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 328–334
UnnecessaryModifier Unnecessary modifier 'static' on interface 'PageRef': member interfaces are implicitly static 781–845
UnnecessaryModifier Unnecessary modifier 'static' on interface 'CleanupQueue': member interfaces are implicitly static 970–973

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103–105

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 42–84
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 42–84

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 106–116
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 229–231
SimplifiedTernary Ternary operators that can be simplified with || or && 317

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 276–278

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 24–28
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 31–33
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 36–38
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 41–43
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 46–48
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 50–60

org/eclipse/jgit/internal/storage/pack/PackExt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PackExt(String)': enum constructors are implicitly private 34–36

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 77–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 85–105
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 113–120
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 137–139
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 158–173
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 175–184
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 186–193
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 195–200
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 207–209
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 220–222
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 225–227

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–2516
EmptyWhileStmt Avoid empty while statements 1939–1941
CollapsibleIfStatements These nested if statements could be combined 2281–2282
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 2296–2299

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 261–263
CollapsibleIfStatements These nested if statements could be combined 273–277

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–567

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–572

org/eclipse/jgit/internal/storage/reftable/MergedReftable.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 299–302

org/eclipse/jgit/internal/storage/reftable/ReftableBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–382

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–216

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–720
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 692

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–840

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10–174

org/eclipse/jgit/internal/transport/connectivity/IterativeConnectivityChecker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 84–86

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 346–348

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 202–204
EmptyCatchBlock Avoid empty catch blocks 421–423

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 44–54
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 68–76
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 89–92
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 101–106
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 108–123
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 125–136
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 217–237
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 253–273
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 289–309
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 316–318
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 346–367

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 266

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–795

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 46–94
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 100–188

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 42–44

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 1490–1499
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 1527–1543

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 95–97

org/eclipse/jgit/lib/FileMode.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 35
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 38
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 41
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 44
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 47
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 50
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 75
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 85
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 90
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 130

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 31–33

org/eclipse/jgit/lib/GpgObjectSigner.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'canLocateSigningKey': the method is declared in an interface type 90–93

org/eclipse/jgit/lib/GpgSignatureVerifier.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'verify': the method is declared in an interface type 59–60

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 116–118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 319
CollapsibleIfStatements These nested if statements could be combined 505–508
CollapsibleIfStatements These nested if statements could be combined 550–554

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–1244

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 208–222

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 307–309
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 311–313
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 315–322

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 225–227

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 54–57
CollapsibleIfStatements These nested if statements could be combined 158–161

org/eclipse/jgit/lib/Ref.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 75–78

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 749–751

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 875–876

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 314–335

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 41–43

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–370

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 39–41

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 14–1357
CollapsibleIfStatements These nested if statements could be combined 375–377
CollapsibleIfStatements These nested if statements could be combined 788–840
CollapsibleIfStatements These nested if statements could be combined 827–830

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 53

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–620
EmptyCatchBlock Avoid empty catch blocks 215–218

org/eclipse/jgit/patch/Patch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–359

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 164–166

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 133–136
EmptyCatchBlock Avoid empty catch blocks 152–167

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 76–112
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 76–112
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 115–242
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 245–360

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 54
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 55
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 56
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 57
EmptyWhileStmt Avoid empty while statements 810–812

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 160–163

org/eclipse/jgit/storage/file/WindowCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–306

org/eclipse/jgit/storage/file/WindowCacheStats.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenFiles': the method is declared in an interface type 30–32
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenBytes': the method is declared in an interface type 39–41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStats': the method is declared in an interface type 47–49

org/eclipse/jgit/storage/pack/PackConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–1222

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 14–704
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 217
EmptyCatchBlock Avoid empty catch blocks 654–656
EmptyCatchBlock Avoid empty catch blocks 665–667
EmptyCatchBlock Avoid empty catch blocks 695–697

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 607–609
EmptyCatchBlock Avoid empty catch blocks 663–665
EmptyCatchBlock Avoid empty catch blocks 683–686
EmptyCatchBlock Avoid empty catch blocks 988–990

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 152–154
EmptyCatchBlock Avoid empty catch blocks 158–160

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 231–233
EmptyCatchBlock Avoid empty catch blocks 268–270

org/eclipse/jgit/transport/ConnectivityChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'ConnectivityCheckInfo': members of interface types are implicitly public 51–137
UnnecessaryModifier Unnecessary modifier 'static' on class 'ConnectivityCheckInfo': types nested within an interface type are implicitly static 51–137

org/eclipse/jgit/transport/Daemon.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 81
EmptyCatchBlock Avoid empty catch blocks 282–284
EmptyCatchBlock Avoid empty catch blocks 308–310
EmptyCatchBlock Avoid empty catch blocks 392–394
EmptyCatchBlock Avoid empty catch blocks 394–396
EmptyCatchBlock Avoid empty catch blocks 396–398
EmptyCatchBlock Avoid empty catch blocks 401–403
EmptyCatchBlock Avoid empty catch blocks 406–408

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 39

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–579
EmptyCatchBlock Avoid empty catch blocks 139–141

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–237
EmptyCatchBlock Avoid empty catch blocks 115–118
EmptyCatchBlock Avoid empty catch blocks 127–130

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 31–64
EmptyCatchBlock Avoid empty catch blocks 188–190

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 159–161
EmptyIfStmt Avoid empty if statements 383–385
EmptyIfStmt Avoid empty if statements 386–388

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 143–145
EmptyIfStmt Avoid empty if statements 521–523

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 77–80
EmptyCatchBlock Avoid empty catch blocks 86–88
EmptyCatchBlock Avoid empty catch blocks 92–94

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 70–73
EmptyCatchBlock Avoid empty catch blocks 82–84
EmptyCatchBlock Avoid empty catch blocks 88–90

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 103–107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 699–722
EmptyCatchBlock Avoid empty catch blocks 1158–1162
EmptyCatchBlock Avoid empty catch blocks 1176–1180

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 338–340

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 110–115

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 22–24

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10–248
EmptyIfStmt Avoid empty if statements 69–71

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 54–65
EmptyCatchBlock Avoid empty catch blocks 232–235

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 43–45

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 263–265

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 747–751

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–2269
EmptyCatchBlock Avoid empty catch blocks 363–365
EmptyCatchBlock Avoid empty catch blocks 374–376
EmptyCatchBlock Avoid empty catch blocks 390–392
EmptyCatchBlock Avoid empty catch blocks 1048–1050
EmptyCatchBlock Avoid empty catch blocks 1375–1377

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–423

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 521–522

org/eclipse/jgit/transport/SshConfigStore.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'EMPTY_CONFIG': the field is declared in an interface type 91–113

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 54–56

org/eclipse/jgit/transport/Transport.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 130–132

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 231–233

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 85–87

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 128–130
EmptyCatchBlock Avoid empty catch blocks 205–207
EmptyCatchBlock Avoid empty catch blocks 244–246

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 372–374
EmptyCatchBlock Avoid empty catch blocks 379–381

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 14–1924
CollapsibleIfStatements These nested if statements could be combined 986–988
EmptyWhileStmt Avoid empty while statements 1353–1355
EmptyCatchBlock Avoid empty catch blocks 1374–1376
EmptyCatchBlock Avoid empty catch blocks 1380–1382

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 313–316

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11–2441
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 206–208
EmptyWhileStmt Avoid empty while statements 1073–1075
EmptyWhileStmt Avoid empty while statements 1333–1335
EmptyWhileStmt Avoid empty while statements 1342–1344
EmptyCatchBlock Avoid empty catch blocks 1389–1391
EmptyCatchBlock Avoid empty catch blocks 1557–1559

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 87–91

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 815–817

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 273–277

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 388–390

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–411

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 442–446
EmptyWhileStmt Avoid empty while statements 482–484
CollapsibleIfStatements These nested if statements could be combined 880–881
EmptyCatchBlock Avoid empty catch blocks 1523–1525

org/eclipse/jgit/util/FS.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 454–456
EmptyIfStmt Avoid empty if statements 1440–1443
EmptyCatchBlock Avoid empty catch blocks 2130–2137
EmptyCatchBlock Avoid empty catch blocks 2469–2471

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 59
CollapsibleIfStatements These nested if statements could be combined 146–160

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 131–133
CollapsibleIfStatements These nested if statements could be combined 147–163

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 310–312
SimplifiedTernary Ternary operators that can be simplified with || or && 854

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 98–100
EmptyCatchBlock Avoid empty catch blocks 198–200

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 305

org/eclipse/jgit/util/LongMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 136–140
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 143–145

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12–1307
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 98–105
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 179–213
EmptyCatchBlock Avoid empty catch blocks 207–209
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 233–267
EmptyCatchBlock Avoid empty catch blocks 261–263
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 284–297
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 314–338
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 356–404
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 415–420
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 434–436
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 454–460
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 473–480
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 493–495
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 510–518
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 531–540
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 555–574
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 587–595
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 608–610
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 626–635
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 659–667
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 685–692
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 730–737
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 752–761
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 776–789
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 804–814
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 1217–1228
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 1241–1250
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 1266–1276

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 67–69
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 84–86
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 88–90

org/eclipse/jgit/util/References.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 31–33

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 377–379

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 38–40

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 116–118
EmptyCatchBlock Avoid empty catch blocks 121–123

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 54
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 562–565
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 567–573

Priority 4

org/eclipse/jgit/api/AddCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 179–180
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 180
UselessParentheses Useless parentheses. 181–182

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 554

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 171
UselessParentheses Useless parentheses. 172

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 439–440
UselessParentheses Useless parentheses. 441
UselessParentheses Useless parentheses. 575

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 223

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 453
UselessParentheses Useless parentheses. 453

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 164–166

org/eclipse/jgit/api/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 383

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 251

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 757
UselessParentheses Useless parentheses. 757–758
UselessParentheses Useless parentheses. 758
UselessParentheses Useless parentheses. 1725

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 223

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 159
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 185
UselessParentheses Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 144

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 287
UselessParentheses Useless parentheses. 409–410
UselessParentheses Useless parentheses. 468
UselessParentheses Useless parentheses. 516

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 50
UselessParentheses Useless parentheses. 100
UselessParentheses Useless parentheses. 138
UselessParentheses Useless parentheses. 173
UselessParentheses Useless parentheses. 217

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Line
UselessParentheses Useless parentheses. 348

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
UselessParentheses Useless parentheses. 651
UselessParentheses Useless parentheses. 729
UselessParentheses Useless parentheses. 730
UselessParentheses Useless parentheses. 731
UselessParentheses Useless parentheses. 732
UselessParentheses Useless parentheses. 733
UselessParentheses Useless parentheses. 734
UselessParentheses Useless parentheses. 793
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 889
UselessParentheses Useless parentheses. 1136–1137

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 152
UselessParentheses Useless parentheses. 307
UselessParentheses Useless parentheses. 473
UselessParentheses Useless parentheses. 473

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Line
UselessParentheses Useless parentheses. 461

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 748
UselessParentheses Useless parentheses. 749

org/eclipse/jgit/ignore/FastIgnoreRule.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'IMatcher.NO_MATCH' due to existing static import 'org.eclipse.jgit.ignore.IMatcher.NO_MATCH' 68

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 97

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 99

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UselessParentheses Useless parentheses. 105
UselessParentheses Useless parentheses. 363

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 34

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 437

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 593
UselessParentheses Useless parentheses. 600

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Line
UselessParentheses Useless parentheses. 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 545

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 436
UselessParentheses Useless parentheses. 442
UselessParentheses Useless parentheses. 449
UselessParentheses Useless parentheses. 455
UselessParentheses Useless parentheses. 472
UselessParentheses Useless parentheses. 496
UselessParentheses Useless parentheses. 582
UselessParentheses Useless parentheses. 590
UselessParentheses Useless parentheses. 670
UselessParentheses Useless parentheses. 720
UselessParentheses Useless parentheses. 839
UselessParentheses Useless parentheses. 949

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 729

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 255
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 257
UselessParentheses Useless parentheses. 271–272
UselessParentheses Useless parentheses. 274–275
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 419
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 425
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 451
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 535

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Line
UselessParentheses Useless parentheses. 559
UselessParentheses Useless parentheses. 559

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 411
UselessParentheses Useless parentheses. 954–957
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1140
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1143
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 1217

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 256–257

org/eclipse/jgit/internal/storage/file/Pack.java

Rule Violation Line
UselessParentheses Useless parentheses. 421
UselessParentheses Useless parentheses. 427
UselessParentheses Useless parentheses. 434
UselessParentheses Useless parentheses. 440
UselessParentheses Useless parentheses. 457
UselessParentheses Useless parentheses. 490
UselessParentheses Useless parentheses. 510
UselessParentheses Useless parentheses. 567
UselessParentheses Useless parentheses. 575
UselessParentheses Useless parentheses. 827
UselessParentheses Useless parentheses. 876
UselessParentheses Useless parentheses. 991
UselessParentheses Useless parentheses. 1082
UselessParentheses Useless parentheses. 1097

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 130

org/eclipse/jgit/internal/storage/file/PackDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 285
UselessParentheses Useless parentheses. 286
UselessParentheses Useless parentheses. 340

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 207

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Line
UselessParentheses Useless parentheses. 198
UselessParentheses Useless parentheses. 305

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 356
UselessParentheses Useless parentheses. 357
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 509

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 1151
UselessParentheses Useless parentheses. 1166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1234

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Line
UselessParentheses Useless parentheses. 286

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 35

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 161

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 353
UselessParentheses Useless parentheses. 2207
UselessParentheses Useless parentheses. 2208–2211
UselessParentheses Useless parentheses. 2297
UselessParentheses Useless parentheses. 2298
UselessParentheses Useless parentheses. 2388
UselessParentheses Useless parentheses. 2405

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
UselessParentheses Useless parentheses. 102
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 203
UselessParentheses Useless parentheses. 237
UselessParentheses Useless parentheses. 238–239
UselessParentheses Useless parentheses. 239
UselessParentheses Useless parentheses. 240
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 252

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 539
UselessParentheses Useless parentheses. 551

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 105

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 105
UselessParentheses Useless parentheses. 449

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 206–207

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 84–85

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UselessParentheses Useless parentheses. 1457

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 248

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 552–553
UselessParentheses Useless parentheses. 675
UselessParentheses Useless parentheses. 675–676
UselessParentheses Useless parentheses. 675–676
UselessParentheses Useless parentheses. 804–805

org/eclipse/jgit/lib/ObjectBuilder.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StandardCharsets.UTF_8' due to existing static import 'java.nio.charset.StandardCharsets.UTF_8' 43

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 538
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 570
UselessParentheses Useless parentheses. 843
UselessParentheses Useless parentheses. 903
UselessParentheses Useless parentheses. 904
UselessParentheses Useless parentheses. 982
UselessParentheses Useless parentheses. 994
UselessParentheses Useless parentheses. 1075–1076
UselessParentheses Useless parentheses. 1077
UselessParentheses Useless parentheses. 1078

org/eclipse/jgit/lib/RefDatabase.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' 441

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
UselessParentheses Useless parentheses. 603
UselessParentheses Useless parentheses. 615
UselessParentheses Useless parentheses. 817
UselessParentheses Useless parentheses. 818
UselessParentheses Useless parentheses. 819

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UselessParentheses Useless parentheses. 269

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Line
UselessParentheses Useless parentheses. 289

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Line
UselessParentheses Useless parentheses. 57

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 108

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 788–789
UselessParentheses Useless parentheses. 788–789
UselessParentheses Useless parentheses. 788
UselessParentheses Useless parentheses. 890–891

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 18
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 19

org/eclipse/jgit/nls/NLS.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 17
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 18

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 251
UselessParentheses Useless parentheses. 253

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 264

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 162

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Line
UselessParentheses Useless parentheses. 91

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 115
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 245

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 529

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 506–507
UselessParentheses Useless parentheses. 880

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 367–368
UselessParentheses Useless parentheses. 403

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 574

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
UselessParentheses Useless parentheses. 142
UselessParentheses Useless parentheses. 143

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 104–122
UselessParentheses Useless parentheses. 454–455
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 521

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 819
UselessParentheses Useless parentheses. 994

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Line
UselessParentheses Useless parentheses. 234

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 246
UselessParentheses Useless parentheses. 744
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 810
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 838
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 842
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 848

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1347

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 136
UselessParentheses Useless parentheses. 292–293

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 322–323

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 121

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 56

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
UselessParentheses Useless parentheses. 165

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
UselessParentheses Useless parentheses. 1044

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Line
UselessParentheses Useless parentheses. 83

org/eclipse/jgit/transport/URIish.java

Rule Violation Line
UselessParentheses Useless parentheses. 244–245
UselessParentheses Useless parentheses. 308
UselessParentheses Useless parentheses. 309
UselessParentheses Useless parentheses. 333
UselessParentheses Useless parentheses. 334

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
UselessParentheses Useless parentheses. 1402
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_TAGS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_TAGS' 1998

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 41
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_AUTHORITATIVE' due to existing import 'java.net.HttpURLConnection' 47
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 53
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 59
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 100

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 50
UselessParentheses Useless parentheses. 51

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 1269
UselessParentheses Useless parentheses. 1406

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
UselessParentheses Useless parentheses. 296–297
UselessParentheses Useless parentheses. 1540–1541
UselessParentheses Useless parentheses. 1542–1543

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Line
UselessParentheses Useless parentheses. 44

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Line
UselessParentheses Useless parentheses. 83

org/eclipse/jgit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses. 120
UselessParentheses Useless parentheses. 127
UselessParentheses Useless parentheses. 134

org/eclipse/jgit/util/FS.java

Rule Violation Line
UselessParentheses Useless parentheses. 1514
UselessParentheses Useless parentheses. 1987–1988
UselessParentheses Useless parentheses. 2003–2004

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
UselessParentheses Useless parentheses. 466
UselessParentheses Useless parentheses. 466

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 31

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 229–230

org/eclipse/jgit/util/HttpSupport.java

Rule Violation Line
UselessParentheses Useless parentheses. 450
UselessParentheses Useless parentheses. 450

org/eclipse/jgit/util/NB.java

Rule Violation Line
UselessParentheses Useless parentheses. 58
UselessParentheses Useless parentheses. 170
UselessParentheses Useless parentheses. 173

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 258
UselessParentheses Useless parentheses. 711
UselessParentheses Useless parentheses. 921
UselessParentheses Useless parentheses. 1269

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Line
UselessParentheses Useless parentheses. 89
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 94

Files

org/eclipse/jgit/api/AddCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 179–180
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 4 180
UselessParentheses Useless parentheses. 4 181–182

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 3 93–160

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 3 125–127
UselessParentheses Useless parentheses. 4 554

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 171
UselessParentheses Useless parentheses. 4 172

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 776–779

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 439–440
UselessParentheses Useless parentheses. 4 441
UselessParentheses Useless parentheses. 4 575

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 4 223

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 453
UselessParentheses Useless parentheses. 4 453

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 164–166

org/eclipse/jgit/api/LogCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 266–271

org/eclipse/jgit/api/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 383

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 251

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 690–695
UselessParentheses Useless parentheses. 4 757
UselessParentheses Useless parentheses. 4 757–758
UselessParentheses Useless parentheses. 4 758
CollapsibleIfStatements These nested if statements could be combined 3 1278–1281
UselessParentheses Useless parentheses. 4 1725

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 372–376

org/eclipse/jgit/api/TagCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 3 213
UselessParentheses Useless parentheses. 4 223

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 159
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 185
UselessParentheses Useless parentheses. 4 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 124–126

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 513–515
EmptyIfStmt Avoid empty if statements 3 603–607
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 3 1101–1103

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–1244
EmptyCatchBlock Avoid empty catch blocks 3 720–722

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 287
UselessParentheses Useless parentheses. 4 409–410
UselessParentheses Useless parentheses. 4 468
UselessParentheses Useless parentheses. 4 516

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 50
UselessParentheses Useless parentheses. 4 100
UselessParentheses Useless parentheses. 4 138
UselessParentheses Useless parentheses. 4 173
UselessParentheses Useless parentheses. 4 217

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 348

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 342
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'DirCacheVersion(int)': enum constructors are implicitly private 3 1038–1040

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 148

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 437–440
EmptyIfStmt Avoid empty if statements 3 442–447
UselessParentheses Useless parentheses. 4 651
UselessParentheses Useless parentheses. 4 729
UselessParentheses Useless parentheses. 4 730
UselessParentheses Useless parentheses. 4 731
UselessParentheses Useless parentheses. 4 732
UselessParentheses Useless parentheses. 4 733
UselessParentheses Useless parentheses. 4 734
UselessParentheses Useless parentheses. 4 793
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 889
CollapsibleIfStatements These nested if statements could be combined 3 901–910
CollapsibleIfStatements These nested if statements could be combined 3 904–909
UselessParentheses Useless parentheses. 4 1136–1137
CollapsibleIfStatements These nested if statements could be combined 3 1226–1232
EmptyWhileStmt Avoid empty while statements 3 1646–1648

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 152
UselessParentheses Useless parentheses. 4 307
UselessParentheses Useless parentheses. 4 473
UselessParentheses Useless parentheses. 4 473

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 215–221

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 461

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 3 30

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 29–31

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 101–108
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 130–132
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 139–141
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 148–150
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 157–159
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 166–168
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 175–177
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 188–190

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 23–25

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 20–22

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 3 78–79

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 3 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 3 144–147
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 3 171–172
EmptyCatchBlock Avoid empty catch blocks 3 559–561
UselessParentheses Useless parentheses. 4 748
UselessParentheses Useless parentheses. 4 749

org/eclipse/jgit/ignore/FastIgnoreRule.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'IMatcher.NO_MATCH' due to existing static import 'org.eclipse.jgit.ignore.IMatcher.NO_MATCH' 4 68

org/eclipse/jgit/ignore/IMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 3 26–38
UnnecessaryModifier Unnecessary modifier 'public' on method 'createPathMatcher': the method is declared in an interface type 3 53–57

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 33
UselessParentheses Useless parentheses. 4 97

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10–310
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 4 99

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 105
CollapsibleIfStatements These nested if statements could be combined 3 302–304
UselessParentheses Useless parentheses. 4 363

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 31–35
UselessParentheses Useless parentheses. 4 34
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 39–41

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 48–50

org/eclipse/jgit/internal/revwalk/AddToBitmapWithCacheFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 61–63

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 56–58

org/eclipse/jgit/internal/revwalk/BitmappedReachabilityChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'dontFollow': private methods cannot be overridden 3 146–150

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–244

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–727
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 437

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 215–217
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 593
UselessParentheses Useless parentheses. 4 600

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–490

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 545

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 3 182–184
UselessParentheses Useless parentheses. 4 436
UselessParentheses Useless parentheses. 4 442
UselessParentheses Useless parentheses. 4 449
UselessParentheses Useless parentheses. 4 455
UselessParentheses Useless parentheses. 4 472
UselessParentheses Useless parentheses. 4 496
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 514
UselessParentheses Useless parentheses. 4 582
UselessParentheses Useless parentheses. 4 590
UselessParentheses Useless parentheses. 4 670
UselessParentheses Useless parentheses. 4 720
UselessParentheses Useless parentheses. 4 839
UselessParentheses Useless parentheses. 4 949

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 150–152

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 326–328
EmptyCatchBlock Avoid empty catch blocks 3 346–348
UselessParentheses Useless parentheses. 4 729

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–149

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 341–343

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 143–145

org/eclipse/jgit/internal/storage/dfs/DfsReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 89–91

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 108

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 29–31
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 33–41
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 43–47
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 49–52
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 3 54–79
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 81–83
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 85–87

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 3 316–318

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 79–81
CollapsibleIfStatements These nested if statements could be combined 3 166–168

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 167–169
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 255
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 257
UselessParentheses Useless parentheses. 4 271–272
UselessParentheses Useless parentheses. 4 274–275
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 4 419
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 4 425
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 451
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 535

org/eclipse/jgit/internal/storage/file/FileReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 281–283
CollapsibleIfStatements These nested if statements could be combined 3 686–688

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 198–201
EmptyCatchBlock Avoid empty catch blocks 3 271–273

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 559
UselessParentheses Useless parentheses. 4 559

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 390–392
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 411
EmptyCatchBlock Avoid empty catch blocks 3 421–423
EmptyCatchBlock Avoid empty catch blocks 3 539–542
EmptyCatchBlock Avoid empty catch blocks 3 934–936
UselessParentheses Useless parentheses. 4 954–957
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1140
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1143
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 1217

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 78–80

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 3 43–47
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 3 49–91
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 3 93–96
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 98–100
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 102–104
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 3 106–108
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 3 110–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 3 116–120
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 3 122–129
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 3 131–133

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 65–67

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 256–257
CollapsibleIfStatements These nested if statements could be combined 3 273–275
CollapsibleIfStatements These nested if statements could be combined 3 289–291
CollapsibleIfStatements These nested if statements could be combined 3 486–488

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 188–190

org/eclipse/jgit/internal/storage/file/Pack.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 3 354–375
UselessParentheses Useless parentheses. 4 421
UselessParentheses Useless parentheses. 4 427
UselessParentheses Useless parentheses. 4 434
UselessParentheses Useless parentheses. 4 440
UselessParentheses Useless parentheses. 4 457
UselessParentheses Useless parentheses. 4 490
UselessParentheses Useless parentheses. 4 510
UselessParentheses Useless parentheses. 4 567
UselessParentheses Useless parentheses. 4 575
EmptyCatchBlock Avoid empty catch blocks 3 691–695
UselessParentheses Useless parentheses. 4 827
UselessParentheses Useless parentheses. 4 876
UselessParentheses Useless parentheses. 4 991
UselessParentheses Useless parentheses. 4 1082
UselessParentheses Useless parentheses. 4 1097

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 130

org/eclipse/jgit/internal/storage/file/PackDirectory.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 224
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 251
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 277
UselessParentheses Useless parentheses. 4 285
UselessParentheses Useless parentheses. 4 286
UselessParentheses Useless parentheses. 4 340

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 207

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 198
UselessParentheses Useless parentheses. 4 305

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 350–352
EmptyCatchBlock Avoid empty catch blocks 3 357–359
EmptyCatchBlock Avoid empty catch blocks 3 362–364

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 35

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–514
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 323
UselessParentheses Useless parentheses. 4 356
UselessParentheses Useless parentheses. 4 357
EmptyCatchBlock Avoid empty catch blocks 3 414–416
EmptyCatchBlock Avoid empty catch blocks 3 435–449
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 509

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 14–1477
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 502
CollapsibleIfStatements These nested if statements could be combined 3 524–525
UselessParentheses Useless parentheses. 4 1151
UselessParentheses Useless parentheses. 4 1166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 4 1234
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 3 1373–1377

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 181–183

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 13–255

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 36–40

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StatsRecorder': member interfaces are implicitly static 3 114–183
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 3 328–334
UnnecessaryModifier Unnecessary modifier 'static' on interface 'PageRef': member interfaces are implicitly static 3 781–845
UnnecessaryModifier Unnecessary modifier 'static' on interface 'CleanupQueue': member interfaces are implicitly static 3 970–973

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 286

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103–105

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 3 42–84
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 3 42–84

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 35

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Priority Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 3 106–116
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 229–231
SimplifiedTernary Ternary operators that can be simplified with || or && 3 317

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 192
EmptyCatchBlock Avoid empty catch blocks 3 276–278

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 24–28
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3 31–33
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3 36–38
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 41–43
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 3 46–48
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 3 50–60

org/eclipse/jgit/internal/storage/pack/PackExt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PackExt(String)': enum constructors are implicitly private 3 34–36

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 77–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 85–105
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 3 113–120
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 3 137–139
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 3 158–173
UselessParentheses Useless parentheses. 4 161
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 3 175–184
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 3 186–193
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 3 195–200
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 3 207–209
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 3 220–222
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 3 225–227

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–2516
UselessParentheses Useless parentheses. 4 353
EmptyWhileStmt Avoid empty while statements 3 1939–1941
UselessParentheses Useless parentheses. 4 2207
UselessParentheses Useless parentheses. 4 2208–2211
CollapsibleIfStatements These nested if statements could be combined 3 2281–2282
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 3 2296–2299
UselessParentheses Useless parentheses. 4 2297
UselessParentheses Useless parentheses. 4 2298
UselessParentheses Useless parentheses. 4 2388
UselessParentheses Useless parentheses. 4 2405

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 102
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 203
UselessParentheses Useless parentheses. 4 237
UselessParentheses Useless parentheses. 4 238–239
UselessParentheses Useless parentheses. 4 239
UselessParentheses Useless parentheses. 4 240
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 252
EmptyWhileStmt Avoid empty while statements 3 261–263
CollapsibleIfStatements These nested if statements could be combined 3 273–277

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–567
UselessParentheses Useless parentheses. 4 539
UselessParentheses Useless parentheses. 4 551

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–572
UselessParentheses Useless parentheses. 4 105

org/eclipse/jgit/internal/storage/reftable/MergedReftable.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 299–302

org/eclipse/jgit/internal/storage/reftable/ReftableBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–382

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–216

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–720
UselessParentheses Useless parentheses. 4 105
UselessParentheses Useless parentheses. 4 449
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 507
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 585
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 692

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–840
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 688

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10–174

org/eclipse/jgit/internal/transport/connectivity/IterativeConnectivityChecker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 84–86

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 206–207
EmptyCatchBlock Avoid empty catch blocks 3 346–348

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 202–204
EmptyCatchBlock Avoid empty catch blocks 3 421–423

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 44–54
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 68–76
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 3 89–92
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 101–106
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 108–123
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 3 125–136
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 217–237
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 253–273
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 289–309
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 316–318
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 346–367

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 266

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–795
UselessParentheses Useless parentheses. 4 84–85

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 3 46–94
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 3 100–188

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 3 42–44

org/eclipse/jgit/lib/Config.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1457
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 3 1490–1499
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 3 1527–1543

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 4 248

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 95–97

org/eclipse/jgit/lib/FileMode.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 35
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 38
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 41
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 44
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 47
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 50
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 75
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 85
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 90
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 130

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3 31–33

org/eclipse/jgit/lib/GpgObjectSigner.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'canLocateSigningKey': the method is declared in an interface type 3 90–93

org/eclipse/jgit/lib/GpgSignatureVerifier.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'verify': the method is declared in an interface type 3 59–60

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 3 116–118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 3 319
CollapsibleIfStatements These nested if statements could be combined 3 505–508
CollapsibleIfStatements These nested if statements could be combined 3 550–554
UselessParentheses Useless parentheses. 4 552–553
UselessParentheses Useless parentheses. 4 675
UselessParentheses Useless parentheses. 4 675–676
UselessParentheses Useless parentheses. 4 675–676
UselessParentheses Useless parentheses. 4 804–805

org/eclipse/jgit/lib/ObjectBuilder.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StandardCharsets.UTF_8' due to existing static import 'java.nio.charset.StandardCharsets.UTF_8' 4 43

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–1244
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 538
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 570
UselessParentheses Useless parentheses. 4 843
UselessParentheses Useless parentheses. 4 903
UselessParentheses Useless parentheses. 4 904
UselessParentheses Useless parentheses. 4 982
UselessParentheses Useless parentheses. 4 994
UselessParentheses Useless parentheses. 4 1075–1076
UselessParentheses Useless parentheses. 4 1077
UselessParentheses Useless parentheses. 4 1078

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 208–222

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 3 307–309
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 3 311–313
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 3 315–322

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 225–227

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 3 54–57
CollapsibleIfStatements These nested if statements could be combined 3 158–161

org/eclipse/jgit/lib/Ref.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 3 75–78

org/eclipse/jgit/lib/RefDatabase.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' 4 441

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 749–751

org/eclipse/jgit/lib/Repository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 603
UselessParentheses Useless parentheses. 4 615
UselessParentheses Useless parentheses. 4 817
UselessParentheses Useless parentheses. 4 818
UselessParentheses Useless parentheses. 4 819
CollapsibleIfStatements These nested if statements could be combined 3 875–876

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 269
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 3 314–335

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 41–43

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–370

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 289

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 39–41

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 57

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 108

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 14–1357
CollapsibleIfStatements These nested if statements could be combined 3 375–377
CollapsibleIfStatements These nested if statements could be combined 3 788–840
UselessParentheses Useless parentheses. 4 788–789
UselessParentheses Useless parentheses. 4 788–789
UselessParentheses Useless parentheses. 4 788
CollapsibleIfStatements These nested if statements could be combined 3 827–830
UselessParentheses Useless parentheses. 4 890–891

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 3 53

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 18
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 19

org/eclipse/jgit/nls/NLS.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 17
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 18

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 251
UselessParentheses Useless parentheses. 4 253

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–620
EmptyCatchBlock Avoid empty catch blocks 3 215–218
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 4 264

org/eclipse/jgit/patch/Patch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–359

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 162

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 164–166

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 133–136
EmptyCatchBlock Avoid empty catch blocks 3 152–167

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 3 76–112
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 3 76–112
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 115
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 3 115–242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 245
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 3 245–360

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 54
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 55
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 56
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 57
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 378
EmptyWhileStmt Avoid empty while statements 3 810–812

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 160–163
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/revwalk/TopoNonIntermixSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 114

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 102

org/eclipse/jgit/storage/file/WindowCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–306

org/eclipse/jgit/storage/file/WindowCacheStats.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenFiles': the method is declared in an interface type 3 30–32
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenBytes': the method is declared in an interface type 3 39–41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStats': the method is declared in an interface type 3 47–49

org/eclipse/jgit/storage/pack/PackConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–1222

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 529
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 623

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 14–704
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 217
EmptyCatchBlock Avoid empty catch blocks 3 654–656
EmptyCatchBlock Avoid empty catch blocks 3 665–667
EmptyCatchBlock Avoid empty catch blocks 3 695–697

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 506–507
EmptyCatchBlock Avoid empty catch blocks 3 607–609
EmptyCatchBlock Avoid empty catch blocks 3 663–665
EmptyCatchBlock Avoid empty catch blocks 3 683–686
UselessParentheses Useless parentheses. 4 880
EmptyCatchBlock Avoid empty catch blocks 3 988–990

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 152–154
EmptyCatchBlock Avoid empty catch blocks 3 158–160
UselessParentheses Useless parentheses. 4 367–368
UselessParentheses Useless parentheses. 4 403

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 231–233
EmptyCatchBlock Avoid empty catch blocks 3 268–270

org/eclipse/jgit/transport/ConnectivityChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'ConnectivityCheckInfo': members of interface types are implicitly public 3 51–137
UnnecessaryModifier Unnecessary modifier 'static' on class 'ConnectivityCheckInfo': types nested within an interface type are implicitly static 3 51–137

org/eclipse/jgit/transport/Daemon.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 81
EmptyCatchBlock Avoid empty catch blocks 3 282–284
EmptyCatchBlock Avoid empty catch blocks 3 308–310
EmptyCatchBlock Avoid empty catch blocks 3 392–394
EmptyCatchBlock Avoid empty catch blocks 3 394–396
EmptyCatchBlock Avoid empty catch blocks 3 396–398
EmptyCatchBlock Avoid empty catch blocks 3 401–403
EmptyCatchBlock Avoid empty catch blocks 3 406–408

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 39

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–579
EmptyCatchBlock Avoid empty catch blocks 3 139–141
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 4 574

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–237
EmptyCatchBlock Avoid empty catch blocks 3 115–118
EmptyCatchBlock Avoid empty catch blocks 3 127–130

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3 31–64
EmptyCatchBlock Avoid empty catch blocks 3 188–190

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 142
UselessParentheses Useless parentheses. 4 143
EmptyCatchBlock Avoid empty catch blocks 3 159–161
EmptyIfStmt Avoid empty if statements 3 383–385
EmptyIfStmt Avoid empty if statements 3 386–388

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 104–122
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 3 143–145
UselessParentheses Useless parentheses. 4 454–455
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 521
EmptyIfStmt Avoid empty if statements 3 521–523

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 77–80
EmptyCatchBlock Avoid empty catch blocks 3 86–88
EmptyCatchBlock Avoid empty catch blocks 3 92–94

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 70–73
EmptyCatchBlock Avoid empty catch blocks 3 82–84
EmptyCatchBlock Avoid empty catch blocks 3 88–90

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 103–107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 3 699–722
UselessParentheses Useless parentheses. 4 819
UselessParentheses Useless parentheses. 4 994
EmptyCatchBlock Avoid empty catch blocks 3 1158–1162
EmptyCatchBlock Avoid empty catch blocks 3 1176–1180

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 338–340

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 110–115

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 3 22–24

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10–248
EmptyIfStmt Avoid empty if statements 3 69–71

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 234

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 3 54–65
EmptyCatchBlock Avoid empty catch blocks 3 232–235

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 43–45

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 263–265

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 246
UselessParentheses Useless parentheses. 4 744
CollapsibleIfStatements These nested if statements could be combined 3 747–751
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 810
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 838
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 842
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 848

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–2269
EmptyCatchBlock Avoid empty catch blocks 3 363–365
EmptyCatchBlock Avoid empty catch blocks 3 374–376
EmptyCatchBlock Avoid empty catch blocks 3 390–392
EmptyCatchBlock Avoid empty catch blocks 3 1048–1050
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1347
EmptyCatchBlock Avoid empty catch blocks 3 1375–1377

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–423
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 4 136
UselessParentheses Useless parentheses. 4 292–293

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 521–522

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 322–323

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 121

org/eclipse/jgit/transport/SshConfigStore.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'EMPTY_CONFIG': the field is declared in an interface type 3 91–113

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 3 54–56

org/eclipse/jgit/transport/Transport.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 130–132

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 231–233

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 85–87

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 128–130
EmptyCatchBlock Avoid empty catch blocks 3 205–207
EmptyCatchBlock Avoid empty catch blocks 3 244–246

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 165
EmptyCatchBlock Avoid empty catch blocks 3 372–374
EmptyCatchBlock Avoid empty catch blocks 3 379–381

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 14–1924
CollapsibleIfStatements These nested if statements could be combined 3 986–988
UselessParentheses Useless parentheses. 4 1044
EmptyWhileStmt Avoid empty while statements 3 1353–1355
EmptyCatchBlock Avoid empty catch blocks 3 1374–1376
EmptyCatchBlock Avoid empty catch blocks 3 1380–1382

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 313–316

org/eclipse/jgit/transport/URIish.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 244–245
UselessParentheses Useless parentheses. 4 308
UselessParentheses Useless parentheses. 4 309
UselessParentheses Useless parentheses. 4 333
UselessParentheses Useless parentheses. 4 334

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11–2441
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 3 206–208
EmptyWhileStmt Avoid empty while statements 3 1073–1075
EmptyWhileStmt Avoid empty while statements 3 1333–1335
EmptyWhileStmt Avoid empty while statements 3 1342–1344
EmptyCatchBlock Avoid empty catch blocks 3 1389–1391
UselessParentheses Useless parentheses. 4 1402
EmptyCatchBlock Avoid empty catch blocks 3 1557–1559
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_TAGS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_TAGS' 4 1998

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 87–91

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 566
EmptyCatchBlock Avoid empty catch blocks 3 815–817

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 273–277

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 388–390

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 4 41
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_AUTHORITATIVE' due to existing import 'java.net.HttpURLConnection' 4 47
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 4 53
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 4 59
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 4 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 4 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 4 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 4 100

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–411
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 169

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 50
UselessParentheses Useless parentheses. 4 51

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 116

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 831
UselessParentheses Useless parentheses. 4 1269
UselessParentheses Useless parentheses. 4 1406

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 296–297
EmptyCatchBlock Avoid empty catch blocks 3 442–446
EmptyWhileStmt Avoid empty while statements 3 482–484
CollapsibleIfStatements These nested if statements could be combined 3 880–881
EmptyCatchBlock Avoid empty catch blocks 3 1523–1525
UselessParentheses Useless parentheses. 4 1540–1541
UselessParentheses Useless parentheses. 4 1542–1543

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 44

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83

org/eclipse/jgit/util/Base64.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 120
UselessParentheses Useless parentheses. 4 127
UselessParentheses Useless parentheses. 4 134

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 166
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 259

org/eclipse/jgit/util/FS.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 454–456
EmptyIfStmt Avoid empty if statements 3 1440–1443
UselessParentheses Useless parentheses. 4 1514
UselessParentheses Useless parentheses. 4 1987–1988
UselessParentheses Useless parentheses. 4 2003–2004
EmptyCatchBlock Avoid empty catch blocks 3 2130–2137
EmptyCatchBlock Avoid empty catch blocks 3 2469–2471

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 59
CollapsibleIfStatements These nested if statements could be combined 3 146–160
UselessParentheses Useless parentheses. 4 466
UselessParentheses Useless parentheses. 4 466

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 131–133
CollapsibleIfStatements These nested if statements could be combined 3 147–163

org/eclipse/jgit/util/FileUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 310–312
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 512
SimplifiedTernary Ternary operators that can be simplified with || or && 3 854

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 31

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 3 98–100
EmptyCatchBlock Avoid empty catch blocks 3 198–200
UselessParentheses Useless parentheses. 4 229–230

org/eclipse/jgit/util/HttpSupport.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 450
UselessParentheses Useless parentheses. 4 450

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 3 305

org/eclipse/jgit/util/LongMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 3 136–140
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 143–145

org/eclipse/jgit/util/NB.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 58
UselessParentheses Useless parentheses. 4 170
UselessParentheses Useless parentheses. 4 173

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12–1307
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 3 98–105
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 3 179–213
UselessParentheses Useless parentheses. 4 204
EmptyCatchBlock Avoid empty catch blocks 3 207–209
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 3 233–267
UselessParentheses Useless parentheses. 4 258
EmptyCatchBlock Avoid empty catch blocks 3 261–263
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 3 284–297
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 3 314–338
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 3 356–404
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 3 415–420
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 434–436
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 454–460
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 3 473–480
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 493–495
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 510–518
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 3 531–540
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 3 555–574
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 3 587–595
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 608–610
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 626–635
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 3 659–667
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 3 685–692
UselessParentheses Useless parentheses. 4 711
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 3 730–737
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 3 752–761
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 3 776–789
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 3 804–814
UselessParentheses Useless parentheses. 4 921
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 3 1217–1228
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 3 1241–1250
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 3 1266–1276
UselessParentheses Useless parentheses. 4 1269

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 67–69
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 79
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 3 84–86
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 3 88–90

org/eclipse/jgit/util/References.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 3 31–33

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 377–379

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 38–40

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 116–118
EmptyCatchBlock Avoid empty catch blocks 3 121–123

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 54
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 3 562–565
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 3 567–573