PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 181

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 619

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 500
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 593
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 639

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 356

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 535

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 225

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 514
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 569

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 683

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 324

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 126

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 624

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 594

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 202

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 149

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 864

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 200
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 293

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 505

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 112

Priority 3

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 127–194

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Stage': nested enums are implicitly static 140–161
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 158–160

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 719–722

org/eclipse/jgit/api/LogCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 285–288
EmptyCatchBlock Avoid empty catch blocks 288–292

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 723–728
CollapsibleIfStatements These nested if statements could be combined 1311–1314

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 405–409

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 216

org/eclipse/jgit/attributes/Attribute.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 70–86

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 157–159

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 431–433
EmptyIfStmt Avoid empty if statements 521–525
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 1019–1021

org/eclipse/jgit/diff/DiffConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenameDetectionType': nested enums are implicitly static 62–71

org/eclipse/jgit/diff/DiffEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'ChangeType': nested enums are implicitly static 75–90
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Side': nested enums are implicitly static 93–99

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45–1243
EmptyCatchBlock Avoid empty catch blocks 722–724

org/eclipse/jgit/diff/Edit.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 67–79

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 377

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 459–462
EmptyIfStmt Avoid empty if statements 464–469
CollapsibleIfStatements These nested if statements could be combined 921–930
CollapsibleIfStatements These nested if statements could be combined 924–929
CollapsibleIfStatements These nested if statements could be combined 1238–1240
EmptyWhileStmt Avoid empty while statements 1620–1622

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 248–254

org/eclipse/jgit/errors/NoMergeBaseException.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MergeBaseFailureReason': nested enums are implicitly static 66–85

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 63

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 63–65

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 135–142
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 164–166
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 173–175
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 182–184
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 191–193
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 200–202
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 209–211
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 222–224

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 57–59

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 54–56

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 111–112

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 157
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 177–180
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 204–205
EmptyCatchBlock Avoid empty catch blocks 592–594

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 162–164

org/eclipse/jgit/ignore/IgnoreNode.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MatchResult': nested enums are implicitly static 62–79

org/eclipse/jgit/ignore/internal/IMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 53–64

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 66

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43–343

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatternState': nested enums are implicitly static 234–236
CollapsibleIfStatements These nested if statements could be combined 337–339

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 64–68
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 72–74

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 106–108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–642
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 129–141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–791
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 348

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–374

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–185
EmptyCatchBlock Avoid empty catch blocks 150–152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–240

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–448
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 114–116

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–329

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 81–83

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 89–91

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–277

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–788

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 248–250

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackSource': nested enums are implicitly static 100–235

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–533

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 249–251

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 183–185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 361–363
EmptyCatchBlock Avoid empty catch blocks 381–383

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 370–372

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 176–178

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 141

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–460

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 122–124

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 62–64
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 66–74
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 76–80
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 82–85
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 87–112
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 114–116
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 118–120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 344–346

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 112–114
CollapsibleIfStatements These nested if statements could be combined 199–201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'InsertLooseObjectResult': nested enums are implicitly static 63–65

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 225–228
EmptyCatchBlock Avoid empty catch blocks 298–300

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 422–424
EmptyCatchBlock Avoid empty catch blocks 459–461
EmptyCatchBlock Avoid empty catch blocks 577–580
EmptyCatchBlock Avoid empty catch blocks 959–961
EmptyCatchBlock Avoid empty catch blocks 984–986

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 111–113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 76–80
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 82–124
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 126–129
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 131–133
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 135–137
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 139–141
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 143–147
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 149–153
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 155–162
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 164–166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 98–100

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 326–328
CollapsibleIfStatements These nested if statements could be combined 342–344
EmptyCatchBlock Avoid empty catch blocks 729–731

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 220–222

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 398–419
EmptyCatchBlock Avoid empty catch blocks 734–738

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 349–351
EmptyCatchBlock Avoid empty catch blocks 356–358
EmptyCatchBlock Avoid empty catch blocks 361–363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–551
EmptyCatchBlock Avoid empty catch blocks 451–453
EmptyCatchBlock Avoid empty catch blocks 472–486

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 47–1509
CollapsibleIfStatements These nested if statements could be combined 557–558
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 1403–1407

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 217–219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 46–274

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 69–73

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 127–133

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 136–138

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 140–150
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 267–269
SimplifiedTernary Ternary operators that can be simplified with || or && 355

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 309–311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 57–61
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 64–66
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 69–71
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 74–76
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 79–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 83–93

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 110–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 118–138
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 146–153
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 170–172
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 191–206
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 208–217
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 219–226
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 228–233
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 240–242
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 253–255
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 258–260

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45–2351
EmptyWhileStmt Avoid empty while statements 1858–1860
CollapsibleIfStatements These nested if statements could be combined 2155–2156
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 2170–2173
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackingPhase': nested enums are implicitly static 2299–2317

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 294–296
CollapsibleIfStatements These nested if statements could be combined 306–310

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–592

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–605

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–693
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 676

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–835

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–287

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43–206

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 234–236
EmptyCatchBlock Avoid empty catch blocks 446–448

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 77–87
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 101–109
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 122–125
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 134–139
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 141–153
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 155–166
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 247–267
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 283–303
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 319–339
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 346–348
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 376–397

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 280

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–783

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 77–117
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 123–211

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 75–77

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 1447–1456
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 1486–1502

org/eclipse/jgit/lib/CoreConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AutoCRLF': nested enums are implicitly static 63–72
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EOL': nested enums are implicitly static 81–90
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EolStreamType': nested enums are implicitly static 97–112
UnnecessaryModifier Unnecessary modifier 'static' on enum 'CheckStat': nested enums are implicitly static 119–131
UnnecessaryModifier Unnecessary modifier 'static' on enum 'SymLinks': nested enums are implicitly static 148–153
UnnecessaryModifier Unnecessary modifier 'static' on enum 'HideDotFiles': nested enums are implicitly static 160–167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 128–130

org/eclipse/jgit/lib/FileMode.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 68
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 71
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 74
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 77
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 83
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 106
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 110
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 115
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 119
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 157

org/eclipse/jgit/lib/GitmoduleEntry.java

Rule Violation Line
ImportFromSamePackage No need to import a type that lives in the same package 45

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 64–66

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'StageState': nested enums are implicitly static 111–199
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 149–151
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 352
CollapsibleIfStatements These nested if statements could be combined 479–482
CollapsibleIfStatements These nested if statements could be combined 524–528

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45–1277

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 241–253

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 340–342
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 344–346
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 348–355

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 257–259

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Action': nested enums are implicitly static 61–118
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 87–90
CollapsibleIfStatements These nested if statements could be combined 191–194

org/eclipse/jgit/lib/Ref.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 108–111

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 68–171
CollapsibleIfStatements These nested if statements could be combined 778–780

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 887–888

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 347–368

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 95–97

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 74–76

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–403

org/eclipse/jgit/lib/internal/BouncyCastleGpgKeyLocator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 122–124

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 72–74

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 47–1355
CollapsibleIfStatements These nested if statements could be combined 408–410
CollapsibleIfStatements These nested if statements could be combined 823–849
CollapsibleIfStatements These nested if statements could be combined 839–841

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 86

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 298

org/eclipse/jgit/patch/BinaryHunk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 61–67

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 152–154

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–653
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatchType': nested enums are implicitly static 107–116
EmptyCatchBlock Avoid empty catch blocks 248–251

org/eclipse/jgit/patch/FormatError.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Severity': nested enums are implicitly static 57–63

org/eclipse/jgit/patch/Patch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–392

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 198–200

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 138–141
EmptyCatchBlock Avoid empty catch blocks 157–172

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 109–145
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 109–145
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 148–275
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 278–393

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 86
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 87
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 88
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 89
EmptyWhileStmt Avoid empty while statements 740–742

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 193–196

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 345–347
EmptyCatchBlock Avoid empty catch blocks 356–358
EmptyCatchBlock Avoid empty catch blocks 386–388

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 429–431
EmptyCatchBlock Avoid empty catch blocks 485–487
EmptyCatchBlock Avoid empty catch blocks 505–508
EmptyCatchBlock Avoid empty catch blocks 788–790

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 185–187
EmptyCatchBlock Avoid empty catch blocks 191–193

org/eclipse/jgit/transport/BaseReceivePack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–1970
EmptyCatchBlock Avoid empty catch blocks 379–381
EmptyCatchBlock Avoid empty catch blocks 390–392
EmptyCatchBlock Avoid empty catch blocks 406–408
EmptyCatchBlock Avoid empty catch blocks 1039–1041
EmptyCatchBlock Avoid empty catch blocks 1346–1348

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 270–272
EmptyCatchBlock Avoid empty catch blocks 307–309

org/eclipse/jgit/transport/Daemon.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 114
EmptyCatchBlock Avoid empty catch blocks 325–327
EmptyCatchBlock Avoid empty catch blocks 351–353
EmptyCatchBlock Avoid empty catch blocks 435–437
EmptyCatchBlock Avoid empty catch blocks 437–439
EmptyCatchBlock Avoid empty catch blocks 439–441
EmptyCatchBlock Avoid empty catch blocks 444–446
EmptyCatchBlock Avoid empty catch blocks 449–451

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 72

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45–560

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 64–97
EmptyCatchBlock Avoid empty catch blocks 221–223

org/eclipse/jgit/transport/GitProtocolConstants.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MultiAck': nested enums are implicitly static 275–277

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 192–194
EmptyIfStmt Avoid empty if statements 416–418
EmptyIfStmt Avoid empty if statements 419–421

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 132–134
EmptyIfStmt Avoid empty if statements 389–391

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 110–112
EmptyCatchBlock Avoid empty catch blocks 112–114
EmptyCatchBlock Avoid empty catch blocks 123–125
EmptyCatchBlock Avoid empty catch blocks 129–131

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103–105
EmptyCatchBlock Avoid empty catch blocks 105–107
EmptyCatchBlock Avoid empty catch blocks 117–119
EmptyCatchBlock Avoid empty catch blocks 123–125

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 432–434
EmptyCatchBlock Avoid empty catch blocks 434–436
EmptyCatchBlock Avoid empty catch blocks 455–457
CollapsibleIfStatements These nested if statements could be combined 519–532
EmptyCatchBlock Avoid empty catch blocks 529–531

org/eclipse/jgit/transport/JschSession.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 190–192

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 103–107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 106–112
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 731–754
EmptyCatchBlock Avoid empty catch blocks 1184–1188
EmptyCatchBlock Avoid empty catch blocks 1200–1204

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AckNackResult': nested enums are implicitly static 85–96
EmptyCatchBlock Avoid empty catch blocks 260–262

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 143–148

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 55–57

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43–310
EmptyIfStmt Avoid empty if statements 101–103

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 87–98
EmptyCatchBlock Avoid empty catch blocks 265–268

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 76–78

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 296–298

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 75–98
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 101–134
CollapsibleIfStatements These nested if statements could be combined 780–784

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 421–423

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 553–554

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 75–127

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 87–89

org/eclipse/jgit/transport/Transport.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 160–162

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 263–265

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 118–120

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 154–156
EmptyCatchBlock Avoid empty catch blocks 214–216
EmptyCatchBlock Avoid empty catch blocks 253–255

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 353–355
EmptyCatchBlock Avoid empty catch blocks 360–362

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 47–1450
CollapsibleIfStatements These nested if statements could be combined 772–774
EmptyWhileStmt Avoid empty while statements 907–909
EmptyCatchBlock Avoid empty catch blocks 928–930
EmptyCatchBlock Avoid empty catch blocks 934–936

org/eclipse/jgit/transport/TransportProtocol.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'URIishField': nested enums are implicitly static 93–104

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 344–347

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44–2260
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RequestPolicy': nested enums are implicitly static 132–162
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 231–233
EmptyCatchBlock Avoid empty catch blocks 1018–1020
EmptyCatchBlock Avoid empty catch blocks 1031–1033
EmptyWhileStmt Avoid empty while statements 1040–1042
EmptyWhileStmt Avoid empty while statements 1277–1279
EmptyWhileStmt Avoid empty while statements 1286–1288
EmptyCatchBlock Avoid empty catch blocks 1333–1335
EmptyCatchBlock Avoid empty catch blocks 1500–1502

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 120–124

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 843–845

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 302–306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 423–425

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45–445

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'OperationType': nested enums are implicitly static 114–125

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 471–475
EmptyWhileStmt Avoid empty while statements 511–513
CollapsibleIfStatements These nested if statements could be combined 899–900
CollapsibleIfStatements These nested if statements could be combined 951–954
EmptyCatchBlock Avoid empty catch blocks 1576–1578

org/eclipse/jgit/util/FS.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 381–383
EmptyIfStmt Avoid empty if statements 1216–1219
EmptyCatchBlock Avoid empty catch blocks 1833–1840
EmptyCatchBlock Avoid empty catch blocks 2172–2174

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 88
CollapsibleIfStatements These nested if statements could be combined 173–191
CollapsibleIfStatements These nested if statements could be combined 174–190

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 166–168
CollapsibleIfStatements These nested if statements could be combined 182–198

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 304–306
SimplifiedTernary Ternary operators that can be simplified with || or && 826

org/eclipse/jgit/util/GitDateFormatter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Format': nested enums are implicitly static 71–117

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 131–133
EmptyCatchBlock Avoid empty catch blocks 231–233

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 322

org/eclipse/jgit/util/LongMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 169–173
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 176–178

org/eclipse/jgit/util/ProcessResult.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 54–69

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45–1340
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 131–138
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 212–246
EmptyCatchBlock Avoid empty catch blocks 240–242
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 266–300
EmptyCatchBlock Avoid empty catch blocks 294–296
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 317–330
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 347–371
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 389–437
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 448–453
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 467–469
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 487–493
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 506–513
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 526–528
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 543–551
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 564–573
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 588–607
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 620–628
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 641–643
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 659–668
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 692–700
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 718–725
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 763–770
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 785–794
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 809–822
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 837–847
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 1250–1261
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 1274–1283
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 1299–1309

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 100–102
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 117–119
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 121–123

org/eclipse/jgit/util/RefMap.java

Rule Violation Line
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 428

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 405–407

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 71–73

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 149–151
EmptyCatchBlock Avoid empty catch blocks 154–156

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 87
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 592–595
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 597–603

Priority 4

org/eclipse/jgit/api/AddCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 212–213
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 213
UselessParentheses Useless parentheses. 214–215

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 582

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 205

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 419–420
UselessParentheses Useless parentheses. 421
UselessParentheses Useless parentheses. 554

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 256

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 433
UselessParentheses Useless parentheses. 433

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 195–197

org/eclipse/jgit/api/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 416

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 284

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 790
UselessParentheses Useless parentheses. 790–791
UselessParentheses Useless parentheses. 791
UselessParentheses Useless parentheses. 1758

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 159
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 185
UselessParentheses Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 144

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 320
UselessParentheses Useless parentheses. 442–443
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 549

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 133
UselessParentheses Useless parentheses. 171
UselessParentheses Useless parentheses. 206
UselessParentheses Useless parentheses. 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Line
UselessParentheses Useless parentheses. 381

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
UselessParentheses Useless parentheses. 670
UselessParentheses Useless parentheses. 748
UselessParentheses Useless parentheses. 749
UselessParentheses Useless parentheses. 750
UselessParentheses Useless parentheses. 751
UselessParentheses Useless parentheses. 752
UselessParentheses Useless parentheses. 753
UselessParentheses Useless parentheses. 812
UselessParentheses Useless parentheses. 813
UselessParentheses Useless parentheses. 813
UselessParentheses Useless parentheses. 813
UselessParentheses Useless parentheses. 909
UselessParentheses Useless parentheses. 1152–1153

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 125
UselessParentheses Useless parentheses. 294
UselessParentheses Useless parentheses. 418
UselessParentheses Useless parentheses. 418

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Line
UselessParentheses Useless parentheses. 493

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 782
UselessParentheses Useless parentheses. 783

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 131

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UselessParentheses Useless parentheses. 138
UselessParentheses Useless parentheses. 398

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 427

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 626
UselessParentheses Useless parentheses. 633

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Line
UselessParentheses Useless parentheses. 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 579

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 541
UselessParentheses Useless parentheses. 547
UselessParentheses Useless parentheses. 554
UselessParentheses Useless parentheses. 560
UselessParentheses Useless parentheses. 577
UselessParentheses Useless parentheses. 601
UselessParentheses Useless parentheses. 687
UselessParentheses Useless parentheses. 695
UselessParentheses Useless parentheses. 768
UselessParentheses Useless parentheses. 818
UselessParentheses Useless parentheses. 937
UselessParentheses Useless parentheses. 1047

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 766

org/eclipse/jgit/internal/storage/dfs/DfsReftableDatabase.java

Rule Violation Line
UselessParentheses Useless parentheses. 238–239

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Line
UselessParentheses Useless parentheses. 578
UselessParentheses Useless parentheses. 578

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
UselessParentheses Useless parentheses. 979–981
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1157
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1160

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 654
UselessParentheses Useless parentheses. 655
UselessParentheses Useless parentheses. 775

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 465
UselessParentheses Useless parentheses. 471
UselessParentheses Useless parentheses. 478
UselessParentheses Useless parentheses. 484
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 534
UselessParentheses Useless parentheses. 554
UselessParentheses Useless parentheses. 611
UselessParentheses Useless parentheses. 619
UselessParentheses Useless parentheses. 869
UselessParentheses Useless parentheses. 918
UselessParentheses Useless parentheses. 1033
UselessParentheses Useless parentheses. 1124
UselessParentheses Useless parentheses. 1139
UselessParentheses Useless parentheses. 1225

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Line
UselessParentheses Useless parentheses. 231
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 393
UselessParentheses Useless parentheses. 394
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 1181
UselessParentheses Useless parentheses. 1196
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1233
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1264

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 242

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Line
UselessParentheses Useless parentheses. 319

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 68

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 194

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 382
UselessParentheses Useless parentheses. 2171
UselessParentheses Useless parentheses. 2172
UselessParentheses Useless parentheses. 2256
UselessParentheses Useless parentheses. 2273

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
UselessParentheses Useless parentheses. 136
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 237
UselessParentheses Useless parentheses. 271
UselessParentheses Useless parentheses. 272–273
UselessParentheses Useless parentheses. 273
UselessParentheses Useless parentheses. 274
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 285

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 564
UselessParentheses Useless parentheses. 576

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 138

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 456

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 113

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UselessParentheses Useless parentheses. 1419

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 281

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 526–527
UselessParentheses Useless parentheses. 643–644
UselessParentheses Useless parentheses. 643–644
UselessParentheses Useless parentheses. 643
UselessParentheses Useless parentheses. 654
UselessParentheses Useless parentheses. 771–772

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 571
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 603
UselessParentheses Useless parentheses. 876
UselessParentheses Useless parentheses. 936
UselessParentheses Useless parentheses. 937
UselessParentheses Useless parentheses. 1015
UselessParentheses Useless parentheses. 1027
UselessParentheses Useless parentheses. 1108–1109
UselessParentheses Useless parentheses. 1110
UselessParentheses Useless parentheses. 1111

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
UselessParentheses Useless parentheses. 620
UselessParentheses Useless parentheses. 632
UselessParentheses Useless parentheses. 829
UselessParentheses Useless parentheses. 830
UselessParentheses Useless parentheses. 831

org/eclipse/jgit/lib/RepositoryBuilder.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.File' 46

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UselessParentheses Useless parentheses. 302

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Line
UselessParentheses Useless parentheses. 317

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Line
UselessParentheses Useless parentheses. 90

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 141

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 823–824
UselessParentheses Useless parentheses. 823
UselessParentheses Useless parentheses. 823–824
UselessParentheses Useless parentheses. 887–888

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 51

org/eclipse/jgit/nls/NLS.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 49
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 50

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 284
UselessParentheses Useless parentheses. 286

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 297

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 195

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Line
UselessParentheses Useless parentheses. 121

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 148
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 278

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 60

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
UselessParentheses Useless parentheses. 371

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 530

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 401–402
UselessParentheses Useless parentheses. 437

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 555

org/eclipse/jgit/transport/FetchResult.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 50

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
UselessParentheses Useless parentheses. 175
UselessParentheses Useless parentheses. 176

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 95–113

org/eclipse/jgit/transport/ObjectCountCallback.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.OutputStream' 46
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 48

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 851
UselessParentheses Useless parentheses. 1026

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Line
UselessParentheses Useless parentheses. 267

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 279
UselessParentheses Useless parentheses. 777
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 843
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 871
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 875
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 881

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 167
UselessParentheses Useless parentheses. 323

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 355–356

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 154

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 89

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
UselessParentheses Useless parentheses. 182

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Line
UselessParentheses Useless parentheses. 115

org/eclipse/jgit/transport/URIish.java

Rule Violation Line
UselessParentheses Useless parentheses. 276–277
UselessParentheses Useless parentheses. 337
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
UselessParentheses Useless parentheses. 1346

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 74
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 80
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 86
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 105
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 110
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 115

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 1302
UselessParentheses Useless parentheses. 1443

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
UselessParentheses Useless parentheses. 325–326
UselessParentheses Useless parentheses. 946
UselessParentheses Useless parentheses. 947
UselessParentheses Useless parentheses. 950
UselessParentheses Useless parentheses. 1592–1593
UselessParentheses Useless parentheses. 1594–1595

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Line
UselessParentheses Useless parentheses. 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Line
UselessParentheses Useless parentheses. 116

org/eclipse/jgit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses. 120
UselessParentheses Useless parentheses. 127
UselessParentheses Useless parentheses. 134

org/eclipse/jgit/util/FS.java

Rule Violation Line
UselessParentheses Useless parentheses. 1290

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
UselessParentheses Useless parentheses. 466
UselessParentheses Useless parentheses. 466

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 64

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 261–262

org/eclipse/jgit/util/NB.java

Rule Violation Line
UselessParentheses Useless parentheses. 91
UselessParentheses Useless parentheses. 203
UselessParentheses Useless parentheses. 206

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
UselessParentheses Useless parentheses. 237
UselessParentheses Useless parentheses. 291
UselessParentheses Useless parentheses. 744
UselessParentheses Useless parentheses. 954
UselessParentheses Useless parentheses. 1302

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Line
UselessParentheses Useless parentheses. 122
UselessParentheses Useless parentheses. 126
UselessParentheses Useless parentheses. 127

org/eclipse/jgit/util/time/MonotonicClock.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.time.Duration' 46

Files

org/eclipse/jgit/api/AddCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 212–213
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 4 213
UselessParentheses Useless parentheses. 4 214–215

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 3 127–194

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Stage': nested enums are implicitly static 3 140–161
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 3 158–160
UselessParentheses Useless parentheses. 4 582

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 204
UselessParentheses Useless parentheses. 4 205

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 719–722

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 419–420
UselessParentheses Useless parentheses. 4 421
UselessParentheses Useless parentheses. 4 554

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 4 256

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 433
UselessParentheses Useless parentheses. 4 433

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 195–197

org/eclipse/jgit/api/LogCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 285–288
EmptyCatchBlock Avoid empty catch blocks 3 288–292

org/eclipse/jgit/api/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 416

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 284

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 723–728
UselessParentheses Useless parentheses. 4 790
UselessParentheses Useless parentheses. 4 790–791
UselessParentheses Useless parentheses. 4 791
CollapsibleIfStatements These nested if statements could be combined 3 1311–1314
UselessParentheses Useless parentheses. 4 1758

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 405–409

org/eclipse/jgit/api/TagCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 3 216

org/eclipse/jgit/attributes/Attribute.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 3 70–86

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 159
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 185
UselessParentheses Useless parentheses. 4 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 157–159

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 431–433
EmptyIfStmt Avoid empty if statements 3 521–525
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 3 1019–1021

org/eclipse/jgit/diff/DiffConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenameDetectionType': nested enums are implicitly static 3 62–71

org/eclipse/jgit/diff/DiffEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'ChangeType': nested enums are implicitly static 3 75–90
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Side': nested enums are implicitly static 3 93–99

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45–1243
EmptyCatchBlock Avoid empty catch blocks 3 722–724

org/eclipse/jgit/diff/Edit.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 67–79

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 320
UselessParentheses Useless parentheses. 4 442–443
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 549

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 133
UselessParentheses Useless parentheses. 4 171
UselessParentheses Useless parentheses. 4 206
UselessParentheses Useless parentheses. 4 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 381

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 377

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 181

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 459–462
EmptyIfStmt Avoid empty if statements 3 464–469
UselessParentheses Useless parentheses. 4 670
UselessParentheses Useless parentheses. 4 748
UselessParentheses Useless parentheses. 4 749
UselessParentheses Useless parentheses. 4 750
UselessParentheses Useless parentheses. 4 751
UselessParentheses Useless parentheses. 4 752
UselessParentheses Useless parentheses. 4 753
UselessParentheses Useless parentheses. 4 812
UselessParentheses Useless parentheses. 4 813
UselessParentheses Useless parentheses. 4 813
UselessParentheses Useless parentheses. 4 813
UselessParentheses Useless parentheses. 4 909
CollapsibleIfStatements These nested if statements could be combined 3 921–930
CollapsibleIfStatements These nested if statements could be combined 3 924–929
UselessParentheses Useless parentheses. 4 1152–1153
CollapsibleIfStatements These nested if statements could be combined 3 1238–1240
EmptyWhileStmt Avoid empty while statements 3 1620–1622

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 125
UselessParentheses Useless parentheses. 4 294
UselessParentheses Useless parentheses. 4 418
UselessParentheses Useless parentheses. 4 418

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 248–254

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 493

org/eclipse/jgit/errors/NoMergeBaseException.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MergeBaseFailureReason': nested enums are implicitly static 3 66–85

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 3 63

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 63–65

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 135–142
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 164–166
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 173–175
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 182–184
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 191–193
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 200–202
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 209–211
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 222–224

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 57–59

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 54–56

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 3 111–112

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 3 157
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 3 177–180
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 3 204–205
EmptyCatchBlock Avoid empty catch blocks 3 592–594
UselessParentheses Useless parentheses. 4 782
UselessParentheses Useless parentheses. 4 783

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 162–164

org/eclipse/jgit/ignore/IgnoreNode.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MatchResult': nested enums are implicitly static 3 62–79

org/eclipse/jgit/ignore/internal/IMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 3 53–64

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 66
UselessParentheses Useless parentheses. 4 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43–343
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 4 131

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 138
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatternState': nested enums are implicitly static 3 234–236
CollapsibleIfStatements These nested if statements could be combined 3 337–339
UselessParentheses Useless parentheses. 4 398

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 64–68
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 72–74

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 106–108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–642
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 3 129–141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–791
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 348

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–374

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–185
EmptyCatchBlock Avoid empty catch blocks 3 150–152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–240

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–448
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 3 114–116
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 427

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–329

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 81–83

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 89–91

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–277

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–788
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 248–250
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 626
UselessParentheses Useless parentheses. 4 633

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackSource': nested enums are implicitly static 3 100–235

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–533

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 579

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 3 249–251
UselessParentheses Useless parentheses. 4 541
UselessParentheses Useless parentheses. 4 547
UselessParentheses Useless parentheses. 4 554
UselessParentheses Useless parentheses. 4 560
UselessParentheses Useless parentheses. 4 577
UselessParentheses Useless parentheses. 4 601
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 619
UselessParentheses Useless parentheses. 4 687
UselessParentheses Useless parentheses. 4 695
UselessParentheses Useless parentheses. 4 768
UselessParentheses Useless parentheses. 4 818
UselessParentheses Useless parentheses. 4 937
UselessParentheses Useless parentheses. 4 1047

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 183–185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 361–363
EmptyCatchBlock Avoid empty catch blocks 3 381–383
UselessParentheses Useless parentheses. 4 766

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 370–372

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 176–178

org/eclipse/jgit/internal/storage/dfs/DfsReftableDatabase.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 238–239

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 141

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–460

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 122–124

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 62–64
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 66–74
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 76–80
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 82–85
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 3 87–112
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 114–116
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 118–120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 3 344–346

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 112–114
CollapsibleIfStatements These nested if statements could be combined 3 199–201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'InsertLooseObjectResult': nested enums are implicitly static 3 63–65

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 225–228
EmptyCatchBlock Avoid empty catch blocks 3 298–300

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 578
UselessParentheses Useless parentheses. 4 578

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 422–424
EmptyCatchBlock Avoid empty catch blocks 3 459–461
EmptyCatchBlock Avoid empty catch blocks 3 577–580
EmptyCatchBlock Avoid empty catch blocks 3 959–961
UselessParentheses Useless parentheses. 4 979–981
EmptyCatchBlock Avoid empty catch blocks 3 984–986
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1157
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1160

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 111–113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 3 76–80
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 3 82–124
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 3 126–129
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 131–133
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 135–137
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 3 139–141
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 3 143–147
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 3 149–153
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 3 155–162
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 3 164–166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 98–100

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 326–328
CollapsibleIfStatements These nested if statements could be combined 3 342–344
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 500
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 593
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 639
UselessParentheses Useless parentheses. 4 654
UselessParentheses Useless parentheses. 4 655
EmptyCatchBlock Avoid empty catch blocks 3 729–731
UselessParentheses Useless parentheses. 4 775

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 220–222

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 3 398–419
UselessParentheses Useless parentheses. 4 465
UselessParentheses Useless parentheses. 4 471
UselessParentheses Useless parentheses. 4 478
UselessParentheses Useless parentheses. 4 484
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 534
UselessParentheses Useless parentheses. 4 554
UselessParentheses Useless parentheses. 4 611
UselessParentheses Useless parentheses. 4 619
EmptyCatchBlock Avoid empty catch blocks 3 734–738
UselessParentheses Useless parentheses. 4 869
UselessParentheses Useless parentheses. 4 918
UselessParentheses Useless parentheses. 4 1033
UselessParentheses Useless parentheses. 4 1124
UselessParentheses Useless parentheses. 4 1139
UselessParentheses Useless parentheses. 4 1225

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 231
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 349–351
EmptyCatchBlock Avoid empty catch blocks 3 356–358
EmptyCatchBlock Avoid empty catch blocks 3 361–363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–551
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 356
UselessParentheses Useless parentheses. 4 393
UselessParentheses Useless parentheses. 4 394
EmptyCatchBlock Avoid empty catch blocks 3 451–453
EmptyCatchBlock Avoid empty catch blocks 3 472–486
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 47–1509
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 535
CollapsibleIfStatements These nested if statements could be combined 3 557–558
UselessParentheses Useless parentheses. 4 1181
UselessParentheses Useless parentheses. 4 1196
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1233
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 4 1264
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 3 1403–1407

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 217–219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 46–274
UselessParentheses Useless parentheses. 4 242

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 69–73

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 3 127–133

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 319

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 136–138

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 68

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Priority Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 3 140–150
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 267–269
SimplifiedTernary Ternary operators that can be simplified with || or && 3 355

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 225
EmptyCatchBlock Avoid empty catch blocks 3 309–311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 57–61
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3 64–66
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3 69–71
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 74–76
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 3 79–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 3 83–93

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 110–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 118–138
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 3 146–153
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 3 170–172
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 3 191–206
UselessParentheses Useless parentheses. 4 194
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 3 208–217
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 3 219–226
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 3 228–233
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 3 240–242
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 3 253–255
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 3 258–260

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45–2351
UselessParentheses Useless parentheses. 4 382
EmptyWhileStmt Avoid empty while statements 3 1858–1860
CollapsibleIfStatements These nested if statements could be combined 3 2155–2156
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 3 2170–2173
UselessParentheses Useless parentheses. 4 2171
UselessParentheses Useless parentheses. 4 2172
UselessParentheses Useless parentheses. 4 2256
UselessParentheses Useless parentheses. 4 2273
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackingPhase': nested enums are implicitly static 3 2299–2317

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 136
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 237
UselessParentheses Useless parentheses. 4 271
UselessParentheses Useless parentheses. 4 272–273
UselessParentheses Useless parentheses. 4 273
UselessParentheses Useless parentheses. 4 274
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 285
EmptyWhileStmt Avoid empty while statements 3 294–296
CollapsibleIfStatements These nested if statements could be combined 3 306–310

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–592
UselessParentheses Useless parentheses. 4 564
UselessParentheses Useless parentheses. 4 576

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–605
UselessParentheses Useless parentheses. 4 138

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–693
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 456
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 514
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 569
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 676

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–835
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 683

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–287

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43–206

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 234–236
EmptyCatchBlock Avoid empty catch blocks 3 446–448

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 77–87
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 101–109
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 3 122–125
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 134–139
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 141–153
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 3 155–166
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 247–267
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 283–303
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 319–339
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 346–348
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 376–397

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 280

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–783
UselessParentheses Useless parentheses. 4 113

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 3 77–117
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 3 123–211

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 3 75–77

org/eclipse/jgit/lib/Config.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1419
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 3 1447–1456
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 3 1486–1502

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 4 281

org/eclipse/jgit/lib/CoreConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AutoCRLF': nested enums are implicitly static 3 63–72
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EOL': nested enums are implicitly static 3 81–90
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EolStreamType': nested enums are implicitly static 3 97–112
UnnecessaryModifier Unnecessary modifier 'static' on enum 'CheckStat': nested enums are implicitly static 3 119–131
UnnecessaryModifier Unnecessary modifier 'static' on enum 'SymLinks': nested enums are implicitly static 3 148–153
UnnecessaryModifier Unnecessary modifier 'static' on enum 'HideDotFiles': nested enums are implicitly static 3 160–167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 128–130

org/eclipse/jgit/lib/FileMode.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 68
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 71
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 74
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 77
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 83
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 106
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 110
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 115
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 119
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 157

org/eclipse/jgit/lib/GitmoduleEntry.java

Rule Violation Priority Line
ImportFromSamePackage No need to import a type that lives in the same package 3 45

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3 64–66

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'StageState': nested enums are implicitly static 3 111–199
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 3 149–151
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 3 352
CollapsibleIfStatements These nested if statements could be combined 3 479–482
CollapsibleIfStatements These nested if statements could be combined 3 524–528
UselessParentheses Useless parentheses. 4 526–527
UselessParentheses Useless parentheses. 4 643–644
UselessParentheses Useless parentheses. 4 643–644
UselessParentheses Useless parentheses. 4 643
UselessParentheses Useless parentheses. 4 654
UselessParentheses Useless parentheses. 4 771–772

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45–1277
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 571
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 603
UselessParentheses Useless parentheses. 4 876
UselessParentheses Useless parentheses. 4 936
UselessParentheses Useless parentheses. 4 937
UselessParentheses Useless parentheses. 4 1015
UselessParentheses Useless parentheses. 4 1027
UselessParentheses Useless parentheses. 4 1108–1109
UselessParentheses Useless parentheses. 4 1110
UselessParentheses Useless parentheses. 4 1111

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 241–253

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 3 340–342
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 3 344–346
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 3 348–355

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 257–259

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Action': nested enums are implicitly static 3 61–118
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 3 87–90
CollapsibleIfStatements These nested if statements could be combined 3 191–194

org/eclipse/jgit/lib/Ref.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 3 108–111

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 3 68–171
CollapsibleIfStatements These nested if statements could be combined 3 778–780

org/eclipse/jgit/lib/Repository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 620
UselessParentheses Useless parentheses. 4 632
UselessParentheses Useless parentheses. 4 829
UselessParentheses Useless parentheses. 4 830
UselessParentheses Useless parentheses. 4 831
CollapsibleIfStatements These nested if statements could be combined 3 887–888

org/eclipse/jgit/lib/RepositoryBuilder.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.File' 4 46

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 302
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 3 347–368

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 95–97

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 74–76

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–403

org/eclipse/jgit/lib/internal/BouncyCastleGpgKeyLocator.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 122–124

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 317

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 72–74

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 141

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 47–1355
CollapsibleIfStatements These nested if statements could be combined 3 408–410
UselessParentheses Useless parentheses. 4 823–824
UselessParentheses Useless parentheses. 4 823
UselessParentheses Useless parentheses. 4 823–824
CollapsibleIfStatements These nested if statements could be combined 3 823–849
CollapsibleIfStatements These nested if statements could be combined 3 839–841
UselessParentheses Useless parentheses. 4 887–888

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 3 86

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 51

org/eclipse/jgit/nls/NLS.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 49
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 50

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 284
UselessParentheses Useless parentheses. 4 286
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 298

org/eclipse/jgit/patch/BinaryHunk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 61–67

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 152–154

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–653
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatchType': nested enums are implicitly static 3 107–116
EmptyCatchBlock Avoid empty catch blocks 3 248–251
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 4 297

org/eclipse/jgit/patch/FormatError.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Severity': nested enums are implicitly static 3 57–63

org/eclipse/jgit/patch/Patch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–392

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 195

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 198–200

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 138–141
EmptyCatchBlock Avoid empty catch blocks 3 157–172

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 121

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 3 109–145
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 3 109–145
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 3 148–275
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 148
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 3 278–393
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 278

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 4 60
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 86
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 87
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 88
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 89
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 324
EmptyWhileStmt Avoid empty while statements 3 740–742

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 193–196
UselessParentheses Useless parentheses. 4 371

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 126

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 530
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 624

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 345–347
EmptyCatchBlock Avoid empty catch blocks 3 356–358
EmptyCatchBlock Avoid empty catch blocks 3 386–388

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 429–431
EmptyCatchBlock Avoid empty catch blocks 3 485–487
EmptyCatchBlock Avoid empty catch blocks 3 505–508
EmptyCatchBlock Avoid empty catch blocks 3 788–790

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 185–187
EmptyCatchBlock Avoid empty catch blocks 3 191–193
UselessParentheses Useless parentheses. 4 401–402
UselessParentheses Useless parentheses. 4 437

org/eclipse/jgit/transport/BaseReceivePack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–1970
EmptyCatchBlock Avoid empty catch blocks 3 379–381
EmptyCatchBlock Avoid empty catch blocks 3 390–392
EmptyCatchBlock Avoid empty catch blocks 3 406–408
EmptyCatchBlock Avoid empty catch blocks 3 1039–1041
EmptyCatchBlock Avoid empty catch blocks 3 1346–1348

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 270–272
EmptyCatchBlock Avoid empty catch blocks 3 307–309

org/eclipse/jgit/transport/Daemon.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 114
EmptyCatchBlock Avoid empty catch blocks 3 325–327
EmptyCatchBlock Avoid empty catch blocks 3 351–353
EmptyCatchBlock Avoid empty catch blocks 3 435–437
EmptyCatchBlock Avoid empty catch blocks 3 437–439
EmptyCatchBlock Avoid empty catch blocks 3 439–441
EmptyCatchBlock Avoid empty catch blocks 3 444–446
EmptyCatchBlock Avoid empty catch blocks 3 449–451

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 72

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45–560
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 4 555

org/eclipse/jgit/transport/FetchResult.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 50

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3 64–97
EmptyCatchBlock Avoid empty catch blocks 3 221–223

org/eclipse/jgit/transport/GitProtocolConstants.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MultiAck': nested enums are implicitly static 3 275–277

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 175
UselessParentheses Useless parentheses. 4 176
EmptyCatchBlock Avoid empty catch blocks 3 192–194
EmptyIfStmt Avoid empty if statements 3 416–418
EmptyIfStmt Avoid empty if statements 3 419–421

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 95–113
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 3 132–134
EmptyIfStmt Avoid empty if statements 3 389–391

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 110–112
EmptyCatchBlock Avoid empty catch blocks 3 112–114
EmptyCatchBlock Avoid empty catch blocks 3 123–125
EmptyCatchBlock Avoid empty catch blocks 3 129–131

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103–105
EmptyCatchBlock Avoid empty catch blocks 3 105–107
EmptyCatchBlock Avoid empty catch blocks 3 117–119
EmptyCatchBlock Avoid empty catch blocks 3 123–125

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 432–434
EmptyCatchBlock Avoid empty catch blocks 3 434–436
EmptyCatchBlock Avoid empty catch blocks 3 455–457
CollapsibleIfStatements These nested if statements could be combined 3 519–532
EmptyCatchBlock Avoid empty catch blocks 3 529–531

org/eclipse/jgit/transport/JschSession.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 190–192

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 103–107

org/eclipse/jgit/transport/ObjectCountCallback.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.OutputStream' 4 46
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 4 48

org/eclipse/jgit/transport/PackParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 3 106–112
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 3 731–754
UselessParentheses Useless parentheses. 4 851
UselessParentheses Useless parentheses. 4 1026
EmptyCatchBlock Avoid empty catch blocks 3 1184–1188
EmptyCatchBlock Avoid empty catch blocks 3 1200–1204

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AckNackResult': nested enums are implicitly static 3 85–96
EmptyCatchBlock Avoid empty catch blocks 3 260–262

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 143–148

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 3 55–57

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43–310
EmptyIfStmt Avoid empty if statements 3 101–103

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 267

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 3 87–98
EmptyCatchBlock Avoid empty catch blocks 3 265–268

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 76–78

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 296–298

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 75–98
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 3 101–134
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 279
UselessParentheses Useless parentheses. 4 777
CollapsibleIfStatements These nested if statements could be combined 3 780–784
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 843
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 871
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 875
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 881

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 421–423

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 4 167
UselessParentheses Useless parentheses. 4 323

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 553–554

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 3 75–127
UselessParentheses Useless parentheses. 4 355–356

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 154

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 3 87–89

org/eclipse/jgit/transport/Transport.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 160–162

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 263–265

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 118–120

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 154–156
EmptyCatchBlock Avoid empty catch blocks 3 214–216
EmptyCatchBlock Avoid empty catch blocks 3 253–255

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 182
EmptyCatchBlock Avoid empty catch blocks 3 353–355
EmptyCatchBlock Avoid empty catch blocks 3 360–362

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 47–1450
CollapsibleIfStatements These nested if statements could be combined 3 772–774
EmptyWhileStmt Avoid empty while statements 3 907–909
EmptyCatchBlock Avoid empty catch blocks 3 928–930
EmptyCatchBlock Avoid empty catch blocks 3 934–936

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 115

org/eclipse/jgit/transport/TransportProtocol.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'URIishField': nested enums are implicitly static 3 93–104

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 344–347

org/eclipse/jgit/transport/URIish.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 276–277
UselessParentheses Useless parentheses. 4 337
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44–2260
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RequestPolicy': nested enums are implicitly static 3 132–162
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 3 231–233
EmptyCatchBlock Avoid empty catch blocks 3 1018–1020
EmptyCatchBlock Avoid empty catch blocks 3 1031–1033
EmptyWhileStmt Avoid empty while statements 3 1040–1042
EmptyWhileStmt Avoid empty while statements 3 1277–1279
EmptyWhileStmt Avoid empty while statements 3 1286–1288
EmptyCatchBlock Avoid empty catch blocks 3 1333–1335
UselessParentheses Useless parentheses. 4 1346
EmptyCatchBlock Avoid empty catch blocks 3 1500–1502

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 120–124

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 594
EmptyCatchBlock Avoid empty catch blocks 3 843–845

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 302–306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 423–425

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 4 74
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 4 80
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 4 86
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 4 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 4 105
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 4 110
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 4 115

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45–445
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 202

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 149

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'OperationType': nested enums are implicitly static 3 114–125
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 864
UselessParentheses Useless parentheses. 4 1302
UselessParentheses Useless parentheses. 4 1443

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 325–326
EmptyCatchBlock Avoid empty catch blocks 3 471–475
EmptyWhileStmt Avoid empty while statements 3 511–513
CollapsibleIfStatements These nested if statements could be combined 3 899–900
UselessParentheses Useless parentheses. 4 946
UselessParentheses Useless parentheses. 4 947
UselessParentheses Useless parentheses. 4 950
CollapsibleIfStatements These nested if statements could be combined 3 951–954
EmptyCatchBlock Avoid empty catch blocks 3 1576–1578
UselessParentheses Useless parentheses. 4 1592–1593
UselessParentheses Useless parentheses. 4 1594–1595

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 4 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 116

org/eclipse/jgit/util/Base64.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 120
UselessParentheses Useless parentheses. 4 127
UselessParentheses Useless parentheses. 4 134

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 200
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 293

org/eclipse/jgit/util/FS.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 381–383
EmptyIfStmt Avoid empty if statements 3 1216–1219
UselessParentheses Useless parentheses. 4 1290
EmptyCatchBlock Avoid empty catch blocks 3 1833–1840
EmptyCatchBlock Avoid empty catch blocks 3 2172–2174

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 88
CollapsibleIfStatements These nested if statements could be combined 3 173–191
CollapsibleIfStatements These nested if statements could be combined 3 174–190
UselessParentheses Useless parentheses. 4 466
UselessParentheses Useless parentheses. 4 466

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 166–168
CollapsibleIfStatements These nested if statements could be combined 3 182–198

org/eclipse/jgit/util/FileUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 304–306
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 505
SimplifiedTernary Ternary operators that can be simplified with || or && 3 826

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 64

org/eclipse/jgit/util/GitDateFormatter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Format': nested enums are implicitly static 3 71–117

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 3 131–133
EmptyCatchBlock Avoid empty catch blocks 3 231–233
UselessParentheses Useless parentheses. 4 261–262

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 3 322

org/eclipse/jgit/util/LongMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 3 169–173
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 176–178

org/eclipse/jgit/util/NB.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91
UselessParentheses Useless parentheses. 4 203
UselessParentheses Useless parentheses. 4 206

org/eclipse/jgit/util/ProcessResult.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 3 54–69

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45–1340
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 3 131–138
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 3 212–246
UselessParentheses Useless parentheses. 4 237
EmptyCatchBlock Avoid empty catch blocks 3 240–242
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 3 266–300
UselessParentheses Useless parentheses. 4 291
EmptyCatchBlock Avoid empty catch blocks 3 294–296
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 3 317–330
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 3 347–371
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 3 389–437
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 3 448–453
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 467–469
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 487–493
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 3 506–513
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 526–528
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 543–551
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 3 564–573
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 3 588–607
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 3 620–628
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 641–643
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 659–668
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 3 692–700
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 3 718–725
UselessParentheses Useless parentheses. 4 744
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 3 763–770
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 3 785–794
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 3 809–822
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 3 837–847
UselessParentheses Useless parentheses. 4 954
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 3 1250–1261
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 3 1274–1283
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 3 1299–1309
UselessParentheses Useless parentheses. 4 1302

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 100–102
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 112
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 3 117–119
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 3 121–123

org/eclipse/jgit/util/RefMap.java

Rule Violation Priority Line
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 428

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 122
UselessParentheses Useless parentheses. 4 126
UselessParentheses Useless parentheses. 4 127

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 405–407

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 71–73

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 149–151
EmptyCatchBlock Avoid empty catch blocks 3 154–156

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 87
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 3 592–595
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 3 597–603

org/eclipse/jgit/util/time/MonotonicClock.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.time.Duration' 4 46