PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 181

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 619

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 500
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 593
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 639

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 356

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 535

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 225

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 540
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 603

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 707

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 388

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 136

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 626

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 594

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 202

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 149

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 864

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 200
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 293

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 525

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 112

Priority 3

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 127194

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Stage': nested enums are implicitly static 140161
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 158160

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 719722

org/eclipse/jgit/api/LogCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 285290

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 723728
CollapsibleIfStatements These nested if statements could be combined 13061309

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 405409

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 216

org/eclipse/jgit/attributes/Attribute.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 7086

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 157159

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 431433
EmptyIfStmt Avoid empty if statements 521525
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 10191021

org/eclipse/jgit/diff/DiffConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenameDetectionType': nested enums are implicitly static 6271

org/eclipse/jgit/diff/DiffEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'ChangeType': nested enums are implicitly static 7590
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Side': nested enums are implicitly static 9399

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 451243
EmptyCatchBlock Avoid empty catch blocks 722724

org/eclipse/jgit/diff/Edit.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 6779

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 369

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 459462
EmptyIfStmt Avoid empty if statements 464469
CollapsibleIfStatements These nested if statements could be combined 921930
CollapsibleIfStatements These nested if statements could be combined 924929
CollapsibleIfStatements These nested if statements could be combined 12381240
EmptyWhileStmt Avoid empty while statements 16151617

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 248254

org/eclipse/jgit/errors/NoMergeBaseException.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MergeBaseFailureReason': nested enums are implicitly static 6685

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 63

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 6365

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 135142
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 164166
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 173175
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 182184
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 191193
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 200202
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 209211
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 222224

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 5759

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 5456

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 111112

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 157
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 177180
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 204205
EmptyCatchBlock Avoid empty catch blocks 592594

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 162164

org/eclipse/jgit/ignore/IgnoreNode.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MatchResult': nested enums are implicitly static 6279

org/eclipse/jgit/ignore/internal/IMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 5364

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 66

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43343

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatternState': nested enums are implicitly static 234236
CollapsibleIfStatements These nested if statements could be combined 337339

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 6468
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 7274

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 106108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44637
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 129141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44791

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44374

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44185
EmptyCatchBlock Avoid empty catch blocks 150152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44237

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44448
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 114116

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44326

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 8183

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 8991

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44277

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44788

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 248250

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackSource': nested enums are implicitly static 100235

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44529

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 249251

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 183185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 359361
EmptyCatchBlock Avoid empty catch blocks 379381

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 377379

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 176178

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 141

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44460

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 122124

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 6264
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 6674
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 8285
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 87112
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 114116
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 118120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 344346

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 112114
CollapsibleIfStatements These nested if statements could be combined 199201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'InsertLooseObjectResult': nested enums are implicitly static 6365

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 218221
EmptyCatchBlock Avoid empty catch blocks 291293

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 422424
EmptyCatchBlock Avoid empty catch blocks 459461
EmptyCatchBlock Avoid empty catch blocks 577580
EmptyCatchBlock Avoid empty catch blocks 959961
EmptyCatchBlock Avoid empty catch blocks 984986

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 111113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 82124
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 126129
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 131133
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 135137
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 143147
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 149153
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 155162
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 164166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 98100

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 326328
CollapsibleIfStatements These nested if statements could be combined 342344
EmptyCatchBlock Avoid empty catch blocks 729731

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 220222

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 398419
EmptyCatchBlock Avoid empty catch blocks 734738

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 349351
EmptyCatchBlock Avoid empty catch blocks 356358
EmptyCatchBlock Avoid empty catch blocks 361363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44551
EmptyCatchBlock Avoid empty catch blocks 451453
EmptyCatchBlock Avoid empty catch blocks 472486

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 471511
CollapsibleIfStatements These nested if statements could be combined 557558
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 14051409

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 217219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 46274

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 6973

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 127133

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 136138

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 75102
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 75102

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 139149
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 262264
SimplifiedTernary Ternary operators that can be simplified with || or && 350

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 309311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 5761
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 6466
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 6971
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 7476
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 7981
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 8393

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 118138
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 146153
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 170172
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 191206
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 208217
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 219226
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 228233
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 240242
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 253255
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 258260

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 452518
EmptyWhileStmt Avoid empty while statements 19491951
CollapsibleIfStatements These nested if statements could be combined 22892290
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 23042307
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackingPhase': nested enums are implicitly static 24332451

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 291293
CollapsibleIfStatements These nested if statements could be combined 303307

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44600

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44605

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44727
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 710

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44859

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44287

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43206

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 372374

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 234236
EmptyCatchBlock Avoid empty catch blocks 446448

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 7787
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 101109
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 122125
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 134139
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 141153
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 155166
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 247267
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 283303
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 319339
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 346348
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 376397

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 299

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44783

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 77117
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 123211

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 7577

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 14761485
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 15131529

org/eclipse/jgit/lib/CoreConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AutoCRLF': nested enums are implicitly static 6372
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EOL': nested enums are implicitly static 8190
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EolStreamType': nested enums are implicitly static 97112
UnnecessaryModifier Unnecessary modifier 'static' on enum 'CheckStat': nested enums are implicitly static 119131
UnnecessaryModifier Unnecessary modifier 'static' on enum 'SymLinks': nested enums are implicitly static 148153
UnnecessaryModifier Unnecessary modifier 'static' on enum 'HideDotFiles': nested enums are implicitly static 160167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 128130

org/eclipse/jgit/lib/FileMode.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 68
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 71
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 74
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 77
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 83
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 108
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 113
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 118
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 123
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 163

org/eclipse/jgit/lib/GitmoduleEntry.java

Rule Violation Line
ImportFromSamePackage No need to import a type that lives in the same package 45

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 6466

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'StageState': nested enums are implicitly static 111199
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 149151
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 352
CollapsibleIfStatements These nested if statements could be combined 474477
CollapsibleIfStatements These nested if statements could be combined 519523

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 451277

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 241253

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 340342
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 344346
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 348355

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 258260

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Action': nested enums are implicitly static 61118
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 8790
CollapsibleIfStatements These nested if statements could be combined 191194

org/eclipse/jgit/lib/Ref.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 108111

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 69172
CollapsibleIfStatements These nested if statements could be combined 782784

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 898899

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 344365

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 9597

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 7476

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44403

org/eclipse/jgit/lib/internal/BouncyCastleGpgKeyLocator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 143145

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7274

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 471355
CollapsibleIfStatements These nested if statements could be combined 408410
CollapsibleIfStatements These nested if statements could be combined 823849
CollapsibleIfStatements These nested if statements could be combined 839841

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 86

org/eclipse/jgit/patch/BinaryHunk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 6167

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 152154

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44653
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatchType': nested enums are implicitly static 107116
EmptyCatchBlock Avoid empty catch blocks 248251

org/eclipse/jgit/patch/FormatError.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Severity': nested enums are implicitly static 5763

org/eclipse/jgit/patch/Patch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 44392

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 198200

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 138141
EmptyCatchBlock Avoid empty catch blocks 157172

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 109145
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 109145
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 148275
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 278393

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 87
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 88
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 89
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 90
EmptyWhileStmt Avoid empty while statements 818820

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 193196

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 343345
EmptyCatchBlock Avoid empty catch blocks 354356
EmptyCatchBlock Avoid empty catch blocks 384386

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 431433
EmptyCatchBlock Avoid empty catch blocks 487489
EmptyCatchBlock Avoid empty catch blocks 507510
EmptyCatchBlock Avoid empty catch blocks 788790

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 185187
EmptyCatchBlock Avoid empty catch blocks 191193

org/eclipse/jgit/transport/BaseReceivePack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 441971
EmptyCatchBlock Avoid empty catch blocks 380382
EmptyCatchBlock Avoid empty catch blocks 391393
EmptyCatchBlock Avoid empty catch blocks 407409
EmptyCatchBlock Avoid empty catch blocks 10401042
EmptyCatchBlock Avoid empty catch blocks 13471349

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 264266
EmptyCatchBlock Avoid empty catch blocks 301303

org/eclipse/jgit/transport/Daemon.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 114
EmptyCatchBlock Avoid empty catch blocks 315317
EmptyCatchBlock Avoid empty catch blocks 341343
EmptyCatchBlock Avoid empty catch blocks 425427
EmptyCatchBlock Avoid empty catch blocks 427429
EmptyCatchBlock Avoid empty catch blocks 429431
EmptyCatchBlock Avoid empty catch blocks 434436
EmptyCatchBlock Avoid empty catch blocks 439441

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 72

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45561

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 9598
EmptyCatchBlock Avoid empty catch blocks 107110

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 6497
EmptyCatchBlock Avoid empty catch blocks 221223

org/eclipse/jgit/transport/GitProtocolConstants.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MultiAck': nested enums are implicitly static 283285

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 192194
EmptyIfStmt Avoid empty if statements 416418
EmptyIfStmt Avoid empty if statements 419421

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 156158
EmptyIfStmt Avoid empty if statements 465467

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 110113
EmptyCatchBlock Avoid empty catch blocks 119121
EmptyCatchBlock Avoid empty catch blocks 125127

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103106
EmptyCatchBlock Avoid empty catch blocks 115117
EmptyCatchBlock Avoid empty catch blocks 121123

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 432434
EmptyCatchBlock Avoid empty catch blocks 434436
EmptyCatchBlock Avoid empty catch blocks 455457
CollapsibleIfStatements These nested if statements could be combined 519532
EmptyCatchBlock Avoid empty catch blocks 529531

org/eclipse/jgit/transport/JschSession.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 190192

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 103107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 106112
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 731754
EmptyCatchBlock Avoid empty catch blocks 11841188
EmptyCatchBlock Avoid empty catch blocks 12001204

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AckNackResult': nested enums are implicitly static 98109
EmptyCatchBlock Avoid empty catch blocks 335337

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 143148

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 5557

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 43281
EmptyIfStmt Avoid empty if statements 102104

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 8798
EmptyCatchBlock Avoid empty catch blocks 265268

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 7678

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 296298

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 7598
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 101134
CollapsibleIfStatements These nested if statements could be combined 780784

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 421423

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 554555

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 75127

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 8789

org/eclipse/jgit/transport/Transport.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 162164

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 263265

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 118120

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 154156
EmptyCatchBlock Avoid empty catch blocks 214216
EmptyCatchBlock Avoid empty catch blocks 253255

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 353355
EmptyCatchBlock Avoid empty catch blocks 360362

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 471699
CollapsibleIfStatements These nested if statements could be combined 855857
EmptyWhileStmt Avoid empty while statements 11551157
EmptyCatchBlock Avoid empty catch blocks 11761178
EmptyCatchBlock Avoid empty catch blocks 11821184

org/eclipse/jgit/transport/TransportProtocol.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'URIishField': nested enums are implicitly static 93104

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 346349

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 442414
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RequestPolicy': nested enums are implicitly static 137167
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 236238
EmptyWhileStmt Avoid empty while statements 10721074
EmptyWhileStmt Avoid empty while statements 13211323
EmptyWhileStmt Avoid empty while statements 13301332
EmptyCatchBlock Avoid empty catch blocks 13771379
EmptyCatchBlock Avoid empty catch blocks 15451547

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 120124

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 843845

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 302306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 421423

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 45445

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'OperationType': nested enums are implicitly static 114125

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 474478
EmptyWhileStmt Avoid empty while statements 514516
CollapsibleIfStatements These nested if statements could be combined 898899
EmptyCatchBlock Avoid empty catch blocks 15721574

org/eclipse/jgit/util/FS.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 388390
EmptyIfStmt Avoid empty if statements 12581261
EmptyCatchBlock Avoid empty catch blocks 18751882
EmptyCatchBlock Avoid empty catch blocks 22142216

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 91
CollapsibleIfStatements These nested if statements could be combined 176194
CollapsibleIfStatements These nested if statements could be combined 177193

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 164166
CollapsibleIfStatements These nested if statements could be combined 180196

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 324326
SimplifiedTernary Ternary operators that can be simplified with || or && 846

org/eclipse/jgit/util/GitDateFormatter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Format': nested enums are implicitly static 71117

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 131133
EmptyCatchBlock Avoid empty catch blocks 231233

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 322

org/eclipse/jgit/util/LongMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 169173
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 176178

org/eclipse/jgit/util/ProcessResult.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 5469

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 451340
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 131138
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 212246
EmptyCatchBlock Avoid empty catch blocks 240242
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 266300
EmptyCatchBlock Avoid empty catch blocks 294296
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 317330
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 347371
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 389437
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 448453
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 467469
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 487493
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 506513
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 526528
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 543551
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 564573
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 588607
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 620628
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 641643
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 659668
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 692700
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 718725
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 763770
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 785794
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 809822
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 837847
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 12501261
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 12741283
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 12991309

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 100102
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 117119
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 121123

org/eclipse/jgit/util/References.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 6466

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 405407

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7173

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 149151
EmptyCatchBlock Avoid empty catch blocks 154156

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 87
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 592595
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 597603

Priority 4

org/eclipse/jgit/api/AddCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 212213
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 213
UselessParentheses Useless parentheses. 214215

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 582

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 205

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 419420
UselessParentheses Useless parentheses. 421
UselessParentheses Useless parentheses. 554

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 256

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 455
UselessParentheses Useless parentheses. 455

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 195197

org/eclipse/jgit/api/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 416

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 284

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 790
UselessParentheses Useless parentheses. 790791
UselessParentheses Useless parentheses. 791
UselessParentheses Useless parentheses. 1753

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 159
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 185
UselessParentheses Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 144

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 320
UselessParentheses Useless parentheses. 442443
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 549

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 133
UselessParentheses Useless parentheses. 171
UselessParentheses Useless parentheses. 206
UselessParentheses Useless parentheses. 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Line
UselessParentheses Useless parentheses. 381

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
UselessParentheses Useless parentheses. 670
UselessParentheses Useless parentheses. 748
UselessParentheses Useless parentheses. 749
UselessParentheses Useless parentheses. 750
UselessParentheses Useless parentheses. 751
UselessParentheses Useless parentheses. 752
UselessParentheses Useless parentheses. 753
UselessParentheses Useless parentheses. 812
UselessParentheses Useless parentheses. 813
UselessParentheses Useless parentheses. 813
UselessParentheses Useless parentheses. 813
UselessParentheses Useless parentheses. 909
UselessParentheses Useless parentheses. 11521153

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 125
UselessParentheses Useless parentheses. 294
UselessParentheses Useless parentheses. 418
UselessParentheses Useless parentheses. 418

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Line
UselessParentheses Useless parentheses. 494

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 782
UselessParentheses Useless parentheses. 783

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 131

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UselessParentheses Useless parentheses. 138
UselessParentheses Useless parentheses. 398

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 67

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 427

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 626
UselessParentheses Useless parentheses. 633

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Line
UselessParentheses Useless parentheses. 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 579

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 541
UselessParentheses Useless parentheses. 547
UselessParentheses Useless parentheses. 554
UselessParentheses Useless parentheses. 560
UselessParentheses Useless parentheses. 577
UselessParentheses Useless parentheses. 601
UselessParentheses Useless parentheses. 687
UselessParentheses Useless parentheses. 695
UselessParentheses Useless parentheses. 768
UselessParentheses Useless parentheses. 818
UselessParentheses Useless parentheses. 937
UselessParentheses Useless parentheses. 1047

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 762

org/eclipse/jgit/internal/storage/dfs/DfsReftableDatabase.java

Rule Violation Line
UselessParentheses Useless parentheses. 240241

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Line
UselessParentheses Useless parentheses. 579
UselessParentheses Useless parentheses. 579

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
UselessParentheses Useless parentheses. 979981
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1157
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1160

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 654
UselessParentheses Useless parentheses. 655
UselessParentheses Useless parentheses. 775

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 465
UselessParentheses Useless parentheses. 471
UselessParentheses Useless parentheses. 478
UselessParentheses Useless parentheses. 484
UselessParentheses Useless parentheses. 501
UselessParentheses Useless parentheses. 534
UselessParentheses Useless parentheses. 554
UselessParentheses Useless parentheses. 611
UselessParentheses Useless parentheses. 619
UselessParentheses Useless parentheses. 869
UselessParentheses Useless parentheses. 918
UselessParentheses Useless parentheses. 1033
UselessParentheses Useless parentheses. 1124
UselessParentheses Useless parentheses. 1139
UselessParentheses Useless parentheses. 1225

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Line
UselessParentheses Useless parentheses. 231
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 393
UselessParentheses Useless parentheses. 394
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 1183
UselessParentheses Useless parentheses. 1198
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1235
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1266

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 242

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Line
UselessParentheses Useless parentheses. 319

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 68

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 194

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 387
UselessParentheses Useless parentheses. 2305
UselessParentheses Useless parentheses. 2306
UselessParentheses Useless parentheses. 2390
UselessParentheses Useless parentheses. 2407

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
UselessParentheses Useless parentheses. 133
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 234
UselessParentheses Useless parentheses. 268
UselessParentheses Useless parentheses. 269270
UselessParentheses Useless parentheses. 270
UselessParentheses Useless parentheses. 271
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 282

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 572
UselessParentheses Useless parentheses. 584

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 138

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 482

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 237238

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 113

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UselessParentheses Useless parentheses. 1443

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 281

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 521522
UselessParentheses Useless parentheses. 638639
UselessParentheses Useless parentheses. 638639
UselessParentheses Useless parentheses. 638
UselessParentheses Useless parentheses. 767768

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 571
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 603
UselessParentheses Useless parentheses. 876
UselessParentheses Useless parentheses. 936
UselessParentheses Useless parentheses. 937
UselessParentheses Useless parentheses. 1015
UselessParentheses Useless parentheses. 1027
UselessParentheses Useless parentheses. 11081109
UselessParentheses Useless parentheses. 1110
UselessParentheses Useless parentheses. 1111

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
UselessParentheses Useless parentheses. 631
UselessParentheses Useless parentheses. 643
UselessParentheses Useless parentheses. 840
UselessParentheses Useless parentheses. 841
UselessParentheses Useless parentheses. 842

org/eclipse/jgit/lib/RepositoryBuilder.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.File' 46

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UselessParentheses Useless parentheses. 299

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Line
UselessParentheses Useless parentheses. 322

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Line
UselessParentheses Useless parentheses. 90

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 141

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 823824
UselessParentheses Useless parentheses. 823824
UselessParentheses Useless parentheses. 823
UselessParentheses Useless parentheses. 887888

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 51
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 52

org/eclipse/jgit/nls/NLS.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 49
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 50

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 284
UselessParentheses Useless parentheses. 286

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 297

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 195

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Line
UselessParentheses Useless parentheses. 124

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 148
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 278

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 61

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
UselessParentheses Useless parentheses. 371

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 532

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 680

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 400401
UselessParentheses Useless parentheses. 436

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 556

org/eclipse/jgit/transport/FetchResult.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 50

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
UselessParentheses Useless parentheses. 175
UselessParentheses Useless parentheses. 176

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 119137
UselessParentheses Useless parentheses. 398399
UselessParentheses Useless parentheses. 445
UselessParentheses Useless parentheses. 465

org/eclipse/jgit/transport/ObjectCountCallback.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.OutputStream' 46
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 48

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 851
UselessParentheses Useless parentheses. 1026

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Line
UselessParentheses Useless parentheses. 267

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 279
UselessParentheses Useless parentheses. 777
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 843
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 871
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 875
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 881

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 167
UselessParentheses Useless parentheses. 323

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 355356

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 154

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 89

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
UselessParentheses Useless parentheses. 182

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Line
UselessParentheses Useless parentheses. 115

org/eclipse/jgit/transport/URIish.java

Rule Violation Line
UselessParentheses Useless parentheses. 277278
UselessParentheses Useless parentheses. 338
UselessParentheses Useless parentheses. 339
UselessParentheses Useless parentheses. 366
UselessParentheses Useless parentheses. 367

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
UselessParentheses Useless parentheses. 1390

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 74
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 80
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 86
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 105
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 110
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 115

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 84

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 1302
UselessParentheses Useless parentheses. 1439

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
UselessParentheses Useless parentheses. 328329
UselessParentheses Useless parentheses. 15891590
UselessParentheses Useless parentheses. 15911592

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Line
UselessParentheses Useless parentheses. 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Line
UselessParentheses Useless parentheses. 116

org/eclipse/jgit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses. 120
UselessParentheses Useless parentheses. 127
UselessParentheses Useless parentheses. 134

org/eclipse/jgit/util/FS.java

Rule Violation Line
UselessParentheses Useless parentheses. 1332

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
UselessParentheses Useless parentheses. 485
UselessParentheses Useless parentheses. 485

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 64

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 261262

org/eclipse/jgit/util/NB.java

Rule Violation Line
UselessParentheses Useless parentheses. 91
UselessParentheses Useless parentheses. 203
UselessParentheses Useless parentheses. 206

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
UselessParentheses Useless parentheses. 237
UselessParentheses Useless parentheses. 291
UselessParentheses Useless parentheses. 744
UselessParentheses Useless parentheses. 954
UselessParentheses Useless parentheses. 1302

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Line
UselessParentheses Useless parentheses. 122
UselessParentheses Useless parentheses. 126
UselessParentheses Useless parentheses. 127

org/eclipse/jgit/util/time/MonotonicClock.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.time.Duration' 46

Files

org/eclipse/jgit/api/AddCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 212213
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 4 213
UselessParentheses Useless parentheses. 4 214215

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 3 127194

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Stage': nested enums are implicitly static 3 140161
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 3 158160
UselessParentheses Useless parentheses. 4 582

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 204
UselessParentheses Useless parentheses. 4 205

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 719722

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 419420
UselessParentheses Useless parentheses. 4 421
UselessParentheses Useless parentheses. 4 554

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 4 256

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 455
UselessParentheses Useless parentheses. 4 455

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 195197

org/eclipse/jgit/api/LogCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 285290

org/eclipse/jgit/api/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 416

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 284

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 723728
UselessParentheses Useless parentheses. 4 790
UselessParentheses Useless parentheses. 4 790791
UselessParentheses Useless parentheses. 4 791
CollapsibleIfStatements These nested if statements could be combined 3 13061309
UselessParentheses Useless parentheses. 4 1753

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 405409

org/eclipse/jgit/api/TagCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 3 216

org/eclipse/jgit/attributes/Attribute.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 3 7086

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 159
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 185
UselessParentheses Useless parentheses. 4 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 157159

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 431433
EmptyIfStmt Avoid empty if statements 3 521525
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 3 10191021

org/eclipse/jgit/diff/DiffConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenameDetectionType': nested enums are implicitly static 3 6271

org/eclipse/jgit/diff/DiffEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'ChangeType': nested enums are implicitly static 3 7590
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Side': nested enums are implicitly static 3 9399

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 451243
EmptyCatchBlock Avoid empty catch blocks 3 722724

org/eclipse/jgit/diff/Edit.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 6779

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 320
UselessParentheses Useless parentheses. 4 442443
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 549

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 133
UselessParentheses Useless parentheses. 4 171
UselessParentheses Useless parentheses. 4 206
UselessParentheses Useless parentheses. 4 252

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 381

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 369

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 181

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 459462
EmptyIfStmt Avoid empty if statements 3 464469
UselessParentheses Useless parentheses. 4 670
UselessParentheses Useless parentheses. 4 748
UselessParentheses Useless parentheses. 4 749
UselessParentheses Useless parentheses. 4 750
UselessParentheses Useless parentheses. 4 751
UselessParentheses Useless parentheses. 4 752
UselessParentheses Useless parentheses. 4 753
UselessParentheses Useless parentheses. 4 812
UselessParentheses Useless parentheses. 4 813
UselessParentheses Useless parentheses. 4 813
UselessParentheses Useless parentheses. 4 813
UselessParentheses Useless parentheses. 4 909
CollapsibleIfStatements These nested if statements could be combined 3 921930
CollapsibleIfStatements These nested if statements could be combined 3 924929
UselessParentheses Useless parentheses. 4 11521153
CollapsibleIfStatements These nested if statements could be combined 3 12381240
EmptyWhileStmt Avoid empty while statements 3 16151617

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 125
UselessParentheses Useless parentheses. 4 294
UselessParentheses Useless parentheses. 4 418
UselessParentheses Useless parentheses. 4 418

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 248254

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 494

org/eclipse/jgit/errors/NoMergeBaseException.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MergeBaseFailureReason': nested enums are implicitly static 3 6685

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 3 63

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 6365

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 135142
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 164166
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 173175
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 182184
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 191193
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 200202
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 209211
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 222224

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 5759

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 5456

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 3 111112

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 3 157
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 3 177180
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 3 204205
EmptyCatchBlock Avoid empty catch blocks 3 592594
UselessParentheses Useless parentheses. 4 782
UselessParentheses Useless parentheses. 4 783

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 162164

org/eclipse/jgit/ignore/IgnoreNode.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MatchResult': nested enums are implicitly static 3 6279

org/eclipse/jgit/ignore/internal/IMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 3 5364

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 66
UselessParentheses Useless parentheses. 4 130

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43343
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 4 131

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 138
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatternState': nested enums are implicitly static 3 234236
CollapsibleIfStatements These nested if statements could be combined 3 337339
UselessParentheses Useless parentheses. 4 398

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 6468
UselessParentheses Useless parentheses. 4 67
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 7274

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 106108

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44637
UnnecessaryModifier Unnecessary modifier 'static' on enum 'State': nested enums are implicitly static 3 129141

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44158

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44791

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44374

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44185
EmptyCatchBlock Avoid empty catch blocks 3 150152

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44237

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44448
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 3 114116
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 427

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44326

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44247

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 8183

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 8991

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44277

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44788
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 477

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 248250
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 626
UselessParentheses Useless parentheses. 4 633

org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackSource': nested enums are implicitly static 3 100235

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44529

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 579

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 3 249251
UselessParentheses Useless parentheses. 4 541
UselessParentheses Useless parentheses. 4 547
UselessParentheses Useless parentheses. 4 554
UselessParentheses Useless parentheses. 4 560
UselessParentheses Useless parentheses. 4 577
UselessParentheses Useless parentheses. 4 601
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 619
UselessParentheses Useless parentheses. 4 687
UselessParentheses Useless parentheses. 4 695
UselessParentheses Useless parentheses. 4 768
UselessParentheses Useless parentheses. 4 818
UselessParentheses Useless parentheses. 4 937
UselessParentheses Useless parentheses. 4 1047

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 183185

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 359361
EmptyCatchBlock Avoid empty catch blocks 3 379381
UselessParentheses Useless parentheses. 4 762

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44182

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 377379

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 176178

org/eclipse/jgit/internal/storage/dfs/DfsReftableDatabase.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 240241

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 141

org/eclipse/jgit/internal/storage/dfs/ReftableBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44460

org/eclipse/jgit/internal/storage/dfs/ReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 122124

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 6264
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 6674
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 8285
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 3 87112
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 114116
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 118120

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 3 344346

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 112114
CollapsibleIfStatements These nested if statements could be combined 3 199201

org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'InsertLooseObjectResult': nested enums are implicitly static 3 6365

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 218221
EmptyCatchBlock Avoid empty catch blocks 3 291293

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 579
UselessParentheses Useless parentheses. 4 579

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 422424
EmptyCatchBlock Avoid empty catch blocks 3 459461
EmptyCatchBlock Avoid empty catch blocks 3 577580
EmptyCatchBlock Avoid empty catch blocks 3 959961
UselessParentheses Useless parentheses. 4 979981
EmptyCatchBlock Avoid empty catch blocks 3 984986
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1157
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1160

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 111113

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 3 7680
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 3 82124
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 3 126129
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 131133
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 135137
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 3 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 3 143147
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 3 149153
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 3 155162
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 3 164166

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 98100

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 326328
CollapsibleIfStatements These nested if statements could be combined 3 342344
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 500
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 593
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 639
UselessParentheses Useless parentheses. 4 654
UselessParentheses Useless parentheses. 4 655
EmptyCatchBlock Avoid empty catch blocks 3 729731
UselessParentheses Useless parentheses. 4 775

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 220222

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 163

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 3 398419
UselessParentheses Useless parentheses. 4 465
UselessParentheses Useless parentheses. 4 471
UselessParentheses Useless parentheses. 4 478
UselessParentheses Useless parentheses. 4 484
UselessParentheses Useless parentheses. 4 501
UselessParentheses Useless parentheses. 4 534
UselessParentheses Useless parentheses. 4 554
UselessParentheses Useless parentheses. 4 611
UselessParentheses Useless parentheses. 4 619
EmptyCatchBlock Avoid empty catch blocks 3 734738
UselessParentheses Useless parentheses. 4 869
UselessParentheses Useless parentheses. 4 918
UselessParentheses Useless parentheses. 4 1033
UselessParentheses Useless parentheses. 4 1124
UselessParentheses Useless parentheses. 4 1139
UselessParentheses Useless parentheses. 4 1225

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 240

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 231
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 349351
EmptyCatchBlock Avoid empty catch blocks 3 356358
EmptyCatchBlock Avoid empty catch blocks 3 361363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 68

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44551
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 356
UselessParentheses Useless parentheses. 4 393
UselessParentheses Useless parentheses. 4 394
EmptyCatchBlock Avoid empty catch blocks 3 451453
EmptyCatchBlock Avoid empty catch blocks 3 472486
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 546

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 471511
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 535
CollapsibleIfStatements These nested if statements could be combined 3 557558
UselessParentheses Useless parentheses. 4 1183
UselessParentheses Useless parentheses. 4 1198
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1235
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 4 1266
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 3 14051409

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 217219

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 46274
UselessParentheses Useless parentheses. 4 242

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 6973

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 3 127133

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 319

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 136138

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 3 75102
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 3 75102

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 68

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Priority Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 3 139149
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 262264
SimplifiedTernary Ternary operators that can be simplified with || or && 3 350

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 225
EmptyCatchBlock Avoid empty catch blocks 3 309311

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 5761
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3 6466
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3 6971
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 7476
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 3 7981
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 3 8393

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 118138
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 3 146153
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 3 170172
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 3 191206
UselessParentheses Useless parentheses. 4 194
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 3 208217
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 3 219226
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 3 228233
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 3 240242
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 3 253255
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 3 258260

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 452518
UselessParentheses Useless parentheses. 4 387
EmptyWhileStmt Avoid empty while statements 3 19491951
CollapsibleIfStatements These nested if statements could be combined 3 22892290
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 3 23042307
UselessParentheses Useless parentheses. 4 2305
UselessParentheses Useless parentheses. 4 2306
UselessParentheses Useless parentheses. 4 2390
UselessParentheses Useless parentheses. 4 2407
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PackingPhase': nested enums are implicitly static 3 24332451

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 133
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 234
UselessParentheses Useless parentheses. 4 268
UselessParentheses Useless parentheses. 4 269270
UselessParentheses Useless parentheses. 4 270
UselessParentheses Useless parentheses. 4 271
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 282
EmptyWhileStmt Avoid empty while statements 3 291293
CollapsibleIfStatements These nested if statements could be combined 3 303307

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44600
UselessParentheses Useless parentheses. 4 572
UselessParentheses Useless parentheses. 4 584

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44605
UselessParentheses Useless parentheses. 4 138

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44249

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44727
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 482
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 540
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 603
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 710

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44859
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 707

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44342

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44417

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44227

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44287

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43206

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 237238
EmptyCatchBlock Avoid empty catch blocks 3 372374

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 234236
EmptyCatchBlock Avoid empty catch blocks 3 446448

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 7787
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 101109
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 3 122125
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 134139
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 141153
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 3 155166
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 247267
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 283303
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 319339
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 346348
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 376397

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 299

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44783
UselessParentheses Useless parentheses. 4 113

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 3 77117
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 3 123211

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 3 7577

org/eclipse/jgit/lib/Config.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1443
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 3 14761485
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 3 15131529

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 4 281

org/eclipse/jgit/lib/CoreConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AutoCRLF': nested enums are implicitly static 3 6372
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EOL': nested enums are implicitly static 3 8190
UnnecessaryModifier Unnecessary modifier 'static' on enum 'EolStreamType': nested enums are implicitly static 3 97112
UnnecessaryModifier Unnecessary modifier 'static' on enum 'CheckStat': nested enums are implicitly static 3 119131
UnnecessaryModifier Unnecessary modifier 'static' on enum 'SymLinks': nested enums are implicitly static 3 148153
UnnecessaryModifier Unnecessary modifier 'static' on enum 'HideDotFiles': nested enums are implicitly static 3 160167

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 128130

org/eclipse/jgit/lib/FileMode.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 68
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 71
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 74
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 77
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 83
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 108
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 113
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 118
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 123
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 163

org/eclipse/jgit/lib/GitmoduleEntry.java

Rule Violation Priority Line
ImportFromSamePackage No need to import a type that lives in the same package 3 45

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3 6466

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'StageState': nested enums are implicitly static 3 111199
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 3 149151
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 3 352
CollapsibleIfStatements These nested if statements could be combined 3 474477
CollapsibleIfStatements These nested if statements could be combined 3 519523
UselessParentheses Useless parentheses. 4 521522
UselessParentheses Useless parentheses. 4 638639
UselessParentheses Useless parentheses. 4 638639
UselessParentheses Useless parentheses. 4 638
UselessParentheses Useless parentheses. 4 767768

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 451277
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 571
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 603
UselessParentheses Useless parentheses. 4 876
UselessParentheses Useless parentheses. 4 936
UselessParentheses Useless parentheses. 4 937
UselessParentheses Useless parentheses. 4 1015
UselessParentheses Useless parentheses. 4 1027
UselessParentheses Useless parentheses. 4 11081109
UselessParentheses Useless parentheses. 4 1110
UselessParentheses Useless parentheses. 4 1111

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 241253

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 3 340342
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 3 344346
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 3 348355

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 258260

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Action': nested enums are implicitly static 3 61118
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 3 8790
CollapsibleIfStatements These nested if statements could be combined 3 191194

org/eclipse/jgit/lib/Ref.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 3 108111

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 3 69172
CollapsibleIfStatements These nested if statements could be combined 3 782784

org/eclipse/jgit/lib/Repository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 631
UselessParentheses Useless parentheses. 4 643
UselessParentheses Useless parentheses. 4 840
UselessParentheses Useless parentheses. 4 841
UselessParentheses Useless parentheses. 4 842
CollapsibleIfStatements These nested if statements could be combined 3 898899

org/eclipse/jgit/lib/RepositoryBuilder.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.File' 4 46

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 299
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 3 344365

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 9597

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 7476

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44403

org/eclipse/jgit/lib/internal/BouncyCastleGpgKeyLocator.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 143145

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 322

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7274

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 141

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 471355
CollapsibleIfStatements These nested if statements could be combined 3 408410
CollapsibleIfStatements These nested if statements could be combined 3 823849
UselessParentheses Useless parentheses. 4 823824
UselessParentheses Useless parentheses. 4 823824
UselessParentheses Useless parentheses. 4 823
CollapsibleIfStatements These nested if statements could be combined 3 839841
UselessParentheses Useless parentheses. 4 887888

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 3 86

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 51
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 52

org/eclipse/jgit/nls/NLS.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 49
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 50

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 284
UselessParentheses Useless parentheses. 4 286

org/eclipse/jgit/patch/BinaryHunk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 6167

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 152154

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44653
UnnecessaryModifier Unnecessary modifier 'static' on enum 'PatchType': nested enums are implicitly static 3 107116
EmptyCatchBlock Avoid empty catch blocks 3 248251
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 4 297

org/eclipse/jgit/patch/FormatError.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Severity': nested enums are implicitly static 3 5763

org/eclipse/jgit/patch/Patch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 44392

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 195

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 198200

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 138141
EmptyCatchBlock Avoid empty catch blocks 3 157172

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 124

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 3 109145
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 3 109145
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 148
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 3 148275
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 3 278393
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 278

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.AnyObjectId' 4 61
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 87
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 88
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 89
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 90
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 388
EmptyWhileStmt Avoid empty while statements 3 818820

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 193196
UselessParentheses Useless parentheses. 4 371

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 136

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 532
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 626

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 343345
EmptyCatchBlock Avoid empty catch blocks 3 354356
EmptyCatchBlock Avoid empty catch blocks 3 384386

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 431433
EmptyCatchBlock Avoid empty catch blocks 3 487489
EmptyCatchBlock Avoid empty catch blocks 3 507510
UselessParentheses Useless parentheses. 4 680
EmptyCatchBlock Avoid empty catch blocks 3 788790

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 185187
EmptyCatchBlock Avoid empty catch blocks 3 191193
UselessParentheses Useless parentheses. 4 400401
UselessParentheses Useless parentheses. 4 436

org/eclipse/jgit/transport/BaseReceivePack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 441971
EmptyCatchBlock Avoid empty catch blocks 3 380382
EmptyCatchBlock Avoid empty catch blocks 3 391393
EmptyCatchBlock Avoid empty catch blocks 3 407409
EmptyCatchBlock Avoid empty catch blocks 3 10401042
EmptyCatchBlock Avoid empty catch blocks 3 13471349

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 264266
EmptyCatchBlock Avoid empty catch blocks 3 301303

org/eclipse/jgit/transport/Daemon.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 114
EmptyCatchBlock Avoid empty catch blocks 3 315317
EmptyCatchBlock Avoid empty catch blocks 3 341343
EmptyCatchBlock Avoid empty catch blocks 3 425427
EmptyCatchBlock Avoid empty catch blocks 3 427429
EmptyCatchBlock Avoid empty catch blocks 3 429431
EmptyCatchBlock Avoid empty catch blocks 3 434436
EmptyCatchBlock Avoid empty catch blocks 3 439441

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 72

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45561
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 4 556

org/eclipse/jgit/transport/FetchResult.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 50

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 9598
EmptyCatchBlock Avoid empty catch blocks 3 107110

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3 6497
EmptyCatchBlock Avoid empty catch blocks 3 221223

org/eclipse/jgit/transport/GitProtocolConstants.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'MultiAck': nested enums are implicitly static 3 283285

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 175
UselessParentheses Useless parentheses. 4 176
EmptyCatchBlock Avoid empty catch blocks 3 192194
EmptyIfStmt Avoid empty if statements 3 416418
EmptyIfStmt Avoid empty if statements 3 419421

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 119137
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 3 156158
UselessParentheses Useless parentheses. 4 398399
UselessParentheses Useless parentheses. 4 445
UselessParentheses Useless parentheses. 4 465
EmptyIfStmt Avoid empty if statements 3 465467

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 110113
EmptyCatchBlock Avoid empty catch blocks 3 119121
EmptyCatchBlock Avoid empty catch blocks 3 125127

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103106
EmptyCatchBlock Avoid empty catch blocks 3 115117
EmptyCatchBlock Avoid empty catch blocks 3 121123

org/eclipse/jgit/transport/JschConfigSessionFactory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 432434
EmptyCatchBlock Avoid empty catch blocks 3 434436
EmptyCatchBlock Avoid empty catch blocks 3 455457
CollapsibleIfStatements These nested if statements could be combined 3 519532
EmptyCatchBlock Avoid empty catch blocks 3 529531

org/eclipse/jgit/transport/JschSession.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 190192

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 103107

org/eclipse/jgit/transport/ObjectCountCallback.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.OutputStream' 4 46
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ProgressMonitor' 4 48

org/eclipse/jgit/transport/PackParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 3 106112
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 3 731754
UselessParentheses Useless parentheses. 4 851
UselessParentheses Useless parentheses. 4 1026
EmptyCatchBlock Avoid empty catch blocks 3 11841188
EmptyCatchBlock Avoid empty catch blocks 3 12001204

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'AckNackResult': nested enums are implicitly static 3 98109
EmptyCatchBlock Avoid empty catch blocks 3 335337

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 143148

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 3 5557

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 43281
EmptyIfStmt Avoid empty if statements 3 102104

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 267

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 3 8798
EmptyCatchBlock Avoid empty catch blocks 3 265268

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 7678

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 296298

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 7598
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Result': nested enums are implicitly static 3 101134
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 279
UselessParentheses Useless parentheses. 4 777
CollapsibleIfStatements These nested if statements could be combined 3 780784
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 843
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 871
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 875
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 881

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 421423

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 4 167
UselessParentheses Useless parentheses. 4 323

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 554555

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 3 75127
UselessParentheses Useless parentheses. 4 355356

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 154

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 3 8789

org/eclipse/jgit/transport/Transport.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 162164

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 263265

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 118120

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 154156
EmptyCatchBlock Avoid empty catch blocks 3 214216
EmptyCatchBlock Avoid empty catch blocks 3 253255

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 182
EmptyCatchBlock Avoid empty catch blocks 3 353355
EmptyCatchBlock Avoid empty catch blocks 3 360362

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 471699
CollapsibleIfStatements These nested if statements could be combined 3 855857
EmptyWhileStmt Avoid empty while statements 3 11551157
EmptyCatchBlock Avoid empty catch blocks 3 11761178
EmptyCatchBlock Avoid empty catch blocks 3 11821184

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 115

org/eclipse/jgit/transport/TransportProtocol.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'URIishField': nested enums are implicitly static 3 93104

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 346349

org/eclipse/jgit/transport/URIish.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 277278
UselessParentheses Useless parentheses. 4 338
UselessParentheses Useless parentheses. 4 339
UselessParentheses Useless parentheses. 4 366
UselessParentheses Useless parentheses. 4 367

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 442414
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RequestPolicy': nested enums are implicitly static 3 137167
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 3 236238
EmptyWhileStmt Avoid empty while statements 3 10721074
EmptyWhileStmt Avoid empty while statements 3 13211323
EmptyWhileStmt Avoid empty while statements 3 13301332
EmptyCatchBlock Avoid empty catch blocks 3 13771379
UselessParentheses Useless parentheses. 4 1390
EmptyCatchBlock Avoid empty catch blocks 3 15451547

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 120124

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 594
EmptyCatchBlock Avoid empty catch blocks 3 843845

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 302306

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 421423

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 4 74
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 4 80
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 4 86
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 4 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 4 105
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 4 110
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 4 115

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 45445
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 202

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 84

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 149

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'OperationType': nested enums are implicitly static 3 114125
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 864
UselessParentheses Useless parentheses. 4 1302
UselessParentheses Useless parentheses. 4 1439

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 328329
EmptyCatchBlock Avoid empty catch blocks 3 474478
EmptyWhileStmt Avoid empty while statements 3 514516
CollapsibleIfStatements These nested if statements could be combined 3 898899
EmptyCatchBlock Avoid empty catch blocks 3 15721574
UselessParentheses Useless parentheses. 4 15891590
UselessParentheses Useless parentheses. 4 15911592

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 77

org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.lib.ObjectReader' 4 56

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 116

org/eclipse/jgit/util/Base64.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 120
UselessParentheses Useless parentheses. 4 127
UselessParentheses Useless parentheses. 4 134

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 200
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 293

org/eclipse/jgit/util/FS.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 388390
EmptyIfStmt Avoid empty if statements 3 12581261
UselessParentheses Useless parentheses. 4 1332
EmptyCatchBlock Avoid empty catch blocks 3 18751882
EmptyCatchBlock Avoid empty catch blocks 3 22142216

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 91
CollapsibleIfStatements These nested if statements could be combined 3 176194
CollapsibleIfStatements These nested if statements could be combined 3 177193
UselessParentheses Useless parentheses. 4 485
UselessParentheses Useless parentheses. 4 485

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 164166
CollapsibleIfStatements These nested if statements could be combined 3 180196

org/eclipse/jgit/util/FileUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 324326
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 525
SimplifiedTernary Ternary operators that can be simplified with || or && 3 846

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 64

org/eclipse/jgit/util/GitDateFormatter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Format': nested enums are implicitly static 3 71117

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 3 131133
EmptyCatchBlock Avoid empty catch blocks 3 231233
UselessParentheses Useless parentheses. 4 261262

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 3 322

org/eclipse/jgit/util/LongMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 3 169173
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 176178

org/eclipse/jgit/util/NB.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91
UselessParentheses Useless parentheses. 4 203
UselessParentheses Useless parentheses. 4 206

org/eclipse/jgit/util/ProcessResult.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Status': nested enums are implicitly static 3 5469

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 451340
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 3 131138
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 3 212246
UselessParentheses Useless parentheses. 4 237
EmptyCatchBlock Avoid empty catch blocks 3 240242
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 3 266300
UselessParentheses Useless parentheses. 4 291
EmptyCatchBlock Avoid empty catch blocks 3 294296
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 3 317330
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 3 347371
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 3 389437
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 3 448453
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 467469
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 487493
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 3 506513
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 526528
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 543551
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 3 564573
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 3 588607
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 3 620628
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 641643
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 659668
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 3 692700
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 3 718725
UselessParentheses Useless parentheses. 4 744
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 3 763770
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 3 785794
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 3 809822
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 3 837847
UselessParentheses Useless parentheses. 4 954
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 3 12501261
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 3 12741283
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 3 12991309
UselessParentheses Useless parentheses. 4 1302

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 100102
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 112
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 3 117119
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 3 121123

org/eclipse/jgit/util/References.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 3 6466

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 122
UselessParentheses Useless parentheses. 4 126
UselessParentheses Useless parentheses. 4 127

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 405407

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7173

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 149151
EmptyCatchBlock Avoid empty catch blocks 3 154156

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 87
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 3 592595
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 3 597603

org/eclipse/jgit/util/time/MonotonicClock.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.time.Duration' 4 46