PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 2

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 148

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 514

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 467
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 560
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 606

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 323

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 502

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 192

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 507
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 570

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 688

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 378

org/eclipse/jgit/revwalk/TopoNonIntermixSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 114

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 102

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 623

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 561

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 169

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 116

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 831

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 166
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 259

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 511

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 79

Priority 3

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 94161

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 125127

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 771774

org/eclipse/jgit/api/LogCommand.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 266271

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 689694
CollapsibleIfStatements These nested if statements could be combined 12731276

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 372376

org/eclipse/jgit/api/TagCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 183

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 124126

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 513515
EmptyIfStmt Avoid empty if statements 603607
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 11011103

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121235
EmptyCatchBlock Avoid empty catch blocks 711713

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 336

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 437440
EmptyIfStmt Avoid empty if statements 442447
CollapsibleIfStatements These nested if statements could be combined 901910
CollapsibleIfStatements These nested if statements could be combined 904909
CollapsibleIfStatements These nested if statements could be combined 12201226
EmptyWhileStmt Avoid empty while statements 16401642

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 215221

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 30

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 2931

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 101108
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 130132
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 148150
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 157159
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 166168
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 175177
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 188190

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 2325

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 2022

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 7879

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 144147
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 171172
EmptyCatchBlock Avoid empty catch blocks 559561

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 168170

org/eclipse/jgit/ignore/IMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 2638
UnnecessaryModifier Unnecessary modifier 'public' on method 'createPathMatcher': the method is declared in an interface type 5357

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 33

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10310

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 302304

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3135
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3941

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 7375

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11604

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11125

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11758

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11320

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11151
EmptyCatchBlock Avoid empty catch blocks 116118

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11204

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11415
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 8183

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11293

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11214

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 4850

org/eclipse/jgit/internal/revwalk/AddToBitmapWithCacheFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 6163

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 5658

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11244

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11747

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 215217

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11490

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 182184

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 150152

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 326328
EmptyCatchBlock Avoid empty catch blocks 346348

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11149

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 341343

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 143145

org/eclipse/jgit/internal/storage/dfs/DfsReftableStack.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8991

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 108

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 2931
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3341
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 4952
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 5479
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 8183
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 8587

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 316318

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7981
CollapsibleIfStatements These nested if statements could be combined 166168

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 164166

org/eclipse/jgit/internal/storage/file/FileReftableStack.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 196199
EmptyCatchBlock Avoid empty catch blocks 315317
CollapsibleIfStatements These nested if statements could be combined 716718

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 202205
EmptyCatchBlock Avoid empty catch blocks 275277

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 389391
EmptyCatchBlock Avoid empty catch blocks 426428
EmptyCatchBlock Avoid empty catch blocks 544547
EmptyCatchBlock Avoid empty catch blocks 942944
EmptyCatchBlock Avoid empty catch blocks 967969

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7880

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 4991
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 9396
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 98100
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 102104
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 106108
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 116120
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 122129
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 131133

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 6567

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 293295
CollapsibleIfStatements These nested if statements could be combined 309311

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 187189

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 364385
EmptyCatchBlock Avoid empty catch blocks 700704

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 349351
EmptyCatchBlock Avoid empty catch blocks 356358
EmptyCatchBlock Avoid empty catch blocks 361363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 35

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11514
EmptyCatchBlock Avoid empty catch blocks 414416
EmptyCatchBlock Avoid empty catch blocks 435449

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 141477
CollapsibleIfStatements These nested if statements could be combined 524525
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 13731377

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 184186

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 13255

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 3640

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StatsRecorder': member interfaces are implicitly static 113182
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 328334
UnnecessaryModifier Unnecessary modifier 'static' on interface 'PageRef': member interfaces are implicitly static 774834
UnnecessaryModifier Unnecessary modifier 'static' on interface 'CleanupQueue': member interfaces are implicitly static 959962

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103105

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 4284
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 4284

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 106116
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 229231
SimplifiedTernary Ternary operators that can be simplified with || or && 317

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 276278

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 2428
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3133
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3638
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 4143
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 4648
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 5060

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 7781
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 85105
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 113120
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 137139
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 158173
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 175184
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 186193
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 195200
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 220222
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 225227

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 122493
EmptyWhileStmt Avoid empty while statements 19181920
CollapsibleIfStatements These nested if statements could be combined 22582259
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 22732276

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 261263
CollapsibleIfStatements These nested if statements could be combined 273277

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11567

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11572

org/eclipse/jgit/internal/storage/reftable/MergedReftable.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 281284

org/eclipse/jgit/internal/storage/reftable/ReftableBatchRefUpdate.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11382

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11216

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11694
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 677

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11840

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11309

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11384

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11194

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11254

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10174

org/eclipse/jgit/internal/transport/connectivity/IterativeConnectivityChecker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8486

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 339341

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 203205
EmptyCatchBlock Avoid empty catch blocks 413415

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 4454
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 6876
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 8992
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 101106
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 108123
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 125136
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 217237
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 253273
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 289309
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 316318
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 346367

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 266

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11753

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 4694
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 100188

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 4244

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 14541463
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 14911507

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 9597

org/eclipse/jgit/lib/FileMode.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 35
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 38
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 41
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 44
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 47
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 50
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 75
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 85
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 90
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 130

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3133

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 116118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 319
CollapsibleIfStatements These nested if statements could be combined 505508
CollapsibleIfStatements These nested if statements could be combined 550554

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121244

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 208222

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 307309
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 311313
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 315322

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 225227

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 5457
CollapsibleIfStatements These nested if statements could be combined 158161

org/eclipse/jgit/lib/Ref.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 7578

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 749751

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 872873

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 311332

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 6264

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 4143

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11370

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 3941

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 141328
CollapsibleIfStatements These nested if statements could be combined 375377
CollapsibleIfStatements These nested if statements could be combined 787823
CollapsibleIfStatements These nested if statements could be combined 812814

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 53

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 119121

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11620
EmptyCatchBlock Avoid empty catch blocks 215218

org/eclipse/jgit/patch/Patch.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11359

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 164166

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 133136
EmptyCatchBlock Avoid empty catch blocks 152167

org/eclipse/jgit/revwalk/BitmappedReachabilityChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'dontFollow': private methods cannot be overridden 141145

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 76112
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 76112
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 115242
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 245360

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 54
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 55
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 56
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 57
EmptyWhileStmt Avoid empty while statements 810812

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 160163

org/eclipse/jgit/storage/file/WindowCacheConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 11306

org/eclipse/jgit/storage/file/WindowCacheStats.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenFiles': the method is declared in an interface type 3032
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenBytes': the method is declared in an interface type 3941
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStats': the method is declared in an interface type 4749

org/eclipse/jgit/storage/pack/PackConfig.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121222

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 312314
EmptyCatchBlock Avoid empty catch blocks 323325
EmptyCatchBlock Avoid empty catch blocks 353355

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 398400
EmptyCatchBlock Avoid empty catch blocks 454456
EmptyCatchBlock Avoid empty catch blocks 474477
EmptyCatchBlock Avoid empty catch blocks 755757

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 152154
EmptyCatchBlock Avoid empty catch blocks 158160

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 231233
EmptyCatchBlock Avoid empty catch blocks 268270

org/eclipse/jgit/transport/ConnectivityChecker.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'ConnectivityCheckInfo': types nested within an interface type are implicitly static 51137
UnnecessaryModifier Unnecessary modifier 'public' on class 'ConnectivityCheckInfo': members of interface types are implicitly public 51137

org/eclipse/jgit/transport/Daemon.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 81
EmptyCatchBlock Avoid empty catch blocks 282284
EmptyCatchBlock Avoid empty catch blocks 308310
EmptyCatchBlock Avoid empty catch blocks 392394
EmptyCatchBlock Avoid empty catch blocks 394396
EmptyCatchBlock Avoid empty catch blocks 396398
EmptyCatchBlock Avoid empty catch blocks 401403
EmptyCatchBlock Avoid empty catch blocks 406408

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 39

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12528

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 6265
EmptyCatchBlock Avoid empty catch blocks 7477

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3164
EmptyCatchBlock Avoid empty catch blocks 188190

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 159161
EmptyIfStmt Avoid empty if statements 383385
EmptyIfStmt Avoid empty if statements 386388

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 123125
EmptyIfStmt Avoid empty if statements 432434

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7780
EmptyCatchBlock Avoid empty catch blocks 8688
EmptyCatchBlock Avoid empty catch blocks 9294

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 7073
EmptyCatchBlock Avoid empty catch blocks 8284
EmptyCatchBlock Avoid empty catch blocks 8890

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 103107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 698721
EmptyCatchBlock Avoid empty catch blocks 11511155
EmptyCatchBlock Avoid empty catch blocks 11671171

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 306308

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 110115

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 2224

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10248
EmptyIfStmt Avoid empty if statements 6971

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 5465
EmptyCatchBlock Avoid empty catch blocks 232235

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 4345

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 263265

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 747751

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 112269
EmptyCatchBlock Avoid empty catch blocks 363365
EmptyCatchBlock Avoid empty catch blocks 374376
EmptyCatchBlock Avoid empty catch blocks 390392
EmptyCatchBlock Avoid empty catch blocks 10481050
EmptyCatchBlock Avoid empty catch blocks 13751377

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 521522

org/eclipse/jgit/transport/SshConfigStore.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'EMPTY_CONFIG': the field is declared in an interface type 91113

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 5456

org/eclipse/jgit/transport/Transport.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 129131

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 231233

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8587

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 121123
EmptyCatchBlock Avoid empty catch blocks 181183
EmptyCatchBlock Avoid empty catch blocks 220222

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 327329
EmptyCatchBlock Avoid empty catch blocks 334336

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 141679
CollapsibleIfStatements These nested if statements could be combined 832834
EmptyWhileStmt Avoid empty while statements 11301132
EmptyCatchBlock Avoid empty catch blocks 11511153
EmptyCatchBlock Avoid empty catch blocks 11571159

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 313316

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 112415
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 203205
EmptyWhileStmt Avoid empty while statements 10691071
EmptyWhileStmt Avoid empty while statements 13181320
EmptyWhileStmt Avoid empty while statements 13271329
EmptyCatchBlock Avoid empty catch blocks 13741376
EmptyCatchBlock Avoid empty catch blocks 15421544

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 8791

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 810812

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 269273

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 388390

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 12411

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 440444
EmptyWhileStmt Avoid empty while statements 480482
CollapsibleIfStatements These nested if statements could be combined 864865
EmptyCatchBlock Avoid empty catch blocks 15071509

org/eclipse/jgit/util/FS.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 394396
EmptyIfStmt Avoid empty if statements 12921295
EmptyCatchBlock Avoid empty catch blocks 19811988
EmptyCatchBlock Avoid empty catch blocks 23202322

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 57
CollapsibleIfStatements These nested if statements could be combined 142160
CollapsibleIfStatements These nested if statements could be combined 143159

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 131133
CollapsibleIfStatements These nested if statements could be combined 147163

org/eclipse/jgit/util/FileUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 309311
SimplifiedTernary Ternary operators that can be simplified with || or && 832

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 98100
EmptyCatchBlock Avoid empty catch blocks 198200

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 305

org/eclipse/jgit/util/LongMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 136140
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 143145

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 121307
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 98105
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 179213
EmptyCatchBlock Avoid empty catch blocks 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 233267
EmptyCatchBlock Avoid empty catch blocks 261263
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 284297
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 314338
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 356404
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 415420
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 434436
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 454460
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 473480
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 493495
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 510518
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 531540
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 555574
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 587595
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 608610
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 626635
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 659667
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 685692
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 730737
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 752761
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 776789
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 804814
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 12171228
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 12411250
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 12661276

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 6769
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 8486
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 8890

org/eclipse/jgit/util/References.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 3133

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 372374

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 3840

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 116118
EmptyCatchBlock Avoid empty catch blocks 121123

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 54
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 562565
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 567573

Priority 4

org/eclipse/jgit/api/AddCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 179180
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 180
UselessParentheses Useless parentheses. 181182

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 549

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 171
UselessParentheses Useless parentheses. 172

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 399400
UselessParentheses Useless parentheses. 401
UselessParentheses Useless parentheses. 535

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 223

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 422
UselessParentheses Useless parentheses. 422

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 162164

org/eclipse/jgit/api/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 383

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 251

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 756757
UselessParentheses Useless parentheses. 756
UselessParentheses Useless parentheses. 757
UselessParentheses Useless parentheses. 1720

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 159
UselessParentheses Useless parentheses. 172
UselessParentheses Useless parentheses. 185
UselessParentheses Useless parentheses. 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 144

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 287
UselessParentheses Useless parentheses. 409410
UselessParentheses Useless parentheses. 468
UselessParentheses Useless parentheses. 516

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 50
UselessParentheses Useless parentheses. 100
UselessParentheses Useless parentheses. 138
UselessParentheses Useless parentheses. 173
UselessParentheses Useless parentheses. 217

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Line
UselessParentheses Useless parentheses. 348

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Line
UselessParentheses Useless parentheses. 651
UselessParentheses Useless parentheses. 729
UselessParentheses Useless parentheses. 730
UselessParentheses Useless parentheses. 731
UselessParentheses Useless parentheses. 732
UselessParentheses Useless parentheses. 733
UselessParentheses Useless parentheses. 734
UselessParentheses Useless parentheses. 793
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 794
UselessParentheses Useless parentheses. 889
UselessParentheses Useless parentheses. 11341135

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 92
UselessParentheses Useless parentheses. 261
UselessParentheses Useless parentheses. 385
UselessParentheses Useless parentheses. 385

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Line
UselessParentheses Useless parentheses. 461

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 748
UselessParentheses Useless parentheses. 749

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 97

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 99

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Line
UselessParentheses Useless parentheses. 105
UselessParentheses Useless parentheses. 363

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses. 34

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 394

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 444

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 593
UselessParentheses Useless parentheses. 600

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Line
UselessParentheses Useless parentheses. 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 546

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 436
UselessParentheses Useless parentheses. 442
UselessParentheses Useless parentheses. 449
UselessParentheses Useless parentheses. 455
UselessParentheses Useless parentheses. 472
UselessParentheses Useless parentheses. 496
UselessParentheses Useless parentheses. 582
UselessParentheses Useless parentheses. 590
UselessParentheses Useless parentheses. 663
UselessParentheses Useless parentheses. 713
UselessParentheses Useless parentheses. 832
UselessParentheses Useless parentheses. 942

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 729

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 245
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 247
UselessParentheses Useless parentheses. 261262
UselessParentheses Useless parentheses. 264265
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 409
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 415
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 441
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 525

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Line
UselessParentheses Useless parentheses. 546
UselessParentheses Useless parentheses. 546

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Line
UselessParentheses Useless parentheses. 962964
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1140
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 1143

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 621
UselessParentheses Useless parentheses. 622
UselessParentheses Useless parentheses. 741

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 130

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 431
UselessParentheses Useless parentheses. 437
UselessParentheses Useless parentheses. 444
UselessParentheses Useless parentheses. 450
UselessParentheses Useless parentheses. 467
UselessParentheses Useless parentheses. 500
UselessParentheses Useless parentheses. 520
UselessParentheses Useless parentheses. 577
UselessParentheses Useless parentheses. 585
UselessParentheses Useless parentheses. 836
UselessParentheses Useless parentheses. 885
UselessParentheses Useless parentheses. 1000
UselessParentheses Useless parentheses. 1091
UselessParentheses Useless parentheses. 1106
UselessParentheses Useless parentheses. 1192

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Line
UselessParentheses Useless parentheses. 207

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Line
UselessParentheses Useless parentheses. 198
UselessParentheses Useless parentheses. 305

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 356
UselessParentheses Useless parentheses. 357
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 509

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Line
UselessParentheses Useless parentheses. 1151
UselessParentheses Useless parentheses. 1166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 1234

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Line
UselessParentheses Useless parentheses. 286

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 35

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 161

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 353
UselessParentheses Useless parentheses. 2274
UselessParentheses Useless parentheses. 2275
UselessParentheses Useless parentheses. 2365
UselessParentheses Useless parentheses. 2382

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Line
UselessParentheses Useless parentheses. 102
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 203
UselessParentheses Useless parentheses. 237
UselessParentheses Useless parentheses. 238239
UselessParentheses Useless parentheses. 239
UselessParentheses Useless parentheses. 240
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 252

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 539
UselessParentheses Useless parentheses. 551

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Line
UselessParentheses Useless parentheses. 105

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 105
UselessParentheses Useless parentheses. 449

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 204205

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 8182

org/eclipse/jgit/lib/Config.java

Rule Violation Line
UselessParentheses Useless parentheses. 1421

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 248

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Line
UselessParentheses Useless parentheses. 552553
UselessParentheses Useless parentheses. 675
UselessParentheses Useless parentheses. 675676
UselessParentheses Useless parentheses. 675676
UselessParentheses Useless parentheses. 804805

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 538
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 570
UselessParentheses Useless parentheses. 843
UselessParentheses Useless parentheses. 903
UselessParentheses Useless parentheses. 904
UselessParentheses Useless parentheses. 982
UselessParentheses Useless parentheses. 994
UselessParentheses Useless parentheses. 10751076
UselessParentheses Useless parentheses. 1077
UselessParentheses Useless parentheses. 1078

org/eclipse/jgit/lib/Repository.java

Rule Violation Line
UselessParentheses Useless parentheses. 600
UselessParentheses Useless parentheses. 612
UselessParentheses Useless parentheses. 814
UselessParentheses Useless parentheses. 815
UselessParentheses Useless parentheses. 816

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Line
UselessParentheses Useless parentheses. 266

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Line
UselessParentheses Useless parentheses. 289

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Line
UselessParentheses Useless parentheses. 57

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Line
UselessParentheses Useless parentheses. 108

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 787788
UselessParentheses Useless parentheses. 787788
UselessParentheses Useless parentheses. 787
UselessParentheses Useless parentheses. 861862

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 18
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 19

org/eclipse/jgit/nls/NLS.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 16
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 17

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Line
UselessParentheses Useless parentheses. 251
UselessParentheses Useless parentheses. 253

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 264

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 162

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Line
UselessParentheses Useless parentheses. 91

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 115
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 245

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Line
UselessParentheses Useless parentheses. 338

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 529

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 647

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Line
UselessParentheses Useless parentheses. 367368
UselessParentheses Useless parentheses. 403

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 523

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Line
UselessParentheses Useless parentheses. 142
UselessParentheses Useless parentheses. 143

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 86104
UselessParentheses Useless parentheses. 365366
UselessParentheses Useless parentheses. 412
UselessParentheses Useless parentheses. 432

org/eclipse/jgit/transport/PackParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 818
UselessParentheses Useless parentheses. 993

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Line
UselessParentheses Useless parentheses. 234

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 246
UselessParentheses Useless parentheses. 744
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 810
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 838
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 842
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 848

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 1347

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 134
UselessParentheses Useless parentheses. 290

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Line
UselessParentheses Useless parentheses. 322323

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 121

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Line
UselessParentheses Useless parentheses. 56

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Line
UselessParentheses Useless parentheses. 156

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Line
UselessParentheses Useless parentheses. 82

org/eclipse/jgit/transport/URIish.java

Rule Violation Line
UselessParentheses Useless parentheses. 244245
UselessParentheses Useless parentheses. 308
UselessParentheses Useless parentheses. 309
UselessParentheses Useless parentheses. 333
UselessParentheses Useless parentheses. 334

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Line
UselessParentheses Useless parentheses. 1387
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_TAGS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_TAGS' 1973

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 41
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_AUTHORITATIVE' due to existing import 'java.net.HttpURLConnection' 47
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 53
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 59
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 100

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Line
UselessParentheses Useless parentheses. 50
UselessParentheses Useless parentheses. 51

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Line
UselessParentheses Useless parentheses. 1269
UselessParentheses Useless parentheses. 1406

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Line
UselessParentheses Useless parentheses. 294295
UselessParentheses Useless parentheses. 15241525
UselessParentheses Useless parentheses. 15261527

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Line
UselessParentheses Useless parentheses. 44

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Line
UselessParentheses Useless parentheses. 83

org/eclipse/jgit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses. 120
UselessParentheses Useless parentheses. 127
UselessParentheses Useless parentheses. 134

org/eclipse/jgit/util/FS.java

Rule Violation Line
UselessParentheses Useless parentheses. 1366
UselessParentheses Useless parentheses. 18381839
UselessParentheses Useless parentheses. 18541855

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Line
UselessParentheses Useless parentheses. 442
UselessParentheses Useless parentheses. 442

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 31

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 229230

org/eclipse/jgit/util/NB.java

Rule Violation Line
UselessParentheses Useless parentheses. 58
UselessParentheses Useless parentheses. 170
UselessParentheses Useless parentheses. 173

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Line
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 258
UselessParentheses Useless parentheses. 711
UselessParentheses Useless parentheses. 921
UselessParentheses Useless parentheses. 1269

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Line
UselessParentheses Useless parentheses. 89
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 94

Files

org/eclipse/jgit/api/AddCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 179180
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'FileMode.GITLINK' due to existing static import 'org.eclipse.jgit.lib.FileMode.GITLINK' 4 180
UselessParentheses Useless parentheses. 4 181182

org/eclipse/jgit/api/ArchiveCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Format': member interfaces are implicitly static 3 94161

org/eclipse/jgit/api/CheckoutCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Stage(int)': enum constructors are implicitly private 3 125127
UselessParentheses Useless parentheses. 4 549

org/eclipse/jgit/api/CleanCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 171
UselessParentheses Useless parentheses. 4 172

org/eclipse/jgit/api/CloneCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 771774

org/eclipse/jgit/api/CommitCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 399400
UselessParentheses Useless parentheses. 4 401
UselessParentheses Useless parentheses. 4 535

org/eclipse/jgit/api/CreateBranchCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_HEADS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_HEADS' 4 223

org/eclipse/jgit/api/DescribeCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 422
UselessParentheses Useless parentheses. 4 422

org/eclipse/jgit/api/FetchCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 162164

org/eclipse/jgit/api/LogCommand.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 266271

org/eclipse/jgit/api/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 383

org/eclipse/jgit/api/NameRevCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 251

org/eclipse/jgit/api/RebaseCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 689694
UselessParentheses Useless parentheses. 4 756757
UselessParentheses Useless parentheses. 4 756
UselessParentheses Useless parentheses. 4 757
CollapsibleIfStatements These nested if statements could be combined 3 12731276
UselessParentheses Useless parentheses. 4 1720

org/eclipse/jgit/api/StashApplyCommand.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 372376

org/eclipse/jgit/api/TagCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'state'. 3 183

org/eclipse/jgit/attributes/Attributes.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 159
UselessParentheses Useless parentheses. 4 172
UselessParentheses Useless parentheses. 4 185
UselessParentheses Useless parentheses. 4 199

org/eclipse/jgit/attributes/AttributesHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144

org/eclipse/jgit/attributes/AttributesRule.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 124126

org/eclipse/jgit/blame/BlameGenerator.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 513515
EmptyIfStmt Avoid empty if statements 3 603607
UnnecessaryModifier Unnecessary modifier 'final' on method 'isFile': private methods cannot be overridden 3 11011103

org/eclipse/jgit/diff/DiffFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121235
EmptyCatchBlock Avoid empty catch blocks 3 711713

org/eclipse/jgit/diff/MyersDiff.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 287
UselessParentheses Useless parentheses. 4 409410
UselessParentheses Useless parentheses. 4 468
UselessParentheses Useless parentheses. 4 516

org/eclipse/jgit/diff/RawTextComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 50
UselessParentheses Useless parentheses. 4 100
UselessParentheses Useless parentheses. 4 138
UselessParentheses Useless parentheses. 4 173
UselessParentheses Useless parentheses. 4 217

org/eclipse/jgit/diff/SimilarityRenameDetector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 348

org/eclipse/jgit/dircache/DirCache.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 336

org/eclipse/jgit/dircache/DirCacheBuilder.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 148

org/eclipse/jgit/dircache/DirCacheCheckout.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 437440
EmptyIfStmt Avoid empty if statements 3 442447
UselessParentheses Useless parentheses. 4 651
UselessParentheses Useless parentheses. 4 729
UselessParentheses Useless parentheses. 4 730
UselessParentheses Useless parentheses. 4 731
UselessParentheses Useless parentheses. 4 732
UselessParentheses Useless parentheses. 4 733
UselessParentheses Useless parentheses. 4 734
UselessParentheses Useless parentheses. 4 793
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 794
UselessParentheses Useless parentheses. 4 889
CollapsibleIfStatements These nested if statements could be combined 3 901910
CollapsibleIfStatements These nested if statements could be combined 3 904909
UselessParentheses Useless parentheses. 4 11341135
CollapsibleIfStatements These nested if statements could be combined 3 12201226
EmptyWhileStmt Avoid empty while statements 3 16401642

org/eclipse/jgit/dircache/DirCacheEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 92
UselessParentheses Useless parentheses. 4 261
UselessParentheses Useless parentheses. 4 385
UselessParentheses Useless parentheses. 4 385

org/eclipse/jgit/dircache/DirCacheIterator.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 215221

org/eclipse/jgit/dircache/DirCacheTree.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 461

org/eclipse/jgit/errors/StoredObjectRepresentationNotAvailableException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'otp'. 3 30

org/eclipse/jgit/fnmatch/CharacterHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 2931

org/eclipse/jgit/fnmatch/GroupHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 101108
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 130132
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 139141
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 148150
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 157159
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 166168
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 175177
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 188190

org/eclipse/jgit/fnmatch/RestrictedWildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 2325

org/eclipse/jgit/fnmatch/WildCardHead.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 2022

org/eclipse/jgit/gitrepo/ManifestParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'readIncludeFile': the method is declared in an interface type 3 7879

org/eclipse/jgit/gitrepo/RepoCommand.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'sha1': the method is declared in an interface type 3 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFile': the method is declared in an interface type 3 144147
UnnecessaryModifier Unnecessary modifier 'public' on method 'readFileWithMode': the method is declared in an interface type 3 171172
EmptyCatchBlock Avoid empty catch blocks 3 559561
UselessParentheses Useless parentheses. 4 748
UselessParentheses Useless parentheses. 4 749

org/eclipse/jgit/hooks/GitHook.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 168170

org/eclipse/jgit/ignore/IMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_MATCH': the field is declared in an interface type 3 2638
UnnecessaryModifier Unnecessary modifier 'public' on method 'createPathMatcher': the method is declared in an interface type 3 5357

org/eclipse/jgit/ignore/internal/NameMatcher.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 33
UselessParentheses Useless parentheses. 4 97

org/eclipse/jgit/ignore/internal/PathMatcher.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10310
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Strings.getPathSeparator' due to existing static import 'org.eclipse.jgit.ignore.internal.Strings.getPathSeparator' 4 99

org/eclipse/jgit/ignore/internal/Strings.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 105
CollapsibleIfStatements These nested if statements could be combined 3 302304
UselessParentheses Useless parentheses. 4 363

org/eclipse/jgit/ignore/internal/WildMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 3135
UselessParentheses Useless parentheses. 4 34
UnnecessaryModifier Unnecessary modifier 'final' on method 'matches': the method is already in a final class 3 3941

org/eclipse/jgit/internal/ketch/ElectionRound.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 7375

org/eclipse/jgit/internal/ketch/KetchLeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11604

org/eclipse/jgit/internal/ketch/KetchPreReceive.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11125

org/eclipse/jgit/internal/ketch/KetchReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11758

org/eclipse/jgit/internal/ketch/KetchSystem.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11320

org/eclipse/jgit/internal/ketch/LagCheck.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11151
EmptyCatchBlock Avoid empty catch blocks 3 116118

org/eclipse/jgit/internal/ketch/LocalReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11204

org/eclipse/jgit/internal/ketch/Proposal.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11415
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'State(boolean)': enum constructors are implicitly private 3 8183
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 394

org/eclipse/jgit/internal/ketch/RemoteGitReplica.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11293

org/eclipse/jgit/internal/ketch/ReplicaConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11214

org/eclipse/jgit/internal/revwalk/AddToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 4850

org/eclipse/jgit/internal/revwalk/AddToBitmapWithCacheFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 6163

org/eclipse/jgit/internal/revwalk/AddUnseenToBitmapFilter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 5658

org/eclipse/jgit/internal/storage/dfs/DfsBlockCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11244

org/eclipse/jgit/internal/storage/dfs/DfsGarbageCollector.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11747
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 444

org/eclipse/jgit/internal/storage/dfs/DfsInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 215217
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 593
UselessParentheses Useless parentheses. 4 600

org/eclipse/jgit/internal/storage/dfs/DfsPackCompactor.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11490

org/eclipse/jgit/internal/storage/dfs/DfsPackDescription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.PACK' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.PACK' 4 546

org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGarbage': the method is already in a final class 3 182184
UselessParentheses Useless parentheses. 4 436
UselessParentheses Useless parentheses. 4 442
UselessParentheses Useless parentheses. 4 449
UselessParentheses Useless parentheses. 4 455
UselessParentheses Useless parentheses. 4 472
UselessParentheses Useless parentheses. 4 496
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 514
UselessParentheses Useless parentheses. 4 582
UselessParentheses Useless parentheses. 4 590
UselessParentheses Useless parentheses. 4 663
UselessParentheses Useless parentheses. 4 713
UselessParentheses Useless parentheses. 4 832
UselessParentheses Useless parentheses. 4 942

org/eclipse/jgit/internal/storage/dfs/DfsPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 150152

org/eclipse/jgit/internal/storage/dfs/DfsReader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 326328
EmptyCatchBlock Avoid empty catch blocks 3 346348
UselessParentheses Useless parentheses. 4 729

org/eclipse/jgit/internal/storage/dfs/DfsReaderOptions.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11149

org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 341343

org/eclipse/jgit/internal/storage/dfs/DfsReftable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 143145

org/eclipse/jgit/internal/storage/dfs/DfsReftableStack.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8991

org/eclipse/jgit/internal/storage/dfs/DfsStreamKey.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 108

org/eclipse/jgit/internal/storage/file/BitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 2931
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 3341
UnnecessaryModifier Unnecessary modifier 'final' on method 'clear': the method is already in a final class 3 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 4952
UnnecessaryModifier Unnecessary modifier 'final' on method 'toEWAHCompressedBitmap': the method is already in a final class 3 5479
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 8183
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 8587

org/eclipse/jgit/internal/storage/file/BitmapIndexImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofObjectType': private methods cannot be overridden 3 316318

org/eclipse/jgit/internal/storage/file/CachedObjectDirectory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7981
CollapsibleIfStatements These nested if statements could be combined 3 166168

org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 164166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 245
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 247
UselessParentheses Useless parentheses. 4 261262
UselessParentheses Useless parentheses. 4 264265
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 4 409
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.PACKED' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.PACKED' 4 415
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 441
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Ref.Storage.NEW' due to existing static import 'org.eclipse.jgit.lib.Ref.Storage.NEW' 4 525

org/eclipse/jgit/internal/storage/file/FileReftableStack.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 196199
EmptyCatchBlock Avoid empty catch blocks 3 315317
CollapsibleIfStatements These nested if statements could be combined 3 716718

org/eclipse/jgit/internal/storage/file/FileRepository.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 202205
EmptyCatchBlock Avoid empty catch blocks 3 275277

org/eclipse/jgit/internal/storage/file/FileSnapshot.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 546
UselessParentheses Useless parentheses. 4 546

org/eclipse/jgit/internal/storage/file/GC.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 389391
EmptyCatchBlock Avoid empty catch blocks 3 426428
EmptyCatchBlock Avoid empty catch blocks 3 544547
EmptyCatchBlock Avoid empty catch blocks 3 942944
UselessParentheses Useless parentheses. 4 962964
EmptyCatchBlock Avoid empty catch blocks 3 967969
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1140
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackExt.INDEX' due to existing static import 'org.eclipse.jgit.internal.storage.pack.PackExt.INDEX' 4 1143

org/eclipse/jgit/internal/storage/file/GcLog.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7880

org/eclipse/jgit/internal/storage/file/InflatingBitSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'maybeContains': the method is already in a final class 3 4347
UnnecessaryModifier Unnecessary modifier 'final' on method 'contains': the method is already in a final class 3 4991
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': private methods cannot be overridden 3 9396
UnnecessaryModifier Unnecessary modifier 'final' on method 'block': private methods cannot be overridden 3 98100
UnnecessaryModifier Unnecessary modifier 'final' on method 'mask': private methods cannot be overridden 3 102104
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEmpty': private methods cannot be overridden 3 106108
UnnecessaryModifier Unnecessary modifier 'final' on method 'or': the method is already in a final class 3 110114
UnnecessaryModifier Unnecessary modifier 'final' on method 'andNot': the method is already in a final class 3 116120
UnnecessaryModifier Unnecessary modifier 'final' on method 'xor': the method is already in a final class 3 122129
UnnecessaryModifier Unnecessary modifier 'final' on method 'getBitmap': the method is already in a final class 3 131133

org/eclipse/jgit/internal/storage/file/LazyObjectIdSetFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 6567

org/eclipse/jgit/internal/storage/file/ObjectDirectory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 293295
CollapsibleIfStatements These nested if statements could be combined 3 309311
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 467
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 560
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 606
UselessParentheses Useless parentheses. 4 621
UselessParentheses Useless parentheses. 4 622
UselessParentheses Useless parentheses. 4 741

org/eclipse/jgit/internal/storage/file/ObjectDirectoryPackParser.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 187189

org/eclipse/jgit/internal/storage/file/PackBitmapIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 130

org/eclipse/jgit/internal/storage/file/PackFile.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'decompress': private methods cannot be overridden 3 364385
UselessParentheses Useless parentheses. 4 431
UselessParentheses Useless parentheses. 4 437
UselessParentheses Useless parentheses. 4 444
UselessParentheses Useless parentheses. 4 450
UselessParentheses Useless parentheses. 4 467
UselessParentheses Useless parentheses. 4 500
UselessParentheses Useless parentheses. 4 520
UselessParentheses Useless parentheses. 4 577
UselessParentheses Useless parentheses. 4 585
EmptyCatchBlock Avoid empty catch blocks 3 700704
UselessParentheses Useless parentheses. 4 836
UselessParentheses Useless parentheses. 4 885
UselessParentheses Useless parentheses. 4 1000
UselessParentheses Useless parentheses. 4 1091
UselessParentheses Useless parentheses. 4 1106
UselessParentheses Useless parentheses. 4 1192

org/eclipse/jgit/internal/storage/file/PackIndexV1.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 207

org/eclipse/jgit/internal/storage/file/PackIndexV2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 198
UselessParentheses Useless parentheses. 4 305

org/eclipse/jgit/internal/storage/file/PackInserter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 349351
EmptyCatchBlock Avoid empty catch blocks 3 356358
EmptyCatchBlock Avoid empty catch blocks 3 361363

org/eclipse/jgit/internal/storage/file/PackLock.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fs'. 3 35

org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11514
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 323
UselessParentheses Useless parentheses. 4 356
UselessParentheses Useless parentheses. 4 357
EmptyCatchBlock Avoid empty catch blocks 3 414416
EmptyCatchBlock Avoid empty catch blocks 3 435449
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 509

org/eclipse/jgit/internal/storage/file/RefDirectory.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 141477
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 502
CollapsibleIfStatements These nested if statements could be combined 3 524525
UselessParentheses Useless parentheses. 4 1151
UselessParentheses Useless parentheses. 4 1166
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_REFS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_REFS' 4 1234
UnnecessaryModifier Unnecessary modifier 'static' on interface 'LooseRef': member interfaces are implicitly static 3 13731377

org/eclipse/jgit/internal/storage/file/RefDirectoryRename.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 184186

org/eclipse/jgit/internal/storage/file/ReflogWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 13255

org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 3640

org/eclipse/jgit/internal/storage/file/WindowCache.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StatsRecorder': member interfaces are implicitly static 3 113182
UnnecessaryModifier Unnecessary modifier 'final' on method 'bits': private methods cannot be overridden 3 328334
UnnecessaryModifier Unnecessary modifier 'static' on interface 'PageRef': member interfaces are implicitly static 3 774834
UnnecessaryModifier Unnecessary modifier 'static' on interface 'CleanupQueue': member interfaces are implicitly static 3 959962

org/eclipse/jgit/internal/storage/file/WindowCursor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 286

org/eclipse/jgit/internal/storage/io/BlockSource.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103105

org/eclipse/jgit/internal/storage/pack/CachedPackUriProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'PackInfo': members of interface types are implicitly public 3 4284
UnnecessaryModifier Unnecessary modifier 'static' on class 'PackInfo': types nested within an interface type are implicitly static 3 4284

org/eclipse/jgit/internal/storage/pack/DeltaIndexScanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 35

org/eclipse/jgit/internal/storage/pack/DeltaTask.java

Rule Violation Priority Line
ForLoopShouldBeWhileLoop This for loop could be simplified to a while loop 3 106116
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 229231
SimplifiedTernary Ternary operators that can be simplified with || or && 3 317

org/eclipse/jgit/internal/storage/pack/DeltaWindow.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 192
EmptyCatchBlock Avoid empty catch blocks 3 276278

org/eclipse/jgit/internal/storage/pack/DeltaWindowEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'set': the method is already in a final class 3 2428
UnnecessaryModifier Unnecessary modifier 'final' on method 'depth': the method is already in a final class 3 3133
UnnecessaryModifier Unnecessary modifier 'final' on method 'type': the method is already in a final class 3 3638
UnnecessaryModifier Unnecessary modifier 'final' on method 'size': the method is already in a final class 3 4143
UnnecessaryModifier Unnecessary modifier 'final' on method 'empty': the method is already in a final class 3 4648
UnnecessaryModifier Unnecessary modifier 'final' on method 'makeNext': the method is already in a final class 3 5060

org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 7781
UnnecessaryModifier Unnecessary modifier 'final' on method 'write': the method is already in a final class 3 85105
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeFileHeader': the method is already in a final class 3 113120
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeObject': the method is already in a final class 3 137139
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeHeader': the method is already in a final class 3 158173
UselessParentheses Useless parentheses. 4 161
UnnecessaryModifier Unnecessary modifier 'final' on method 'objectHeader': private methods cannot be overridden 3 175184
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDelta': private methods cannot be overridden 3 186193
UnnecessaryModifier Unnecessary modifier 'final' on method 'ofsDeltaVarIntLength': private methods cannot be overridden 3 195200
UnnecessaryModifier Unnecessary modifier 'final' on method 'getCopyBuffer': the method is already in a final class 3 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'length': the method is already in a final class 3 220222
UnnecessaryModifier Unnecessary modifier 'final' on method 'getDigest': the method is already in a final class 3 225227

org/eclipse/jgit/internal/storage/pack/PackWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 122493
UselessParentheses Useless parentheses. 4 353
EmptyWhileStmt Avoid empty while statements 3 19181920
CollapsibleIfStatements These nested if statements could be combined 3 22582259
UnnecessaryModifier Unnecessary modifier 'final' on method 'have': private methods cannot be overridden 3 22732276
UselessParentheses Useless parentheses. 4 2274
UselessParentheses Useless parentheses. 4 2275
UselessParentheses Useless parentheses. 4 2365
UselessParentheses Useless parentheses. 4 2382

org/eclipse/jgit/internal/storage/pack/PackWriterBitmapPreparer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 102
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 203
UselessParentheses Useless parentheses. 4 237
UselessParentheses Useless parentheses. 4 238239
UselessParentheses Useless parentheses. 4 239
UselessParentheses Useless parentheses. 4 240
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'PackBitmapIndex.FLAG_REUSE' due to existing static import 'org.eclipse.jgit.internal.storage.file.PackBitmapIndex.FLAG_REUSE' 4 252
EmptyWhileStmt Avoid empty while statements 3 261263
CollapsibleIfStatements These nested if statements could be combined 3 273277

org/eclipse/jgit/internal/storage/reftable/BlockReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11567
UselessParentheses Useless parentheses. 4 539
UselessParentheses Useless parentheses. 4 551

org/eclipse/jgit/internal/storage/reftable/BlockWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11572
UselessParentheses Useless parentheses. 4 105

org/eclipse/jgit/internal/storage/reftable/MergedReftable.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 281284

org/eclipse/jgit/internal/storage/reftable/ReftableBatchRefUpdate.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11382

org/eclipse/jgit/internal/storage/reftable/ReftableOutputStream.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11216

org/eclipse/jgit/internal/storage/reftable/ReftableReader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11694
UselessParentheses Useless parentheses. 4 105
UselessParentheses Useless parentheses. 4 449
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 507
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 570
UnusedNullCheckInEquals Invoke equals() on the object you've already ensured is not null 3 677

org/eclipse/jgit/internal/storage/reftable/ReftableWriter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11840
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 688

org/eclipse/jgit/internal/storage/reftree/Command.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11309

org/eclipse/jgit/internal/storage/reftree/RefTree.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11384

org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11194

org/eclipse/jgit/internal/storage/reftree/Scanner.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11254

org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10174

org/eclipse/jgit/internal/transport/connectivity/IterativeConnectivityChecker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8486

org/eclipse/jgit/internal/transport/http/NetscapeCookieFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 204205
EmptyCatchBlock Avoid empty catch blocks 3 339341

org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 203205
EmptyCatchBlock Avoid empty catch blocks 3 413415

org/eclipse/jgit/lib/AbbreviatedObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 4454
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 6876
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromObjectId': the method is already in a final class 3 8992
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 101106
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 108123
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt32': private methods cannot be overridden 3 125136
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 217237
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 253273
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 289309
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 316318
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 346367

org/eclipse/jgit/lib/AnyObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 266

org/eclipse/jgit/lib/BaseRepositoryBuilder.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11753
UselessParentheses Useless parentheses. 4 8182

org/eclipse/jgit/lib/BitmapIndex.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Bitmap': members of interface types are implicitly public 3 4694
UnnecessaryModifier Unnecessary modifier 'public' on interface 'BitmapBuilder': members of interface types are implicitly public 3 100188

org/eclipse/jgit/lib/BranchConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BranchRebaseMode(String)': enum constructors are implicitly private 3 4244

org/eclipse/jgit/lib/Config.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1421
UnnecessaryModifier Unnecessary modifier 'static' on interface 'SectionParser': member interfaces are implicitly static 3 14541463
UnnecessaryModifier Unnecessary modifier 'static' on interface 'ConfigEnum': member interfaces are implicitly static 3 14911507

org/eclipse/jgit/lib/ConfigSnapshot.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'StringUtils.toLowerCase' due to existing static import 'org.eclipse.jgit.util.StringUtils.toLowerCase' 4 248

org/eclipse/jgit/lib/DefaultTypedConfigGetter.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 9597

org/eclipse/jgit/lib/FileMode.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 35
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 38
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 41
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 44
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 47
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 50
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 75
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 80
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 85
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 90
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 130

org/eclipse/jgit/lib/GpgConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'GpgFormat(String)': enum constructors are implicitly private 3 3133

org/eclipse/jgit/lib/IndexDiff.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StageState(int)': enum constructors are implicitly private 3 116118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getWorkingTreeIterator': the method is declared in an interface type 3 319
CollapsibleIfStatements These nested if statements could be combined 3 505508
CollapsibleIfStatements These nested if statements could be combined 3 550554
UselessParentheses Useless parentheses. 4 552553
UselessParentheses Useless parentheses. 4 675
UselessParentheses Useless parentheses. 4 675676
UselessParentheses Useless parentheses. 4 675676
UselessParentheses Useless parentheses. 4 804805

org/eclipse/jgit/lib/ObjectChecker.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121244
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 538
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_LENGTH' 4 570
UselessParentheses Useless parentheses. 4 843
UselessParentheses Useless parentheses. 4 903
UselessParentheses Useless parentheses. 4 904
UselessParentheses Useless parentheses. 4 982
UselessParentheses Useless parentheses. 4 994
UselessParentheses Useless parentheses. 4 10751076
UselessParentheses Useless parentheses. 4 1077
UselessParentheses Useless parentheses. 4 1078

org/eclipse/jgit/lib/ObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 208222

org/eclipse/jgit/lib/ObjectIdOwnerMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'newSegment': private methods cannot be overridden 3 307309
UnnecessaryModifier Unnecessary modifier 'final' on method 'computeGrowAt': private methods cannot be overridden 3 311313
UnnecessaryModifier Unnecessary modifier 'final' on method 'equals': private methods cannot be overridden 3 315322

org/eclipse/jgit/lib/ObjectIdSubclassMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 225227

org/eclipse/jgit/lib/RebaseTodoLine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Action(String, String)': enum constructors are implicitly private 3 5457
CollapsibleIfStatements These nested if statements could be combined 3 158161

org/eclipse/jgit/lib/Ref.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Storage(boolean, boolean)': enum constructors are implicitly private 3 7578

org/eclipse/jgit/lib/RefUpdate.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 749751

org/eclipse/jgit/lib/Repository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 600
UselessParentheses Useless parentheses. 4 612
UselessParentheses Useless parentheses. 4 814
UselessParentheses Useless parentheses. 4 815
UselessParentheses Useless parentheses. 4 816
CollapsibleIfStatements These nested if statements could be combined 3 872873

org/eclipse/jgit/lib/RepositoryCache.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 266
UnnecessaryModifier Unnecessary modifier 'static' on interface 'Key': member interfaces are implicitly static 3 311332

org/eclipse/jgit/lib/StoredConfig.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 6264

org/eclipse/jgit/lib/SubmoduleConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'FetchRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 4143

org/eclipse/jgit/lib/TreeFormatter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11370

org/eclipse/jgit/merge/EolAwareOutputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/merge/MergeAlgorithm.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 289

org/eclipse/jgit/merge/MergeConfig.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 3941

org/eclipse/jgit/merge/MergeFormatterPass.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 57

org/eclipse/jgit/merge/MergeResult.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 108

org/eclipse/jgit/merge/ResolveMerger.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 141328
CollapsibleIfStatements These nested if statements could be combined 3 375377
UselessParentheses Useless parentheses. 4 787788
CollapsibleIfStatements These nested if statements could be combined 3 787823
UselessParentheses Useless parentheses. 4 787788
UselessParentheses Useless parentheses. 4 787
CollapsibleIfStatements These nested if statements could be combined 3 812814
UselessParentheses Useless parentheses. 4 861862

org/eclipse/jgit/merge/ThreeWayMerger.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inCore'. 3 53

org/eclipse/jgit/nls/GlobalBundleCache.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 18
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 19

org/eclipse/jgit/nls/NLS.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationBundleLoadingException' 4 16
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.errors.TranslationStringMissingException' 4 17

org/eclipse/jgit/notes/NoteMapMerger.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 251
UselessParentheses Useless parentheses. 4 253

org/eclipse/jgit/patch/CombinedFileHeader.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 119121

org/eclipse/jgit/patch/FileHeader.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11620
EmptyCatchBlock Avoid empty catch blocks 3 215218
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'RawParseUtils.decode' due to existing static import 'org.eclipse.jgit.util.RawParseUtils.decode' 4 264

org/eclipse/jgit/patch/Patch.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11359

org/eclipse/jgit/revplot/AbstractPlotRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 162

org/eclipse/jgit/revplot/PlotWalk.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 164166

org/eclipse/jgit/revwalk/BitmapWalker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 133136
EmptyCatchBlock Avoid empty catch blocks 3 152167

org/eclipse/jgit/revwalk/BitmappedReachabilityChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'dontFollow': private methods cannot be overridden 3 141145

org/eclipse/jgit/revwalk/DateRevQueue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91

org/eclipse/jgit/revwalk/DepthWalk.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Commit': members of interface types are implicitly public 3 76112
UnnecessaryModifier Unnecessary modifier 'static' on class 'Commit': types nested within an interface type are implicitly static 3 76112
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.RevWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 115
UnnecessaryModifier Unnecessary modifier 'public' on class 'RevWalk': members of interface types are implicitly public 3 115242
UnnecessaryModifier Unnecessary modifier 'public' on class 'ObjectWalk': members of interface types are implicitly public 3 245360
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.eclipse.jgit.revwalk.ObjectWalk' due to existing same package import 'org.eclipse.jgit.revwalk.*' 4 245

org/eclipse/jgit/revwalk/ObjectWalk.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 54
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 55
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 56
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 57
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 378
EmptyWhileStmt Avoid empty while statements 3 810812

org/eclipse/jgit/revwalk/RevCommitList.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 160163
UselessParentheses Useless parentheses. 4 338

org/eclipse/jgit/revwalk/TopoNonIntermixSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 114

org/eclipse/jgit/revwalk/TopoSortGenerator.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 102

org/eclipse/jgit/storage/file/WindowCacheConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 11306

org/eclipse/jgit/storage/file/WindowCacheStats.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenFiles': the method is declared in an interface type 3 3032
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOpenBytes': the method is declared in an interface type 3 3941
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStats': the method is declared in an interface type 3 4749

org/eclipse/jgit/storage/pack/PackConfig.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121222

org/eclipse/jgit/submodule/SubmoduleWalk.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 529
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 623

org/eclipse/jgit/transport/BasePackConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 312314
EmptyCatchBlock Avoid empty catch blocks 3 323325
EmptyCatchBlock Avoid empty catch blocks 3 353355

org/eclipse/jgit/transport/BasePackFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 398400
EmptyCatchBlock Avoid empty catch blocks 3 454456
EmptyCatchBlock Avoid empty catch blocks 3 474477
UselessParentheses Useless parentheses. 4 647
EmptyCatchBlock Avoid empty catch blocks 3 755757

org/eclipse/jgit/transport/BasePackPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 152154
EmptyCatchBlock Avoid empty catch blocks 3 158160
UselessParentheses Useless parentheses. 4 367368
UselessParentheses Useless parentheses. 4 403

org/eclipse/jgit/transport/BundleFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 231233
EmptyCatchBlock Avoid empty catch blocks 3 268270

org/eclipse/jgit/transport/ConnectivityChecker.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'ConnectivityCheckInfo': types nested within an interface type are implicitly static 3 51137
UnnecessaryModifier Unnecessary modifier 'public' on class 'ConnectivityCheckInfo': members of interface types are implicitly public 3 51137

org/eclipse/jgit/transport/Daemon.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 81
EmptyCatchBlock Avoid empty catch blocks 3 282284
EmptyCatchBlock Avoid empty catch blocks 3 308310
EmptyCatchBlock Avoid empty catch blocks 3 392394
EmptyCatchBlock Avoid empty catch blocks 3 394396
EmptyCatchBlock Avoid empty catch blocks 3 396398
EmptyCatchBlock Avoid empty catch blocks 3 401403
EmptyCatchBlock Avoid empty catch blocks 3 406408

org/eclipse/jgit/transport/DaemonService.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 39

org/eclipse/jgit/transport/FetchProcess.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12528
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'ReceiveCommand.Result.OK' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.OK' 4 523

org/eclipse/jgit/transport/FilterSpec.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 6265
EmptyCatchBlock Avoid empty catch blocks 3 7477

org/eclipse/jgit/transport/FtpChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'FtpException': types nested within an interface type are implicitly static 3 3164
EmptyCatchBlock Avoid empty catch blocks 3 188190

org/eclipse/jgit/transport/HttpAuthMethod.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 142
UselessParentheses Useless parentheses. 4 143
EmptyCatchBlock Avoid empty catch blocks 3 159161
EmptyIfStmt Avoid empty if statements 3 383385
EmptyIfStmt Avoid empty if statements 3 386388

org/eclipse/jgit/transport/HttpConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86104
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'HttpRedirectMode(String)': enum constructors are implicitly private 3 123125
UselessParentheses Useless parentheses. 4 365366
UselessParentheses Useless parentheses. 4 412
EmptyIfStmt Avoid empty if statements 3 432434
UselessParentheses Useless parentheses. 4 432

org/eclipse/jgit/transport/InternalFetchConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7780
EmptyCatchBlock Avoid empty catch blocks 3 8688
EmptyCatchBlock Avoid empty catch blocks 3 9294

org/eclipse/jgit/transport/InternalPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 7073
EmptyCatchBlock Avoid empty catch blocks 3 8284
EmptyCatchBlock Avoid empty catch blocks 3 8890

org/eclipse/jgit/transport/NetRCCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 103107

org/eclipse/jgit/transport/PackParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'checkIfTooLarge': private methods cannot be overridden 3 698721
UselessParentheses Useless parentheses. 4 818
UselessParentheses Useless parentheses. 4 993
EmptyCatchBlock Avoid empty catch blocks 3 11511155
EmptyCatchBlock Avoid empty catch blocks 3 11671171

org/eclipse/jgit/transport/PacketLineIn.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 306308

org/eclipse/jgit/transport/ProtocolV0Parser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 110115

org/eclipse/jgit/transport/ProtocolV2Hook.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on field 'DEFAULT': the field is declared in an interface type 3 2224

org/eclipse/jgit/transport/ProtocolV2Parser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10248
EmptyIfStmt Avoid empty if statements 3 6971

org/eclipse/jgit/transport/PushCertificateIdent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 234

org/eclipse/jgit/transport/PushCertificateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'StringReader': member interfaces are implicitly static 3 5465
EmptyCatchBlock Avoid empty catch blocks 3 232235

org/eclipse/jgit/transport/PushConfig.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'PushRecurseSubmodulesMode(String)': enum constructors are implicitly private 3 4345

org/eclipse/jgit/transport/PushProcess.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 263265

org/eclipse/jgit/transport/ReceiveCommand.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 246
UselessParentheses Useless parentheses. 4 744
CollapsibleIfStatements These nested if statements could be combined 3 747751
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.NOT_ATTEMPTED' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.NOT_ATTEMPTED' 4 810
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 838
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 842
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Result.REJECTED_OTHER_REASON' due to existing static import 'org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_REASON' 4 848

org/eclipse/jgit/transport/ReceivePack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 112269
EmptyCatchBlock Avoid empty catch blocks 3 363365
EmptyCatchBlock Avoid empty catch blocks 3 374376
EmptyCatchBlock Avoid empty catch blocks 3 390392
EmptyCatchBlock Avoid empty catch blocks 3 10481050
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.HEAD' due to existing static import 'org.eclipse.jgit.lib.Constants.HEAD' 4 1347
EmptyCatchBlock Avoid empty catch blocks 3 13751377

org/eclipse/jgit/transport/RefAdvertiser.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.OBJECT_ID_STRING_LENGTH' due to existing static import 'org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH' 4 134
UselessParentheses Useless parentheses. 4 290

org/eclipse/jgit/transport/RefSpec.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 521522

org/eclipse/jgit/transport/RemoteRefUpdate.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 322323

org/eclipse/jgit/transport/SideBandInputStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 121

org/eclipse/jgit/transport/SshConfigStore.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'EMPTY_CONFIG': the field is declared in an interface type 3 91113

org/eclipse/jgit/transport/TagOpt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TagOpt(String)': enum constructors are implicitly private 3 5456

org/eclipse/jgit/transport/Transport.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 129131

org/eclipse/jgit/transport/TransportAmazonS3.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 231233

org/eclipse/jgit/transport/TransportBundleFile.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/eclipse/jgit/transport/TransportBundleStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8587

org/eclipse/jgit/transport/TransportGitAnon.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 121123
EmptyCatchBlock Avoid empty catch blocks 3 181183
EmptyCatchBlock Avoid empty catch blocks 3 220222

org/eclipse/jgit/transport/TransportGitSsh.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 156
EmptyCatchBlock Avoid empty catch blocks 3 327329
EmptyCatchBlock Avoid empty catch blocks 3 334336

org/eclipse/jgit/transport/TransportHttp.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 141679
CollapsibleIfStatements These nested if statements could be combined 3 832834
EmptyWhileStmt Avoid empty while statements 3 11301132
EmptyCatchBlock Avoid empty catch blocks 3 11511153
EmptyCatchBlock Avoid empty catch blocks 3 11571159

org/eclipse/jgit/transport/TransportLocal.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 82

org/eclipse/jgit/transport/TransportSftp.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 313316

org/eclipse/jgit/transport/URIish.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 244245
UselessParentheses Useless parentheses. 4 308
UselessParentheses Useless parentheses. 4 309
UselessParentheses Useless parentheses. 4 333
UselessParentheses Useless parentheses. 4 334

org/eclipse/jgit/transport/UploadPack.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 112415
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IOConsumer': member interfaces are implicitly static 3 203205
EmptyWhileStmt Avoid empty while statements 3 10691071
EmptyWhileStmt Avoid empty while statements 3 13181320
EmptyWhileStmt Avoid empty while statements 3 13271329
EmptyCatchBlock Avoid empty catch blocks 3 13741376
UselessParentheses Useless parentheses. 4 1387
EmptyCatchBlock Avoid empty catch blocks 3 15421544
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Constants.R_TAGS' due to existing static import 'org.eclipse.jgit.lib.Constants.R_TAGS' 4 1973

org/eclipse/jgit/transport/UsernamePasswordCredentialsProvider.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 8791

org/eclipse/jgit/transport/WalkFetchConnection.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 561
EmptyCatchBlock Avoid empty catch blocks 3 810812

org/eclipse/jgit/transport/WalkPushConnection.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 269273

org/eclipse/jgit/transport/WalkRemoteObjectDatabase.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 388390

org/eclipse/jgit/transport/http/HttpConnection.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_OK' due to existing import 'java.net.HttpURLConnection' 4 41
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_AUTHORITATIVE' due to existing import 'java.net.HttpURLConnection' 4 47
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_PERM' due to existing import 'java.net.HttpURLConnection' 4 53
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_MOVED_TEMP' due to existing import 'java.net.HttpURLConnection' 4 59
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_SEE_OTHER' due to existing import 'java.net.HttpURLConnection' 4 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_NOT_FOUND' due to existing import 'java.net.HttpURLConnection' 4 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_UNAUTHORIZED' due to existing import 'java.net.HttpURLConnection' 4 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.net.HttpURLConnection.HTTP_FORBIDDEN' due to existing import 'java.net.HttpURLConnection' 4 100

org/eclipse/jgit/treewalk/CanonicalTreeParser.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 12411
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 169

org/eclipse/jgit/treewalk/InstantComparator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 50
UselessParentheses Useless parentheses. 4 51

org/eclipse/jgit/treewalk/NameConflictTreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 116

org/eclipse/jgit/treewalk/TreeWalk.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 831
UselessParentheses Useless parentheses. 4 1269
UselessParentheses Useless parentheses. 4 1406

org/eclipse/jgit/treewalk/WorkingTreeIterator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 294295
EmptyCatchBlock Avoid empty catch blocks 3 440444
EmptyWhileStmt Avoid empty while statements 3 480482
CollapsibleIfStatements These nested if statements could be combined 3 864865
EmptyCatchBlock Avoid empty catch blocks 3 15071509
UselessParentheses Useless parentheses. 4 15241525
UselessParentheses Useless parentheses. 4 15261527

org/eclipse/jgit/treewalk/filter/ByteArraySet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 44

org/eclipse/jgit/treewalk/filter/TreeFilterMarker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83

org/eclipse/jgit/util/Base64.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 120
UselessParentheses Useless parentheses. 4 127
UselessParentheses Useless parentheses. 4 134

org/eclipse/jgit/util/ChangeIdUtil.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 166
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 259

org/eclipse/jgit/util/FS.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 394396
EmptyIfStmt Avoid empty if statements 3 12921295
UselessParentheses Useless parentheses. 4 1366
UselessParentheses Useless parentheses. 4 18381839
UselessParentheses Useless parentheses. 4 18541855
EmptyCatchBlock Avoid empty catch blocks 3 19811988
EmptyCatchBlock Avoid empty catch blocks 3 23202322

org/eclipse/jgit/util/FS_POSIX.java

Rule Violation Priority Line
AvoidUsingOctalValues Do not start a literal by 0 unless its an octal value 3 57
CollapsibleIfStatements These nested if statements could be combined 3 142160
CollapsibleIfStatements These nested if statements could be combined 3 143159
UselessParentheses Useless parentheses. 4 442
UselessParentheses Useless parentheses. 4 442

org/eclipse/jgit/util/FS_Win32.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 131133
CollapsibleIfStatements These nested if statements could be combined 3 147163

org/eclipse/jgit/util/FileUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 309311
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 511
SimplifiedTernary Ternary operators that can be simplified with || or && 3 832

org/eclipse/jgit/util/GSSManagerFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 31

org/eclipse/jgit/util/GitDateParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ParseableSimpleDateFormat(String)': enum constructors are implicitly private 3 98100
EmptyCatchBlock Avoid empty catch blocks 3 198200
UselessParentheses Useless parentheses. 4 229230

org/eclipse/jgit/util/LfsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type 3 305

org/eclipse/jgit/util/LongMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'index': private methods cannot be overridden 3 136140
UnnecessaryModifier Unnecessary modifier 'final' on method 'createArray': private methods cannot be overridden 3 143145

org/eclipse/jgit/util/NB.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 58
UselessParentheses Useless parentheses. 4 170
UselessParentheses Useless parentheses. 4 173

org/eclipse/jgit/util/RawParseUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 121307
UnnecessaryModifier Unnecessary modifier 'final' on method 'match': the method is already in a final class 3 98105
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseBase10': the method is already in a final class 3 179213
UselessParentheses Useless parentheses. 4 204
EmptyCatchBlock Avoid empty catch blocks 3 207209
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseLongBase10': the method is already in a final class 3 233267
UselessParentheses Useless parentheses. 4 258
EmptyCatchBlock Avoid empty catch blocks 3 261263
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt16': the method is already in a final class 3 284297
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt32': the method is already in a final class 3 314338
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt64': the method is already in a final class 3 356404
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseHexInt4': the method is already in a final class 3 415420
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 434436
UnnecessaryModifier Unnecessary modifier 'final' on method 'parseTimeZoneOffset': the method is already in a final class 3 454460
UnnecessaryModifier Unnecessary modifier 'final' on method 'next': the method is already in a final class 3 473480
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 493495
UnnecessaryModifier Unnecessary modifier 'final' on method 'nextLF': the method is already in a final class 3 510518
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerEnd': the method is already in a final class 3 531540
UnnecessaryModifier Unnecessary modifier 'final' on method 'headerStart': the method is already in a final class 3 555574
UnnecessaryModifier Unnecessary modifier 'final' on method 'prev': the method is already in a final class 3 587595
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 608610
UnnecessaryModifier Unnecessary modifier 'final' on method 'prevLF': the method is already in a final class 3 626635
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMap': the method is already in a final class 3 659667
UnnecessaryModifier Unnecessary modifier 'final' on method 'lineMapOrBinary': the method is already in a final class 3 685692
UselessParentheses Useless parentheses. 4 711
UnnecessaryModifier Unnecessary modifier 'final' on method 'author': the method is already in a final class 3 730737
UnnecessaryModifier Unnecessary modifier 'final' on method 'committer': the method is already in a final class 3 752761
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagger': the method is already in a final class 3 776789
UnnecessaryModifier Unnecessary modifier 'final' on method 'encoding': the method is already in a final class 3 804814
UselessParentheses Useless parentheses. 4 921
UnnecessaryModifier Unnecessary modifier 'final' on method 'commitMessage': the method is already in a final class 3 12171228
UnnecessaryModifier Unnecessary modifier 'final' on method 'tagMessage': the method is already in a final class 3 12411250
UnnecessaryModifier Unnecessary modifier 'final' on method 'endOfParagraph': the method is already in a final class 3 12661276
UselessParentheses Useless parentheses. 4 1269

org/eclipse/jgit/util/RawSubStringPattern.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 6769
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 79
UnnecessaryModifier Unnecessary modifier 'final' on method 'neq': private methods cannot be overridden 3 8486
UnnecessaryModifier Unnecessary modifier 'final' on method 'lc': private methods cannot be overridden 3 8890

org/eclipse/jgit/util/References.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isSameObject': the method is declared in an interface type 3 3133

org/eclipse/jgit/util/RelativeDateFormatter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 94

org/eclipse/jgit/util/TemporaryBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 372374

org/eclipse/jgit/util/io/SilentFileInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 3840

org/eclipse/jgit/util/io/StreamCopyThread.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 116118
EmptyCatchBlock Avoid empty catch blocks 3 121123

org/eclipse/jgit/util/sha1/SHA1.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 54
UnnecessaryModifier Unnecessary modifier 'final' on method 'init': the method is already in a final class 3 562565
UnnecessaryModifier Unnecessary modifier 'final' on method 'save': the method is already in a final class 3 567573