PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 2

org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 116

Priority 3

org/eclipse/jgit/lfs/LfsBlobFilter.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 87–89

org/eclipse/jgit/lfs/LfsPointer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 110–112

org/eclipse/jgit/lfs/LfsPrePushHook.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 10–258
EmptyWhileStmt Avoid empty while statements 119–121

org/eclipse/jgit/lfs/Protocol.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'gson': the method is declared in an interface type 137–142

org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 48–59
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 73–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromLongObjectId': the method is already in a final class 94–99
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 108–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 116–130
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt64': private methods cannot be overridden 132–144
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 222–238
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 254–270
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 286–302
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 309–311
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 339–356

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 267

org/eclipse/jgit/lfs/lib/LongObjectId.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 219–232

Priority 4

org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 110–111
UselessParentheses Useless parentheses. 276–277

Files

org/eclipse/jgit/lfs/LfsBlobFilter.java

Rule Violation Priority Line
EmptyWhileStmt Avoid empty while statements 3 87–89

org/eclipse/jgit/lfs/LfsPointer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 110–112

org/eclipse/jgit/lfs/LfsPrePushHook.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 10–258
EmptyWhileStmt Avoid empty while statements 3 119–121

org/eclipse/jgit/lfs/Protocol.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'gson': the method is declared in an interface type 3 137–142

org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 110–111
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 116
UselessParentheses Useless parentheses. 4 276–277

org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isId': the method is already in a final class 3 48–59
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 73–81
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromLongObjectId': the method is already in a final class 3 94–99
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromString': the method is already in a final class 3 108–114
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 116–130
UnnecessaryModifier Unnecessary modifier 'final' on method 'hexUInt64': private methods cannot be overridden 3 132–144
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 222–238
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 254–270
UnnecessaryModifier Unnecessary modifier 'final' on method 'prefixCompare': the method is already in a final class 3 286–302
UnnecessaryModifier Unnecessary modifier 'final' on method 'getFirstByte': the method is already in a final class 3 309–311
UnnecessaryModifier Unnecessary modifier 'final' on method 'name': the method is already in a final class 3 339–356

org/eclipse/jgit/lfs/lib/AnyLongObjectId.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 267

org/eclipse/jgit/lfs/lib/LongObjectId.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'fromHexString': private methods cannot be overridden 3 219–232